Re: weird libpq GSSAPI comment

2020-01-08 Thread Stephen Frost
Greetings, * Stephen Frost (sfr...@snowman.net) wrote: > * Alvaro Herrera (alvhe...@2ndquadrant.com) wrote: > > On 2020-Jan-06, Stephen Frost wrote: > > > > I wonder if part of the confusion might be due to the synonyms we're > > > > using here for "in use". Things seem to be "got running", "set

Re: weird libpq GSSAPI comment

2020-01-06 Thread Stephen Frost
Greetings, * Alvaro Herrera (alvhe...@2ndquadrant.com) wrote: > On 2020-Jan-06, Stephen Frost wrote: > > > > I wonder if part of the confusion might be due to the synonyms we're > > > using here for "in use". Things seem to be "got running", "set up", > > > "operating", "negotiated", ... - maybe

Re: weird libpq GSSAPI comment

2020-01-06 Thread Alvaro Herrera
Hello, On 2020-Jan-06, Robbie Harwood wrote: > This looks correct to me (and uses plenty of parentheticals, so it feels > in keeping with something I'd write) :) (You know, long ago I used to write with a lot of parenthicals (even nested ones). But I read somewhere that prose is more natural fo

Re: weird libpq GSSAPI comment

2020-01-06 Thread Alvaro Herrera
On 2020-Jan-06, Stephen Frost wrote: > > I wonder if part of the confusion might be due to the synonyms we're > > using here for "in use". Things seem to be "got running", "set up", > > "operating", "negotiated", ... - maybe that's part of the barrier to > > understanding? > > How about somethin

Re: weird libpq GSSAPI comment

2020-01-06 Thread Robbie Harwood
Stephen Frost writes: >> Alvaro Herrera writes: > > How about something like this? > > * If GSSAPI Encryption is enabled, then call pg_GSS_have_cred_cache() > * which will return true if we can acquire credentials (and give us a > * handle to use in conn->gcred), and then send a packet to the

Re: weird libpq GSSAPI comment

2020-01-06 Thread Stephen Frost
Greetings, * Robbie Harwood (rharw...@redhat.com) wrote: > Alvaro Herrera writes: > > > How about this? > > > > * If GSSAPI is enabled and we can reach a credential cache, > > * set up a handle for it; if it's operating, just send a > > * GSS st

Re: weird libpq GSSAPI comment

2020-01-03 Thread Robbie Harwood
Alvaro Herrera writes: > How about this? > > * If GSSAPI is enabled and we can reach a credential cache, > * set up a handle for it; if it's operating, just send a > * GSS startup message, instead of the SSL negotiation and > * r

Re: weird libpq GSSAPI comment

2020-01-03 Thread Robbie Harwood
Stephen Frost writes: > Greetings, > > (I've added Robbie to this thread, so he can correct me if/when I go > wrong in my descriptions regarding the depths of GSSAPI ;) Hi, appreciate the CC since I'm not subscribed anymore. Thanks for your patience while I was PTO. > * Alvaro Herrera (alvhe..

Re: weird libpq GSSAPI comment

2019-12-27 Thread Alvaro Herrera
On 2019-Dec-27, Stephen Frost wrote: > Maybe part of the confusion here is that there's two different things- a > credential cache, and then a credential *handle*. Calling > gss_acquire_cred() will, if a credential *cache* exists, return to us a > credential *handle* (in the form of conn->gcred)

Re: weird libpq GSSAPI comment

2019-12-27 Thread Stephen Frost
Greetings, (I've added Robbie to this thread, so he can correct me if/when I go wrong in my descriptions regarding the depths of GSSAPI ;) * Alvaro Herrera (alvhe...@2ndquadrant.com) wrote: > I found this comment in fe-connect.c: > > /* > * If GSSAPI is enabled a

weird libpq GSSAPI comment

2019-12-24 Thread Alvaro Herrera
I found this comment in fe-connect.c: /* * If GSSAPI is enabled and we have a credential cache, try to * set it up before sending startup messages. If it's already * operating, don't try SSL and instead just build the startup