On Mon, Jun 21, 2021 at 12:06 PM Nitin Jadhav
wrote:
> That was by mistake and I have corrected it in the attached patch.
Thanks for the patch. Here are some comments. Please ignore if I
repeat any of the comments given previously, as I didn't look at the
entire thread.
1) A new line between
Hi,
I'd really like to see this enabled by default, say with a default
interval of 10 seconds. If it has to be enabled explicitly, most
people won't, but I think a lot of people would benefit from knowing
why their system is slow to start up when that sort of thing happens.
I don't see much
Few comments for v4 patch:
@@ -7351,6 +7363,8 @@ StartupXLOG(void)
(errmsg("redo starts at %X/%X",
LSN_FORMAT_ARGS(ReadRecPtr;
+ InitStartupProgress();
+
/*
* main redo apply loop
*/
@@ -7358,6
> What is DUMMY about ? If you just want to separate the "start" from "end",
> you could write:
>
> /* codes for start of operations */
> FSYNC_IN_PROGRESS
> SYNCFS_IN_PROGRESS
> ...
> /* codes for end of operations */
> FSYNC_END
> SYNCFS_END
> ...
That was by mistake and I have corrected it in
+ * Codes of the operations performed during startup process
+ */
+typedef enum StartupProcessOp
+{
+ SYNCFS_IN_PROGRESS,
+ FSYNC_IN_PROGRESS,
+ RECOVERY_IN_PROGRESS,
+ RESET_UNLOGGED_REL_IN_PROGRESS,
+ DUMMY,
+ SYNCFS_END,
+ FSYNC_END,
+
101 - 105 of 105 matches
Mail list logo
