Re: with oids option not removed in pg_dumpall

2019-05-23 Thread Andres Freund
Hi, On 2019-05-23 16:26:38 +0300, Surafel Temesgen wrote: > Thank you for applying > > regards > Surafel > > On Thu, May 23, 2019 at 3:43 AM Michael Paquier wrote: > > > On Tue, May 21, 2019 at 05:24:57PM +0900, Michael Paquier wrote: > > > Good catch. Your cleanup looks correct to me. Andre

Re: with oids option not removed in pg_dumpall

2019-05-23 Thread Surafel Temesgen
Thank you for applying regards Surafel On Thu, May 23, 2019 at 3:43 AM Michael Paquier wrote: > On Tue, May 21, 2019 at 05:24:57PM +0900, Michael Paquier wrote: > > Good catch. Your cleanup looks correct to me. Andres, perhaps you > > would prefer doing the cleanup yourself? > > As I am clean

Re: with oids option not removed in pg_dumpall

2019-05-22 Thread Michael Paquier
On Tue, May 21, 2019 at 05:24:57PM +0900, Michael Paquier wrote: > Good catch. Your cleanup looks correct to me. Andres, perhaps you > would prefer doing the cleanup yourself? As I am cleaning up the area for another issue, applied. -- Michael signature.asc Description: PGP signature

Re: with oids option not removed in pg_dumpall

2019-05-21 Thread Michael Paquier
On Tue, May 21, 2019 at 09:31:48AM +0300, Surafel Temesgen wrote: > Commit 578b229718e8f remove oids option from pg_dump but its is > still in pg_dumpall .The attach patch remove it Good catch. Your cleanup looks correct to me. Andres, perhaps you would prefer doing the cleanup yourself? -- Mich

with oids option not removed in pg_dumpall

2019-05-20 Thread Surafel Temesgen
Hello, Commit 578b229718e8f remove oids option from pg_dump but its is still in pg_dumpall .The attach patch remove it regards Surafel diff --git a/doc/src/sgml/ref/pg_dumpall.sgml b/doc/src/sgml/ref/pg_dumpall.sgml index 24c8c031d6..b35c702f99 100644 --- a/doc/src/sgml/ref/pg_dumpall.sgml +++ b/do