Re: xact_start for walsender & logical decoding not updated

2020-01-08 Thread Tom Lane
Alvaro Herrera writes: >> I'm not 100% sure why the failure either. The assertion is in >> code that should only be reached in a parallel worker, and surely >> walsenders don't launch parallel queries? But it looks to me >> that all the critters using force_parallel_mode are unhappy. > I reprod

Re: xact_start for walsender & logical decoding not updated

2020-01-08 Thread Alvaro Herrera
On 2020-Jan-07, Tom Lane wrote: > Alvaro Herrera writes: > > On 2020-Jan-07, Tom Lane wrote: > > That seems a pretty simple patch; attached (untested). > > I think you want && not ||, but otherwise that looks about right. Thanks, you were right; pushed. > > However, my > > patch seemed a pret

Re: xact_start for walsender & logical decoding not updated

2020-01-07 Thread Tom Lane
Alvaro Herrera writes: > On 2020-Jan-07, Tom Lane wrote: >> ... and, having now looked at the patch, I'm not surprised. >> Breaking stmtStartTimestamp, which is what you did, seems like >> an awfully side-effect-filled route to the goal. If you want >> to prevent monitoring from showing this, why

Re: xact_start for walsender & logical decoding not updated

2020-01-07 Thread Alvaro Herrera
On 2020-Jan-07, Tom Lane wrote: > I wrote: > > The buildfarm seems less than happy with this. > > ... and, having now looked at the patch, I'm not surprised. > Breaking stmtStartTimestamp, which is what you did, seems like > an awfully side-effect-filled route to the goal. If you want > to preve

Re: xact_start for walsender & logical decoding not updated

2020-01-07 Thread Tom Lane
I wrote: > The buildfarm seems less than happy with this. ... and, having now looked at the patch, I'm not surprised. Breaking stmtStartTimestamp, which is what you did, seems like an awfully side-effect-filled route to the goal. If you want to prevent monitoring from showing this, why didn't you

Re: xact_start for walsender & logical decoding not updated

2020-01-07 Thread Tom Lane
Alvaro Herrera writes: > OK, I pushed my patch to branches 10 - master. > (See https://postgr.es/m/20200107211624.GA18974@alvherre.pgsql ) The buildfarm seems less than happy with this. regards, tom lane

Re: xact_start for walsender & logical decoding not updated

2020-01-07 Thread Alvaro Herrera
On 2019-Dec-29, Tomas Vondra wrote: > On Fri, Dec 27, 2019 at 04:46:18PM -0300, Alvaro Herrera wrote: > > > > This patch changes xact.c to avoid updating transaction start timestamps > > for walsenders (maybe more commentary is desirable). I think logical > > decoding is just a special form of w

Re: xact_start for walsender & logical decoding not updated

2019-12-28 Thread Tomas Vondra
On Fri, Dec 27, 2019 at 04:46:18PM -0300, Alvaro Herrera wrote: On 2019-Dec-13, Kyotaro Horiguchi wrote: At Fri, 13 Dec 2019 13:05:41 +0800, Craig Ringer wrote in > On Wed, 11 Dec 2019 at 02:08, Alvaro Herrera > wrote: > > > On 2019-Dec-10, Tomas Vondra wrote: > > > > > On Tue, Dec 10, 2019

Re: xact_start for walsender & logical decoding not updated

2019-12-27 Thread Alvaro Herrera
On 2019-Dec-13, Kyotaro Horiguchi wrote: > At Fri, 13 Dec 2019 13:05:41 +0800, Craig Ringer > wrote in > > On Wed, 11 Dec 2019 at 02:08, Alvaro Herrera > > wrote: > > > > > On 2019-Dec-10, Tomas Vondra wrote: > > > > > > > On Tue, Dec 10, 2019 at 09:42:17AM +0900, Kyotaro Horiguchi wrote: > >

Re: xact_start for walsender & logical decoding not updated

2019-12-12 Thread Kyotaro Horiguchi
At Fri, 13 Dec 2019 13:05:41 +0800, Craig Ringer wrote in > On Wed, 11 Dec 2019 at 02:08, Alvaro Herrera > wrote: > > > On 2019-Dec-10, Tomas Vondra wrote: > > > > > On Tue, Dec 10, 2019 at 09:42:17AM +0900, Kyotaro Horiguchi wrote: > > > > At Tue, 10 Dec 2019 00:44:09 +0100, Tomas Vondra < >

Re: xact_start for walsender & logical decoding not updated

2019-12-12 Thread Craig Ringer
On Wed, 11 Dec 2019 at 02:08, Alvaro Herrera wrote: > On 2019-Dec-10, Tomas Vondra wrote: > > > On Tue, Dec 10, 2019 at 09:42:17AM +0900, Kyotaro Horiguchi wrote: > > > At Tue, 10 Dec 2019 00:44:09 +0100, Tomas Vondra < > tomas.von...@2ndquadrant.com> wrote in > > > > I'm not sure how much xact_s

Re: xact_start for walsender & logical decoding not updated

2019-12-10 Thread Andres Freund
Hi, On 2019-12-10 12:56:56 +0100, Tomas Vondra wrote: > On Mon, Dec 09, 2019 at 04:04:40PM -0800, Andres Freund wrote: > > On 2019-12-10 00:44:09 +0100, Tomas Vondra wrote: > > > I think there's a minor bug in pg_stat_activity tracking of walsender > > > processes. The issue is that xact_start is

Re: xact_start for walsender & logical decoding not updated

2019-12-10 Thread Alvaro Herrera
On 2019-Dec-10, Tomas Vondra wrote: > On Tue, Dec 10, 2019 at 09:42:17AM +0900, Kyotaro Horiguchi wrote: > > At Tue, 10 Dec 2019 00:44:09 +0100, Tomas Vondra > > wrote in > > I'm not sure how much xact_start for walsender is useful and we really > > is not running a statement there. Also autov

Re: xact_start for walsender & logical decoding not updated

2019-12-10 Thread Tomas Vondra
On Tue, Dec 10, 2019 at 09:42:17AM +0900, Kyotaro Horiguchi wrote: At Tue, 10 Dec 2019 00:44:09 +0100, Tomas Vondra wrote in Hi, I think there's a minor bug in pg_stat_activity tracking of walsender processes. The issue is that xact_start is only updated at the very beginning when the walsend

Re: xact_start for walsender & logical decoding not updated

2019-12-10 Thread Tomas Vondra
On Mon, Dec 09, 2019 at 04:04:40PM -0800, Andres Freund wrote: Hi, On 2019-12-10 00:44:09 +0100, Tomas Vondra wrote: I think there's a minor bug in pg_stat_activity tracking of walsender processes. The issue is that xact_start is only updated at the very beginning when the walsender starts (so

Re: xact_start for walsender & logical decoding not updated

2019-12-09 Thread Kyotaro Horiguchi
At Tue, 10 Dec 2019 00:44:09 +0100, Tomas Vondra wrote in > Hi, > > I think there's a minor bug in pg_stat_activity tracking of walsender > processes. The issue is that xact_start is only updated at the very > beginning when the walsender starts (so it's almost exactly equal to > backend_start)

Re: xact_start for walsender & logical decoding not updated

2019-12-09 Thread Andres Freund
Hi, On 2019-12-10 00:44:09 +0100, Tomas Vondra wrote: > I think there's a minor bug in pg_stat_activity tracking of walsender > processes. The issue is that xact_start is only updated at the very > beginning when the walsender starts (so it's almost exactly equal to > backend_start) and then just

xact_start for walsender & logical decoding not updated

2019-12-09 Thread Tomas Vondra
Hi, I think there's a minor bug in pg_stat_activity tracking of walsender processes. The issue is that xact_start is only updated at the very beginning when the walsender starts (so it's almost exactly equal to backend_start) and then just flips between NULL and that value. Reproducing this is t