Re: zlib detection in Meson on Windows broken?

2024-05-22 Thread Dave Page
On Wed, 22 May 2024 at 17:50, Nazir Bilal Yavuz wrote: > Hi, > > On Wed, 22 May 2024 at 17:21, Dave Page wrote: > > > > Hi > > > > On Wed, 22 May 2024 at 14:11, Nazir Bilal Yavuz > wrote: > >> > >> > >> I tried to install your latest zlib artifact (nmake one) to the > >> Windows CI images (not

Re: zlib detection in Meson on Windows broken?

2024-05-22 Thread Nazir Bilal Yavuz
Hi, On Wed, 22 May 2024 at 17:21, Dave Page wrote: > > Hi > > On Wed, 22 May 2024 at 14:11, Nazir Bilal Yavuz wrote: >> >> >> I tried to install your latest zlib artifact (nmake one) to the >> Windows CI images (not the official ones) [1]. Then, I used the >> default meson.build file to build

Re: zlib detection in Meson on Windows broken?

2024-05-22 Thread Dave Page
Hi On Wed, 22 May 2024 at 14:11, Nazir Bilal Yavuz wrote: > Hi, > > On Tue, 21 May 2024 at 18:24, Dave Page wrote: > > > > > > > > On Tue, 21 May 2024 at 16:04, Andres Freund wrote: > >> > >> Hi, > >> > >> On 2024-05-20 11:58:05 +0100, Dave Page wrote: > >> > I have very little experience

Re: zlib detection in Meson on Windows broken?

2024-05-22 Thread Nazir Bilal Yavuz
Hi, On Tue, 21 May 2024 at 18:24, Dave Page wrote: > > > > On Tue, 21 May 2024 at 16:04, Andres Freund wrote: >> >> Hi, >> >> On 2024-05-20 11:58:05 +0100, Dave Page wrote: >> > I have very little experience with Meson, and even less interpreting it's >> > logs, but it seems to me that it's not

Re: zlib detection in Meson on Windows broken?

2024-05-22 Thread Dave Page
On Tue, 21 May 2024 at 20:54, Andrew Dunstan wrote: > > On 2024-05-21 Tu 11:04, Andres Freund wrote: > > Hi, > > > > On 2024-05-20 11:58:05 +0100, Dave Page wrote: > >> I have very little experience with Meson, and even less interpreting > it's > >> logs, but it seems to me that it's not

Re: zlib detection in Meson on Windows broken?

2024-05-22 Thread Dave Page
On Tue, 21 May 2024 at 18:00, Andres Freund wrote: > Hi, > > On 2024-05-20 11:58:05 +0100, Dave Page wrote: > > I then attempt to build PostgreSQL: > > > > meson setup build > > -Dextra_include_dirs=C:/build64/openssl/include,C:/build64/zlib/include > >

Re: zlib detection in Meson on Windows broken?

2024-05-21 Thread Tristan Partin
On Tue May 21, 2024 at 10:04 AM CDT, Andres Freund wrote: Hi, On 2024-05-20 11:58:05 +0100, Dave Page wrote: > I have very little experience with Meson, and even less interpreting it's > logs, but it seems to me that it's not including the extra lib and include > directories when it runs the

Re: zlib detection in Meson on Windows broken?

2024-05-21 Thread Andrew Dunstan
On 2024-05-21 Tu 11:04, Andres Freund wrote: Hi, On 2024-05-20 11:58:05 +0100, Dave Page wrote: I have very little experience with Meson, and even less interpreting it's logs, but it seems to me that it's not including the extra lib and include directories when it runs the test compile,

Re: zlib detection in Meson on Windows broken?

2024-05-21 Thread Andres Freund
Hi, On 2024-05-20 11:58:05 +0100, Dave Page wrote: > I then attempt to build PostgreSQL: > > meson setup build > -Dextra_include_dirs=C:/build64/openssl/include,C:/build64/zlib/include > -Dextra_lib_dirs=C:/build64/openssl/lib,C:/build64/zlib/lib -Dssl=openssl > -Dzlib=enabled

Re: zlib detection in Meson on Windows broken?

2024-05-21 Thread Dave Page
On Tue, 21 May 2024 at 16:04, Andres Freund wrote: > Hi, > > On 2024-05-20 11:58:05 +0100, Dave Page wrote: > > I have very little experience with Meson, and even less interpreting it's > > logs, but it seems to me that it's not including the extra lib and > include > > directories when it runs

Re: zlib detection in Meson on Windows broken?

2024-05-21 Thread Andres Freund
Hi, On 2024-05-20 11:58:05 +0100, Dave Page wrote: > I have very little experience with Meson, and even less interpreting it's > logs, but it seems to me that it's not including the extra lib and include > directories when it runs the test compile, given the command line it's > reporting: > > cl

Re: zlib detection in Meson on Windows broken?

2024-05-21 Thread Dave Page
Hi On Tue, 21 May 2024 at 15:12, Sandeep Thakkar < sandeep.thak...@enterprisedb.com> wrote: > Hi Dave, > > > On Tue, May 21, 2024 at 3:12 PM Dave Page wrote: > >> Hi Sandeep, Nazir, >> >> On Tue, 21 May 2024 at 10:14, Nazir Bilal Yavuz >> wrote: >> >>> Hi, >>> >>> On Tue, 21 May 2024 at 10:20,

Re: zlib detection in Meson on Windows broken?

2024-05-21 Thread Sandeep Thakkar
Hi Dave, On Tue, May 21, 2024 at 3:12 PM Dave Page wrote: > Hi Sandeep, Nazir, > > On Tue, 21 May 2024 at 10:14, Nazir Bilal Yavuz > wrote: > >> Hi, >> >> On Tue, 21 May 2024 at 10:20, Sandeep Thakkar >> wrote: >> > >> > Hi Dave, >> > >> > Is the .pc file generated after the successful build

Re: zlib detection in Meson on Windows broken?

2024-05-21 Thread Dave Page
Hi Sandeep, Nazir, On Tue, 21 May 2024 at 10:14, Nazir Bilal Yavuz wrote: > Hi, > > On Tue, 21 May 2024 at 10:20, Sandeep Thakkar > wrote: > > > > Hi Dave, > > > > Is the .pc file generated after the successful build of zlib? If yes, > then meson should be able to detect the installation

Re: zlib detection in Meson on Windows broken?

2024-05-21 Thread Nazir Bilal Yavuz
Hi, On Tue, 21 May 2024 at 10:20, Sandeep Thakkar wrote: > > Hi Dave, > > Is the .pc file generated after the successful build of zlib? If yes, then > meson should be able to detect the installation ideally If meson is not able to find the .pc file automatically, using 'meson setup ...

Re: zlib detection in Meson on Windows broken?

2024-05-21 Thread Sandeep Thakkar
Hi Dave, Is the .pc file generated after the successful build of zlib? If yes, then meson should be able to detect the installation ideally On Mon, May 20, 2024 at 4:28 PM Dave Page wrote: > Hi > > I'm working on updating the build of PostgreSQL that pgAdmin uses in its > Windows installers to

Re: zlib detection in Meson on Windows broken?

2024-05-20 Thread Andrew Dunstan
On 2024-05-20 Mo 06:58, Dave Page wrote: Hi I'm working on updating the build of PostgreSQL that pgAdmin uses in its Windows installers to use Meson ready for the v17 release. I'm using Visual Studio 2022, on Windows Server 2022. I've been unable to persuade Meson to detect zlib, whilst