Re: Allow escape in application_name

At Tue, 7 Sep 2021 11:30:27 +, "kuroda.hay...@fujitsu.com" wrote in > I attached the rebased version. Tests and descriptions were added. > In my understanding Ikeda-san's indication is included. I have some comments by a quick look. +* one have higher priority. See also th

Re: Gather performance analysis

On Tue, Sep 7, 2021 at 8:41 PM Tomas Vondra wrote: > Hi, > > The numbers presented in this thread seem very promising - clearly > there's significant potential for improvements. I'll run similar > benchmarks too, to get a better understanding of this. > Thanks for showing interest. > > Can you

Re: [UNVERIFIED SENDER] Re: Challenges preventing us moving to 64 bit transaction id (XID)?

On Tue, Sep 07, 2021 at 02:38:13PM +0800, Julien Rouhaud wrote: > On Tue, Sep 7, 2021 at 12:20 PM Michael Paquier wrote: >> And a couple of months later, the development cycle of 15 has begun. >> While re-reading the thread, I got the impression that there is no >> reason to not move on with at le

Re: Gather performance analysis

On Wed, Sep 8, 2021 at 3:08 AM Andres Freund wrote: > Looking at this profile made me wonder if this was a build without > optimizations. The pg_atomic_read_u64()/pg_atomic_read_u64_impl() calls > should > be inlined. And while perf can reconstruct inlined functions when using > --call-graph=dwa

Re: .ready and .done files considered harmful

At Tue, 7 Sep 2021 18:40:24 +, "Bossart, Nathan" wrote in > On 9/7/21, 11:31 AM, "Robert Haas" wrote: > > I guess we still have to pick one or the other, but I don't really > > know how to do that, since both methods seem to be relatively fine, > > and the scenarios where one is better than

Re: [BUG]Update Toast data failure in logical replication

On Wed, Sep 8, 2021 at 11:26 AM Ajin Cherian wrote: > On Wed, Aug 11, 2021 at 10:45 PM Dilip Kumar > wrote: > > > Yeah we can avoid that by detecting any toasted replica identity key > > in HeapDetermineModifiedColumns, check the attached patch. > > > > I had a second look at this, and I just ha

Re: Gather performance analysis

Hi, On 2021-09-08 11:45:16 +0530, Dilip Kumar wrote: > On Wed, Sep 8, 2021 at 3:08 AM Andres Freund wrote: > > > > Looking at this profile made me wonder if this was a build without > > optimizations. The pg_atomic_read_u64()/pg_atomic_read_u64_impl() calls > > should > > be inlined. And while

Re: Rewriting the test of pg_upgrade as a TAP test - take three - remastered set

On Tue, Sep 07, 2021 at 02:43:15PM -0700, Rachel Heaton wrote: > Running check tests in the pg_upgrade folder fails for this reason. Thanks, rebased as attached. Andrew has posted another patch set that completely reworks the shape of the modules by moving them into a dedicated namespace, meaning

Re: parallelizing the archiver

On Wed, Sep 8, 2021 at 6:36 AM Bossart, Nathan wrote: > > I'd like to gauge interest in parallelizing the archiver process. > [...] > Based on previous threads I've seen, I believe many in the community > would like to replace archive_command entirely, but what I'm proposing > here would build on

Re: PG Docs - CREATE SUBSCRIPTION option list order

v2 --> v3 The subscription_parameter names are now split into 2 groups using Amit's suggestion [1] on how to categorise them. I also made some grammar improvements to their descriptions. PSA. -- [1] https://www.postgresql.org/message-id/CAA4eK1Kmu74xHk2jcHTmKq8HBj3xK6n%3DRfiJB6dfV5zVSqqiFg

Re: Add jsonlog log_destination for JSON server logs

On Wed, Sep 01, 2021 at 04:39:43PM -0400, Sehrope Sarkuni wrote: > That makes the elog.c changes in the JSON logging patch minimal as all it's > really doing is invoking the new write_jsonlog(...) function. Looking at 0001, to do things in order. > @@ -46,8 +46,8 @@ typedef struct > char

<    1   2