Re: Signed vs Unsigned (take 2) (src/backend/storage/ipc/procarray.c)

2021-09-15 Thread Fujii Masao
On 2021/09/15 21:27, Ranier Vilela wrote: I found this in the commit log in the patch. I agree that these patches are refactoring ones. But I'm thinking that it's worth doing back-patch, to make future back-patching easy. Thought? Thanks for picking this. Pushed. Thanks! Regard

Re: Added schema level support for publication.

2021-09-15 Thread Amit Kapila
On Wed, Sep 15, 2021 at 12:30 PM Amit Kapila wrote: > > On Tue, Sep 14, 2021 at 2:08 PM vignesh C wrote: > > > > I have handled this in the patch attached. > > > > 4. > AlterPublicationSchemas() > { > .. > + /* > + * If the table option was not specified remove the existing tables > + * from the

Re: Hook for extensible parsing.

2021-09-15 Thread Julien Rouhaud
On Thu, Sep 16, 2021 at 5:40 AM Andres Freund wrote: > > > I don't have any better ideas to offer :-( ... but I very much fear > > that the approach proposed here is a dead end. > > I unfortunately don't see a good way forward without changing the way we do > parsing on a more fundamental level :(

Re: right join with partitioned table crash

2021-09-15 Thread Justin Pryzby
On Wed, Sep 15, 2021 at 07:53:49PM -0400, Tom Lane wrote: > Jaime Casanova writes: > > Here's another crash caught by sqlsmith. > > Fun. Looks like it fails back to v12, but not in v11, > so it's some optimization we added in v12 that's at fault. It seems to be a regression (?) in 12.6 (2021-02

Re: proposal: possibility to read dumped table's name from file

2021-09-15 Thread Pavel Stehule
Hi In yesterday's patch I used strndup, which is not available on win. I am sending update when I used pnstrdup instead. Regards Pavel diff --git a/doc/src/sgml/ref/pg_dump.sgml b/doc/src/sgml/ref/pg_dump.sgml index 7682226b99..1b74c0eadd 100644 --- a/doc/src/sgml/ref/pg_dump.sgml +++ b/doc/src/

Re: Column Filtering in Logical Replication

2021-09-15 Thread vignesh C
On Thu, Sep 16, 2021 at 8:45 AM Amit Kapila wrote: > > On Wed, Sep 15, 2021 at 6:06 PM Alvaro Herrera > wrote: > > > > On 2021-Sep-15, vignesh C wrote: > > > The patch > > > Generic_object_type_parser_002_table_schema_publication.patch has the > > > changes that were used to handle the parsing.

Re: Allow escape in application_name

2021-09-15 Thread Fujii Masao
On 2021/09/16 12:36, kuroda.hay...@fujitsu.com wrote: you mean that this is not strtoXXX, right? Yes, the behavior of process_log_prefix_padding() is different from strtoint() or pg_strtoint32(). For example, how the heading space characters are handled is different. If we use the name like

Re: Added schema level support for publication.

2021-09-15 Thread Amit Kapila
On Wed, Sep 15, 2021 at 4:45 PM Greg Nancarrow wrote: > > On Tue, Sep 14, 2021 at 6:38 PM vignesh C wrote: > > > > I have handled this in the patch attached. > > > > Regarding the following function in the v28-0002 patch: > > +/* > + * Check if the relation schema is member of the schema list. >

Re: [Proposal] Global temporary tables

2021-09-15 Thread Pavel Stehule
Hi looks so this patch is broken again. Please, can you do rebase? Regards Pavel čt 16. 9. 2021 v 8:28 odesílatel wenjing napsal: > > > > > > > > >

<    1   2