Re: Data is copied twice when specifying both child and parent table in publication

On Wed, Dec 8, 2021 at 11:11 AM Amit Kapila wrote: > > On Tue, Dec 7, 2021 at 5:53 PM vignesh C wrote: > > > > On Fri, Dec 3, 2021 at 11:24 AM houzj.f...@fujitsu.com > > wrote: > > > > > > > 2) Any particular reason why the code and tests are backbranched but > > not the document changes? > > >

Re: row filtering for logical replication

On Thu, Dec 2, 2021 at 2:59 PM houzj.f...@fujitsu.com wrote: > ... > Attach the v44-0005 top-up patch. > This version addressed all the comments received so far, > mainly including the following changes: > 1) rename rfcol_valid_for_replica to rfcol_valid > 2) Remove the struct PublicationInfo and

Re: Data is copied twice when specifying both child and parent table in publication

On Wed, Dec 8, 2021 at 11:30 AM vignesh C wrote: > > On Wed, Dec 8, 2021 at 11:11 AM Amit Kapila wrote: > > > > On Tue, Dec 7, 2021 at 5:53 PM vignesh C wrote: > > > > > > On Fri, Dec 3, 2021 at 11:24 AM houzj.f...@fujitsu.com > > > wrote: > > > > > > > > > > 2) Any particular reason why the co

Re: Is it correct to update db state in control file as "shutting down" during end-of-recovery checkpoint?

On Wed, Dec 8, 2021 at 10:59 AM Bossart, Nathan wrote: > >> Another option we might want to consider is to just skip updating the > >> state entirely for end-of-recovery checkpoints. The state would > >> instead go straight from DB_IN_CRASH_RECOVERY to DB_IN_PRODUCTION. I > >> don't know if it's

Re: Skipping logical replication transactions on subscriber side

On Wed, Dec 8, 2021 at 2:16 PM Amit Kapila wrote: > > On Tue, Dec 7, 2021 at 5:06 PM Masahiko Sawada wrote: > > > > On Mon, Dec 6, 2021 at 2:17 PM Amit Kapila wrote: > > > > I'll submit the patch tomorrow. > > > > While updating the patch, I realized that skipping a transaction that > > is prepa

Re: GUC flags

On Mon, Dec 06, 2021 at 07:36:55AM -0600, Justin Pryzby wrote: > The script checks that guc.c and sample config are consistent. > > I think your undertanding of INTENTIONALLY_NOT_INCLUDED is not right. > That's a list of stuff it "avoids reporting" as an suspected error, not an > additional list o

Re: row filtering for logical replication

On Mon, Dec 6, 2021 at 6:04 PM Euler Taveira wrote: > > On Mon, Dec 6, 2021, at 3:35 AM, Dilip Kumar wrote: > > On Mon, Dec 6, 2021 at 6:49 AM Euler Taveira wrote: > > > > On Fri, Dec 3, 2021, at 8:12 PM, Euler Taveira wrote: > > > > PS> I will update the commit message in the next version. I bar

Re: Skipping logical replication transactions on subscriber side

On Wed, Dec 8, 2021 at 11:48 AM Masahiko Sawada wrote: > > On Wed, Dec 8, 2021 at 2:16 PM Amit Kapila wrote: > > > > On Tue, Dec 7, 2021 at 5:06 PM Masahiko Sawada > > wrote: > > > > > > On Mon, Dec 6, 2021 at 2:17 PM Amit Kapila > > > wrote: > > > > > > I'll submit the patch tomorrow. > > >

Re: Make mesage at end-of-recovery less scary.

At Tue, 09 Nov 2021 16:27:51 +0900 (JST), Kyotaro Horiguchi wrote in > This is the updated version. > > - emode_for_currupt_record() now uses currentSource instead of > readSource. > > - If zero record length is faced, make sure the whole header is zeroed > before deciding it as the end-of

Re: Skipping logical replication transactions on subscriber side

On Wed, Dec 8, 2021 at 3:50 PM Amit Kapila wrote: > > On Wed, Dec 8, 2021 at 11:48 AM Masahiko Sawada wrote: > > > > On Wed, Dec 8, 2021 at 2:16 PM Amit Kapila wrote: > > > > > > On Tue, Dec 7, 2021 at 5:06 PM Masahiko Sawada > > > wrote: > > > > > > > > On Mon, Dec 6, 2021 at 2:17 PM Amit Kap

Re: add recovery, backup, archive, streaming etc. activity messages to server logs along with ps display

On Wed, Dec 08, 2021 at 10:47:57AM +0530, Bharath Rupireddy wrote: > Thanks for taking a look at the patch. How about the attached v4? > > I added a CF entry - https://commitfest.postgresql.org/36/3443/ + else if (source == XLOG_FROM_STREAM) + ereport(LOG, + (err

Re: Make pg_waldump report replication origin ID, LSN, and timestamp.

On Mon, Dec 06, 2021 at 11:24:09PM +0900, Masahiko Sawada wrote: > On Mon, Dec 6, 2021 at 5:09 PM Michael Paquier wrote: >> Shouldn't you check for parsed.origin_lsn instead? The replication >> origin is stored there as far as I read EndPrepare(). > > Also, looking at PrepareRedoAdd(), we check

Re: Is it correct to update db state in control file as "shutting down" during end-of-recovery checkpoint?

At Wed, 8 Dec 2021 11:47:30 +0530, Bharath Rupireddy wrote in > On Wed, Dec 8, 2021 at 10:59 AM Bossart, Nathan wrote: > > >> Another option we might want to consider is to just skip updating the > > >> state entirely for end-of-recovery checkpoints. The state would > > >> instead go straight

<    1   2