Re: Support tls-exporter as channel binding for TLSv1.3

2022-10-12 Thread Michael Paquier
On Tue, Sep 20, 2022 at 11:51:44AM -0700, Jacob Champion wrote: > On Tue, Sep 20, 2022 at 11:01 AM Jacob Champion > wrote: >> Well, I'm working on a next version, but it's ballooning in complexity >> as I try to navigate the fix for OpenSSL 1.0.1 (which is currently >> failing the tests, unsurpri

Re: Move backup-related code to xlogbackup.c/.h

2022-10-12 Thread Bharath Rupireddy
On Wed, Oct 12, 2022 at 1:04 PM Alvaro Herrera wrote: > > > Hm. Here's the v3 patch set without exposing WAL insert lock related > > functions. Please have a look. > > Hmm, I don't like your 0001 very much. This sort of thing: Thanks for reviewing. > +ControlFileData * > +GetControlFile(void) >

Re: make_ctags: use -I option to ignore pg_node_attr macro

2022-10-12 Thread Tatsuo Ishii
> OK, that sounds good then. I would make a feature request to have a > switch that supresses creation of these links, then. Ok, I have added "-n" option to make_ctags so that it skips to create the links. Also I have changed make_etags so that it exec make_ctags, which seems to be the consensus

Re: Use LIMIT instead of Unique for DISTINCT when all distinct pathkeys are redundant

2022-10-12 Thread David Rowley
On Thu, 13 Oct 2022 at 16:47, Richard Guo wrote: > Currently in the patch the optimization is done before we check for > presorted paths or do the explicit sort of the cheapest path. How about > we move this optimization into the branch where we've found any > presorted paths? Maybe something lik

Re: START_REPLICATION SLOT causing a crash in an assert build

2022-10-12 Thread Masahiko Sawada
On Thu, Oct 13, 2022 at 1:21 AM Andres Freund wrote: > > Hi, > > On 2022-10-11 17:10:52 +0900, Masahiko Sawada wrote: > > +# Reset the replication slot statistics. > > +$node->safe_psql('postgres', > > + "SELECT pg_stat_reset_replication_slot('regression_slot');"); > > +my $result = $node->saf

<    1   2