Re: Invalidate the subscription worker in cases where a user loses their superuser status

2023-10-12 Thread vignesh C
On Thu, 12 Oct 2023 at 11:10, Amit Kapila wrote: > > On Sun, Oct 8, 2023 at 8:22 AM vignesh C wrote: > > > > --- a/src/include/catalog/pg_subscription.h > +++ b/src/include/catalog/pg_subscription.h > @@ -127,6 +127,7 @@ typedef struct Subscription > * skipped */ > char*name; /* Name of t

Re: Add support for AT LOCAL

2023-10-12 Thread Vik Fearing
On 10/13/23 05:07, Michael Paquier wrote: On Fri, Oct 13, 2023 at 02:20:59AM +0200, Vik Fearing wrote: On 10/10/23 05:34, Michael Paquier wrote: I am attaching a v5 that addresses the documentation bits, could you look at the business with date.c? Here is a v6 Thanks for the new version.

Re: Add support for AT LOCAL

2023-10-12 Thread Michael Paquier
On Fri, Oct 13, 2023 at 07:03:20AM +0200, Vik Fearing wrote: > Thank you, Michael君! No pb, ヴィックさん。 -- Michael signature.asc Description: PGP signature

Re: pg_upgrade's interaction with pg_resetwal seems confusing

2023-10-12 Thread Dilip Kumar
On Fri, Oct 13, 2023 at 9:29 AM Amit Kapila wrote: > > On Fri, Oct 13, 2023 at 12:00 AM Robert Haas wrote: > > > > On Thu, Oct 12, 2023 at 7:17 AM Amit Kapila wrote: > > > Now, as mentioned in the first paragraph, it seems we anyway don't > > > need to reset the WAL at the end when setting the n

Re: Tab completion for AT TIME ZONE

2023-10-12 Thread Michael Paquier
On Fri, Oct 13, 2023 at 03:07:25AM +0200, Vik Fearing wrote: > The SQL committee already has another operator starting with AT which is AT > LOCAL. The other patch was the reason why I looked at this one. At the end, I've made peace with Dagfinn's argument two messages ago, and applied the patch

Re: pg_upgrade's interaction with pg_resetwal seems confusing

2023-10-12 Thread Amit Kapila
On Fri, Oct 13, 2023 at 10:37 AM Dilip Kumar wrote: > > On Fri, Oct 13, 2023 at 9:29 AM Amit Kapila wrote: > > > > On Fri, Oct 13, 2023 at 12:00 AM Robert Haas wrote: > > > > > > On Thu, Oct 12, 2023 at 7:17 AM Amit Kapila > > > wrote: > > > > Now, as mentioned in the first paragraph, it seems

Re: PostgreSQL domains and NOT NULL constraint

2023-10-12 Thread Tom Lane
Vik Fearing writes: > Regardless of what the spec may or may not say about v1.d, it still > remains that nulls should not be allowed in a *base table* if the domain > says nulls are not allowed. Not mentioned in this thread but the > constraints are also applied when CASTing to the domain. Hm

Re: Invalidate the subscription worker in cases where a user loses their superuser status

2023-10-12 Thread Amit Kapila
On Fri, Oct 13, 2023 at 10:04 AM vignesh C wrote: > > On Thu, 12 Oct 2023 at 11:10, Amit Kapila wrote: > > > > On Sun, Oct 8, 2023 at 8:22 AM vignesh C wrote: > > > > > > > --- a/src/include/catalog/pg_subscription.h > > +++ b/src/include/catalog/pg_subscription.h > > @@ -127,6 +127,7 @@ typedef

Re: Tab completion for AT TIME ZONE

2023-10-12 Thread Vik Fearing
On 10/13/23 06:31, Michael Paquier wrote: On Fri, Oct 13, 2023 at 03:07:25AM +0200, Vik Fearing wrote: The SQL committee already has another operator starting with AT which is AT LOCAL. The other patch was the reason why I looked at this one. Thank you for updating and committing this patc

Re: Pro et contra of preserving pg_proc oids during pg_upgrade

2023-10-12 Thread Laurenz Albe
On Thu, 2023-10-12 at 19:56 +0300, Nikita Malakhov wrote: > Say, we have data processed by some user function and we want to keep > reference to this function > in our data. In this case we have two ways - first - store string output of > regprocedure, which is not > very convenient, and the seco

Re: [PATCH] Add support function for containment operators

2023-10-12 Thread jian he
On Tue, Aug 1, 2023 at 10:07 AM Laurenz Albe wrote: > > > > > > > I had an idea about this: > > > So far, you only consider constant ranges. But if we have a STABLE range > > > expression, you could use an index scan for "expr <@ range", for example > > > Index Cond (expr >= lower(range) AND expr

<    1   2