Re: Pgoutput not capturing the generated columns

Hi, here are my review comments for patch v7-0002 == Commit Message NITPICKS - rearrange paragraphs - typo "donot" - don't start a sentence with "And" - etc. Please see the attachment for my suggested commit message text updates and take from it whatever you agree with. == doc/src/sgml/

Re: Xact end leaves CurrentMemoryContext = TopMemoryContext

On Tue, 18 Jun 2024 at 16:53, Tom Lane wrote: > I'll poke at this tomorrow, unless you're hot to try it right now. Please go ahead. I was just in suggestion mode here. David

Re: What is a typical precision of gettimeofday()?

> On 19 Mar 2024, at 13:28, Peter Eisentraut wrote: > > I feel that we don't actually have any information about this portability > concern. Does anyone know what precision we can expect from gettimeofday()? > Can we expect the full microsecond precision usually? At PGConf.dev Hannu Kross

Flush pgstats file during checkpoints

Hi all, On HEAD, xlog.c has the following comment, which has been on my own TODO list for a couple of weeks now: * TODO: With a bit of extra work we could just start with a pgstat file * associated with the checkpoint redo location we're starting from. Please find a patch series to imp

Re: Conflict Detection and Resolution

On Tue, Jun 18, 2024 at 10:17 AM Dilip Kumar wrote: > > On Mon, Jun 17, 2024 at 3:23 PM Amit Kapila wrote: > > > > On Wed, Jun 12, 2024 at 10:03 AM Dilip Kumar wrote: > > > > > > On Tue, Jun 11, 2024 at 7:44 PM Tomas Vondra > > > wrote: > > > > > > > > Yes, that's correct. However, many cases c

Re: Missing docs for new enable_group_by_reordering GUC

On 6/18/24 09:32, Bruce Momjian wrote: This commit added enable_group_by_reordering: commit 0452b461bc4 Author: Alexander Korotkov Date: Sun Jan 21 22:21:36 2024 +0200 It mentions it was added as a GUC to postgresql.conf, but I see no SGML docs for this new GUC value.

Re: Conflict Detection and Resolution

On Mon, Jun 17, 2024 at 8:51 PM Robert Haas wrote: > > On Mon, Jun 17, 2024 at 1:42 AM Amit Kapila wrote: > > The difference w.r.t the existing mechanisms for holding deleted data > > is that we don't know whether we need to hold off the vacuum from > > cleaning up the rows because we can't say w

DOCS: Generated table columns are skipped by logical replication

Hi hackers, While reviewing another thread that proposes to include "generated columns" support for logical replication [1] I was looking for any existing PostgreSQL documentation on this topic. But, I found almost nothing about it at all -- I only saw one aside mention saying that logical replic

Re: Conflict Detection and Resolution

On Tue, Jun 18, 2024 at 11:54 AM Dilip Kumar wrote: > > On Mon, Jun 17, 2024 at 8:51 PM Robert Haas wrote: > > > > On Mon, Jun 17, 2024 at 1:42 AM Amit Kapila wrote: > > > The difference w.r.t the existing mechanisms for holding deleted data > > > is that we don't know whether we need to hold of

Re: State of pg_createsubscriber

On 18.06.24 05:59, Amit Kapila wrote: 1. After promotion, the pre-existing replication objects should be removed (either optionally or always), otherwise, it can lead to a new subscriber not being able to restart or getting some unwarranted data. [1][2]. 2. Retaining synced slots on new subscrib

Maybe don't process multi xmax in FreezeMultiXactId() if it is already marked as invalid?

On 14.06.2024 10:45, Anton A. Melnikov wrote: The src/backend/access/heap/README.tuplock says about HEAP_XMAX_INVALID bit that "Any tuple with this bit set does not have a valid value stored in XMAX." Found that FreezeMultiXactId() tries to process such an invalid multi xmax and may looks for a

Re:Re: Add support to TLS 1.3 cipher suites and curves lists

Hi, Thanks a lot for the review. Indeed the original ssl_ecdh_curve is used to set a single value of curve name. If we want to change it to indicate a list of curve names, is there any rule for naming in Postgres? like ssl_curve_groups? Original Email

<    1   2