Hi,
On Fri, 12 Sept 2025 at 02:17, Melanie Plageman
wrote:
>
> While looking at this, I decided it didn't make sense to have sweep
> variables in the strategy object, so I've actually changed the way
> StrategySweepNextBuffer() works. There was also an issue with the
> sweep -- it could run into
On Tuesday, September 2, 2025 6:00 PM shveta malik
wrote:
>
> On Mon, Sep 1, 2025 at 5:45 PM shveta malik
> wrote:
> >
> > >
> > > Here is V70 patch set.
> > >
> >
> > The patch v70-0001 looks good to me. Verified, all the old issues are
> > resolved.
> >
> > Will resume review of v70-0002 now
Hi Andres / Robert,
On Mon, Sep 8, 2025 at 5:55 PM Andres Freund wrote:
>
> Hi,
>
> On 2025-09-06 09:12:19 -0400, Robert Treat wrote:
[..]
> > > [..], but 6.1 is the LTS kernel, so plenty of people
> > > are going to hit those regressions with io_uring io_method, won't
> > > they?
>
> I doubt it,
Hi all,
One obstacle to the move of pg_stat_statements to the shmem pgstats
that we have in core is that there is no easy way to track the total
number of entries that are stored in the shared hash table of pgstats
for variable-sized stats kinds.
PGSS currently hash_get_num_entries() as a cheap w
516 contributors this cycle vs 462 last cycle.
When name accents/capitalization differed, I went with the string used in
the previous year.
Some of the names that come from bug reports and doc fixes are just first
names, and the discussion threads shed no light on the full name of the
person.
I
On Tue, Sep 9, 2025 at 2:39 PM Zhijie Hou (Fujitsu)
wrote:
> I agree. For synchronized_standby_slots, I think it is acceptable to report
> only
> parsing errors, because slots could be dropped even after validating the slot
> existence during GUC loading. Additionally, we would report WARNINGs fo
On 2025-09-12 08:36, Peter Eisentraut wrote:
On 08.09.25 15:20, Holger Hoffstätte wrote:
I tried building against LLVM-21 and noticed that a function for symbol
lookup was renamed (without semantic changes), breaking the LLVM JIT.
The following patch fixes this by adding a version guard. It appl
On Fri, Sep 12, 2025 at 8:55 AM Zhijie Hou (Fujitsu)
wrote:
>
> I agree. Here is a V73 patch that will restart the worker if the retention
> resumes. I also addressed other comments posted by Amit[1].
>
Few comments:
* In adjust_xid_advance_interval(), for the case when retention is
On Fri, Sep 12, 2025 at 8:55 AM Zhijie Hou (Fujitsu)
wrote:
>
>
> I agree. Here is a V73 patch that will restart the worker if the retention
> resumes. I also addressed other comments posted by Amit[1].
>
Thanks for the patch. Few comments:
1)
There is a small window where worker can exit while
> On Sep 12, 2025, at 15:23, Michael Paquier wrote:
>
>
> --
> Michael
> <0001-Add-support-for-entry-counting-in-pgstats.patch><0002-injection_points-Add-entry-counting.patch>
The code overall looks good to me, very clear and neat. Just a few small
comments:
1 - 0001
```
+* set. T
Hi Amit,
On Mon, Sep 8, 2025 at 9:52 AM Ashutosh Sharma wrote:
>
> Hi Amit,
>
> On Sat, Sep 6, 2025 at 10:46 AM Amit Kapila wrote:
> >
> > On Fri, Sep 5, 2025 at 12:50 PM Ashutosh Sharma
> > wrote:
> > >
> > > Good to hear that you’re also interested in working on this task.
> > >
> > > On Thu
On Fri, Sep 12, 2025 at 9:38 AM Amit Kapila wrote:
>
>
> One thing related to this which needs a discussion is after this
> change, it is possible that part of the transaction contains
> additional logical_wal_info. I couldn't think of a problem due to this
> but users using pg_waldump or other WA
hi.
in [1],
RememberAllDependentForRebuilding
/*
* A policy can depend on a column because the column is
* specified in the policy's USING or WITH CHECK qual
* expressions. It might be possible to rewrite and recheck
On Thu, 11 Sept 2025 at 12:00, Rahila Syed wrote:
>
> Hi,
>
>
>>
>>
>> BTW, we should also try to conclude on my yesterday's point as to why
>> it is okay to have the same behavior for default_tablespace and
>> default_table_access_method and not for this parameter? I am asking
>> because if we ch
On Thu, Sep 11, 2025 at 9:27 AM Chao Li wrote:
>
> But v2 needs a rebase, I cannot apply it to master.
>
hi.
please check attached v3-0001, v3-0002.
v3-0001: ALTER TABLE DROP COLUMN cascade to drop any whole-row
referenced constraints and indexes.
v3-0002: ALTER COLUMN SET DATA TYPE error out wh
On Friday, September 12, 2025 4:48 PM shveta malik
wrote:
> On Fri, Sep 12, 2025 at 8:55 AM Zhijie Hou (Fujitsu)
> wrote:
> >
> >
> > I agree. Here is a V73 patch that will restart the worker if the
> > retention resumes. I also addressed other comments posted by Amit[1].
> >
>
> Thanks for the
On Fri, Sep 12, 2025 at 1:07 PM Ashutosh Sharma wrote:
>
> On Mon, Sep 8, 2025 at 9:52 AM Ashutosh Sharma wrote:
> >
> > I think we can do that, since sync_skip_reason appears to be a
> > descriptive metadata rather than statistical data like
> > slot_sync_skip_count and last_slot_sync_skip. Howe
On Mon, Sep 8, 2025 at 7:07 PM Jakub Wartak
wrote:
>
> On Tue, Aug 26, 2025 at 1:53 PM Amul Sul wrote:
> >
> [..patch]
>
> Hi Amul!
>
Thanks for your review. I'm replying to a few of your comments now,
but for the rest, I need to think about them. I'm kind of in agreement
with some of them for t
Hi, Tom!
Thank you for working on this. I see you've fixed the patch and
committed it as a0b99fc1220. I tested it a bit and see some side effects
which may be unintentional.
1. SCHEMA lost object_name.
Before:
postgres=# create schema foo;
CREATE SCHEMA
postgres=# drop schema fo
Even the documentation states/warns:
"Set restore_command to a simple command to copy files from the WAL archive. If
you plan to have multiple standby servers for high availability purposes, make
sure that recovery_target_timeline is set to latest (the default), to make the
standby server follow
Hello hackers,
I've noticed some places where elements of ProcGlobal->allProcs are
addressed directly via arr index.
But in proc.h macros GetPGProcByNumber exist, that was added to get proc
objects by index,
so I suggest minor refactoring 'ProcGlobal->allProcs[index]' ->
'GetPGProcByNumber(inde
On 12.09.2025 14:01, Sergey Shinderuk wrote:
object_name is null for the table column, but not null for its default
value.
As for schema_name, I'm not sure whether it should be null or not.
Currently schema_name is null for triggers and policy objects, but that
may be accidental.
Perhaps "
On 2025-09-12 09:47, Holger Hoffstätte wrote:
On 2025-09-12 08:36, Peter Eisentraut wrote:
In my testing with LLVM 21, I'm getting an additional error:
../src/backend/jit/llvm/llvmjit_wrap.cpp:56:18: error: no matching constructor
for initialization of 'llvm::orc::RTDyldObjectLinkingLayer'
On Fri, Sep 12, 2025, at 2:05 AM, Amit Kapila wrote:
> Yeah, I am also not sure that it is worth adding a new option to save
> backward compatibility for this option. It seems intuitive to use
> existing publications when they exist, though we should clearly
> document it.
>
That's why we have a "
On 05.09.25 14:30, Peter Eisentraut wrote:
On 29.08.25 14:48, Álvaro Herrera wrote:
On 2025-Aug-29, jian he wrote:
On Fri, Aug 29, 2025 at 5:46 AM Tom Lane wrote:
WFM, although I think you could shorten it to "tables, materialized
views, and foreign tables". We generally expect that parti
On 04.09.25 11:01, Peter Eisentraut wrote:
On 03.09.25 17:04, Peter Eisentraut wrote:
Consider a third-party extension that does something like dblink or
postgres_fdw. It will compile against a server and also a libpq. The
server and the libpq might not be of the same major version. (On
Deb
Hi,
On 11/09/2025 16:28, Sami Imseih wrote:
I prefer a separate thread for this, as it's an optimization of the
existing behavior.
OK, I removed my changes to CreatePortal. I left the test description
fixes and added a proposed commit message.
If no objections I will set it to ready for com
Peter Eisentraut writes:
> I propose the attached patch to fix this. I think this restores the
> original meaning better.
I'm okay with this wording change, but I would stay with
ERRCODE_FEATURE_NOT_SUPPORTED rather than calling this
a "syntax error". It's not a syntax error IMV, but a
potenti
Hi,
On Tue, 2 Sept 2025 at 17:54, Andrew Dunstan wrote:
>
> Ah, you’re right, but then again, I’d expect ALL_SGML to be used
> consistently, but it isn't and I didn't check.
> v3 does that.
> Note that GENERATED_SGML where'te included in these two targets but I think
> there's no harm in check
On 2025-09-12 14:47, Holger Hoffstätte wrote:
I temporarily removed the __arch64__ guard and can reproduce the above error,
using either gcc-15 or clang-21. It seems this llvm monkey patch backport thing
is affected by the following commit in llvm-21:
https://github.com/llvm/llvm-project/commit/
Thanks Shveta for all your comments. I'll prepare a version 2 of the patch
including your proposals.
Regards
Fabrice
On Thu, 11 Sep 2025, 07:42 shveta malik wrote:
> On Sun, Sep 7, 2025 at 1:32 PM Fabrice Chapuis
> wrote:
> >
> > Hi,
> > Here the version 1 of the patch with the modifications.
On 12.09.25 16:52, David E. Wheeler wrote:
On Sep 12, 2025, at 10:37, Peter Eisentraut wrote:
This was a change that was intentionally backpatched in a different way in
order to preserve ABI compatibility. Compare commits 344662848ac on
REL_18_STABLE and 0b934d3994f on REL_17_STABLE. So ev
On Sep 12, 2025, at 11:37, Peter Eisentraut wrote:
> I don't think we need any ABI checking until there is a dot-0 release, so I
> don't agree that a facility like that is needed.
Hrm. I wonder how best to filter out a branch without a dot-0 tag.
> Just compare against the previous release tag
On Fri, Sep 12, 2025 at 11:08 AM Tom Lane wrote:
> I was arguing for labeling plan nodes according to which OJ they
> start (always a unique relid). Richard was arguing for labeling
> according to which OJ(s) they complete (zero, one, or more relids).
I agree with everything in your reply up to
Hello Peter!
Thanks for updates. Here is a small fix for clang "variable set but not
used" warnings.
--
Regards,
Timur Magomedov
From 8c17b18dc0c15ae87945169a85c3ee944fc815b7 Mon Sep 17 00:00:00 2001
From: Timur Magomedov
Date: Fri, 12 Sep 2025 17:09:50 +0300
Subject: [PATCH] Fixed "set but not
Robert Haas writes:
> So, it looks to me like the way this works today is that
> join_is_legal() figures out the relevant SpecialJoinInfo and then
> add_outer_joins_to_relids() decides what to add to the joinrel's relid
> set. So I think, though I am not quite sure, that if somewhere around
> that
On Fri, 2025-09-12 at 14:04 +0900, Michael Paquier wrote:
> On Fri, Sep 12, 2025 at 10:21:27AM +0530, Dilip Kumar wrote:
> > Yeah, asserting it at the end makes sense, as we can ensure that
> > XLogFlush() and XLogNeedsFlush() agree on the same thing without
> > adding additional overhead. Here is
On 08.09.25 17:17, David E. Wheeler wrote:
The RC1 change surprised me a little; here’s the log:
Leaf changes summary: 1 artifact changed
Changed leaf types summary: 0 leaf type changed
Removed/Changed/Added functions summary: 0 Removed, 1 Changed, 0 Added function
Removed/Changed/Added variabl
On Tue, 2025-09-09 at 23:13 -0400, Jonathan S. Katz wrote:
> Hi,
>
> Attached is a draft of the PostgreSQL 18 GA press release. A few
> comments before the ask for reviewing:
"This release adds the [`PG_UNICODE_FAST`], which accelerates lookups
using the `upper` and `lower` string comparison fun
Peter Eisentraut writes:
> On 12.09.25 16:52, David E. Wheeler wrote:
>> Excellent! But an example like this presumably helps make Tom’s case that
>> each branch could have a file that suggests which commit to use as the base
>> for comparison, so that in this example it could be set to 34466284
Hi.
Per Coverity.
Coverity reports this resource leak in test_binaryheap module.
I think that is right.
Trivial patch attached.
best regards,
Ranier Vilela
avoid-resource-leak-test_binaryheap.patch
Description: Binary data
Álvaro Herrera wrote:
> On 2025-Sep-12, Antonin Houska wrote:
>
> > Euler Taveira wrote:
> >
> > > Interesting. I'm wondering that if this patch is applied we could remove
> > > the
> > > following code [...] from pg_logical_slot_get_changes_guts and
> > > LogicalSlotAdvanceAndCheckSnapState
On Wed, Sep 10, 2025 at 12:00 PM Arseniy Mukhin
wrote:
>
>
> 6) We have fixed size queue entries, so I think we don't need this
> "padding" logic at the end of the page anymore, because we know how
> many entries we can have on each page.
+1
Probably we also no longer need to have a pair of page
On 2025-09-12 Fr 10:12 AM, Nazir Bilal Yavuz wrote:
Hi,
On Tue, 2 Sept 2025 at 17:54, Andrew Dunstan wrote:
Ah, you’re right, but then again, I’d expect ALL_SGML to be used consistently,
but it isn't and I didn't check.
v3 does that.
Note that GENERATED_SGML where'te included in these two
On Fri, Sep 12, 2025 at 8:46 AM Jonathan S. Katz wrote:
>
> On 9/9/25 11:13 PM, Jonathan S. Katz wrote:
> > Hi,
> >
> > Attached is a draft of the PostgreSQL 18 GA press release. A few
> > comments before the ask for reviewing:
> >
> > * I still need to write up the theme and the quote, which I'll
On Fri, Sep 12, 2025 at 10:11:59AM -0700, Jeff Davis wrote:
> The name PG_UNICODE_FAST is meant to convey that it provides full
> unicode semantics for case mapping and pattern matching, while also
> being fast because it uses memcmp for comparisons. While the name
> PG_C_UTF8 is meant to convey th
Here are some review comments on v3-0004:
In general, I think this looks pretty nice, but I think it needs more
cleanup and polishing.
There doesn't seem to be any reason for
astreamer_waldump_content_new() to take an astreamer *next argument.
If you look at astreamer.h, you'll see that some astr
On Fri, Sep 12, 2025 at 1:54 PM Ranier Vilela wrote:
> Per Coverity.
>
> Coverity reports this resource leak in test_binaryheap module.
> I think that is right.
>
> Trivial patch attached.
If this were correct, we'd need to also free the memory in all the
error paths. But of course, in both error
On Fri, Sep 12, 2025 at 9:03 AM Naga Appani wrote:
>
+
+
+ Returns statistics about current multixact usage:
+ num_mxids is the total number of multixact IDs
assigned since startup,
+ num_members is the total number of multixact
member entries created since startup,
GetMultiXactInfo() returns
Hello,
Thanks for putting this together! It's quite the monster. I read
through and found the following points worth mentioning:
I think almost all of the non-stock section titles Are Lacking Case
Title.
> The new
> [`io_method`](https://www.postgresql.org/docs/18/runtime-config-resource.html
Hi,
On 2025-09-02 10:24:34 +0200, Daniel Gustafsson wrote:
> > On 15 Aug 2025, at 12:20, Nazir Bilal Yavuz wrote:
> > On Fri, 15 Aug 2025 at 12:19, Daniel Gustafsson wrote:
> >>
> >>> On 15 Aug 2025, at 10:46, Nazir Bilal Yavuz wrote:
>
> >>> Sometimes OpenBSD CI tasks fail with 'No space lef
=?utf-8?Q?=C3=81lvaro?= Herrera writes:
> On 2025-Sep-12, Tom Lane wrote:
>> My concern is that when we get a report, we might decide to apply
>> some fix to remove the ABI delta, or we might decide it's intentional
>> and/or harmless and leave the code as-is.
> The solution I propose for this (w
>> Attached are the v18 patches for adding RESPECT/IGNORE NULLS options
>> to some window functions. Recent changes to doc/src/sgml/func.sgml
>> required v17 to be rebased. Other than that, nothing has been changed.
>>
>> Oliver, do you have any comments on the patches?
>>
>
> Looks good, tried it
Noah Misch writes:
> On Thu, Sep 11, 2025 at 10:12:59PM -0400, Tom Lane wrote:
>> I'm content with making it master-only.
> I've pushed the test update to master.
Thanks. I'll go deal with the original issue shortly.
regards, tom lane
On Thu, Sep 11, 2025 at 10:12:59PM -0400, Tom Lane wrote:
> Noah Misch writes:
> > On Thu, Sep 11, 2025 at 03:34:47PM -0400, Tom Lane wrote:
> >> However ... it might still be okay to cram it into v18. Do you have
> >> an opinion about that?
>
> > Feels like something I wouldn't do, but I don't
On Fri, Sep 12, 2025 at 2:28 PM Robert Haas wrote:
> Is there a real need to pass XLogDumpPrivate to astreamer_wal_read or
> astreamer_archive_read? The only things that they need are archive_fd,
> archive_name, archive_streamer, archive_streamer_buf, and
> archive_streamer_read_ptr. In other word
On Fri, Sep 12, 2025 at 12:13:23PM -0700, Jeff Davis wrote:
> On Fri, 2025-09-12 at 13:21 -0500, Nico Williams wrote:
> > How does one do form-insensitive comparisons?
>
> If you mean case insensitive matching, you can do:
I meant form-insensitive, as in comparing equivalent strings where one
mig
On Tue, Aug 26, 2025 at 4:58 AM Andrei Lepikhov wrote:
>
> 1. Why is it necessary to maintain the GetExplainExtensionId and
> GetPlannerExtensionId routines? It seems that using a single
> extension_id (related to the order of the library inside the
> file_scanner) is more transparent and more str
On Fri, 2025-09-12 at 15:48 -0500, Nico Williams wrote:
> I meant form-insensitive, as in comparing equivalent strings where
> one
> might be using decomposed sequences and another pre-conposed
> sequences
> (and either might be normalized or not at all).
Use NORMALIZE(a) = NORMALIZE(b).
This is
I wrote:
> Looking at the patch, the delta in database.out raises
> another question:
> ALTER DATABASE regression_tbd RENAME TO regression_utf8;
> ALTER DATABASE regression_utf8 SET TABLESPACE regress_tblspace;
> ALTER DATABASE regression_utf8 RESET TABLESPACE;
> +ERROR: unrecognized configurat
On Sat, Sep 6, 2025 at 9:52 AM Paul Ohlhauser
wrote:
> My point is not that the user is not happy, that they have to change
> permissions.
> It is that the user would rather get a clear error message than to get two
> separate messages (warning that doesn't mention "ignore" and authentication
>
Robert Haas writes:
> On Fri, Sep 12, 2025 at 1:54 PM Ranier Vilela wrote:
>> Coverity reports this resource leak in test_binaryheap module.
>> I think that is right.
> If this were correct, we'd need to also free the memory in all the
> error paths. But of course, in both error and non-error pa
Hmm. I don't have a copy of Andrei's email in my gmail. I see it in
the archives but I have not got it. I don't understand how that
happened. I now wonder if there are other emails from Andrei I haven't
received.
On Fri, Sep 12, 2025 at 4:34 PM Melanie Plageman
wrote:
> On Tue, Aug 26, 2025 at 4:
Hi,
On Wed, Sep 10, 2025 at 8:13 PM Amit Kapila wrote:
>
> > How about streaming the conflicts in fixed format to a separate log
> > file other than regular postgres server log file?
>
> I would prefer this info to be stored in tables as it would be easy to
> query them. If we use separate LOGs t
Hi,
On Fri, Sep 12, 2025 at 3:13 AM Dilip Kumar wrote:
>
> I was looking into another thread where we provide an error table for
> COPY [1], it requires the user to pre-create the error table. And
> inside the COPY command we will validate the table, validation in that
> context is a one-time pro
> Only question is if we should avoid the extra portal hashtable lookup as
> well, or leave that for a separate patch.
I prefer a separate thread for this, as it's an optimization of the
existing behavior.
--
Sami Imseih
Amazon Web Services (AWS)
> I hear what you're saying, but I don't see how it relates to the
> paragraph you replied to.
I realized something incorrect in my last email: I wrote that google
doesn't ask permission for the email/profile scope. That's not true,
it didn't show the scope screen because I already gave permission
On Fri, 2025-09-12 at 08:06 +0200, Peter Eisentraut wrote:
> committed
Thank you!
Laurenz Albe
68 matches
Mail list logo
