Re: Optimize LISTEN/NOTIFY

2025-10-10 Thread Joel Jacobson
On Fri, Oct 10, 2025, at 20:46, Joel Jacobson wrote: > On Wed, Oct 8, 2025, at 20:46, Tom Lane wrote: >> "Joel Jacobson" writes: >>> On Tue, Oct 7, 2025, at 22:15, Tom Lane wrote: 5. ChannelHashAddListener: "already registered" case is not reached, which surprises me a bit, and neither i

Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options

2025-10-10 Thread Tatsuo Ishii
>> Also the error is certainly user-facing, >> so using elog() was quite inappropriate. It should be ereport with an >> errcode of (probably) ERRCODE_FEATURE_NOT_SUPPORTED. Rolling your >> own implementation of get_func_name() wasn't great either. > > I overlooked the elog() call and "own implem

Re: speedup COPY TO for partitioned table.

2025-10-10 Thread Álvaro Herrera
On 2025-Oct-10, jian he wrote: > On Fri, Oct 10, 2025 at 6:03 AM Masahiko Sawada wrote: > > Yes, but I think it's more consistent given that we use the > > parentheses in all other places in copyto.c. > > If you look at tablecmds.c, like ATExecSetNotNull, there are > parentheses and no parenthe

Re: [PATCH TEST] Fix logical replication setup in subscription test `t/009_matviews.pl`

2025-10-10 Thread Ashutosh Bapat
On Fri, Oct 10, 2025 at 1:20 PM Hayato Kuroda (Fujitsu) wrote: > > Dear Michael, > > > On Thu, Oct 09, 2025 at 03:37:25PM +0300, Грем Снорт wrote: > > > I've found a simple problem in one of subscription tests > > > (`src/test/subscription/t/009_matviews.pl`). > > > > (Added a couple of folks in C

Re: [PATCH] jit: fix build with LLVM-21

2025-10-10 Thread Holger Hoffstätte
On 2025-09-12 16:22, Holger Hoffstätte wrote: On 2025-09-12 14:47, Holger Hoffstätte wrote: I temporarily removed the __arch64__ guard and can reproduce the above error, using either gcc-15 or clang-21. It seems this llvm monkey patch backport thing is affected by the following commit in llvm-2

Re: [PATCH] Remove make_temptable_name_n()

2025-10-10 Thread Nathan Bossart
On Fri, Oct 10, 2025 at 06:22:46PM +0300, Aleksander Alekseev wrote: > The proposed patch removes make_temptable_name_n() in matview.c. This > function is used only once and can be replaced with psprintf(). This dates back to commit cc1965a, and I see some discussion about this function in the cor

Re: Preserve index stats during ALTER TABLE ... TYPE ...

2025-10-10 Thread Bertrand Drouvot
Hi, On Fri, Oct 10, 2025 at 07:37:59AM -0500, Sami Imseih wrote: > Hi, > > Thanks for raising this issue and for the patch! Thanks for looking at it! > > As you can see, the index stats (linked to the column that has been > > altered) are > > not preserved. I think that they should be preserve

Re: [PATCH TEST] Fix logical replication setup in subscription test `t/009_matviews.pl`

2025-10-10 Thread Amit Kapila
On Thu, Oct 9, 2025 at 6:07 PM Грем Снорт wrote: > > Hello! > I've found a simple problem in one of subscription tests > (`src/test/subscription/t/009_matviews.pl`). > When running this test, it completes successfully (All tests successful. > Result: PASS) but there is an error in subscriber's l

Re: speedup COPY TO for partitioned table.

2025-10-10 Thread jian he
On Fri, Oct 10, 2025 at 6:03 AM Masahiko Sawada wrote: > > > > --- > > > + relation_name = get_rel_name(childreloid); > > > + ereport(ERROR, > > > + errcode(ERRCODE_WRONG_OBJECT_TYPE), > > > + errmsg("cannot co

Re: [PATCH] ecpg: check return value of replace_variables()

2025-10-10 Thread Daniel Gustafsson
> On 7 Oct 2025, at 16:04, Aleksander Alekseev wrote: > Currently in src/interfaces/ecpg/ecpglib/prepare.c we don't check the > return value of replace_variables(). The proposed patch fixes this. > The rest of the code looks OK to me. Seems reasonable on a first glance, I'll pick it up. -- Dani

Re: URLs in rbtree.c are broken

2025-10-10 Thread Chao Li
On Fri, Oct 10, 2025 at 3:34 PM Daniel Gustafsson wrote: > > On 10 Oct 2025, at 09:00, Chao Li wrote: > > > For the first one, by search for “Thomas Niemann’s Sorting and Searching > Algorithms: a Cookbook”, I got > https://www.epaperpress.com/sortsearch/rbt.html, but I am not sure it > provides

Re: RFC: extensible planner state

2025-10-10 Thread Robert Haas
On Fri, Oct 10, 2025 at 11:58 AM Tom Lane wrote: > Should the CF entry be closed out now? > > https://commitfest.postgresql.org/patch/5994/ Yes, done now. -- Robert Haas EDB: http://www.enterprisedb.com

Re: new environment variable INITDB_LOCALE_PROVIDER

2025-10-10 Thread Jeff Davis
On Sat, 2025-10-11 at 08:30 +0800, Chao Li wrote: > * If we make that fail, I don’t think that would break existing > scripts. Because the default provider is libc and you are introducing > a new environment variable to set locale provider, thus a plain > initdb will not use builtin provider. Maybe

Re: create table like including storage parameter

2025-10-10 Thread jian he
On Wed, Oct 1, 2025 at 2:42 PM jian he wrote: > > “including parameters” would add another keyword "PARAMETERS''. > currently "INCLUDING STORAGE PARAMETER" no need to add a new keyword. > If other people favor “including parameters”, then we can do it that > way in the future. > > attached is just