Re: New docs chapter on Transaction Management and related changes

2022-11-18 Thread Bruce Momjian
thought contains a negative. > > In any case, are you thinking something like this: > > " 64 open subxids are cached in shared memory for each backend; after > that point the overhead increases significantly due to additional disk I/O > f

Re: New docs chapter on Transaction Management and related changes

2022-11-18 Thread Bruce Momjian
hen it first causes a database modification. > Frequently abbreviated as xid. > When stored on disk, xids are only 32-bits wide, so only > approximately four billion write transaction IDs can be generated; > to permit the system to run for longer tha

Re: New docs chapter on Transaction Management and related changes

2022-11-18 Thread Bruce Momjian
AND CHAIN is specified, a new transaction is > immediately started with the same transaction characteristics (seelinkend="sql-set-transaction"/>) as the just finished one. > This new transaction won't be in the aborted state, even > if the old transaction was

Re: New docs chapter on Transaction Management and related changes

2022-11-18 Thread Bruce Momjian
must be allocated. Yeah, I went with more generic wording since the point seems to be that sometimes xid and sometimes vxids are waited on. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Indecision is a decision. Inaction is an action. Mark Batterson

Re: New docs chapter on Transaction Management and related changes

2022-11-18 Thread Bruce Momjian
On Tue, Nov 15, 2022 at 10:16:44AM +, Simon Riggs wrote: > On Tue, 8 Nov 2022 at 03:41, Bruce Momjian wrote: > > > > On Mon, Nov 7, 2022 at 10:58:05AM +, Simon Riggs wrote: > > > What I've posted is the merged patch, i.e. your latest patch, plus > >

Re: New docs chapter on Transaction Management and related changes

2022-11-18 Thread Bruce Momjian
On Fri, Nov 18, 2022 at 02:33:26PM -0500, Bruce Momjian wrote: > On Sun, Nov 13, 2022 at 12:56:30PM +0100, Laurenz Albe wrote: > > > Maybe there's a way to reword the entire phrase that leads to a better > > > formulation of the idea. > > > > Any of your

Re: New docs chapter on Transaction Management and related changes

2022-11-22 Thread Bruce Momjian
are shown in > > + pg_locks > > + in columns virtualxid and > > + transactionid. Read-only transactions > > + will have virtualxids but NULL > > + transactionids, while read-write transactions > > + will have both as non-NULL. > > + > > P

Re: New docs chapter on Transaction Management and related changes

2022-11-22 Thread Bruce Momjian
ppose it's a stylistic choice.) I think we have a plurality mismatch so I went with "SQL statements" and didn't need "an" or "any" (even newer paragraph version): Transactions can be created explicitly using BEGIN or START TRANSACTION and ended using

Re: New docs chapter on Transaction Management and related changes

2022-11-22 Thread Bruce Momjian
On Tue, Nov 22, 2022 at 07:47:26PM +0100, Erik Rijkers wrote: > Op 22-11-2022 om 19:00 schreef Bruce Momjian: > > On Mon, Nov 21, 2022 at 11:15:36AM +0100, Laurenz Albe wrote: > > >..., while both columns will be set in read-write transactions. > > > > Agreed, ch

Re: New docs chapter on Transaction Management and related changes

2022-11-23 Thread Bruce Momjian
On Wed, Nov 23, 2022 at 08:57:33AM +0100, Laurenz Albe wrote: > On Tue, 2022-11-22 at 13:50 -0500, Bruce Momjian wrote: > > Agreed, updated patch attached. > > I cannot find any more problems, and I shouldn't mention the extra empty > line at the end of the patch. Fixed.

Re: New docs chapter on Transaction Management and related changes

2022-11-23 Thread Bruce Momjian
On Wed, Nov 23, 2022 at 02:17:19AM -0600, Justin Pryzby wrote: > On Tue, Nov 22, 2022 at 01:50:36PM -0500, Bruce Momjian wrote: > > + > > + > > + A more complex example with multiple nested subtransactions: > > + > > +BEGIN; > > +INSERT INTO ta

Re: Prefetch the next tuple's memory during seqscans

2022-11-23 Thread Bruce Momjian
/storage-page-layout.html#STORAGE-PAGE-LAYOUT-FIGURE I remember someone showing that having our item pointers at the _end_ of the page and tuples at the start moving toward the end increased performance significantly. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Indecision is a decision. Inaction is an action. Mark Batterson

Re: Prefetch the next tuple's memory during seqscans

2022-11-23 Thread Bruce Momjian
On Wed, Nov 23, 2022 at 11:03:22AM -0500, Bruce Momjian wrote: > > CPUs have several different kinds of 'hardware prefetchers' (worth > > reading about), that look out for sequential and striding patterns and > > try to get the cache line ready before you access

Re: Document parameter count limit

2022-11-23 Thread Bruce Momjian
n't want this". > > > Yeah, the wording is a bit tongue-in-cheek.  Figured assuming a committer > wants > this at all we'd come up with better wording.  I like your suggestion. Does this come up enough to document it? I assume the error message the user receives i

Re: Add sub-transaction overflow status in pg_stat_activity

2022-11-23 Thread Bruce Momjian
er internal/warning columns in that view, I think it makes sense. Oddly, is our 64 snapshot performance limit even documented anywhere? I know it is in Simon's patch I am working on. -- Bruce Momjian https://momjian.us EDB https://enterprise

Re: Patch: Global Unique Index

2022-11-25 Thread Bruce Momjian
hecking. I am actually not sure how that can be done without locking all indexes or inserting placeholder entries in all indexes. (Yeah, that sounds bad, unless I am missing something.) -- Bruce Momjian https://momjian.us EDB https://enterprised

Re: Report roles in pg_upgrade pg_ prefix check

2022-11-25 Thread Bruce Momjian
heck is only executed against the old cluster the patch removes the > check when printing the error. +1 -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Embrace your flaws. They make you human, rather than perfect, which you will never be.

Re: An attempt to avoid locally-committed-but-not-replicated-to-standby-transactions in synchronous replication

2022-11-28 Thread Bruce Momjian
are telling me all three cloud vendors changed how query cancel behaves on an unresponsive synchronous replica? That is certainly a testament that the community needs to change or at least review our behavior. -- Bruce Momjian https://momjian.us EDB ht

Re: An attempt to avoid locally-committed-but-not-replicated-to-standby-transactions in synchronous replication

2022-11-28 Thread Bruce Momjian
sirability -> Design -> Implement -> Test -> Review -> Commit https://wiki.postgresql.org/wiki/Todo#Development_Process Telling us what other cloud vendors do is not sufficient. -- Bruce Momjian https://momjian.us EDB

Re: Patch: Global Unique Index

2022-11-28 Thread Bruce Momjian
On Fri, Nov 25, 2022 at 05:03:06PM -0800, David Zhang wrote: > Hi Bruce, > > Thank you for helping review the patches in such detail. > > On 2022-11-25 9:48 a.m., Bruce Momjian wrote: > > Looking at the patch, I am unclear how the the patch prevents concurrent

Re: CF 2022-11: entries "Ready for Committer" with recent activity

2022-11-28 Thread Bruce Momjian
age-id/flat/canbhv-e_iy9fmrerxrch8tztyenpfo72hf_xd2hldppva4d...@mail.gmail.com > > Seems committable. I plan to commit this in a few hours. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Embrace your flaws. They make you human, rather than perfect, which you will never be.

Re: Add 64-bit XIDs into PostgreSQL 15

2022-11-28 Thread Bruce Momjian
ortgage > company every month just to be sure they don't get mad. I think the problem is that we still have bloat with 64-bit XIDs, specifically pg_xact and pg_multixact files. Yes, that bloat is less serious, but it is still an issue worth reporting in the server logs, though not serious

Re: An attempt to avoid locally-committed-but-not-replicated-to-standby-transactions in synchronous replication

2022-11-28 Thread Bruce Momjian
On Mon, Nov 28, 2022 at 01:31:39PM -0800, Andrey Borodin wrote: > On Mon, Nov 28, 2022 at 12:59 PM Bruce Momjian wrote: > > > > You can prepare a patch, but it unlikely to get much interest until you > > get agreement on what the behavior should be. > > We discu

Re: Add 64-bit XIDs into PostgreSQL 15

2022-11-29 Thread Bruce Momjian
XID wraparound. If XID wraparound is no longer an issue, we might find that our freeze limits can be much higher than they are now. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Embrace your flaws. They make you human, rather than perfect, which you will never be.

Re: An attempt to avoid locally-committed-but-not-replicated-to-standby-transactions in synchronous replication

2022-11-29 Thread Bruce Momjian
; approach? I think ALTER SYSTEM should be allowed, particularly so you can modify synchronous_standby_names, no? -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Embrace your flaws. They make you human, rather than perfect, which you will never be.

Re: Add 64-bit XIDs into PostgreSQL 15

2022-11-29 Thread Bruce Momjian
a > similarly strenuous reaction is the right model. But that's also not > to say that we should do nothing at all. Yeah, we would probably need to warn on every 1 million transactions or something. -- Bruce Momjian https://momjian.us EDB

Re: New docs chapter on Transaction Management and related changes

2022-11-29 Thread Bruce Momjian
On Fri, Nov 18, 2022 at 02:11:50PM -0500, Bruce Momjian wrote: > On Mon, Nov 7, 2022 at 11:04:46PM +0100, Laurenz Albe wrote: > > On Sat, 2022-11-05 at 10:08 +, Simon Riggs wrote: > > > Agreed; new compilation patch attached, including mine and then > > > Ro

Re: Patch: Global Unique Index

2022-11-29 Thread Bruce Momjian
'd better realize that > there's a high probability of failure, or at least coming out > with something nobody will want to use. Agreed, my earlier point was that this would need a lot of thought to get right since we don't do this often. The exclusion constraint i

Re: Patch: Global Unique Index

2022-11-29 Thread Bruce Momjian
ertion is > in progress. That will be expensive in itself, and it will > turn ATTACH PARTITION into a performance disaster. Yes, that would require index locks. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Embrace your

pg_dump bugs reported as pg_upgrade bugs

2022-11-29 Thread Bruce Momjian
using pg_dump and restore and just ignoring errors or fixing them later, while this is not possible when using pg_upgrade. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Embrace your flaws. They make you human, rather than

Re: New docs chapter on Transaction Management and related changes

2022-11-30 Thread Bruce Momjian
On Wed, Nov 30, 2022 at 07:33:44AM +0100, Peter Eisentraut wrote: > On 30.11.22 02:51, Bruce Momjian wrote: > > Patch applied back to PG 11. Thanks to Simon for getting this important > > information in our docs, and for the valuable feedback from others that > > made thi

Re: pg_dump bugs reported as pg_upgrade bugs

2022-11-30 Thread Bruce Momjian
On Wed, Nov 30, 2022 at 12:22:57AM -0500, Tom Lane wrote: > Bruce Momjian writes: > > FYI, you might wonder why so many bugs reported on pg_upgrade eventually > > are bugs in pg_dump. Well, of course, partly is it because pg_upgrade > > relies on pg_dump, but a bigger iss

Re: New docs chapter on Transaction Management and related changes

2022-11-30 Thread Bruce Momjian
On Wed, Nov 30, 2022 at 07:10:35AM -0700, David G. Johnston wrote: > On Wed, Nov 30, 2022 at 6:52 AM Bruce Momjian wrote: > I'd maybe accept having it back-patched to v15 on that basis but not any > further. > > But I agree that our general behavior is to only apply this scop

Re: New docs chapter on Transaction Management and related changes

2022-11-30 Thread Bruce Momjian
On Wed, Nov 30, 2022 at 08:25:19AM -0700, David G. Johnston wrote: > On Wed, Nov 30, 2022 at 8:02 AM Bruce Momjian wrote: > On Wed, Nov 30, 2022 at 07:10:35AM -0700, David G. Johnston wrote: > If everyone agrees this new chapter is helpful, and as helpful to PG 11 > us

Re: New docs chapter on Transaction Management and related changes

2022-12-01 Thread Bruce Momjian
dy to ship. > I too vote for reverting it out of the released branches. Patch reverted in all back branches. I was hoping to get support for more aggressive backpatches of docs, but obviously failed. I should have been clearer about my intent to backpatch, and will

Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view?

2021-04-14 Thread Bruce Momjian
On Tue, Apr 13, 2021 at 01:30:16PM -0400, Álvaro Herrera wrote: > On 2021-Apr-12, Bruce Momjian wrote: > > > OK, the attached patch renames pg_stat_activity.queryid to 'query_id'. I > > have not changed any of the APIs which existed before this feature was > >

Re: partial heap only tuples

2021-04-19 Thread Bruce Momjian
nsider the lifecycle of the data over That is an intersting point --- we often focus on optimizing frequent operations, but preventing rare but expensive-in-aggregate events from happening is also useful. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com If only the physical world exists, free will is an illusion.

Re: Do we need to update copyright for PG11 branch

2021-04-19 Thread Bruce Momjian
> No, that's not our practice. We technically only update in back branches: ./doc/src/sgml/legal.sgml in head and back branches ./COPYRIGHT in back branches -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com If on

Re: when the startup process doesn't

2021-04-19 Thread Bruce Momjian
e per minute, or some > configurable interval, e.g. perhaps add messages something like this: Yes, this certainly needs improvement. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com If only the physical world exists, free will is an illusion.

Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view?

2021-04-20 Thread Bruce Momjian
On Wed, Apr 14, 2021 at 02:33:26PM -0400, Bruce Momjian wrote: > On Tue, Apr 13, 2021 at 01:30:16PM -0400, Álvaro Herrera wrote: > > On 2021-Apr-12, Bruce Momjian wrote: > > > > > OK, the attached patch renames pg_stat_activity.queryid to 'query_id'. I > >

Re: Problems around compute_query_id

2021-04-20 Thread Bruce Momjian
kend reported a queryid. For > processes > like autovacuum process, they will never report a new identifier so they > reported the previous one. Resetting the field like the other ones in > pgstat_bestart() fixes the problem for autovacuum and any similar process. I slightly adj

Re: ML-based indexing ("The Case for Learned Index Structures", a paper from Google)

2021-04-21 Thread Bruce Momjian
or concurrent performance. This means that some indexes perform very well for a single user but poorly for multiple users. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com If only the physical world exists, free will is an illusion.

Re: proposal for PostgreSQL program

2021-04-21 Thread Bruce Momjian
process. You should read the FAQs and then subscribe to the appropriate email list. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com If only the physical world exists, free will is an illusion.

Re: compute_query_id and pg_stat_statements

2021-04-24 Thread Bruce Momjian
ws an error in the server logs, but preventing server start seems extreme. Also, compute_query_id is PGC_SUSET, meaning it can be changed by the super-user, so you could enable compute_query_id without a server restart, which makes failing on start kind of odd. -- Bruce Momjian https://momjian.us

Re: compute_query_id and pg_stat_statements

2021-04-24 Thread Bruce Momjian
(or another > extension that changes it) would not have to pay the overhead. That's a pretty weird API. I think we just need people to turn it on like they are doing when the configure pg_stat_statements anyway. pg_stat_statements already requires configuration anyway. -- Bruce Mo

Re: compute_query_id and pg_stat_statements

2021-04-26 Thread Bruce Momjian
being used, right? This is closer to Magnus's idea of having a three-value compute_query_id, except is it more controlled by pg_stat_statements. Another idea would be to throw a user-visible warning if the pg_stat_statements extension is loaded and compute_query_id is off. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com If only the physical world exists, free will is an illusion.

Re: compute_query_id and pg_stat_statements

2021-04-26 Thread Bruce Momjian
On Mon, Apr 26, 2021 at 12:56:13PM -0400, Tom Lane wrote: > Stephen Frost writes: > > * Bruce Momjian (br...@momjian.us) wrote: > >> Techically, pg_stat_statements can turn on compute_query_id when it is > >> loaded, even if it is 'off' in postgresql.conf

Re: pg_hba.conf.sample wording improvement

2021-04-30 Thread Bruce Momjian
inaccurate for > example in that the current wording for "host" appears to say that it does > not apply to GSS-encrypted connections. Yes, much better. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com If only t

Re: Some oversights in query_id calculation

2021-05-03 Thread Bruce Momjian
pg_stat_statements check > > > > Sorry, my bad. I was running make check-world, but did it with -j4 flag > > which was a mistake. > > > > The patch is OK. > > Thanks for reviewing! Patch applied, thanks. -- Bruce Momjian https://momjian.us EDB

Re: v14 mechanical code beautification patches

2021-05-05 Thread Bruce Momjian
opyright (c) 2004 by Internet Systems Consortium, Inc. ("ISC") * Copyright (c) 1996,1999 by Internet Software Consortium. but I am not sure we still need to update those, so I would remove it. -- Bruce Momjian https://momjian.us EDB

Re: v14 mechanical code beautification patches

2021-05-05 Thread Bruce Momjian
gt; https://www.postgresql.org/message-id/200502021700.j12H05j20872%40candle.pha.pa.us > > which made the point that those were moving targets back in 2005. > I doubt they still are, so I don't see much point in keeping this > in the checklist. > > (There may or may not be value i

Re: v14 mechanical code beautification patches

2021-05-06 Thread Bruce Momjian
not sure it's worth analyzing the differences in detail. > I definitely wouldn't just adopt all the diffs blindly. > > In any case, that RELEASE_CHANGES item is clearly a dead letter > now, so I'll go remove it. OK, thanks for checking. I think there was some conc

Re: Have I found an interval arithmetic bug?

2021-05-07 Thread Bruce Momjian
ce of the three “justify” functions is, therefore, harmless. > > Bruce / Tom: > Can we revisit this topic ? I thought we agreed that the attached patch will be applied to PG 15. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com

Re: Have I found an interval arithmetic bug?

2021-05-07 Thread Bruce Momjian
On Fri, May 7, 2021 at 07:39:31PM -0700, Zhihong Yu wrote: > > > On Fri, May 7, 2021 at 7:23 PM Bruce Momjian wrote: > > On Fri, May  7, 2021 at 07:23:42PM -0700, Zhihong Yu wrote: > > On Tue, Apr 13, 2021 at 10:55 AM Bryn Llewellyn > wrote: >

PG 14 release notes, first draft

2021-05-09 Thread Bruce Momjian
lot of feedback. I plan to work on completing this document this coming week in preparation for beta next week. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com If only the physical world exists, free will is an illusion.

Re: PG 14 release notes, first draft

2021-05-10 Thread Bruce Momjian
On Mon, May 10, 2021 at 08:16:16AM +0200, Laurenz Albe wrote: > On Mon, 2021-05-10 at 02:03 -0400, Bruce Momjian wrote: > > When using \e in psql, if the buffer is not modified by the editor, ignore > > the editor contents and leave the buffer unchanged (Laurenz Albe) > > The

Re: PG 14 release notes, first draft

2021-05-10 Thread Bruce Momjian
On Mon, May 10, 2021 at 02:51:28PM +0800, Julien Rouhaud wrote: > On Mon, May 10, 2021 at 02:03:08AM -0400, Bruce Momjian wrote: > > I have committed the first draft of the PG 14 release notes. You can > > see the most current build of them here: > > > > ht

Re: PG 14 release notes, first draft

2021-05-10 Thread Bruce Momjian
On Mon, May 10, 2021 at 05:28:24PM +0900, Masahiko Sawada wrote: > On Mon, May 10, 2021 at 3:03 PM Bruce Momjian wrote: > > > > I have committed the first draft of the PG 14 release notes. You can > > see the most current build of them here: > > > > http

Re: PG 14 release notes, first draft

2021-05-10 Thread Bruce Momjian
On Mon, May 10, 2021 at 08:52:44PM +1200, David Rowley wrote: > On Mon, 10 May 2021 at 18:03, Bruce Momjian wrote: > > I need clarification on many items, and the document still needs its > > items properly ordered, and markup added. I also expect a lot of > > feedback. >

Re: PG 14 release notes, first draft

2021-05-10 Thread Bruce Momjian
On Mon, May 10, 2021 at 01:44:12PM +0200, Matthias van de Meent wrote: > On Mon, 10 May 2021 at 08:03, Bruce Momjian wrote: > > > > I have committed the first draft of the PG 14 release notes. You can > > see the most current build of them here: > > https://mo

Re: PG 14 release notes, first draft

2021-05-10 Thread Bruce Momjian
On Mon, May 10, 2021 at 07:39:17PM +0200, Laurenz Albe wrote: > On Mon, 2021-05-10 at 12:38 -0400, Bruce Momjian wrote: > > I came up with this release note text: > > > > > > > > > > > > When editing the previous query or a fil

Re: PG 14 release notes, first draft

2021-05-10 Thread Bruce Momjian
Previously tuples whose insertion would have exceeded the page's fill factor were instead added to new pages. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com If only the physical world exists, free will is an illusion.

Re: PG 14 release notes, first draft

2021-05-10 Thread Bruce Momjian
On Mon, May 10, 2021 at 07:50:14AM -0400, Joe Conway wrote: > On 5/10/21 2:03 AM, Bruce Momjian wrote: > > I have committed the first draft of the PG 14 release notes. You can > > see the most current build of them here: > > > > https://momjian.us/pgsql_docs/rele

Re: PG 14 release notes, first draft

2021-05-10 Thread Bruce Momjian
On Tue, May 11, 2021 at 12:35:28PM +1200, David Rowley wrote: > Thanks for making the updates. > > On Tue, 11 May 2021 at 05:07, Bruce Momjian wrote: > > > > On Mon, May 10, 2021 at 08:52:44PM +1200, David Rowley wrote: > > > > Improve the performance of parall

Re: PG 14 release notes, first draft

2021-05-10 Thread Bruce Momjian
On Mon, May 10, 2021 at 04:14:56PM -0700, Peter Geoghegan wrote: > On Mon, May 10, 2021 at 3:58 PM Bruce Momjian wrote: > > OK, you are confirming what Matthias suggested. I added these two > > items, which both seem to apply only to heap pages, not index pages: > > That

Re: PG 14 release notes, first draft

2021-05-10 Thread Bruce Momjian
On Mon, May 10, 2021 at 04:02:27PM +0300, Alexander Korotkov wrote: > Hi, Bruce! > > On Mon, May 10, 2021 at 9:03 AM Bruce Momjian wrote: > > I have committed the first draft of the PG 14 release notes. You can > > see the most current build of them here: > > >

Re: PG 14 release notes, first draft

2021-05-10 Thread Bruce Momjian
On Mon, May 10, 2021 at 10:53:03PM +0900, Ian Lawrence Barwick wrote: > 2021年5月10日(月) 15:03 Bruce Momjian : > > > > I have committed the first draft of the PG 14 release notes. You can > > see the most current build of them here: > > > > https://momj

Re: PG 14 release notes, first draft

2021-05-11 Thread Bruce Momjian
low" is wrong - should just say that VACUUM VERBOSE reports.. Updated to: Have VACUUM VERBOSE report page deletion counts for each scan of an index (Peter Geoghegan) > |By default, only the root of partitioned tables are imported. > *is* imported Fixed. > Ca

Re: PG 14 release notes, first draft

2021-05-11 Thread Bruce Momjian
On Mon, May 10, 2021 at 08:53:54PM -0700, Peter Geoghegan wrote: > On Mon, May 10, 2021 at 7:18 PM Bruce Momjian wrote: > > > > On Mon, May 10, 2021 at 04:14:56PM -0700, Peter Geoghegan wrote: > > > On Mon, May 10, 2021 at 3:58 PM Bruce Momjian wrote: > > > >

Re: PG 14 release notes, first draft

2021-05-11 Thread Bruce Momjian
On Tue, May 11, 2021 at 06:57:19AM -0400, Joe Conway wrote: > On 5/10/21 9:56 PM, Bruce Momjian wrote: > > On Mon, May 10, 2021 at 07:50:14AM -0400, Joe Conway wrote: > > > On 5/10/21 2:03 AM, Bruce Momjian wrote: > > > > I have committed the first draft of the

Re: PG 14 release notes, first draft

2021-05-11 Thread Bruce Momjian
On Mon, May 10, 2021 at 02:03:08AM -0400, Bruce Momjian wrote: > I have committed the first draft of the PG 14 release notes. You can > see the most current build of them here: > > https://momjian.us/pgsql_docs/release-14.html > > I need clarification on many items

Re: PG 14 release notes, first draft

2021-05-11 Thread Bruce Momjian
On Tue, May 11, 2021 at 11:26:48AM -0400, Joe Conway wrote: > On 5/11/21 11:11 AM, Bruce Momjian wrote: > > > Previously existence of such columns were ignored when caller had table > > > level privileges. > > > > I can't reproduce the NULL using colu

Re: PG 14 release notes, first draft

2021-05-11 Thread Bruce Momjian
On Tue, May 11, 2021 at 12:31:01PM -0400, Joe Conway wrote: > On 5/11/21 11:37 AM, Bruce Momjian wrote: > > On Tue, May 11, 2021 at 11:26:48AM -0400, Joe Conway wrote: > > > On 5/11/21 11:11 AM, Bruce Momjian wrote: > > > > > Previously existence of such col

Re: PG 14 release notes, first draft

2021-05-11 Thread Bruce Momjian
On Tue, May 11, 2021 at 03:51:39PM -0400, Tom Lane wrote: > Joe Conway writes: > > On 5/11/21 1:30 PM, Bruce Momjian wrote: > >> It just feels like this change makes the function's behavior less > >> consistent. > > > See Tom's commit message

Re: PG 14 release notes, first draft

2021-05-11 Thread Bruce Momjian
properly parse multiple adjacent discarded tokens in quotes (Alexander Korotkov) Previously, quoted text that contained multiple adjacent discarded tokens were treated as multiple tokens, causing incorrect tsquery output, e.g., websearch_to_tsquery('"aaa: bbb"') used to output 'aaa <2> bbb', but now outputs 'aaa <-> bbb'. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com If only the physical world exists, free will is an illusion.

Re: PG 14 release notes, first draft

2021-05-11 Thread Bruce Momjian
that this item be phrased more or less as follows: > > "Allow VACUUM to eagerly place newly deleted B-Tree pages in the Free > Space Map. Previously VACUUM could only place preexisting deleted > pages in the Free Space Map for recycling." So, previously

Re: PG 14 release notes, first draft

2021-05-11 Thread Bruce Momjian
fficently process cache invalidation messages This allows Logical decoding to work efficiently in presence of a large amount of DDL. > * Speed truncation of small tables on large shared buffer servers (Kirk > Jamison) > >

Re: PG 14 release notes, first draft

2021-05-11 Thread Bruce Momjian
ce map (Peter Geoghegan) Previously VACUUM could only place preexisting deleted pages in the free space map. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com If only the physical world exists, free will is an illusion.

Re: PG 14 release notes, first draft

2021-05-11 Thread Bruce Momjian
ssing "Tomas" in the first release note. Yes, I saw that and fixed, thanks. > 2. Would you want to s/standbys/subscribers/ given an instance can be in > read/write mode but still receive logical changes? Or did this patch > affect only subscribers that are also standbys? I don't know. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com If only the physical world exists, free will is an illusion.

Re: PG 14 release notes, first draft

2021-05-11 Thread Bruce Momjian
say "all crashes" here. > | Increase warning time and hard limit before transaction id and > multi-transaction wraparound (Noah Misch) > | This should reduce the number of failures without warning. > > I'd say: This should reduce the possibility of failures that occ

Re: PG 14 release notes, first draft

2021-05-11 Thread Bruce Momjian
> b4af70cb21 Simplify state managed by VACUUM. > 4753ef37e0 Use a WaitLatch for vacuum/autovacuum sleeping > 9dd963ae25 Recycle nbtree pages deleted during same VACUUM. > 3c3b8a4b26 Truncate line pointer array during VACUUM. > > ad1c36b070 Fix foreign-key selectivity estimation in

Re: PG 14 release notes, first draft

2021-05-11 Thread Bruce Momjian
TWJkhw%40mail.gmail.com Seems we might want to have a general release note item that mentions improved update/delete performance for partitioned tables, yes? I think the run-time pruning and single-parition pullup are significant. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com If only the physical world exists, free will is an illusion.

Re: PG 14 release notes, first draft

2021-05-11 Thread Bruce Momjian
On Mon, May 10, 2021 at 07:53:08AM -0700, Peter Geoghegan wrote: > On Sun, May 9, 2021 at 11:03 PM Bruce Momjian wrote: > > I have committed the first draft of the PG 14 release notes. > > This definitely isn't necessary, since the commit in question was a > totally mechan

Re: PG 14 release notes, first draft

2021-05-11 Thread Bruce Momjian
ded tokens in quotes (Alexander Korotkov) > > > > > > > > Previously, quoted text that contained multiple adjacent discarded > > tokens were treated as multiple tokens, causing incorrect tsquery > > output, e.g., websearch_to_tsquery('"aaa: bbb"') used to output > > 'aaa <2> bbb', but now outputs 'aaa <-> bbb'. > > > > > > This item looks good to me. Good, thanks. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com If only the physical world exists, free will is an illusion.

Re: PG 14 release notes, first draft

2021-05-11 Thread Bruce Momjian
On Tue, May 11, 2021 at 05:13:21PM -0500, Justin Pryzby wrote: > On Tue, May 11, 2021 at 10:35:23AM -0400, Bruce Momjian wrote: > > > | Allow more than the common name (CN) to be matched for client > > > certificate authentication (Andrew Dunstan) > > > Your d

Re: PG 14 release notes, first draft

2021-05-12 Thread Bruce Momjian
> > > 1. I do believe ther eis a missing "Tomas" in the first release note. > > 2. Would you want to s/standbys/subscribers/ given an instance can be in > > read/write mode but still receive logical changes? > > > > Right, that makes sense to

Re: PG 14 release notes, first draft

2021-05-12 Thread Bruce Momjian
On Wed, May 12, 2021 at 09:18:27AM +0530, Amit Kapila wrote: > On Wed, May 12, 2021 at 2:36 AM Bruce Momjian wrote: > > > > > > OK, I added this: > > > > > > > > > > > > Allow logical decoding to

Re: PG 14 release notes, first draft

2021-05-12 Thread Bruce Momjian
On Wed, May 12, 2021 at 10:06:05AM -0500, Justin Pryzby wrote: > On Tue, May 11, 2021 at 10:45:04PM -0400, Bruce Momjian wrote: > > OK, so this is where I am confused. I searched for distinguished name > > (DN) and came up with DN being a concatentation of all the fields >

Re: PG 14 release notes, first draft

2021-05-12 Thread Bruce Momjian
.org/message-id/CA%2BHiwqEcawatEaUh1uTbZMEZTJeLzbroRTz9_X9Z5CFjTWJkhw%40mail.gmail.com OK, I added this entry: Improve the performance of updates/deletes on partitioned tables when only a few partitions are affected (Amit Langote, Tom Lane) This also al

Re: PG 14 release notes, first draft

2021-05-12 Thread Bruce Momjian
On Tue, May 11, 2021 at 05:47:27PM -0400, Álvaro Herrera wrote: > On 2021-May-11, Bruce Momjian wrote: > > > > 86dc90056d Rework planning and execution of UPDATE and DELETE. > > > a1115fa078 Postpone some more stuff out of ExecInitModifyTable. > > > c5b7

Re: compute_query_id and pg_stat_statements

2021-05-12 Thread Bruce Momjian
in the server logs on server start via shared_preload_libraries, or when querying pg_stat_statements system view. We simply say to change compute_query_id=on or to provide a custom query id implementation. -- Bruce Momjian https://momjian.us EDB

Re: compute_query_id and pg_stat_statements

2021-05-12 Thread Bruce Momjian
On Thu, May 13, 2021 at 08:52:36AM +0800, Julien Rouhaud wrote: > On Wed, May 12, 2021 at 08:36:18PM -0400, Bruce Momjian wrote: > > The problem with compute_query_id=auto is that there is no way to know > > if the query id is actually enabled, unless you guess from the installed

Re: compute_query_id and pg_stat_statements

2021-05-12 Thread Bruce Momjian
On Thu, May 13, 2021 at 09:57:00AM +0800, Julien Rouhaud wrote: > On Wed, May 12, 2021 at 09:13:25PM -0400, Bruce Momjian wrote: > > On Thu, May 13, 2021 at 08:52:36AM +0800, Julien Rouhaud wrote: > > > > > > Well, as implemented you can get the value of compute_q

Re: PG 14 release notes, first draft

2021-05-12 Thread Bruce Momjian
Dramatically improve Unicode normalization (John Naylor) This speeds normalize() and IS NORMALIZED. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com If only the physical world exists, free will is an illusion.

Re: PG 14 release notes, first draft

2021-05-12 Thread Bruce Momjian
On Wed, May 12, 2021 at 06:06:31PM -0400, Álvaro Herrera wrote: > On 2021-May-12, Bruce Momjian wrote: > > > OK, I added it into the existing entry: > > > > > > > > > > > > Allow subscripting of jsonb (Dmitry Dolgov) > &

Re: PG 14 release notes, first draft

2021-05-12 Thread Bruce Momjian
oolean-like values which were previously synonyms of md5 are no longer accepted. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com If only the physical world exists, free will is an illusion.

Re: compute_query_id and pg_stat_statements

2021-05-12 Thread Bruce Momjian
On Thu, May 13, 2021 at 11:16:13AM +0800, Julien Rouhaud wrote: > On Wed, May 12, 2021 at 11:06:52PM -0400, Bruce Momjian wrote: > > On Thu, May 13, 2021 at 09:57:00AM +0800, Julien Rouhaud wrote: > > > > > source? What if you have for instance pg_stat_st

Re: compute_query_id and pg_stat_statements

2021-05-13 Thread Bruce Momjian
On Thu, May 13, 2021 at 12:03:42PM +0800, Julien Rouhaud wrote: > On Wed, May 12, 2021 at 11:33:32PM -0400, Bruce Momjian wrote: > I don't know what to say. So here is a summary of the complaints that I'm > aware of: > > - > https://w

Re: PG 14 release notes, first draft

2021-05-13 Thread Bruce Momjian
) This also allows updates/deletes on partitioned tables to use execution-time partition pruning. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com If only the physical world exists, free will is an illusion.

Re: compute_query_id and pg_stat_statements

2021-05-13 Thread Bruce Momjian
sm you feel would work > better? Or is that constraint incompatible with sane behavior for this > feature? I think we just need to leave it is on/off, and then help people find the way to fix it if the misconfigure it, which I think is already been shown to be possible. -- Bruce Momjian

<    8   9   10   11   12   13   14   15   16   17   >