Re: [HACKERS] Parallel Hash take II

ge w mostly optimizes response time. Resource consumption is measured by the number of disk pages accessed and number of tuples processed, while response time is the elapsed time for executing the query." http://db.cs.berkeley.edu/papers/ERL-M93-28.pdf -- Thomas Munro http://www.enterprisedb.com

Re: [HACKERS] Parallel Hash take II

to use only work_mem / participants. That'd be the other way to give Parallel Hash a fair amount of memory compared to the competition, but I didn't propose that because it'd be a change to the already-released behaviour. Then I'd have been saying "hey, look at this new plan I wrote, it performs

Re: [HACKERS] Parallel Hash take II

uld work fine if you like O(please-melt-my-computer), especially if combined with a similar approach to choosing worker numbers. Some kind of feedback system? Seems like a different kind of planner, but I have no clue. If you have ideas/papers/references, it'd be great to see a new thread on that subject. -- Thomas Munro http://www.enterprisedb.com

Re: pgindent run?

ed. > I doubt that mechanized enforcement would fall at the global minimum. Is there no way to get reasonable indentation that doesn't depend on that typedefs list? -- Thomas Munro http://www.enterprisedb.com

Re: [HACKERS] HASH_CHUNK_SIZE vs malloc rounding

ss, 512 byte size class when you allocate 32kb + 1 byte. [1] https://www.gnu.org/software/libc/manual/html_node/The-GNU-Allocator.html [2] http://goog-perftools.sourceforge.net/doc/tcmalloc.html -- Thomas Munro http://www.enterprisedb.com

Re: [HACKERS] HASH_CHUNK_SIZE vs malloc rounding

On Tue, Nov 29, 2016 at 6:27 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Thomas Munro <thomas.mu...@enterprisedb.com> writes: >> I bet other allocators also do badly with "32KB plus a smidgen". To >> minimise overhead we'd probably need to try to arrange for

Re: [HACKERS] Parallel Hash take II

articipant to arrive at > a barrier is going to be selected, and the last wakes everyone > up. Wouldn't it be better to do have the last arrived participant be > selected? It already got a scheduler timeslice, it's memory is most > likely to be in cache etc? Given that in cases w

TupleDescCopy doesn't clear atthasdef, attnotnull, attidentity

he example of CreateTupleDescCopy() I think it should also clear attnotnull and attidentity. Please see attached. -- Thomas Munro http://www.enterprisedb.com fix-TupleDescCopy-v1.patch Description: Binary data

Re: [HACKERS] Causal reads take II

On Wed, Nov 29, 2017 at 2:58 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Sat, Oct 28, 2017 at 6:24 AM, Thomas Munro > <thomas.mu...@enterprisedb.com> wrote: >> I managed to reproduce something like this on one of my home lab >> machines running a d

Re: [HACKERS] Parallel Hash take II

On Mon, Nov 27, 2017 at 10:25 PM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > On Thu, Nov 23, 2017 at 12:36 AM, Thomas Munro > <thomas.mu...@enterprisedb.com> wrote: >> Here's a new patch set with responses to the last batch of review comments. > > Rebased

Re: [HACKERS] WIP: [[Parallel] Shared] Hash

entry. It would be nice if the CF could show more clearly which thread is 'active' (for the benefit of humans and also robots), and list any others as archived/old/history. -- Thomas Munro http://www.enterprisedb.com

Re: es_query_dsa is broken

on like what you've sketched > here, because Tom will complain about breaking binary compatibility > with EState (and maybe other PlanState nodes) in a released branch. I will post both versions. I've been stuck for a while now trying to come up with a query that actually breaks, s

Re: [HACKERS] <> join selectivity estimate question

On Fri, Dec 1, 2017 at 4:05 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Wed, Nov 29, 2017 at 11:55 PM, Thomas Munro > <thomas.mu...@enterprisedb.com> wrote: >> Thank you for the original pointer and the commit. Everything here >> seems to make intuitive se

Doc tweak for huge_pages?

. I think we should adjust the manual to make clear that it's the *explicit request for huge pages* that is supported only on Linux (and hopefully soon Windows). Am I being too pedantic? -- Thomas Munro http://www.enterprisedb.com huge-pages-doc-tweak.patch Description: Binary data

Re: Doc tweak for huge_pages?

On Fri, Dec 1, 2017 at 5:04 PM, Justin Pryzby <pry...@telsasoft.com> wrote: > On Fri, Dec 01, 2017 at 04:01:24PM +1300, Thomas Munro wrote: >> Hi hackers, >> >> The manual implies that only Linux can use huge pages. That is not >> true: FreeBSD, Illumos and pr

Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)

/rows/row' PASSING t1.doc COLUMNS data int PATH 'child::a[1][attribute::hoge="haha"]') as x; + data + -- + (0 rows) + Maybe you forgot to git-add the expected file? [1] https://travis-ci.org/postgresql-cfbot/postgresql/builds/305979133 -- Thomas Munro http://www.enterprisedb.com

Re: [HACKERS] Supporting huge pages on Windows

ased version of his patch. The last version conflicted with the change from SGML to XML that just landed in commit 3c49c6fa. -- Thomas Munro http://www.enterprisedb.com win_large_pages_v15.patch Description: Binary data

Re: es_query_dsa is broken

On Thu, Nov 30, 2017 at 11:19 PM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > On Thu, Nov 30, 2017 at 4:01 AM, Robert Haas <robertmh...@gmail.com> wrote: >>> Better ideas? >> >> How about this: >> >> 1. Remo

Re: explain analyze output with parallel workers - question about meaning of information for explain.depesz.com

On Tue, Dec 5, 2017 at 8:49 PM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > On Tue, Dec 5, 2017 at 6:39 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: >> I have one another observation in the somewhat related area. From the >> code, it looks like

Re: Doc tweak for huge_pages?

On Sat, Dec 2, 2017 at 4:08 AM, Peter Eisentraut <peter.eisentr...@2ndquadrant.com> wrote: > On 11/30/17 23:35, Thomas Munro wrote: >> On Fri, Dec 1, 2017 at 5:04 PM, Justin Pryzby <pry...@telsasoft.com> wrote: >>> On Fri, Dec 01, 2017 at 04:01:24PM +1300, Thoma

Re: [sqlsmith] Parallel worker executor crash on master

ge? Not sure how either of those things could happen, since we only set it to NULL in ExecShutdownGather() after which point we shouldn't call ExecGather() again, and any MemoryContext problems with pei should have caused problems already without this patch (for example in ExecParallelCleanup). Clearly I'm missing something. -- Thomas Munro http://www.enterprisedb.com

Re: Top-N sorts verses parallelism

set_rel_pathlist will consider only pathkeys from existing index scans that set_plain_rel_pathlist found, not creating new pathkeys by sorting. -- Thomas Munro http://www.enterprisedb.com

Re: Top-N sorts verses parallelism

On Fri, Dec 15, 2017 at 10:05 AM, Jeff Janes <jeff.ja...@gmail.com> wrote: > On Tue, Dec 12, 2017 at 10:46 PM, Thomas Munro > <thomas.mu...@enterprisedb.com> wrote: >> >> Hi hackers, >> >> The start-up cost of bounded (top-N) sorts is sensitive at the sma

Re: Top-N sorts verses parallelism

the point at which the curves cross over will be hard to get right due to all kinds of other variables, so I guess that kind of thing is expected. PS Oops, I do actually know how to spell "versus". Typos are so much more embarrassing in subject lines! -- Thomas Munro http://www.enterprisedb.com

access/parallel.h lacks PGDLLIMPORT

or similar. -- Thomas Munro http://www.enterprisedb.com

Re: [HACKERS] Parallel Hash take II

would raise an error), so I removed this redundant check. > + /* If this is an overflow chunk, we skip it. */ > + if (chunk_header.overflow) > + continue; > + > + accessor->read_ntuples = 0; > +

Re: Parallel Index Scan vs BTP_DELETED and BTP_HALF_DEAD

On Wed, Dec 13, 2017 at 4:20 PM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > On Wed, Dec 13, 2017 at 3:41 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: >> Good. I hope that the patch I have posted above is able to resolve >> this problem. I am askin

Shouldn't execParallel.c null-terminate query_string in the parallel DSM?

Hi hackers, I just saw some trailing garbage in my log file emanating from a parallel worker when my query happened to be a BUFFERALIGNed length (in this case 64 characters). Did commit 4c728f382970 forget to make sure the null terminator is copied? See attached proposed fix. -- Thomas Munro

Re: es_query_dsa is broken

On Thu, Dec 7, 2017 at 12:51 PM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > On Wed, Dec 6, 2017 at 10:16 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: >> On Wed, Dec 6, 2017 at 1:14 AM, Robert Haas <robertmh...@gmail.com> wrote: >>> On Tue,

Re: [HACKERS] SERIALIZABLE with parallel query

remove it, other than that everything is fine. so I am moving the patch > into "ready for committer" state. Thank you! I will try to find a good benchmark that will really exercise parallel query + SSI. -- Thomas Munro http://www.enterprisedb.com

Re: Parallel Index Scan vs BTP_DELETED and BTP_HALF_DEAD

TED bit set, not BTP_HALF_DEAD (I could tell because I added logging). Clearly pages are periodically being marked half-dead but I haven't yet managed to get an index scan to hit one of those. -- Thomas Munro http://www.enterprisedb.com /* Set up the schema like this: drop table j

Top-N sorts verses parallelism

to underestimation of top-N for small values of N? Or is there some other way to think about this problem? Thoughts? -- Thomas Munro http://www.enterprisedb.com

Re: FP16 Support?

ese short floats as an extension type? -- Thomas Munro http://www.enterprisedb.com

Re: [HACKERS] A GUC to prevent leader processes from running subplans?

On Tue, Nov 14, 2017 at 10:30 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Sat, Nov 11, 2017 at 10:48 PM, Thomas Munro > <thomas.mu...@enterprisedb.com> wrote: >> How about parallel_leader_participation = on|off? The attached >> version has it that

Re: FP16 Support?

On Tue, Nov 14, 2017 at 6:49 PM, Kohei KaiGai <kai...@heterodb.com> wrote: > 2017-11-14 10:33 GMT+09:00 Thomas Munro <thomas.mu...@enterprisedb.com>: >> On Tue, Nov 14, 2017 at 1:11 PM, Kohei KaiGai <kai...@heterodb.com> wrote: >>> Any opinions? >> &g

Re: [HACKERS] [PATCH] Incremental sort

mpirically that it's better to be able to sort groups of at least MIN_GROUP_SIZE than to be able to skip the comparisons on the leading attributes, but why is that the case? [1] https://github.com/macdice/postgres/commit/ab0f8aff9c4b25d5598aa6b3c630df864302f572 -- Thomas Munro http://www.enterprisedb.com

Re: [HACKERS] [PATCH] Incremental sort

On Tue, Nov 21, 2017 at 1:00 PM, Alexander Korotkov <a.korot...@postgrespro.ru> wrote: > On Mon, Nov 20, 2017 at 12:24 AM, Thomas Munro > <thomas.mu...@enterprisedb.com> wrote: >> Is there some reason not to use ApplySortComparator for this? I think >> you're

could not receive data from WAL stream: SSL SYSCALL error: Success

ought I'd share this in case it makes more sense to someone more familiar with this stuff. -- Thomas Munro http://www.enterprisedb.com

Re: [HACKERS] Parallel tuplesort (for parallel B-Tree index creation)

have to call BarrierArriveAndWait() at the right time and that's all. Nice and tidy. -- Thomas Munro http://www.enterprisedb.com

Re: [HACKERS] SERIALIZABLE with parallel query

On Thu, Nov 30, 2017 at 2:44 PM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > On Thu, Nov 30, 2017 at 2:32 PM, Michael Paquier > <michael.paqu...@gmail.com> wrote: >> Could this question be answered? The patch still applies so I am >> moving it to next

Re: [HACKERS] Parallel Hash take II

On Sat, Dec 2, 2017 at 4:46 PM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > On Sat, Dec 2, 2017 at 3:54 PM, Thomas Munro > <thomas.mu...@enterprisedb.com> wrote: >> On Sat, Dec 2, 2017 at 1:55 PM, Andres Freund <and...@anarazel.de> wrote: >>> - A

Re: [HACKERS] Parallel Hash take II

On Fri, Dec 8, 2017 at 12:07 PM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > I suppose if we wanted to make this type of problem go away, but still > keep files for forensic purposes, we could introduce a "restart > number", and stick it into the top level t

Re: [HACKERS] Parallel tuplesort (for parallel B-Tree index creation)

On Fri, Dec 8, 2017 at 2:23 PM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > On Fri, Dec 8, 2017 at 1:57 PM, Peter Geoghegan <p...@bowt.ie> wrote: >> 1. Thomas' barrier abstraction was added by commit 1145acc7. I think >> that you should use a static barrier

Re: explain analyze output with parallel workers - question about meaning of information for explain.depesz.com

On Wed, Dec 6, 2017 at 12:02 AM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Tue, Dec 5, 2017 at 1:29 PM, Thomas Munro > <thomas.mu...@enterprisedb.com> wrote: >> Or would it be an option to change the time >> ExecXXXRetrieveInstrumentation() is called so

Re: explain analyze output with parallel workers - question about meaning of information for explain.depesz.com

ake that argument because I don't think it matters. The patch makes the tests in test-hash-join-rescan-instr-v1.patch pass (from my previous message). Please also consider that test patch for commit. -- Thomas Munro http://www.enterprisedb.com

Parallel Index Scan vs BTP_DELETED and BTP_HALF_DEAD

nse? [1] http://dpaste.com/05PGJ4E -- Thomas Munro http://www.enterprisedb.com

Re: Parallel Index Scan vs BTP_DELETED and BTP_HALF_DEAD

On Mon, Dec 11, 2017 at 3:51 PM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > I heard a report of a 10.1 cluster hanging with several 'BtreePage' > wait_events showing in pg_stat_activity. I forgot to add, for bug reporter credit purposes: thanks to Patrick Hemmer for the off

Re: Parallel Index Scan vs BTP_DELETED and BTP_HALF_DEAD

On Mon, Dec 11, 2017 at 8:14 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Mon, Dec 11, 2017 at 8:21 AM, Thomas Munro > <thomas.mu...@enterprisedb.com> wrote: >> ... and then it called _bt_parallel_seize() itself, in violation of >> the rule (by my reading o

Re: [HACKERS] kqueue

On Thu, Jun 22, 2017 at 7:19 PM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > I don't plan to resubmit this patch myself, but I was doing some > spring cleaning and rebasing today and I figured it might be worth > quietly leaving a working patch here just in case anyone fro

Re: Postgres with pthread

sessions eventually then I guess we'll want to model sessions as first class objects and pass them around explicitly or using a single TLS variable current_session. > I think the biggest problem with doing this for real is that it's a huge > project, and that it'll take a long time. > > Thanks for working on this! +1 [1] http://db.cs.berkeley.edu/papers/ERL-M90-34.pdf -- Thomas Munro http://www.enterprisedb.com

Re: es_query_dsa is broken

of duplicated work we do when it happens as well as scarce slot consumption. If we did that, then all of a sudden es_query_dsa would make sense again (ie it'd be whole-query scoped), and we could revert that hacky change. Or we could do both things anyway. -- Thomas Munro http://www.enterprisedb.com

Re: [HACKERS] Parallel Hash take II

vide a way for executor nodes to change their ExecProcNode functions at any later time, which requires a way for execProcnode.c to redo any wrapper functions. -- Thomas Munro http://www.enterprisedb.com parallel-hash-v28.patchset.tgz Description: GNU Zip compressed data

Re: condition variable cleanup and subtransactions

greed. That affects any user of condition variables inside DSM segments, including the released Parallel Index Scan and Parallel Bitmap Heap Scan code. -- Thomas Munro http://www.enterprisedb.com

Compiler warnings with --enable-dtrace

/38D06FCCB225BA1C6699D4E7%40amenophis [2] https://github.com/Perl/perl5/blob/a385812b685b3164e706880a72ee60c9cc9573e4/Makefile.SH#L870 -- Thomas Munro http://www.enterprisedb.com 0001-Fix-const-warnings-when-building-with-enable-dtrace.patch Description: Binary data

Re: [HACKERS] Parallel Append implementation

On Wed, May 9, 2018 at 1:15 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Tue, May 8, 2018 at 12:10 AM, Thomas Munro > <thomas.mu...@enterprisedb.com> wrote: >> It's not a scan, it's not a join and it's not an aggregation so I >> think it needs to be in a n

Re: Compiler warnings with --enable-dtrace

On Sun, May 13, 2018 at 8:40 AM, Peter Geoghegan wrote: > On Fri, May 11, 2018 at 11:46 PM, Christoph Berg wrote: >> Re: Peter Geoghegan 2018-05-12 >>

Re: [HACKERS] Parallel Append implementation

evel as those others. It's a different kind of thing. -- Thomas Munro http://www.enterprisedb.com

An out-of-date comment in nodeIndexonlyscan.c

update chains, I don't know, so I'm not sure what wording to propose instead. -- Thomas Munro http://www.enterprisedb.com

Re: [HACKERS] Clock with Adaptive Replacement

he POSIX serialisation rules, and that's independent of direct IO (which it doesn't even support). -- Thomas Munro http://www.enterprisedb.com

Re: inconsistency and inefficiency in setup_conversion()

ki.pl. I think for Windows you might need to add it to the line in src/tools/msvc/Solution.pm that invokes genbki.pl via system()? [1] https://ci.appveyor.com/project/postgresql-cfbot/postgresql/build/1.0.48 -- Thomas Munro http://www.enterprisedb.com

Re: Postgres, fsync, and OSs (specifically linux)

rtly that also needs similar machinery, but can't easily share with md.c due to technical details. I'd love there to be just one of those, and for it to be simpler and general. -- Thomas Munro http://www.enterprisedb.com

Re: Postgres, fsync, and OSs (specifically linux)

On Sat, May 19, 2018 at 4:51 PM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > Next, make check hangs in initdb on both of my pet OSes when md.c > raises an error (fseek fails) and we raise and error while raising and > error and deadlock against ourselves. Backtrac

Re: PG11 jit failing on ppc64el

t does on ppc. See build farm member eelpout which is running Debian. -- Thomas Munro http://www.enterprisedb.com

Re: Add --include-table-data-where option to pg_dump, to export only a subset of table data

ove code. + /* When match_data is set, split the pattern on the ':' chararcter, typo + * Also return extra pointer-sized data by setting extra_data paramter typo [1] https://ci.appveyor.com/project/postgresql-cfbot/postgresql/build/1.0.311 -- Thomas Munro http://www.enterprisedb.com

Re: [sqlsmith] Unpinning error in parallel worker

On Wed, Apr 25, 2018 at 8:15 AM, Jonathan Rudenberg <jonat...@titanous.com> wrote: > On Tue, Apr 24, 2018, at 16:06, Thomas Munro wrote: >> I'll write a patch to fix that unpleasant symptom. While holding >> DynamicSharedMemoryControlLock we shouldn't raise any errors

Re: Postgres 11 release notes

r a third author credit for this one? See commits 1c72ec6 (and follow-up a7a7387) which extended ARM CRC support to non-Linux systems. -- Thomas Munro http://www.enterprisedb.com

Re: printf format selection vs. reality

rce. I'm not working on this myself but I thought I'd mention it in case it interests someone out there... [1] https://clang.llvm.org/docs/ClangPlugins.html -- Thomas Munro http://www.enterprisedb.com

Re: [PATCH v14] GSSAPI encryption support

g and ending tag mismatch: para line 2026 and sect1 ^ Docs malformed. [1] http://cfbot.cputube.org/robbie-harwood.html -- Thomas Munro http://www.enterprisedb.com

Re: PG11 jit failing on ppc64el

On Thu, May 24, 2018 at 3:48 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Thomas Munro <thomas.mu...@enterprisedb.com> writes: >> BTW It is working on arm64 too, starting with LLVM 6. 5 crashed the >> same way as it does on ppc. See build farm member eelpout

Re: Allowing printf("%m") only where it actually works

On Mon, May 21, 2018 at 2:41 PM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > I've raised this on the freebsd-hackers > list, let's see... I bet there's other software out there that just > prints out "m" when things go wrong. It's arguably something that

Re: Avoiding Tablespace path collision for primary and standby

pporting some kind of variable in the tablespace path that could then be set differently in each cluster's .conf. -- Thomas Munro http://www.enterprisedb.com

Re: [HACKERS] lseek/read/write overhead becomes visible at scale ..

current HP-UX does have them... but unfortunately their man pages don't have a HISTORY section. FWIW these functions just showed up in the latest POSIX standard[2] (issue 7, 2017/2018?), having moved from "XSI option" to "base". [1] https://www.postgresql.org/message-id/flat/

Re: [HACKERS] Planning counters in pg_stat_statements

or other extensions too, and could also be used for the "query ID", which is, after all, the model that the abandoned planning_time member was following. Just a thought. -- Thomas Munro http://www.enterprisedb.com

Re: Removing unneeded self joins

ething automatic, and interesting that there is one linear knob to classify your workload rather than N knobs for N optimisations. -- Thomas Munro http://www.enterprisedb.com

Re: GiST VACUUM

m/project/postgresql-cfbot/postgresql/build/1.0.16 -- Thomas Munro http://www.enterprisedb.com

Re: PATCH: pgbench - option to build using ppoll() for larger connection counts

On Tue, Mar 27, 2018 at 9:23 AM, Rady, Doug <radyd...@amazon.com> wrote: > pgbench11-ppoll-v12.patch Hi Doug, FYI this patch is trying and failing to use ppoll() on Windows: https://ci.appveyor.com/project/postgresql-cfbot/postgresql/build/1.0.30 -- Thomas Munro http://www.enterprisedb.com

Re: Allowing printf("%m") only where it actually works

st prints out "m" when things go wrong. It's arguably something that you'd want the complier to understand as a C dialect thing. -- Thomas Munro http://www.enterprisedb.com

Re: inconsistency and inefficiency in setup_conversion()

On Fri, May 18, 2018 at 10:53 PM, John Naylor <jcnay...@gmail.com> wrote: > On 5/17/18, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: >> Hi John, >> >> This failed for my patch testing robot on Windows, with this message[1]: > ... >> I see tha

Re: Allowing printf("%m") only where it actually works

, so we'd at least have a post-commit canary. -- Thomas Munro http://www.enterprisedb.com prevent-errno.patch Description: Binary data

Re: [HACKERS] kqueue

On Wed, Apr 11, 2018 at 1:05 PM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > I heard through the grapevine of some people currently investigating > performance problems on busy FreeBSD systems, possibly related to the > postmaster pipe. I suspect this patch

Re: Add --include-table-data-where option to pg_dump, to export only a subset of table data

patch seems to be corrupted in some way, maybe ANSI control characters or something... perhaps you set colour.ui = always in your git config, instead of auto? You might also consider using git format-patch so you can include a brief commit message that explains the feature. -- Thomas Munro http://www.enterprisedb.com

Re: [HACKERS] kqueue

on in the Unix domain socket layer that is now being hacked on[2], though it's not clear if that'd affect the results reported earlier or not. [1] https://www.postgresql.org/message-id/CAEepm%3D0w9AAHAH73-tkZ8VS2Lg6JzY4ii3TG7t-R%2B_MWyUAk9g%40mail.gmail.com [2] https://reviews.freebsd.org/D15430 -- Thomas Munro http://www.enterprisedb.com

Re: Checkpoint not retrying failed fsync?

On Sun, Apr 8, 2018 at 9:17 PM, Thomas Munro wrote: > New patch attached. For Linux users (read: almost all users) this patch on its own is a bit like rearranging the deck chairs on the Titanic. Because retrying on failure is useless, among other problems, Craig and Andres are work

Re: WAL prefetch

On Sat, Jun 16, 2018 at 9:38 PM, Tomas Vondra wrote: > On 06/15/2018 08:01 PM, Andres Freund wrote: >> On 2018-06-14 10:13:44 +0300, Konstantin Knizhnik wrote: >>> On 14.06.2018 09:52, Thomas Munro wrote: >>>> Why stop at the page cache... what about shared buffer

Re: pg_config.h.win32 missing a set of flags from pg_config.h.in added in v11 development

rsion of the eternally drafty standard. Effectively, we'll fall back to ldap_init() and disallow "ldaps" unless you have a fairly recent OpenLDAP or Windows (I suspect that covers > 99% of users). -- Thomas Munro http://www.enterprisedb.com

Re: Add function to release an allocated SQLDA

riptor. If there is a This seems to be a spurious hunk, but I cannot see what changed. -- Thomas Munro http://www.enterprisedb.com

Re: [PATCH v16] GSSAPI encryption support

On Fri, Jun 8, 2018 at 9:00 AM, Nico Williams wrote: > On Tue, Jun 05, 2018 at 12:16:31PM +1200, Thomas Munro wrote: >> On Sat, May 26, 2018 at 6:58 AM, Robbie Harwood wrote: >> > Me and the bot are having an argument. This should green Linux but I >> > dunno about W

Re: Add necessary package list to ldap TAP's README

support is probably reasonable, but I'm disturbed by the lack of docs. I think he used Brew paths? https://www.postgresql.org/message-id/0a7646b1-f6f6-1364-f0e3-814aed302db4%402ndquadrant.com -- Thomas Munro http://www.enterprisedb.com

Re: Postgres, fsync, and OSs (specifically linux)

+* back, as that'd lead to loosing error reporting guarantees on s/loosing/losing/ [1] https://github.com/torvalds/linux/commit/712f4aad406bb1ed67f3f98d04c044191f0ff593 [2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit/lib/errseq.c?h=linux-4.14.y=0799a0ea96e4923f52f85fe315b62e9176a3319c -- Thomas Munro http://www.enterprisedb.com

Re: WAL prefetch

On Thu, Jun 14, 2018 at 1:09 AM, Konstantin Knizhnik wrote: > pg_wal_prefetch function will infinitely traverse WAL and prefetch block > references in WAL records > using posix_fadvise(WILLNEED) system call. Hi Konstantin, Why stop at the page cache... what about shared buffers? -

Re: Memory leaks in BufFileOpenShared()

On Fri, Jun 15, 2018 at 8:42 PM, Antonin Houska wrote: > Tatsuo Ishii wrote: > >> The changes were made by this commit to add infrastructure for sharing >> temporary files between backends, according to the author (Thomas >> Munro). >> >> http

Re: [bug fix] ECPG: freeing memory for pgtypes crashes on Windows

ses might be something like this, in their own tree, conditional on major version: #define PGTYPESchar_free(x) PGTYPESdate_free((date *)(x)) -- Thomas Munro http://www.enterprisedb.com pgtypes_freemem_v5.patch Description: Binary data

Re: Undo logs

Hi Simon, On Mon, May 28, 2018 at 11:40 PM, Simon Riggs wrote: > On 24 May 2018 at 23:22, Thomas Munro wrote: >> The lowest level piece of this work is a physical undo log manager, > >> 1. Efficient appending of new undo data from many concurrent >> backends. Lik

Re: Allowing printf("%m") only where it actually works

ror(save_errno)); > > which on the whole might be the most expedient thing. That was what I was going to propose, until I started wondering why we need to do anything here. -- Thomas Munro http://www.enterprisedb.com

Re: Allowing printf("%m") only where it actually works

ma(warning(suppress:4101)) can be used in macros (unlike #pragma) and should shut that warning up, but it doesn't work for me, not sure why). Of course that produces many errors since we do that all over the place: https://ci.appveyor.com/project/macdice/postgres/build/1.0.184 -- Thomas Munro http://w

Re: libpq compression

library mismatch would produce an incomprehensible corrupt stream message? -- Thomas Munro http://www.enterprisedb.com

Re: libpq compression

./../src/interfaces/libpq/libpq.so: undefined reference to `zpq_buffered' ../../../../../src/interfaces/libpq/libpq.so: undefined reference to `zpq_create' ../../../../../src/interfaces/libpq/libpq.so: undefined reference to `zpq_write' -- Thomas Munro http://www.enterprisedb.com

Re: [HACKERS] Partition-wise join for join between (declaratively) partitioned tables

need some tests to test PWJ with default partitions. Marking >> this as ready for committer. Hi Rajkumar, partition_join ... FAILED The regression test currently fails with your v4 patch because a redundant Result node has been removed from a query plan. That may be due to commit 11cf92f6

Re: buildfarm vs code

On Wed, Jun 6, 2018 at 4:09 AM, Andrew Dunstan wrote: > At my talk at pgcon last Friday [1] I presented some ideas for how people > could run a full buildfarm run against their code, including a 4 line recipe > using some Docker recipes I had created. Thomas Munro suggested it would

Re: [PATCH v16] GSSAPI encryption support

I put some instructions here: https://wiki.postgresql.org/wiki/Continuous_Integration The .patch there could certainly be improved (ideally, I think, it'd run the whole build farm animal script) but it's a start. -- Thomas Munro http://www.enterprisedb.com

  1   2   3   4   5   6   7   8   9   10   >