On Wed, 12 Apr 2023 at 21:45, Drouvot, Bertrand
wrote:
>
> hi hackers,
>
> In the logical decoding on standby thread [1], Andres proposed 2 new tests
> (that I did
> not find the time to complete before the finish line):
>
> - Test that we can subscribe to the standby (with the publication create
On Tue, 25 Apr 2023 at 12:51, Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 4/25/23 6:23 AM, Amit Kapila wrote:
> > On Mon, Apr 24, 2023 at 3:36 PM Drouvot, Bertrand
> > wrote:
> >>
> >> Without the second "pg_log_standby_snapshot()" then
> >> wait_for_subscription_sync() would be waiting
> >> some ti
On Wed, 26 Apr 2023 at 13:45, Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 4/26/23 6:06 AM, vignesh C wrote:
> > On Tue, 25 Apr 2023 at 12:51, Drouvot, Bertrand
> > wrote:
> > Thanks for the updated patch.
> > Few comments:
>
> Thanks for loo
On Wed, 26 Apr 2023 at 12:02, Masahiko Sawada wrote:
>
> On Tue, Mar 28, 2023 at 3:22 PM houzj.f...@fujitsu.com
> wrote:
> >
> > On Tuesday, March 28, 2023 1:41 PM Amit Kapila
> > wrote:
> > >
> > > On Mon, Mar 27, 2023 at 5:37 PM Amit Kapila
> > > wrote:
> > > >
> > > > On Mon, Mar 27, 2023 a
On Wed, 3 May 2023 at 15:59, Amit Kapila wrote:
>
> On Tue, May 2, 2023 at 4:52 PM Drouvot, Bertrand
> wrote:
> >
> >
> > As per your suggestion, changing the insert ordering (like in V8 attached)
> > makes it now work on the failing environment too.
> >
>
> I think it is better to use wait_for_
On Fri, 5 May 2023 at 12:34, Amit Kapila wrote:
>
> On Fri, May 5, 2023 at 11:08 AM Drouvot, Bertrand
> wrote:
> >
> > On 5/4/23 6:43 AM, Amit Kapila wrote:
> > > On Thu, May 4, 2023 at 8:37 AM vignesh C wrote:
> > >>
> > >> Thanks for posti
On Fri, Mar 25, 2022 at 3:29 AM Tomas Vondra
wrote:
>
> Hi,
>
> Pushed, after going through the patch once more, addressed the remaining
> FIXMEs, corrected a couple places in the docs and comments, etc. Minor
> tweaks, nothing important.
While rebasing patch [1] I found a couple of comments:
sta
On Tue, Mar 22, 2022 at 12:38 PM vignesh C wrote:
>
> Hi,
>
> This feature adds an option to skip changes of all tables in specified
> schema while creating publication.
> This feature is helpful for use cases where the user wants to
> subscribe to all the changes except fo
On Tue, Mar 22, 2022 at 3:23 PM vignesh C wrote:
>
> On Tue, Mar 22, 2022 at 5:29 AM Andres Freund wrote:
> >
> > On 2022-02-13 19:34:05 +0530, vignesh C wrote:
> > > Thanks for the comments, the attached v14 patch has the changes for the
> > > same.
On Sun, Mar 27, 2022 at 2:54 AM Andres Freund wrote:
>
> Hi,
>
> I'm working to increase the test coverage of pgstat related stuff higher (for
> the shared memory stats patch, of course).
>
> "Accidentally" noticed that
> SELECT * FROM pg_stat_get_replication_slot(NULL);
> crashes. This is pres
On Tue, Mar 29, 2022 at 11:02 AM Amit Kapila wrote:
>
> On Sat, Mar 26, 2022 at 7:53 PM vignesh C wrote:
> >
> > The patch was not applying on HEAD, attached patch which is rebased on
> > top of HEAD.
> >
>
> IIUC, this patch provides an option that allows us
On Tue, Mar 29, 2022 at 4:12 PM Amit Kapila wrote:
>
> On Tue, Mar 29, 2022 at 11:01 AM Amit Kapila wrote:
> >
> > On Sat, Mar 26, 2022 at 7:53 PM vignesh C wrote:
> > >
> > > The patch was not applying on HEAD, attached patch which is rebased on
> &g
On Wed, Mar 30, 2022 at 11:22 AM Amit Kapila wrote:
>
> On Tue, Mar 29, 2022 at 8:11 PM vignesh C wrote:
> >
> > On Tue, Mar 29, 2022 at 11:02 AM Amit Kapila
> > wrote:
> > >
> >
> > Thanks for the suggestion, I have changed the patch as suggeste
On Wed, Mar 30, 2022 at 5:42 PM Bharath Rupireddy
wrote:
>
> On Wed, Mar 30, 2022 at 5:37 PM Bharath Rupireddy
> wrote:
> >
> > On Wed, Mar 30, 2022 at 4:29 PM Amit Kapila wrote:
> > >
> > > On Wed, Mar 30, 2022 at 12:22 PM vignesh C wrote:
> >
On Wed, Mar 30, 2022 at 7:22 PM Ashutosh Bapat
wrote:
>
> Hi Vignesh,
> Some review comments on 0001
>
> On Wed, Mar 16, 2022 at 11:17 AM vignesh C wrote:
>
> >
> > The changes for the same are available int the v5 patch available at [1].
> > [1] -
>
On Thu, Mar 31, 2022 at 2:52 PM Amit Kapila wrote:
>
> On Thu, Mar 31, 2022 at 9:14 AM Amit Kapila wrote:
> >
> > On Wed, Mar 30, 2022 at 7:40 PM Ashutosh Bapat
> > wrote:
> > > >
> > > > The changes for the same are available int the v5 patch available at
> > > > [1].
> > > > [1] -
> > > > ht
On Mon, Apr 4, 2022 at 6:50 PM Ashutosh Bapat
wrote:
>
> I didn't find this in https://commitfest.postgresql.org/37/. Is this
> somewhere in the commitfest?
I missed adding it earlier, I have added it to commitfest today:
https://commitfest.postgresql.org/38/3610/
Regards,
Vignesh
and statistic collector.
Only superusers are allowed to request to log the backtrace
because allowing any users to issue this request at an unbounded rate
would cause lots of log messages and which can lead to denial of service.
On receipt of the request, at the next CHECK_FOR_INTERRUPTS(),
the targe
On Fri, Apr 8, 2022 at 4:38 AM Peter Smith wrote:
>
> Hi Vignesh, FYI the patch is recently broken again and is failing on cfbot
> [1].
>
> --
> [1] http://cfbot.cputube.org/patch_38_3610.log
I'm working on fixing a few review comments, I will be posting an
updated version to handle this tod
On Tue, Apr 5, 2022 at 6:21 AM Peter Smith wrote:
>
> Here are my comments for the latest patch v6-0001.
>
> (I will post my v6-0002 review comments separately)
>
> PATCH v6-0001 comments
> ==
>
> 1.1 General - Option name
>
> I still feel like the option name is not ideal. Unf
On Tue, Apr 5, 2022 at 8:17 AM Peter Smith wrote:
>
> Here are my comments for the latest patch v6-0002.
>
> PATCH v6-0002 comments
> ==
>
> 2.1 General - should this be an independent patch?
>
> In many ways, I think most of this patch is unrelated to the other
> "local_only"
On Tue, Apr 12, 2022 at 10:26 AM Peter Smith wrote:
>
> On Thu, Apr 7, 2022 at 2:09 PM Peter Smith wrote:
> >
> > FYI, here is a test script that is using the current patch (v6) to
> > demonstrate a way to share table data between different numbers of
> > nodes (up to 5 of them here).
> >
> > The
On Tue, Apr 12, 2022 at 12:19 PM Amit Kapila wrote:
>
> On Tue, Apr 12, 2022 at 11:53 AM vignesh C wrote:
> >
> > On Sat, Mar 26, 2022 at 7:37 PM vignesh C wrote:
> > >
> > > On Tue, Mar 22, 2022 at 12:38 PM vignesh C wrote:
> > > >
> >
On Tue, Apr 12, 2022 at 4:46 PM Amit Kapila wrote:
>
> On Tue, Apr 12, 2022 at 4:17 PM vignesh C wrote:
> >
> > On Tue, Apr 12, 2022 at 12:19 PM Amit Kapila
> > wrote:
> > >
> > >
> > > For the second syntax (Alter Publication ...), isn'
On Wed, Apr 6, 2022 at 12:29 PM vignesh C wrote:
>
> On Tue, Apr 5, 2022 at 9:18 PM Robert Haas wrote:
> >
> > On Wed, Mar 30, 2022 at 12:03 PM Justin Pryzby wrote:
> > > On Wed, Mar 30, 2022 at 11:53:52AM -0400, Greg Stark wrote:
> > > > Sadly the cfbot
On Thu, Apr 14, 2022 at 1:53 PM Peter Smith wrote:
>
> Here are my review comments for v8-0001.
>
> ==
>
> 1. Commit message
>
> CREATE SUBSCRIPTION sub1 CONNECTION 'dbname =postgres port='
> PUBLICATION pub1 with (local_only = true);
>
> The spaces in the CONNECTION string are a bit stran
On Fri, Apr 15, 2022 at 11:49 AM Kyotaro Horiguchi
wrote:
>
> At Thu, 14 Apr 2022 10:33:50 +0530, vignesh C wrote in
> > On Wed, Apr 6, 2022 at 12:29 PM vignesh C wrote:
> > >
> > > On Tue, Apr 5, 2022 at 9:18 PM Robert Haas wrote:
> > > > This lo
On Thu, Apr 14, 2022 at 7:18 PM Peter Eisentraut
wrote:
>
> On 12.04.22 08:23, vignesh C wrote:
> > I have also included the implementation for skipping a few tables from
> > all tables publication, the 0002 patch has the implementation for the
> > same.
> > This fe
On Mon, Apr 18, 2022 at 12:32 PM Amit Kapila wrote:
>
> On Fri, Apr 15, 2022 at 1:26 AM Euler Taveira wrote:
> >
> > On Thu, Apr 14, 2022, at 10:47 AM, Peter Eisentraut wrote:
> >
> > On 12.04.22 08:23, vignesh C wrote:
> > > I have also included the implem
On Tue, Apr 19, 2022 at 8:29 AM Peter Smith wrote:
>
> I checked the latest v9-0001 patch. Below are my review comments.
>
> Other than these few trivial comments this 0001 patch looks good to me.
>
> ~~~
>
> 1. src/backend/replication/pgoutput/pgoutput.c - whitespace
>
> @@ -1696,6 +1714,10 @@ st
On Wed, Apr 20, 2022 at 7:26 AM Peter Smith wrote:
>
> Below are my review comments for the v9-0002 patch (except I did not
> yet look at the TAP tests).
>
> ~~~
>
> 1. General comment - describe.c
>
> I wondered why the copy_data enum value is not displayed by the psql
> \drs+ command. Should it
On Wed, Apr 20, 2022 at 11:19 AM Peter Smith wrote:
>
> Below are my review comments for the v9-0002 patch (TAP test part only).
>
> (The order of my comments is a bit muddled because I jumped around in
> the file a bit while reviewing it).
>
> ==
>
> 1. create_subscription - missing comment.
On Fri, Apr 8, 2022 at 2:44 PM houzj.f...@fujitsu.com
wrote:
>
> On Wednesday, April 6, 2022 1:20 PM Amit Kapila
> wrote:
>
> > In this email, I would like to discuss allowing streaming logical
> > transactions (large in-progress transactions) by background workers
> > and parallel apply in gene
On Tue, Apr 26, 2022 at 11:32 AM osumi.takami...@fujitsu.com
wrote:
>
> On Thursday, April 21, 2022 12:15 PM vignesh C wrote:
> > Updated patch by changing the syntax to use EXCEPT instead of SKIP.
> Hi
>
>
> This is my review comments on the v2 patch.
>
> (1) gr
On Fri, 13 Oct 2023 at 17:15, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear hackers,
>
> > >
> > > > > I mean instead of resetwal directly modifying the control file we
> > > > > will modify that value in the server using the binary_upgrade function
> > > > > and then have that value flush to the disk
On Mon, 16 Oct 2023 at 14:44, Amit Kapila wrote:
>
> On Sat, Oct 14, 2023 at 10:45 AM Hayato Kuroda (Fujitsu)
> wrote:
> >
> > Here is a new patch.
> >
> > Previously I wrote:
> > > Based on above idea, I made new version patch which some functionalities
> > > were
> > > exported from pg_resetwa
On Tue, 17 Oct 2023 at 14:17, Amit Kapila wrote:
>
> On Fri, Oct 13, 2023 at 11:08 AM Amit Kapila wrote:
> >
> > On Fri, Oct 13, 2023 at 10:04 AM vignesh C wrote:
> > >
> > > On Thu, 12 Oct 2023 at 11:10, Amit Kapila wrote:
> > > >
> &g
On Wed, 18 Oct 2023 at 14:55, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Peter,
>
> Thank you for reviewing! PSA new version.
> Note that 0001 and 0002 are combined into one patch.
>
> > Here are some review comments for v51-0001
> >
> > ==
> > src/bin/pg_upgrade/check.c
> >
> > 0.
> > +check_old
On Mon, 16 Oct 2023 at 10:33, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Vignesh,
>
> Thank you for reviewing! PSA new version.
>
> >
> > Few comments:
> > 1) Most of the code in binary_upgrade_set_next_oid is similar to
> > SetNextObjectId, but SetNextObjectId has the error handling to report
> > an
On Wed, 18 Oct 2023 at 14:55, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Peter,
>
> Thank you for reviewing! PSA new version.
> Note that 0001 and 0002 are combined into one patch.
>
> > Here are some review comments for v51-0001
> >
> > ==
> > src/bin/pg_upgrade/check.c
> >
> > 0.
> > +check_old
On Thu, 31 Aug 2023 at 17:18, Kumar, Sachin wrote:
>
> Hi Everyone, based on internal discussion with Masahiko
> I have implemented concurrent DDL support for initial schema sync.
>
> Concurrent Patch workflow
>
> 1. When TableSync worker creates a replicaton slot, It will
> save the slot lsn into
On Fri, 7 Jul 2023 at 12:41, Masahiko Sawada wrote:
>
> On Wed, Jul 5, 2023 at 11:14 AM Masahiko Sawada wrote:
> >
> > On Mon, Jun 19, 2023 at 5:29 PM Peter Smith wrote:
> > >
> > > Hi,
> > >
> > > Below are my review comments for the PoC patch 0001.
> > >
> > > In addition, the patch needed re
On Thu, 19 Oct 2023 at 16:14, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Vignesh,
>
> Thanks for reviewing! New patch can be available in [1].
>
> >
> > Few comments:
> > 1) We will be able to override the value of max_slot_wal_keep_size by
> > using --new-options like '--new-options "-c
> > max_slo
On Thu, 19 Oct 2023 at 16:16, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Vignesh,
>
> Thanks for revieing! New patch can be available in [1].
>
> > Few comments:
> > 1) Even if we comment 3rd point "Emit a non-transactional message",
> > test_slot2 still appears in the invalid_logical_replication_slo
On Thu, 21 Sept 2023 at 11:27, Michael Paquier wrote:
>
> On Fri, Sep 15, 2023 at 03:08:21PM +0530, vignesh C wrote:
> > On Tue, 12 Sept 2023 at 14:25, Hayato Kuroda (Fujitsu)
> > wrote:
> >> Is there a possibility that apply worker on old cluster connects to th
On Fri, 27 Oct 2023 at 12:09, vignesh C wrote:
>
> On Thu, 21 Sept 2023 at 11:27, Michael Paquier wrote:
> >
> > On Fri, Sep 15, 2023 at 03:08:21PM +0530, vignesh C wrote:
> > > On Tue, 12 Sept 2023 at 14:25, Hayato Kuroda (Fujitsu)
> > > wrote:
> > &
On Tue, 31 Oct 2023 at 17:51, Amit Kapila wrote:
>
> On Tue, Oct 31, 2023 at 4:53 PM Nisha Moond wrote:
> >
> > There is a failure with 't/003_logical_slots.pl' test during the
> > upgrade. The failure is intermittent and observed in the Windows
> > environment.
> >
>
> How did you reach the conc
On Fri, 27 Oct 2023 at 17:05, Amit Kapila wrote:
>
> On Fri, Oct 27, 2023 at 12:09 PM vignesh C wrote:
> >
> > Apart from this I'm still checking that the old cluster's subscription
> > relations states are READY state still, but there is a possibility
>
On Wed, 1 Nov 2023 at 10:13, Michael Paquier wrote:
>
> On Mon, Oct 30, 2023 at 03:05:09PM +0530, vignesh C wrote:
> > The patch was not applying because of recent commits. Here is a
> > rebased version of the patches.
>
> + * We don't want the launcher to run w
1dc1f841296dd40b3f37ecaf Mon Sep 17 00:00:00 2001
From: Vignesh C
Date: Fri, 3 Nov 2023 14:57:48 +0530
Subject: [PATCH] Added GUC hook for max_logical_replication_workers.
During a binary upgrade, pg_upgrade sets this variable to 0 via the command
line in an attempt to prevent startup of the
On Tue, 7 Nov 2023 at 13:25, Amit Kapila wrote:
>
> On Tue, Nov 7, 2023 at 10:01 AM Zhijie Hou (Fujitsu)
> wrote:
> >
> > On Tuesday, November 7, 2023 12:14 PM Kuroda, Hayato/黒田 隼人
> > wrote:
> > >
> > > Dear hackers,
> > >
> > > PSA the patch to solve the issue [1].
> > >
> > > Kindly Peter E.
his cannot synchronize the table data, maybe the message should
> be more like "Timed out while waiting for the table state to become
> 'd' (datasync)"
Modified
> ~~~
>
> 30.
> +command_fails(
> + [
> + 'pg_upgrade', '--no-sync',
On Thu, 2 Nov 2023 at 17:01, Amit Kapila wrote:
>
> On Thu, Nov 2, 2023 at 3:41 PM vignesh C wrote:
> >
> > I have slightly modified it now and also made it consistent with the
> > replication slot upgrade, but I was not sure if we need to add
> > anything more
On Wed, 8 Nov 2023 at 08:43, vignesh C wrote:
>
> On Tue, 7 Nov 2023 at 13:25, Amit Kapila wrote:
> >
> > On Tue, Nov 7, 2023 at 10:01 AM Zhijie Hou (Fujitsu)
> > wrote:
> > >
> > > On Tuesday, November 7, 2023 12:14 PM Kuroda, Hayato/黒田 隼人
On Thu, 9 Nov 2023 at 21:12, Tristan Partin wrote:
>
> On Thu Nov 9, 2023 at 9:31 AM CST, Nazir Bilal Yavuz wrote:
> > Hi,
> >
> > On Thu, 9 Nov 2023 at 18:27, Tristan Partin wrote:
> > >
> > > Can you try with Meson v1.2.3?
> >
> > I tried with Meson v1.2.3 and upstream, both failed with the sam
endencies on
> the slots and origins to see that the spawned sync workers turned
> crazy because of the inconsistencies. Right?
I did testing in the same lines that you mentioned. Apart from that I
also reviewed the design where it was using the old subscription id
like in case of table sync w
On Thu, 9 Nov 2023 at 07:44, Peter Smith wrote:
>
> Thanks for addressing my previous review comments.
>
> I re-checked the latest patch v12-0001 and found the following:
>
> ==
> Commit message
>
> 1.
> The new SQL binary_upgrade_create_sub_rel_state function has the following
> syntax:
> SEL
On Mon, 13 Nov 2023 at 13:52, Michael Paquier wrote:
>
> On Fri, Nov 10, 2023 at 07:26:18PM +0530, vignesh C wrote:
> > I did testing in the same lines that you mentioned. Apart from that I
> > also reviewed the design where it was using the old subscription id
> > li
ync worker spawned after the upgrade because the subscription ID
> + * tracked by the publisher does not match anymore.
>
> missing whitespace
>
> /SUBREL_STATE_DATASYNC:A relation/SUBREL_STATE_DATASYNC: A relation/
Modified
Also added a couple of missing test cases. The atta
On Mon, 13 Nov 2023 at 17:02, Amit Kapila wrote:
>
> On Fri, Nov 10, 2023 at 7:26 PM vignesh C wrote:
> >
> > Thanks for the comments, the attached v13 version patch has the
> > changes for the same.
> >
>
> +
> + ReplicationOriginNameForLogicalRep(
On Mon, 13 Nov 2023 at 17:49, Amit Kapila wrote:
>
> On Mon, Nov 13, 2023 at 5:01 PM Amit Kapila wrote:
> >
> > On Fri, Nov 10, 2023 at 7:26 PM vignesh C wrote:
> > >
> > > Thanks for the comments, the attached v13 version patc
On Fri, 10 Nov 2023 at 19:26, vignesh C wrote:
>
> On Thu, 9 Nov 2023 at 12:23, Michael Paquier wrote:
> >
>
> > Note: actually, this would be OK if we are able to keep the OIDs of
> > the subscribers consistent across upgrades? I'm OK to not do nothing
> >
On Sun, 19 Nov 2023 at 06:52, vignesh C wrote:
>
> On Fri, 10 Nov 2023 at 19:26, vignesh C wrote:
> >
> > On Thu, 9 Nov 2023 at 12:23, Michael Paquier wrote:
> > >
> >
> > > Note: actually, this would be OK if we are able to keep the OIDs of
> &
7;, $new_sub1->data_dir, '-b', $bindir,
> + '-B', $bindir,'-s', $new_sub1->host,
> + '-p', $old_sub1->port, '-P', $new_sub1->port,
> + $mode,
> + ],
> + 'run of pg_upgrade --ch
On Thu, 16 Nov 2023 at 18:25, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Vignesh,
>
> Thanks for updating the patch! Here are some comments.
> They are mainly cosmetic because I have not read yours these days.
>
> 01. binary_upgrade_add_sub_rel_state()
>
> ```
> +/* We must check these things bef
FROM tab_not_upgraded1");
> +is($result, qq(0),
> + "no change in table tab_not_upgraded1 afer enable subscription which
> is not part of the publication"
>
> /afer/after/
Modified
> ~~~
>
> 14.
> +# -
On Tue, 21 Nov 2023 at 07:11, Michael Paquier wrote:
>
> On Mon, Nov 20, 2023 at 09:49:41AM +0530, Amit Kapila wrote:
> > On Tue, Nov 14, 2023 at 7:21 AM vignesh C wrote:
> >> There are couple of things happening here: a) In the first part we
> >> take care of se
On Thu, 23 Nov 2023 at 05:56, Peter Smith wrote:
>
> Here are some review comments for patch v17-0001
>
> ==
> src/bin/pg_dump/pg_dump.c
>
> 1. getSubscriptionTables
>
> +/*
> + * getSubscriptionTables
> + * Get information about subscription membership for dumpable tables. This
> + *wil
f there's a subscription with tables
> in a state other than 'r' (ready) or 'i' (init) and/
Modified
The attached v19 version patch has the changes for the same.
Regards,
Vignesh
From 5f3a248ff1f723c01d55bcaeb665c5f8f38824a1 Mon Sep 17 00:00:00 2001
From: Vignesh C
On Mon, 20 Nov 2023 at 05:27, Michael Paquier wrote:
>
> On Sun, Nov 19, 2023 at 06:56:05AM +0530, vignesh C wrote:
> > On Sun, 19 Nov 2023 at 06:52, vignesh C wrote:
> >> On Fri, 10 Nov 2023 at 19:26, vignesh C wrote:
> >>> I will analyze more on this and po
On Sat, 25 Nov 2023 at 17:50, Amit Kapila wrote:
>
> On Sat, Nov 25, 2023 at 7:21 AM vignesh C wrote:
> >
>
> Few comments on v19:
> ==
> 1.
> +
> + The subscriptions will be migrated to the new cluster in a disabled
> state.
On Fri, 24 Nov 2023 at 18:37, Shubham Khanna
wrote:
>
> n Fri, Nov 24, 2023 at 6:33 PM vignesh C wrote:
> >
> > Hi,
> >
> > Improved tab completion for "ALTER DEFAULT PRIVILEGE" and "ALTER TABLE":
> > 1) GRANT, REVOKE and FOR USER keyword
On Mon, 27 Nov 2023 at 17:12, Amit Kapila wrote:
>
> On Mon, Nov 27, 2023 at 3:18 PM vignesh C wrote:
> >
> > On Sat, 25 Nov 2023 at 17:50, Amit Kapila wrote:
> > >
> > > On Sat, Nov 25, 2023 at 7:21 AM vignesh C wrote:
> > > >
> > >
&g
On Sat, 25 Nov 2023 at 17:50, Amit Kapila wrote:
>
> 2.
> + * b) SUBREL_STATE_SYNCDONE: A relation upgraded while in this state
> + * would retain the replication origin in certain cases.
>
> I think this is vague. Can we briefly describe cases where the origins
> would be retained?
Modified
> 3
On Mon, 27 Nov 2023 at 06:53, Peter Smith wrote:
>
> Here are some review comments for patch set v19*
>
> //
>
> v19-0001.
>
> No comments
>
> ///
>
> v19-0002.
>
> (I saw that both changes below seemed cut/paste from similar
> functions, but I will ask the questions anyway).
>
> ==
>
On Wed, 29 Nov 2023 at 15:02, Amit Kapila wrote:
>
> On Tue, Nov 28, 2023 at 4:12 PM vignesh C wrote:
> >
>
> Few comments on the latest patch:
> ===
> 1.
> + if (fout->remoteVersion >= 17)
> + appendPQExpBufferStr(query, &qu
On Thu, 30 Nov 2023 at 06:37, Peter Smith wrote:
>
> Here are some review comments for patch v20-0001
>
> ==
>
> 1. getSubscriptions
>
> + if (dopt->binary_upgrade && fout->remoteVersion >= 17)
> + appendPQExpBufferStr(query, " s.subenabled\n");
> + else
> + appendPQExpBufferStr(query, " f
On Thu, 30 Nov 2023 at 13:35, Amit Kapila wrote:
>
> On Wed, Nov 29, 2023 at 3:02 PM Amit Kapila wrote:
> >
>
> In general, the test cases are a bit complex to understand, so, it
> will be difficult to enhance these later. The complexity comes from
> the fact that one upgrade test is trying to te
t; /b) if/b)/
Modified
> ~~~
>
> 14.
> +# Create another subscription and drop the subscription's replication origin
> +$old_sub->safe_psql('postgres',
> + "CREATE SUBSCRIPTION regress_sub4 CONNECTION '$connstr' PUBLICATION
> regress_pub3 WITH (
On Tue, 5 Dec 2023 at 11:11, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Sawada-san, hackers,
>
> Based on comments I made a fix. PSA the patch.
>
Thanks for the patch, the changes look good to me.
Regards,
Vignesh
ate");
>
> Hmm. Not sure that this is safe. Shouldn't this be a
> poll_query_until(), polling that the state of the relation is what we
> want it to be after requesting a fresh of the publication on the
> subscriber?
This is not required as the table will be added in init s
On Thu, 7 Dec 2023 at 07:20, Masahiko Sawada wrote:
>
> On Mon, Dec 4, 2023 at 8:01 PM Amit Kapila wrote:
> >
> > On Fri, Dec 1, 2023 at 11:24 PM vignesh C wrote:
> > >
> > > The attached v22 version patch has the changes for the same.
> > >
> >
On Wed, 13 Dec 2023 at 01:56, Masahiko Sawada wrote:
>
> On Thu, Dec 7, 2023 at 8:15 PM vignesh C wrote:
> >
> > On Tue, 5 Dec 2023 at 10:56, Michael Paquier wrote:
> > >
> > > On Mon, Dec 04, 2023 at 04:30:49PM +0530, Amit Kapila wrote:
> > > &g
On Wed, 6 Dec 2023 at 12:59, Michael Paquier wrote:
>
> On Wed, Dec 06, 2023 at 12:15:50PM +0530, Shubham Khanna wrote:
> > Patch is not applying. Please share the Rebased Version. Please find the
> > error:
>
> Thanks. Here you go with a v6.
Few comments:
1) Now that the MSVC build scripts are
On Tue, 19 Dec 2023 at 02:06, Daniel Verite wrote:
>
> Hi,
>
> PFA a patch that attempts to fix the bug that \. on a line
> by itself is handled incorrectly by COPY FROM ... CSV.
> This issue has been discussed several times previously,
> for instance in [1] and [2], and mentioned in the
> doc f
On Mon, 18 Dec 2023 at 19:00, Jelte Fennema-Nio wrote:
>
> The more I think about it and look at the code, the more I like the
> usage of the loop style proposed in the previous 0003 patch (which
> automatically declares a loop variable for the scope of the loop using
> a second for loop).
>
> I d
On Tue, 19 Dec 2023 at 21:22, Nathan Bossart wrote:
>
> On Tue, Dec 19, 2023 at 03:44:43PM +0100, Jelte Fennema-Nio wrote:
> > On Tue, 19 Dec 2023 at 11:59, vignesh C wrote:
> >> I noticed that this change can be done in several other places too.
> >
> > M
On Tue, 19 Dec 2023 at 20:54, Peter Eisentraut wrote:
>
> On 18.12.23 14:52, Peter Eisentraut wrote:
> >> 2) I had seen that if sed/gzip is not available meson build will fail:
> >> 2.a)
> >> Program gsed sed found: NO
> >> meson.build:334:6: ERROR: Program 'gsed sed' not found or not executable
>
On Tue, 19 Dec 2023 at 16:57, Daniel Verite wrote:
>
> vignesh C wrote:
>
> > I noticed that these tests are passing without applying patch too:
>
> > +insert into copytest2(test) values('line1'), ('\.'), ('line2');
> > +co
On Wed, 20 Dec 2023 at 21:13, Peter Eisentraut wrote:
>
> On 20.12.23 12:40, Andres Freund wrote:
> > Hm, or perhaps we should just get rid of sed use altogether. The sepgsql
> > case
> > is trivially translateable to perl, and postprocess_dtrace.sed isn't
> > much harder.
>
> Maybe yeah, but als
Hi,
I didn't see anyone volunteering for the January Commitfest, so I'll
volunteer to be CF manager for January 2024 Commitfest.
Regards,
Vignesh
On Fri, 22 Dec 2023 at 01:17, Daniel Verite wrote:
>
> vignesh C wrote:
>
> > Thanks for the updated patch, any reason why this is handled only in csv.
> > postgres=# copy test1 from '/home/vignesh/postgres/inst/bin/copy1.out';
> > COPY 1
> &
On Sun, 24 Dec 2023 at 07:16, Michael Paquier wrote:
>
> On Sat, Dec 23, 2023 at 08:52:38AM +0530, vignesh C wrote:
> > I didn't see anyone volunteering for the January Commitfest, so I'll
> > volunteer to be CF manager for January 2024 Commitfest.
>
> (Addin
On Thu, 28 Dec 2023 at 15:59, Amit Kapila wrote:
>
> On Wed, Dec 13, 2023 at 12:09 PM vignesh C wrote:
> >
> > Thanks for the comments, the attached v25 version patch has the
> > changes for the same.
> >
>
> I have looked at it again and made some cosmetic c
Hi,
Commitfest 2024-01 is starting in 3 days!
Please register the patches which have not yet registered. Also if
someone has some pending patch that is not yet submitted, please
submit and register for 2024-01 Commitfest.
I will be having a look at the commitfest entries, correcting the
status if
On Sun, 31 Dec 2023 at 06:19, Michael Paquier wrote:
>
> On Fri, Dec 29, 2023 at 02:41:55PM +0530, vignesh C wrote:
> > Commitfest 2024-01 is starting in 3 days!
> > Please register the patches which have not yet registered. Also if
> > someone has some pending patch t
On Sun, 24 Dec 2023 at 18:40, vignesh C wrote:
>
> On Sun, 24 Dec 2023 at 07:16, Michael Paquier wrote:
> >
> > On Sat, Dec 23, 2023 at 08:52:38AM +0530, vignesh C wrote:
> > > I didn't see anyone volunteering for the January Commitfest, so I'll
> > &g
On Wed, 6 Dec 2023 at 12:53, Euler Taveira wrote:
>
> On Thu, Nov 9, 2023, at 8:12 PM, Michael Paquier wrote:
>
> On Thu, Nov 09, 2023 at 03:41:53PM +0100, Peter Eisentraut wrote:
> > On 08.11.23 00:12, Michael Paquier wrote:
> >> - Should the subdirectory pg_basebackup be renamed into something m
On Mon, 1 Jan 2024 at 21:01, Magnus Hagander wrote:
>
> On Mon, Jan 1, 2024 at 4:35 AM vignesh C wrote:
> >
> > On Sun, 24 Dec 2023 at 18:40, vignesh C wrote:
> > >
> > > On Sun, 24 Dec 2023 at 07:16, Michael Paquier wrote:
> > > >
> > &
On Tue, 2 Jan 2024 at 15:43, Magnus Hagander wrote:
>
> On Tue, Jan 2, 2024 at 3:45 AM vignesh C wrote:
> >
> > On Mon, 1 Jan 2024 at 21:01, Magnus Hagander wrote:
> > >
> > > On Mon, Jan 1, 2024 at 4:35 AM vignesh C wrote:
> > > >
> &
701 - 800 of 1897 matches
Mail list logo
