At Thu, 30 Sep 2021 09:40:06 +0900 (JST), Kyotaro Horiguchi
wrote in
> At Mon, 27 Sep 2021 17:31:03 +1300, Thomas Munro
> wrote in
> > On Thu, Jul 15, 2021 at 4:48 PM Kyotaro Horiguchi
> > wrote:
> > > Gah... Thank you for noticing me. I thought that I have sent the
> > > rebased version.
At Mon, 27 Sep 2021 17:31:03 +1300, Thomas Munro wrote
in
> On Thu, Jul 15, 2021 at 4:48 PM Kyotaro Horiguchi
> wrote:
> > Gah... Thank you for noticing me. I thought that I have sent the
> > rebased version. This is the rebased version on the current master.
>
> Hi Kyotaro,
>
> Did you see
On Thu, Jul 15, 2021 at 4:48 PM Kyotaro Horiguchi
wrote:
> Gah... Thank you for noticing me. I thought that I have sent the
> rebased version. This is the rebased version on the current master.
Hi Kyotaro,
Did you see this?
At Thu, 15 Jul 2021 00:39:52 +0500, Ibrar Ahmed wrote
in
> On Wed, Jun 30, 2021 at 12:54 PM Kyotaro Horiguchi
> wrote:
> > Maybe I will rebase it soon.
> >
> > Yes, rebase is required, therefore I am changing the status to "Waiting On
> Author"
> http://cfbot.cputube.org/patch_33_2113.log
On Wed, Jun 30, 2021 at 12:54 PM Kyotaro Horiguchi
wrote:
> At Fri, 09 Apr 2021 09:36:59 +0900 (JST), Kyotaro Horiguchi <
> horikyota@gmail.com> wrote in
> > I'm surprised to see this pushed this soon. Thanks for pushing this!
>
> Then this has been reverted. I'm not sure how to check for
At Fri, 09 Apr 2021 09:36:59 +0900 (JST), Kyotaro Horiguchi
wrote in
> I'm surprised to see this pushed this soon. Thanks for pushing this!
Then this has been reverted. I'm not sure how to check for the
possible defect happens on that platform, but, anyways I reverted the
CF item to "Needs
At Thu, 8 Apr 2021 23:51:34 +1200, Thomas Munro wrote
in
> On Thu, Apr 8, 2021 at 9:46 PM Thomas Munro wrote:
> > I squashed the patch set into one because half of them were fixups,
> > and the two main patches were really parts of the same change and
> > should go in together.
> >
> > I fixed
On Thu, Apr 8, 2021 at 9:46 PM Thomas Munro wrote:
> I squashed the patch set into one because half of them were fixups,
> and the two main patches were really parts of the same change and
> should go in together.
>
> I fixed a few compiler warnings (GCC 10.2 reported several
> uninitialised
I squashed the patch set into one because half of them were fixups,
and the two main patches were really parts of the same change and
should go in together.
I fixed a few compiler warnings (GCC 10.2 reported several
uninitialised variables, comparisons that are always true, etc) and
some
On Wed, Apr 7, 2021 at 8:50 PM Kyotaro Horiguchi
wrote:
> I haven't changed the name "XLog reader" to "XLog decoder". I'm doing
> that but it affects somewhat wide range of code.
Thanks for the new patch set! Let's not worry about renaming it for now.
This fails in check-world as seen on
At Tue, 6 Apr 2021 16:09:55 -0700, Andres Freund wrote in
> Hi,
>
> > XLogPageRead(XLogReaderState *xlogreader, XLogRecPtr targetPagePtr, int
> > reqLen,
> > XLogRecPtr targetRecPtr, char *readBuf)
> > {
> > @@ -12170,7 +12169,8 @@ retry:
> > readLen
On 2021-Apr-07, Thomas Munro wrote:
> On Wed, Apr 7, 2021 at 11:18 AM Alvaro Herrera
> wrote:
> > BTRW it's funny that after these patches, "xlogreader" no longer reads
> > anything. It's more an "xlog interpreter" -- the piece of code that
> > splits individual WAL records from a stream of
On Wed, Apr 7, 2021 at 11:18 AM Alvaro Herrera wrote:
> BTRW it's funny that after these patches, "xlogreader" no longer reads
> anything. It's more an "xlog interpreter" -- the piece of code that
> splits individual WAL records from a stream of WAL bytes that's caller's
> responsibility to
On 2021-Apr-07, Thomas Munro wrote:
> I wonder if it would be better to have the client code access these
> values through functions (even if they just access the variables in a
> static inline function), to create a bit more separation? Something
> like XLogReaderGetWanted(_lsn, _wanted), and
Hi,
On 2021-04-07 05:09:53 +1200, Thomas Munro wrote:
> From 560cdfa444a3b05a0e6b8054f3cfeadf56e059fc Mon Sep 17 00:00:00 2001
> From: Kyotaro Horiguchi
> Date: Thu, 5 Sep 2019 20:21:55 +0900
> Subject: [PATCH v18 1/3] Move callback-call from ReadPageInternal to
> XLogReadRecord.
>
> The
On Wed, Apr 7, 2021 at 5:09 AM Thomas Munro wrote:
> 0001 + 0002 get rid of the callback interface and replace it with a
> state machine, making it the client's problem to supply data when it
> returns XLREAD_NEED_DATA. I found this interface nicer to work with,
> for my WAL decoding buffer
On Wed, Mar 31, 2021 at 7:17 PM Kyotaro Horiguchi
wrote:
> At Wed, 31 Mar 2021 10:00:02 +1300, Thomas Munro
> wrote in
> > On Thu, Mar 4, 2021 at 3:29 PM Kyotaro Horiguchi
> > wrote:
> > > A recent commot about LSN_FORMAT_ARGS conflicted this.
> > > Just rebased.
> >
> > FYI I've been looking
At Wed, 31 Mar 2021 10:00:02 +1300, Thomas Munro wrote
in
> On Thu, Mar 4, 2021 at 3:29 PM Kyotaro Horiguchi
> wrote:
> > A recent commot about LSN_FORMAT_ARGS conflicted this.
> > Just rebased.
>
> FYI I've been looking at this, and I think it's a very nice
> improvement. I'll post some
On Thu, Mar 4, 2021 at 3:29 PM Kyotaro Horiguchi
wrote:
> A recent commot about LSN_FORMAT_ARGS conflicted this.
> Just rebased.
FYI I've been looking at this, and I think it's a very nice
improvement. I'll post some review comments and a rebase shortly.
A recent commot about LSN_FORMAT_ARGS conflicted this.
Just rebased.
regards
--
Kyotaro Horiguchi
NTT Open Source Software Center
>From b23cb65696a42e32b657f12bcf2355acd3100084 Mon Sep 17 00:00:00 2001
From: Kyotaro Horiguchi
Date: Thu, 5 Sep 2019 20:21:55 +0900
Subject: [PATCH v17 1/4] Move
Thank you for the comment and sorry for late reply.
At Fri, 17 Jul 2020 14:14:44 +0900, Takashi Menjo
wrote in
> Hi,
>
> I applied your v15 patchset to master
> ed2c7f65bd9f15f8f7cd21ad61602f983b1e72e9. Here are three feedback points
> for you:
>
> = 1. Build error when WAL_DEBUG is defined
At Tue, 08 Sep 2020 11:56:29 +0900 (JST), Kyotaro Horiguchi
wrote in
> Thank you for the comment, Menjo-san, and noticing me of that, Michael.
I found why the message I was writing was gone from the draft folder..
Sorry for the garbage.
--
Kyotaro Horiguchi
NTT Open Source Software Center
Thank you for the comment, Menjo-san, and noticing me of that, Michael.
Sorry for late reply.
At Fri, 17 Jul 2020 14:14:44 +0900, Takashi Menjo
wrote in
> Hi,
>
> I applied your v15 patchset to master
> ed2c7f65bd9f15f8f7cd21ad61602f983b1e72e9. Here are three feedback points
> for you:
>
>
On Fri, Jul 17, 2020 at 02:14:44PM +0900, Takashi Menjo wrote:
> I applied your v15 patchset to master
> ed2c7f65bd9f15f8f7cd21ad61602f983b1e72e9. Here are three feedback points
> for you:
And the CF bot complains as well here. Horiguchi-san, this patch is
waiting on author for a couple of
Hi,
I applied your v15 patchset to master
ed2c7f65bd9f15f8f7cd21ad61602f983b1e72e9. Here are three feedback points
for you:
= 1. Build error when WAL_DEBUG is defined manually =
How to reproduce:
$ sed -i -E -e 's|^/\* #define WAL_DEBUG \*/$|#define WAL_DEBUG|'
src/include/pg_config_manual.h
cfbot is complaining as this is no longer applicable. Rebased.
In v14, some reference to XLogReaderState parameter to read_pages
functions are accidentally replaced by the reference to the global
variable xlogreader. Fixed it, too.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
Thank you for the comment.
At Tue, 26 May 2020 20:17:47 +0800, Craig Ringer wrote
in
> On Tue, 26 May 2020, 15:40 Kyotaro Horiguchi,
> wrote:
>
> >
> > This patch removes all the three callbacks (open/close/page_read) in
> > XL_ROUTINE from XLogReaderState. It only has "cleanup" callback
>
On Tue, 26 May 2020, 15:40 Kyotaro Horiguchi,
wrote:
>
> This patch removes all the three callbacks (open/close/page_read) in
> XL_ROUTINE from XLogReaderState. It only has "cleanup" callback
> instead.
>
I actually have a use in mind for these callbacks - to support reading WAL
for logical
At Wed, 22 Apr 2020 10:12:46 +0900 (JST), Kyotaro Horiguchi
wrote in
> cd12323440 conflicts with this. Rebased.
b060dbe000 is conflicting. I gave up isolating XLogOpenSegment from
xlogreader.c, since the two are tightly coupled than I thought.
This patch removes all the three callbacks
At Tue, 21 Apr 2020 17:04:27 +0900 (JST), Kyotaro Horiguchi
wrote in
>
Mmm. The message body seems disappearing for uncertain reason.
cd12323440 conflicts with this. Rebased.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
>From b3b780c2143ae70b82fb1e8256e771f11276af31 Mon
I found this conficts with a7e8ece41cf7a96d8a9c4c037cdfef304d950831.
Rebased on it.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
>From e67149578c750977a2a2872d3f4dbb3a86c82a6d Mon Sep 17 00:00:00 2001
From: Kyotaro Horiguchi
Date: Thu, 5 Sep 2019 20:21:55 +0900
Subject: [PATCH
5d0c2d5eba shot out this.
Rebased.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
>From 6837855f0c938b5e34039897158bc912c6619d2b Mon Sep 17 00:00:00 2001
From: Kyotaro Horiguchi
Date: Thu, 5 Sep 2019 20:21:55 +0900
Subject: [PATCH v7 1/4] Move callback-call from
At Tue, 21 Jan 2020 19:45:10 +0900 (JST), Kyotaro Horiguchi
wrote in
> Hello.
>
> At Mon, 20 Jan 2020 17:24:07 +0900 (JST), Kyotaro Horiguchi
> wrote in
> > Separating XLogBeginRead seems reasonable. The annoying recptr trick
> > is no longer needed. In particular some logical-decoding
On 21/01/2020 13:33, Craig Ringer wrote:
On Tue, 21 Jan 2020 at 18:46, Kyotaro Horiguchi wrote:
It seems to me that it works perfectly, and everything looks good
I seem to remember some considerable pain in this area when it came to
timeline switches. Especially with logical decoding and
On 21/01/2020 12:45, Kyotaro Horiguchi wrote:
At Mon, 20 Jan 2020 17:24:07 +0900 (JST), Kyotaro Horiguchi
wrote in
Separating XLogBeginRead seems reasonable. The annoying recptr trick
is no longer needed. In particular some logical-decoding stuff become
far cleaner by the patch.
On Tue, 21 Jan 2020 at 18:46, Kyotaro Horiguchi wrote:
>
> Hello.
>
> At Mon, 20 Jan 2020 17:24:07 +0900 (JST), Kyotaro Horiguchi
> wrote in
> > Separating XLogBeginRead seems reasonable. The annoying recptr trick
> > is no longer needed. In particular some logical-decoding stuff become
> >
Hello.
At Mon, 20 Jan 2020 17:24:07 +0900 (JST), Kyotaro Horiguchi
wrote in
> Separating XLogBeginRead seems reasonable. The annoying recptr trick
> is no longer needed. In particular some logical-decoding stuff become
> far cleaner by the patch.
>
> fetching_ckpt of ReadRecord is a bit
Thanks!
At Fri, 17 Jan 2020 20:14:36 +0200, Heikki Linnakangas wrote
in
> On 29/11/2019 10:14, Kyotaro Horiguchi wrote:
> > At Thu, 28 Nov 2019 21:37:03 +0900 (JST), Kyotaro Horiguchi
> > wrote in
> 0dc8ead463 hit this. Rebased.
> >>>
> >>> Please review the pg_waldump.c hunks in 0001;
On 2020-Jan-17, Heikki Linnakangas wrote:
> I changed that by adding new function, XLogBeginRead(), that repositions the
> reader, and removed the 'lsn' argument from XLogReadRecord() altogether. All
> callers except one in findLastCheckPoint() pg_rewind.c positioned the reader
> once, and then
On 29/11/2019 10:14, Kyotaro Horiguchi wrote:
At Thu, 28 Nov 2019 21:37:03 +0900 (JST), Kyotaro Horiguchi
wrote in
0dc8ead463 hit this. Rebased.
Please review the pg_waldump.c hunks in 0001; they revert recent changes.
Ughhh! I'l check it. Thank you for noticing!!
Fixed that, re-rebased
At Thu, 28 Nov 2019 21:37:03 +0900 (JST), Kyotaro Horiguchi
wrote in
> > > 0dc8ead463 hit this. Rebased.
> >
> > Please review the pg_waldump.c hunks in 0001; they revert recent changes.
>
> Ughhh! I'l check it. Thank you for noticing!!
Fixed that, re-rebased and small comment and cosmetic
At Wed, 27 Nov 2019 01:11:40 -0300, Alvaro Herrera
wrote in
> On 2019-Nov-27, Kyotaro Horiguchi wrote:
>
> > At Thu, 24 Oct 2019 14:51:01 +0900 (JST), Kyotaro Horiguchi
> > wrote in
> > > Rebased.
> >
> > 0dc8ead463 hit this. Rebased.
>
> Please review the pg_waldump.c hunks in 0001; they
On 2019-Nov-27, Kyotaro Horiguchi wrote:
> At Thu, 24 Oct 2019 14:51:01 +0900 (JST), Kyotaro Horiguchi
> wrote in
> > Rebased.
>
> 0dc8ead463 hit this. Rebased.
Please review the pg_waldump.c hunks in 0001; they revert recent changes.
--
Álvaro Herrera
On Wed, Nov 27, 2019 at 12:09:23PM +0900, Kyotaro Horiguchi wrote:
> 0dc8ead463 hit this. Rebased.
Note: Moved to next CF.
--
Michael
signature.asc
Description: PGP signature
At Thu, 24 Oct 2019 14:51:01 +0900 (JST), Kyotaro Horiguchi
wrote in
> Rebased.
0dc8ead463 hit this. Rebased.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
>From d9007aee88f7400b0f03ced1b80584964a1b0b79 Mon Sep 17 00:00:00 2001
From: Kyotaro Horiguchi
Date: Thu, 5 Sep 2019
Rebased.
I intentionally left duplicate code in XLogNeedData but changed my
mind to remove it. It makes the function small and clearer.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
>From 7c4ce152d248546c8f56057febae6b17b6fa71bb Mon Sep 17 00:00:00 2001
From: Kyotaro Horiguchi
At Wed, 25 Sep 2019 15:50:32 +0900 (Tokyo Standard Time), Kyotaro Horiguchi
wrote in
<20190925.155032.13779064.horikyota@gmail.com>
> 709d003fbd hit this. Rebased.
Oops! I found a silly silent bug that it doesn't verify the first
page in new segments. Moreover it didin't load the first
Hello.
709d003fbd hit this. Rebased.
Works fine but needs detailed verification and maybe further
cosmetic fixes.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
>From 6be22b10c9df068c53c98ad3106e1bd88e07aeeb Mon Sep 17 00:00:00 2001
From: Kyotaro Horiguchi
Date: Thu, 5 Sep
Attached is new version:
- Rebased. Cleaned up
- Rebased to the current master
- Fixed a known bug in the first step patch. It caused
timeline-following failure on a standby of a promoted primary.
- Fixed confused naming and setting of the parameter
includes_paeg_header.
- Removed useless
At Thu, 22 Aug 2019 10:43:52 +0900 (Tokyo Standard Time), Kyotaro Horiguchi
wrote in
<20190822.104352.26342272.horikyota@gmail.com>
> I think you diff is intelligible enough for me. I'll take this if
> you haven't done. Anyway I'm staring on this.
- Reducing state variables
It was a
On 22/08/2019 04:43, Kyotaro Horiguchi wrote:
At Mon, 29 Jul 2019 22:39:57 +0300, Heikki Linnakangas wrote in
On 12/07/2019 10:10, Kyotaro Horiguchi wrote:
* XLogReaderState->readBuf is now allocated and controlled by the
* caller, not by xlogreader.c itself. When XLogReadRecord() needs
Thank you for the suggestion, Heikki.
At Mon, 29 Jul 2019 22:39:57 +0300, Heikki Linnakangas wrote
in
> On 12/07/2019 10:10, Kyotaro Horiguchi wrote:
> >> Just FYI, to me this doesn't clearly enough look like an improvement,
> >> for a change of this size.
> > Thanks for the opiniton. I kinda
On 12/07/2019 10:10, Kyotaro Horiguchi wrote:
At Tue, 28 May 2019 04:45:24 -0700, Andres Freund wrote in
<20190528114524.dvj6ymap2virl...@alap3.anarazel.de>
Hi,
On 2019-04-18 21:02:57 +0900, Kyotaro HORIGUCHI wrote:
Hello. As mentioned before [1], read_page callback in
XLogReaderState is a
At Tue, 28 May 2019 04:45:24 -0700, Andres Freund wrote in
<20190528114524.dvj6ymap2virl...@alap3.anarazel.de>
> Hi,
>
> On 2019-04-18 21:02:57 +0900, Kyotaro HORIGUCHI wrote:
> > Hello. As mentioned before [1], read_page callback in
> > XLogReaderState is a cause of headaches. Adding another
>
Hello. The patch gets disliked by my tool chain. Fixed the usage
of PG_USED_FOR_ASSERTS_ONLY and rebased to bd56cd75d2.
--
Kyotaro Horiguchi
NTT Open Source Software Center
>From 1dabdce6993b73408b950cb8c348c4999178b9a0 Mon Sep 17 00:00:00 2001
From: Kyotaro Horiguchi
Date: Thu, 18 Apr 2019
Hi,
On 2019-04-18 21:02:57 +0900, Kyotaro HORIGUCHI wrote:
> Hello. As mentioned before [1], read_page callback in
> XLogReaderState is a cause of headaches. Adding another
> remote-controlling stuff to xlog readers makes things messier [2].
>
> I refactored XLOG reading functions so that we
Kyotaro HORIGUCHI wrote:
> v3-0001 : Changed macrosas suggested.
This attachment is missing, please send it too.
--
Antonin Houska
Web: https://www.cybertec-postgresql.com
Thank you for looking this, Antonin.
At Wed, 22 May 2019 13:53:23 +0200, Antonin Houska wrote in
<25494.1558526...@spoje.net>
> Kyotaro HORIGUCHI wrote:
>
> > Hello. Thank you for looking this.
> > ...
> > Yeah, I'll register this, maybe the week after next week.
>
> I've checked the new
Kyotaro HORIGUCHI wrote:
> Hello. Thank you for looking this.
> ...
> Yeah, I'll register this, maybe the week after next week.
I've checked the new version. One more thing I noticed now is that XLR_STATE.j
is initialized to zero, either by XLogReaderAllocate() which zeroes the whole
reader
Hello. Thank you for looking this.
At Thu, 25 Apr 2019 13:58:20 +0200, Antonin Houska wrote in
<18581.1556193500@localhost>
> Kyotaro HORIGUCHI wrote:
>
> > Hello. As mentioned before [1], read_page callback in
> > XLogReaderState is a cause of headaches. Adding another
> > remote-controlling
Kyotaro HORIGUCHI wrote:
> Hello. As mentioned before [1], read_page callback in
> XLogReaderState is a cause of headaches. Adding another
> remote-controlling stuff to xlog readers makes things messier [2].
The patch I posted in thread [2] tries to solve another problem: it tries to
merge
Hello. As mentioned before [1], read_page callback in
XLogReaderState is a cause of headaches. Adding another
remote-controlling stuff to xlog readers makes things messier [2].
I refactored XLOG reading functions so that we don't need the
callback. In short, ReadRecrod now calls XLogPageRead
62 matches
Mail list logo
