Re: Teach pg_upgrade test to honor NO_TEMP_INSTALL

2019-05-24 Thread Andrew Dunstan
On 5/24/19 11:22 AM, Andres Freund wrote: > Hi, > > On 2019-05-22 13:08:41 -0700, Andres Freund wrote: >> On 2019-05-22 16:04:34 -0400, Andrew Dunstan wrote: >>> If I disable install, the buildfarm fails the upgrade check even when >>> not using NO_TEMP_INSTALL. >>> >>> >>> excerpts from the

Re: Teach pg_upgrade test to honor NO_TEMP_INSTALL

2019-05-24 Thread Tom Lane
Andres Freund writes: > Andrew, after the latest set of changes, the reversed order should now > work reliably? Also, Thomas should be able to revert his cfbot hack ... regards, tom lane

Re: Teach pg_upgrade test to honor NO_TEMP_INSTALL

2019-05-24 Thread Andres Freund
Hi, On 2019-05-22 13:08:41 -0700, Andres Freund wrote: > On 2019-05-22 16:04:34 -0400, Andrew Dunstan wrote: > > If I disable install, the buildfarm fails the upgrade check even when > > not using NO_TEMP_INSTALL. > > > > > > excerpts from the log: > > sh:

Re: Teach pg_upgrade test to honor NO_TEMP_INSTALL

2019-05-22 Thread Andres Freund
On 2019-05-22 16:04:34 -0400, Andrew Dunstan wrote: > > On 5/22/19 2:42 PM, Andres Freund wrote: > > Hi, > > > > On 2019-05-22 14:27:51 -0400, Tom Lane wrote: > >> Andres Freund writes: > >>> On 2019-05-22 14:06:47 -0400, Tom Lane wrote: > Not sure about that last bit. pg_upgrade has the

Re: Teach pg_upgrade test to honor NO_TEMP_INSTALL

2019-05-22 Thread Andrew Dunstan
On 5/22/19 2:42 PM, Andres Freund wrote: > Hi, > > On 2019-05-22 14:27:51 -0400, Tom Lane wrote: >> Andres Freund writes: >>> On 2019-05-22 14:06:47 -0400, Tom Lane wrote: Not sure about that last bit. pg_upgrade has the issue of possibly wanting to deal with 2 installations, unlike

Re: Teach pg_upgrade test to honor NO_TEMP_INSTALL

2019-05-22 Thread Andres Freund
Hi, On 2019-05-22 14:27:51 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2019-05-22 14:06:47 -0400, Tom Lane wrote: > >> Not sure about that last bit. pg_upgrade has the issue of possibly > >> wanting to deal with 2 installations, unlike the rest of the tree, > >> so I'm not sure that

Re: Teach pg_upgrade test to honor NO_TEMP_INSTALL

2019-05-22 Thread Tom Lane
Andres Freund writes: > On 2019-05-22 14:06:47 -0400, Tom Lane wrote: >> Not sure about that last bit. pg_upgrade has the issue of possibly >> wanting to deal with 2 installations, unlike the rest of the tree, >> so I'm not sure that fixing its problem means there's something we >> need to

Re: Teach pg_upgrade test to honor NO_TEMP_INSTALL

2019-05-22 Thread Andres Freund
Hi, On 2019-05-22 14:06:47 -0400, Tom Lane wrote: > Andres Freund writes: > > Seems what we need to fix the immediate issue is to ressurect: > > > # We need to make it use psql from our temporary installation, > > # because otherwise the installcheck run below would try to > > # use psql from

Re: Teach pg_upgrade test to honor NO_TEMP_INSTALL

2019-05-22 Thread Tom Lane
Andres Freund writes: > Seems what we need to fix the immediate issue is to ressurect: > # We need to make it use psql from our temporary installation, > # because otherwise the installcheck run below would try to > # use psql from the proper installation directory, which might > # be outdated

Re: Teach pg_upgrade test to honor NO_TEMP_INSTALL

2019-05-22 Thread Andres Freund
Hi, On 2019-05-22 10:58:54 -0400, Tom Lane wrote: > Thomas Munro writes: > > After these commits (and Tom's commit "Un-break pg_upgrade regression > > test."), cfbot broke: I should just have finished working two hours earlier yesterday :(. > > sh: 1: /usr/local/pgsql/bin/psql: not found > >

Re: Teach pg_upgrade test to honor NO_TEMP_INSTALL

2019-05-22 Thread Tom Lane
Thomas Munro writes: > After these commits (and Tom's commit "Un-break pg_upgrade regression > test."), cfbot broke: > sh: 1: /usr/local/pgsql/bin/psql: not found I can confirm that here: check-world passes as long as I've done "make install" beforehand ... but of course that should not be

Re: Teach pg_upgrade test to honor NO_TEMP_INSTALL

2019-05-22 Thread Thomas Munro
On Wed, May 22, 2019 at 7:41 AM Andres Freund wrote:> > On 2019-05-21 12:19:18 -0700, Andres Freund wrote: > > Roughly like in the attached? > > > -check: test.sh all > > - MAKE=$(MAKE) bindir="$(tbindir)" libdir="$(tlibdir)" > > EXTRA_REGRESS_OPTS="$(EXTRA_REGRESS_OPTS)" $(SHELL) $<

Re: Teach pg_upgrade test to honor NO_TEMP_INSTALL

2019-05-21 Thread Andres Freund
Hi, On 2019-05-21 12:19:18 -0700, Andres Freund wrote: > Roughly like in the attached? > -check: test.sh all > - MAKE=$(MAKE) bindir="$(tbindir)" libdir="$(tlibdir)" > EXTRA_REGRESS_OPTS="$(EXTRA_REGRESS_OPTS)" $(SHELL) $< $(DOINST) > +check: test.sh all temp-install > + MAKE=$(MAKE)

Re: Teach pg_upgrade test to honor NO_TEMP_INSTALL

2019-05-21 Thread Andres Freund
Hi, On 2019-05-21 14:48:27 -0400, Andrew Dunstan wrote: > On 5/20/19 9:58 PM, Andres Freund wrote: > > Hi Andrew, > > > > On 2019-03-30 16:42:16 -0400, Andrew Dunstan wrote: > >> On some machines (*cough* Mingw *cough*) installs are very slow. We've > >> ameliorated this by allowing temp installs

Re: Teach pg_upgrade test to honor NO_TEMP_INSTALL

2019-05-21 Thread Tom Lane
Andrew Dunstan writes: > On 5/20/19 9:58 PM, Andres Freund wrote: >> I'm confused as to why this was done as a purely optional path, rather >> than just ripping out the pg_upgrade specific install? > By specifying NO_TEMP_INSTALL you are in effect certifying that there is > already a suitable

Re: Teach pg_upgrade test to honor NO_TEMP_INSTALL

2019-05-21 Thread Andrew Dunstan
On 5/20/19 9:58 PM, Andres Freund wrote: > Hi Andrew, > > On 2019-03-30 16:42:16 -0400, Andrew Dunstan wrote: >> On some machines (*cough* Mingw *cough*) installs are very slow. We've >> ameliorated this by allowing temp installs to be reused, but the >> pg_upgrade Makefile never got the

Re: Teach pg_upgrade test to honor NO_TEMP_INSTALL

2019-05-20 Thread Andres Freund
Hi Andrew, On 2019-03-30 16:42:16 -0400, Andrew Dunstan wrote: > On some machines (*cough* Mingw *cough*) installs are very slow. We've > ameliorated this by allowing temp installs to be reused, but the > pg_upgrade Makefile never got the message. Here's a patch that does > that. I'd like to

Re: Teach pg_upgrade test to honor NO_TEMP_INSTALL

2019-03-30 Thread Tom Lane
Andrew Dunstan writes: > On some machines (*cough* Mingw *cough*) installs are very slow. We've > ameliorated this by allowing temp installs to be reused, but the > pg_upgrade Makefile never got the message. Here's a patch that does > that. I'd like to backpatch it, at least to 9.5 where we

Re: Teach pg_upgrade test to honor NO_TEMP_INSTALL

2019-03-30 Thread Daniel Gustafsson
On Saturday, March 30, 2019 9:42 PM, Andrew Dunstan wrote: > On some machines (cough Mingw cough) installs are very slow. We've > ameliorated this by allowing temp installs to be reused, but the > pg_upgrade Makefile never got the message. Here's a patch that does > that. I'd like to backpatch

Teach pg_upgrade test to honor NO_TEMP_INSTALL

2019-03-30 Thread Andrew Dunstan
On some machines (*cough* Mingw *cough*) installs are very slow. We've ameliorated this by allowing temp installs to be reused, but the pg_upgrade Makefile never got the message. Here's a patch that does that. I'd like to backpatch it, at least to 9.5 where we switched the pg_upgrade location.