[HACKERS] New pg_dump committed...

2000-09-14 Thread Philip Warner
I've now committed the latest pg_dump. The following is the list of changes: - Support for relkind = RELKIND_VIEW. - Use symbols for tests on relkind (ie. use RELKIND_VIEW, not 'v') - Fix bug in support for -b option (== --blobs). - Dump views as views (using 'create view'). - Remove 'isViewRule

Re: [HACKERS] current is broken

2000-09-14 Thread Philip Warner
At 22:23 14/09/00 -0400, Tom Lane wrote: > >Oh, I finally see the problem: when you come to dump out the rules, you >need to avoid dumping the rules that correspond to views because you're >going to emit the CREATE VIEW commands separately. > >You don't really need a rulekind though. If it's an O

RE: [HACKERS] current is broken

2000-09-14 Thread Hiroshi Inoue
> -Original Message- > From: Tom Lane [mailto:[EMAIL PROTECTED]] > > Philip Warner <[EMAIL PROTECTED]> writes: > > The only thing that's missing is a 'rulekind' for rules - it > would be very > > nice if pg_dump could use a simple method (that didn't involve munging > > names) to determin

Re: [HACKERS] current is broken

2000-09-14 Thread Tom Lane
Philip Warner <[EMAIL PROTECTED]> writes: > The only thing that's missing is a 'rulekind' for rules - it would be very > nice if pg_dump could use a simple method (that didn't involve munging > names) to determin is a rule is a 'view rule'. Oh, I finally see the problem: when you come to dump out

Re: [HACKERS] pg_dump of regression (again)

2000-09-14 Thread Tom Lane
Philip Warner <[EMAIL PROTECTED]> writes: > OK - I'll use typname in CREATE AGGREGATE, and see how it hangs together. > Do you know if the type parser is invoked in function declarations? Sort of --- it looks like the production is for SimpleTypename not a full typename. This is something that

RE: [HACKERS] current is broken

2000-09-14 Thread Philip Warner
At 10:40 15/09/00 +0900, Hiroshi Inoue wrote: > >Now we have a relkind for views and in addtion haven't we >already had pg_views view to encapsulate the definition of >views. > The only thing that's missing is a 'rulekind' for rules - it would be very nice if pg_dump could use a simple method (t

RE: [HACKERS] current is broken

2000-09-14 Thread Hiroshi Inoue
> -Original Message- > From: Ross J. Reedstrom > > On Wed, Sep 13, 2000 at 03:44:25PM +1000, Philip Warner wrote: > > At 13:07 13/09/00 +0900, Tatsuo Ishii wrote: > > >It seems current source is broken if MB is enabled. > > Gah, I Was afraid of this. My patch, I'm afraid. > > > > > > >

RE: [HACKERS] Status of new relation file naming

2000-09-14 Thread Mikheev, Vadim
> > So, I assume that you vote YES on this subject? -:) > > (As far as I remember, it was your idea). > > > > Yes. UNIQUE_ID file names: Hiroshi, Marc, Vadim We can use oids as unique ids, but these were another oids -:) Vadim

Re: [HACKERS] pg_dump of regression (again)

2000-09-14 Thread Philip Warner
At 11:44 14/09/00 -0400, Tom Lane wrote: > >> The problem is the "numeric[]" type. > >numeric[] is a correct display of the type (and more intelligible than >_numeric IMHO), but quoting it is not correct. If you are feeding the >output of format_type through something that believes it's quoting a

Re: [HACKERS] Performance improvement hints + measurement

2000-09-14 Thread Tom Lane
[EMAIL PROTECTED] writes: >> You could probably generalize the existing code for hashjoin tables >> to support hash aggregation as well. Now that I think about it, that >> sounds like a really cool idea. Should put it on the TODO list. > Yep. It should be easy. It could be used as part of Hash

RE: [HACKERS] Status of new relation file naming

2000-09-14 Thread Hiroshi Inoue
> -Original Message- > From: Mikheev, Vadim [mailto:[EMAIL PROTECTED]] > > > Philip Warner mentioned about the advantage of random number. > > It's exactly what I've wanted to say. > > > > >> it removes the temptation to write utilities that rely on > > >> the internal representation of o

RE: [HACKERS] Status of new relation file naming

2000-09-14 Thread Mikheev, Vadim
> Philip Warner mentioned about the advantage of random number. > It's exactly what I've wanted to say. > > >> it removes the temptation to write utilities that rely on > >> the internal representation of our data. > > It is preferable that file naming rule is encapsulated so that we > can change

RE: [HACKERS] Status of new relation file naming

2000-09-14 Thread The Hermit Hacker
On Thu, 14 Sep 2000, Mikheev, Vadim wrote: > > > > Rename... Why would we need in rename with OID filenames? > > > > Andreas seems to refer to in place replacement of OID files e.g. > > using your *relink*. > > Sorry, I've messed things for myself. > > Ok. In short, I vote for UNIQUE_ID (unr

RE: [HACKERS] Status of new relation file naming

2000-09-14 Thread Hiroshi Inoue
> -Original Message- > From: Mikheev, Vadim [mailto:[EMAIL PROTECTED]] > > > > Rename... Why would we need in rename with OID filenames? > > > > Andreas seems to refer to in place replacement of OID files e.g. > > using your *relink*. > > Sorry, I've messed things for myself. > > Ok. In sho

RE: [HACKERS] strange behaviour (bug)

2000-09-14 Thread Mikheev, Vadim
> I looked into your XLOG stuff a little. > It seems that XLogFileOpen() isn't implemented yet. > Would/should XLogFIleOpen() guarantee to open a Relation > properly at any time ? If each relation will have unique file name then there will be no problem. If a relation was dropped then after crash

Re: [HACKERS] Dumping views as views?

2000-09-14 Thread Philip Warner
At 11:45 14/09/00 -0400, Tom Lane wrote: >Philip Warner <[EMAIL PROTECTED]> writes: >> - when getting table info, also call pg_get_viewdef (which returns 'not a >> view' for non-view relations). > >Huh? Just use the relkind to detect views. Sorry; what the above means is that I will get the view

RE: [HACKERS] Status of new relation file naming

2000-09-14 Thread Mikheev, Vadim
> > Rename... Why would we need in rename with OID filenames? > > Andreas seems to refer to in place replacement of OID files e.g. > using your *relink*. Sorry, I've messed things for myself. Ok. In short, I vote for UNIQUE_ID (unrelated to pg_class.oid) file names. I think that it's better to

RE: [HACKERS] strange behaviour (bug)

2000-09-14 Thread Hiroshi Inoue
> -Original Message- > From: Mikheev, Vadim [mailto:[EMAIL PROTECTED]] > > > > I'm going to handle btree split but currently there is no way > > > to rollback it - we unlock splitted pages after parent > > > is locked and concurrent backend may update one/both of > > > siblings before we g

Re: [HACKERS] Status of new relation file naming

2000-09-14 Thread Hiroshi Inoue
"Mikheev, Vadim" wrote: > Rename... Why would we need in rename with OID filenames? Andreas seems to refer to in place replacement of OID files e.g. using your *relink*. Regards. Hiroshi Inoue

Re: [HACKERS] current is broken

2000-09-14 Thread Ross J. Reedstrom
On Wed, Sep 13, 2000 at 03:44:25PM +1000, Philip Warner wrote: > At 13:07 13/09/00 +0900, Tatsuo Ishii wrote: > >It seems current source is broken if MB is enabled. Gah, I Was afraid of this. My patch, I'm afraid. > > > > I haven't looked at the code yet, but isViewRule is going to change to us

Re: [HACKERS] RE: [COMMITTERS] pgsql/src/interfaces/jdbc/org/postgresql/jdbc1(DatabaseMetaData.java)

2000-09-14 Thread Peter Mount
On Tue, 12 Sep 2000, Bruce Momjian wrote: > > > As if my JDBC patch hasn't already caused enough grief, there is now a > > > one-line change necessary. Due to the Mark Holloman "New Relkind for > > > Views" patch, my support for views in the driver will need to be updated > > > to match. The ch

RE: [HACKERS] strange behaviour (bug)

2000-09-14 Thread Mikheev, Vadim
> > I'm going to handle btree split but currently there is no way > > to rollback it - we unlock splitted pages after parent > > is locked and concurrent backend may update one/both of > > siblings before we get our locks back. > > We have to continue with split or could leave parent unchanged > >

RE: [HACKERS] Status of new relation file naming

2000-09-14 Thread Mikheev, Vadim
Rename... Why would we need in rename with OID filenames? Ok, let's start with OID (*without tablename prefix|suffix*) filenames and we'll see later how it will work. So, could someone implement OID filenames? (Please use RelFileNode structure). Vadim > > > You have to tell us whether you plan

[HACKERS] Touched-up regression tests

2000-09-14 Thread Thomas Lockhart
I've made minor modifications to the abstime and horology regression tests, to move cross-type tests to horology and abstime-only tests to abstime. I slightly rearranged the order of regression tests in the date/time area, and made the abstime test part of the "parallel safe" test sequence. All t

Re: [HACKERS] Dumping views as views?

2000-09-14 Thread Tom Lane
Philip Warner <[EMAIL PROTECTED]> writes: > - when getting table info, also call pg_get_viewdef (which returns 'not a > view' for non-view relations). Huh? Just use the relkind to detect views. regards, tom lane

Re: [HACKERS] pg_dump of regression (again)

2000-09-14 Thread Tom Lane
Philip Warner <[EMAIL PROTECTED]> writes: > Continuing to try to use format_type to output all types, I get the > following in the regression database: > CREATE AGGREGATE newavg ( >BASETYPE = integer, >SFUNC = int4_accum, >STYPE = "numeric[]", >INITCOND = '{0,0,0}', >FINA

Re: [HACKERS] Indexing of LIKE queries is broken in current sources

2000-09-14 Thread Thomas Lockhart
> After a little bit of thought I think I see a way out that avoids > opening the function-selectivity can of worms. Let's translate LIKE > to an operator same as we always did (and add an operator for ILIKE). > The forms with an ESCAPE clause can be translated to the same operators > but with a

Re: [HACKERS] Indexing of LIKE queries is broken in current sources

2000-09-14 Thread Tom Lane
Thomas Lockhart <[EMAIL PROTECTED]> writes: >> It seems that the parser now emits some kind of function call for LIKE >> expressions, whereas the optimizer's code to use indexes for LIKE is >> looking for an operator. > Oh, that's bad. I changed it to the function call to allow > three-parameter

Re: [GENERAL] List funnies ?

2000-09-14 Thread The Hermit Hacker
there was a problem with database corruption in pgsql-general that we fixed last night ... if anyone else is interested in helping, I'm going to be working with the Mj2 guys on moving the backend from BerkeleyDB -> PostgreSQL ... if anyone is interested in helping out, let me know ... On Thu, 14

Re: [HACKERS] pg_dump bug (if use multibyte)

2000-09-14 Thread Trurl McByte
On Thu, 14 Sep 2000 (Today), Trurl McByte wrote: TM> TM> TM> TM> pg_dump.c: In function `AsViewRule': sorry - 'isViewRule'! TM> pg_dump.c:267: parse error before `int' TM> /* 'int len;' not in declaration block */ TM> pg_dump.c:268: 'len' undeclared (first use in this function)

[HACKERS] pg_dump bug (if use multibyte)

2000-09-14 Thread Trurl McByte
pg_dump.c: In function `AsViewRule': pg_dump.c:267: parse error before `int' /* 'int len;' not in declaration block */ pg_dump.c:268: 'len' undeclared (first use in this function) pg_dump.c:268: (Each undeclared identifier is reported only once pg_dump.c:268: for each function it appears in.) p

RE: [HACKERS] List funnies ?

2000-09-14 Thread The Hermit Hacker
removed On Thu, 14 Sep 2000, Zeljko Trogrlic wrote: > Me too, and I'm getting some stuff two times, like I'm double subscribed > (which I shouldn't be). Sometimes it takes few days for messages to appear > on list etc. > > At 10:12 14.9.2000 , [EMAIL PROTECTED] wrote: > >I was just about to a

Re: [GENERAL] List funnies ?

2000-09-14 Thread Jules Bean
On Thu, Sep 14, 2000 at 09:01:50AM -0300, The Hermit Hacker wrote: > > okay, this is most odd ... according to the list software, you are still > only subscribed to the general list: Marc I can also confirm that I had no message on pgsql-general for about two days until the thread 'List Funnies

[HACKERS] Re: [GENERAL] List funnies ?

2000-09-14 Thread The Hermit Hacker
okay, this is most odd ... according to the list software, you are still only subscribed to the general list: Address: [EMAIL PROTECTED] Address is valid. Address is registered as: [EMAIL PROTECTED] Registered at Fri Sep 1 15:33:13 2000 GMT. Registration data last change

[HACKERS] Dumping views as views?

2000-09-14 Thread Philip Warner
In a continuing effort to make pg_dump produce valid SQL where possible, I would like to move away from the 'Create Table'/'Create Rule' method of defining views, and actually dump the 'Create View' command. This seems quite do-able, but before I start I thought I would ask if there were any rea

RE: [HACKERS] List funnies ?

2000-09-14 Thread Zeljko Trogrlic
Me too, and I'm getting some stuff two times, like I'm double subscribed (which I shouldn't be). Sometimes it takes few days for messages to appear on list etc. At 10:12 14.9.2000 , [EMAIL PROTECTED] wrote: >I was just about to ask the same question... > >med vänlig hälsning >/Dana > >-Origin

[HACKERS] Re: [GENERAL] List funnies ?

2000-09-14 Thread fabrizio . ermini
> Has something happened to the list server ? > > I am only subscribed to the general list, but after two days of nothing I'm > now getting the hackers list stuff. > So it's not just me? How sad, I was hoping I had be promoted to Hacker status... ;-) /\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\

[HACKERS] pg_dump of regression (again)

2000-09-14 Thread Philip Warner
Continuing to try to use format_type to output all types, I get the following in the regression database: CREATE AGGREGATE newavg ( BASETYPE = integer, SFUNC = int4_accum, STYPE = "numeric[]", INITCOND = '{0,0,0}', FINALFUNC = numeric_avg ); where the original source was: C

Re: AW: [HACKERS] Status of new relation file naming

2000-09-14 Thread Philip Warner
At 10:00 14/09/00 +0200, Zeugswetter Andreas SB wrote: > >> > My vote is for a random number, and then someone can write >> > the tools to display the file info. I'll even volunteer to >> > work on them... > >What was the advantage of random number over oid [+version] >in the light that there is

RE: [HACKERS] List funnies ?

2000-09-14 Thread Dana . Reed
I was just about to ask the same question... med vänlig hälsning /Dana -Original Message- From: [EMAIL PROTECTED] [SMTP:[EMAIL PROTECTED]] Sent: Thursday, September 14, 2000 10:09 AM To: [EMAIL PROTECTED]; [EMAIL PROTECTED] Subject:[HACKERS] List funnies ? Has something

[HACKERS] List funnies ?

2000-09-14 Thread Steve Heaven
Has something happened to the list server ? I am only subscribed to the general list, but after two days of nothing I'm now getting the hackers list stuff. Steve -- thorNET - Internet Consultancy, Services & Training Phone: 01454 854413 Fax: 01454 854412 http://www.thornet.co.uk

AW: [HACKERS] Status of new relation file naming

2000-09-14 Thread Zeugswetter Andreas SB
> > My vote is for a random number, and then someone can write > > the tools to display the file info. I'll even volunteer to > > work on them... What was the advantage of random number over oid [+version] in the light that there is an extra field in pg_class for other smgrs ? We surely want re

AW: [HACKERS] Status of new relation file naming

2000-09-14 Thread Zeugswetter Andreas SB
> > You have to tell us whether you plan to implement > > a safe file rename in WAL ? If yes a simple filename > > without version would be possible and better. > > What do you mean? The previous discussion we had where we concluded, that an os rename of a file cannot be done without risc. Bu