Re: [HACKERS] Help with ADD COLUMN

2002-11-23 Thread Philip Warner
At 03:48 PM 23/11/2002 -0800, Christopher Kings-Lynne wrote: I assume that's the correct behaviour? If they specify a default, the column should be auto-filled with that default, right? Good question. We might want some input from other DBs; Dec RDB default existing rows to NULL irrespective o

Re: [HACKERS] Help with ADD COLUMN

2002-11-23 Thread Tom Lane
"Christopher Kings-Lynne" <[EMAIL PROTECTED]> writes: > The one big programming difficulty I see is the process of running through > all the existing tuples in the relation the column was added to and > evaluating the default for each row. Basically you wanna do an "UPDATE tab SET col = ". I'd su

Re: quote_ident and schemas (was Re: [HACKERS] connectby with schema)

2002-11-23 Thread Masaru Sugawara
On Fri, 22 Nov 2002 15:21:48 -0800 Joe Conway <[EMAIL PROTECTED]> wrote: > OK. Attached patch removes calls within the function to quote_ident, requiring > the user to appropriately quote their own identifiers. I also tweaked the > regression test to deal with "value" becoming a reserved word. >

Re: [HACKERS] Optimizer & boolean syntax

2002-11-23 Thread Daniele Orlandi
Tom Lane wrote: Only two of them are logically equivalent. Consider NULL. Ohhh IS NOT TRUE or IS NOT FALSE also match NULL, I never knew this :) Even for the first two, assuming equivalence requires hard-wiring an assumption about the behavior of the "bool = bool" operator; which is a user-r

[HACKERS] Help with ADD COLUMN

2002-11-23 Thread Christopher Kings-Lynne
Hi Guys, I'm starting work on ADD COLUMN. I'm going to allow: * SERIAL, SERIAL8 * DEFAULT * NOT NULL etc... The one big programming difficulty I see is the process of running through all the existing tuples in the relation the column was added to and evaluating the default for each row. I ass

Re: [HACKERS] regression failures

2002-11-23 Thread Bruce Momjian
OK, regression tests adjusted and cat version updated. --- Tom Lane wrote: > Joe Conway <[EMAIL PROTECTED]> writes: > > Tom Lane wrote: > >> There should have been a catversion bump for the domain-constraints > >> patch, but

Re: [HACKERS] regression failures

2002-11-23 Thread Tom Lane
Joe Conway <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> There should have been a catversion bump for the domain-constraints >> patch, but there wasn't. When was your previous CVS pull? > Several days ago at least. Then you probably got bit by that patch --- it was applied a couple days ago.

Re: [HACKERS] regression failures

2002-11-23 Thread Joe Conway
Tom Lane wrote: There should have been a catversion bump for the domain-constraints patch, but there wasn't. When was your previous CVS pull? Several days ago at least. I use cvsup every few days to sync up. Is there a way I can tell exactly when? Joe ---(end of bro

Re: [HACKERS] regression failures

2002-11-23 Thread Tom Lane
Joe Conway <[EMAIL PROTECTED]> writes: > I guess a recent change requires an initdb but no change was forced? There should have been a catversion bump for the domain-constraints patch, but there wasn't. When was your previous CVS pull? regards, tom lane -

Re: [HACKERS] regression failures

2002-11-23 Thread Rod Taylor
On Sat, 2002-11-23 at 01:04, Joe Conway wrote: > I'm getting lots of regression failures: > > > 25 of 89 tests failed. > > > all pretty much looking like: > >SELECT '' AS one, o.* FROM OID_TBL o WHERE o.f1 = 1234; > ! ERROR: Relation "pg_c