Re: [HACKERS] Bad macro in pg_wchar.h?

2003-06-03 Thread Bruce Momjian
Patch applied. Thanks. --- Oliver Elphick wrote: > In src/include/mb/pg_wchar.h we have: > > #define PG_ENCODING_BE_LAST PG_ISO_8859_8 > #define PG_ENCODING_FE_LAST PG_WIN1256 > > but the last client encoding in the enum l

Re: [HACKERS] Postgres config file: autocommit = off

2003-06-03 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > In thinking about it, I don't see how we can ignore .psqlrc if it has > autocommit set to off. Imagine I am in psql and I do '\i file', and it > works, so I code up psql -c in a script, and it doesn't work --- would > be quite strange. What's your point

Re: [HACKERS] Status during copy [patch]

2003-06-03 Thread Bruce Momjian
Yes, completely agree. Added to TODO: > o Return the number of rows loaded/unloaded --- Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > How do people feel about this patch? Currently COPY doesn't ev

Re: Logging (was Re: [HACKERS] Suggestion GRANT ALTER, TRIGGER ON ALTER)

2003-06-03 Thread Josh Berkus
Bruce, > * Allow logging of only data definition(DDL), or DDL and modification > statements > > I can't see why someone would want to see only SELECT and not others, > and I can't imagine wanting modification statements and not DDL. This seems very reasonable to me. David? -- Josh Berkus Agl

Re: [HACKERS] initdb problems handling super username with spaces.

2003-06-03 Thread Tom Lane
"Francisco Figueiredo Jr." <[EMAIL PROTECTED]> writes: > [ initdb fails with superuser name that contains spaces ] I've put in some fixes for the most obvious problems, though I'd not want to swear there are no other places that are careless about this. > psql also seems to be with problems as it

Re: Logging (was Re: [HACKERS] Suggestion GRANT ALTER, TRIGGER ON ALTER)

2003-06-03 Thread Bruce Momjian
Seems this would be the easiest way: * Allow logging of only data definition(DDL), or DDL and modification statements I can't see why someone would want to see only SELECT and not others, and I can't imagine wanting modification statements and not DDL. Added to TODO.

Re: [HACKERS] [GENERAL] ERROR: Memory exhausted in AllocSetAlloc(188)

2003-06-03 Thread Bruce Momjian
We already have this TODO item: * Add deferred trigger queue file (Jan) --- Alvaro Herrera wrote: > On Wed, May 21, 2003 at 04:39:18PM -0400, Tom Lane wrote: > > > Each pending deferred-trigger action takes about 4

Re: [HACKERS] Status during copy [patch]

2003-06-03 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > How do people feel about this patch? Currently COPY doesn't even return > a line count of the number of lines processed, while this patch would > make psql \copy produce date/time and count every 1000 rows, then print > a similar completion message. See

Re: [HACKERS] Postgres config file: autocommit = off

2003-06-03 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> Yeah, it's a bit warty, but psql -c is inherently different from a psql >> script. IMHO it's not reasonable to make (shell) scripts using psql -c > How is it different, except for having no prompt? It's different because it's explici

Re: [HACKERS] Postgres config file: autocommit = off

2003-06-03 Thread Bruce Momjian
Oh, yes, sorry, I was confusing psql -c and -f. -c is clearly different. --- Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Tom Lane wrote: > >> Yeah, it's a bit warty, but psql -c is inherently different f

Re: [HACKERS] Postgres config file: autocommit = off

2003-06-03 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > In thinking about it, I don't see how we can ignore .psqlrc if it has > > autocommit set to off. Imagine I am in psql and I do '\i file', and it > > works, so I code up psql -c in a script, and it doesn't work --- would > > be quite s

Re: [HACKERS] Feature suggestions (long)

2003-06-03 Thread Bruce Momjian
I was able to merge your ideas into the TODO because they are also items that relate to other optimizations. Look for 'subtable' on the web TODO to see the changes: > * Allow a single index to index multiple tables (for inheritance and subtables) > * Improve the planner to use CHECK constraints

Re: [HACKERS] Feature suggestions (long)

2003-06-03 Thread Bruce Momjian
This seems related to table spaces --- once we have them, having some automatic way to spread the data across tablespaces would make sense, so I have added this discussion to that TODO.detail. --- Martijn van Oosterhout wrot

Re: [HACKERS] Postgres config file: autocommit = off

2003-06-03 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > SET autocommit to 'off' is going away in 7.4 so the SET USER command > > will not work anymore in that release, and I can't think of a > > workaround. There will be interface-specific settings, I assume, but I > > am not sure how that

Re: [HACKERS] Postgres config file: autocommit = off

2003-06-03 Thread Bruce Momjian
SET autocommit to 'off' is going away in 7.4 so the SET USER command will not work anymore in that release, and I can't think of a workaround. There will be interface-specific settings, I assume, but I am not sure how that would be controlled per-user. ---

Re: [HACKERS] Postgres config file: autocommit = off

2003-06-03 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > SET autocommit to 'off' is going away in 7.4 so the SET USER command > > will not work anymore in that release, and I can't think of a > > workaround. There will be interface-specific settings, I assume, but I > > am not sure how that

Re: [HACKERS] Postgres config file: autocommit = off

2003-06-03 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > SET autocommit to 'off' is going away in 7.4 so the SET USER command > will not work anymore in that release, and I can't think of a > workaround. There will be interface-specific settings, I assume, but I > am not sure how that would be controlled per-u

Re: [HACKERS] Problems with renaming a column

2003-06-03 Thread Rod Taylor
On Mon, 2003-06-02 at 14:00, Tom Lane wrote: > Rod Taylor <[EMAIL PROTECTED]> writes: > > As you can see below, after a rename the check constraint still refers > > to 'col' and not 'newname' as pg_constraint.consrc is not updated. > > The same issue has always existed with regard to pg_attrdef.ad

Re: [HACKERS] Problems with renaming a column

2003-06-03 Thread Tom Lane
Rod Taylor <[EMAIL PROTECTED]> writes: >> I do not think we need to remove the column. > Is it ok that the consrc column is not synch'd with conbin? What does > it provide if it doesn't match? Documentation of the original form of the constraint, perhaps? > At very least we should be discouragi

Re: [HACKERS] Problems with renaming a column

2003-06-03 Thread Tom Lane
Rod Taylor <[EMAIL PROTECTED]> writes: > As you can see below, after a rename the check constraint still refers > to 'col' and not 'newname' as pg_constraint.consrc is not updated. The same issue has always existed with regard to pg_attrdef.adsrc. pg_dump ought to be using the binary column not th

Re: [HACKERS] Proposal for Re-ordering CONF (was: Re: GUC and postgresql.conf docs)

2003-06-03 Thread Josh Berkus
Tom, > Josh's proposal looks pretty good to me in general, though some of the > details seem a little odd. "max_files_per_process" doesn't belong under > lock management (perhaps better to stick it under Memory Usage, possibly > renaming that category to Resource Consumption) and the Query Tuning

Re: [HACKERS] Status during copy [patch]

2003-06-03 Thread Bruce Momjian
How do people feel about this patch? Currently COPY doesn't even return a line count of the number of lines processed, while this patch would make psql \copy produce date/time and count every 1000 rows, then print a similar completion message.

Re: [HACKERS] Postgres config file: autocommit = off

2003-06-03 Thread Nigel J. Andrews
On Sun, 1 Jun 2003, Rasmus Resen Amossen wrote: > >We have been there, done that, and decided it was a bad idea. I suggest > >you do a little reading in the mail list archives. > > I have searched the lists archives for the words "commit", "autocommit" and > "transaction" but couldn't find any

Re: [HACKERS] Proposal for Re-ordering CONF (was: Re: GUC and postgresql.conf docs)

2003-06-03 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Agreed, postgresql.conf and the documentation should match. Guc.c needs > to be in variable _type_ order, so I don't know what can be done > there. We could make each table in guc.c follow the logical ordering Josh suggests for its subset of the variabl

[HACKERS] Some quick notes about extending libpq for new protocol

2003-06-03 Thread Tom Lane
Here are my notes about what to do to extend libpq's API to support the new features of the 3.0 frontend/backend protocol. Not very polished but I trust you can follow it. Any objections? regards, tom lane LIBPQ updates for new protocol -- N

Re: [HACKERS] SET CONSTRAINTS not schema-aware

2003-06-03 Thread Bruce Momjian
OK, added to TODO: Allow SET CONSTRAINTS to be qualified by schema/table Peter, I assume SET CONSTRAINTS can't control a domain's constraints --- it isn't actually a data object in the transaction. Am I right? ---

Re: [HACKERS] Proposal for Re-ordering CONF (was: Re: GUC and postgresql.conf docs)

2003-06-03 Thread Josh Berkus
Bruce, > I don't think people change _that_ _many_ postgresql.conf settings, so > reordering should be OK with them, especially if they get a clearer > output. Yeah. I put in the objection because Elein already made it to me. I also think that most people don't adjust *enough* Postgresql.conf s

Re: [HACKERS] Proposal for Re-ordering CONF (was: Re: GUC and postgresql.conf

2003-06-03 Thread Bruce Momjian
Agreed, postgresql.conf and the documentation should match. Guc.c needs to be in variable _type_ order, so I don't know what can be done there. The current postgresql.conf ordering is based on my reordering a few releases back to make it clearer. Feel free to improve it. I don't think people c

[HACKERS] Proposal for Re-ordering CONF (was: Re: GUC and postgresql.conf docs)

2003-06-03 Thread Josh Berkus
Bruce, > I have developed the following patch to address these issues. I have > removed the lock GUC settings from postgresql.conf, as suggested. (They > aren't even enabled in the general builds.) Great! Just to keep you from getting complacent, what follows is a proposal for re-ordering th

[HACKERS] Problems with renaming a column

2003-06-03 Thread Rod Taylor
As you can see below, after a rename the check constraint still refers to 'col' and not 'newname' as pg_constraint.consrc is not updated. Of course, this functions fine (conbin is still valid) but when it comes time to do a pg_dump, the database is dumped using the old column name. It seems this

Re: [HACKERS] Linux startup script

2003-06-03 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches I will try to apply it within the next 48 hours. --- Darko Prenosil wrote: > I have noti

[HACKERS] PostgreSQL for windows 98

2003-06-03 Thread Hugo Ferreira da Silva
Hi all, Somebody know if this version of PostgreSQL for win 32 ( ) work's under windows 98? And, if it work's, how do I install? Cause when I try to connect, I receive this error message: "PSQL.EXE: could not connect to server: Socket error, no description available. ( 0x274D) Is the server r