Re: [PATCHES] [HACKERS] Text <-> C string

2008-04-15 Thread Brendan Jurd
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 - -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Sat, Mar 29, 2008 at 5:40 AM, Brendan Jurd wrote: > On 29/03/2008, Tom Lane wrote: > > I intentionally didn't touch xml.c, nor anyplace that is not dealing > > in text, even if it happens to be b

Re: [HACKERS] pulling libpqtypes from queue

2008-04-15 Thread tomas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Tue, Apr 15, 2008 at 10:57:37AM -0400, Merlin Moncure wrote: > On Tue, Apr 15, 2008 at 10:48 AM, <[EMAIL PROTECTED]> wrote: > > On Tue, Apr 15, 2008 at 09:48:37AM -0400, Merlin Moncure wrote: > > > On Tue, Apr 15, 2008 at 9:36 AM, Alvaro Herrera

Re: [HACKERS] Lessons from commit fest

2008-04-15 Thread NikhilS
Hi, > The idea that we "fix" stylistic issues on the fly is not sustainable. > > We should offer help and mentorship to new patch submitters in all > > areas (including stylistic) but they should do the work. It is the only > > way we will mold them to submit patches in the proper way. > > > >

Re: [HACKERS] Lessons from commit fest

2008-04-15 Thread Decibel!
On Apr 14, 2008, at 4:15 PM, Bruce Momjian wrote: If you don't want an issue to get forgotten, then make a TODO entry for it. But the purpose of commit fest is to make sure we deal with things that can be dealt with in a timely fashion. It's not going to cause solutions to unsolved problems

Re: [HACKERS] Lessons from commit fest

2008-04-15 Thread Brendan Jurd
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Wed, Apr 16, 2008 at 2:17 AM, Joshua D. Drake wrote: > On Tue, 15 Apr 2008 12:12:24 -0400 > Alvaro Herrera wrote: > > > Tom Lane wrote: > > > > > I tend to just fix this stuff while committing, rather than lecture > > > the submitters about i

Re: [HACKERS] WIP: Pg_upgrade - page layout converter (PLC) hook

2008-04-15 Thread Heikki Linnakangas
Zdenek Kotala wrote: Heikki Linnakangas napsal(a): I would suggest starting with putting some serious effort into pg_migrator. This page layout conversion is actually pretty trivial compared to all that, and even more so if you can get the page layout conversion working in pg_migrator first.

Re: [HACKERS] pg_terminate_backend() issues

2008-04-15 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > I am starting to think we need to analyze the source code rather than > testing, because of what we are testing for. I was thinking about that a bit more, in connection with trying to verbalize why I don't like your patch ;-) The fundamental assumption

Re: [HACKERS] pg_terminate_backend() issues

2008-04-15 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Tom Lane wrote: > >> I was able to get things to more or less work most of the time with > >> three or four additional ugly hacks in postgres.c, but I still don't > >> have any great confidence that there aren't windows where a termina

Re: [HACKERS] pg_terminate_backend() issues

2008-04-15 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > >> I think if we want pg_terminate_backend, we have to do it the way that > >> was originally discussed: have it issue SIGTERM and fix whatever needs > >> to be fixed in the SIGTERM code path. > > > Well, with no movement on this TODO i

Re: [HACKERS] count(*) performance improvement ideas

2008-04-15 Thread Tom Lane
"Stephen Denne" <[EMAIL PROTECTED]> writes: > From: Tom Lane [mailto:[EMAIL PROTECTED] >> As for 2) and 3), can't you look into the pg_settings view? > pg_settings view doesn't contain custom variables created on the fly, Really? [ pokes around ... ] Hm, you're right, because add_placeholder_va

Re: [HACKERS] count(*) performance improvement ideas

2008-04-15 Thread Stephen Denne
(apologies for the email format & top posting, I've had to temporarily switch to using a web interface from home that doesn't seem to know what plain text is) pg_settings view doesn't contain custom variables created on the fly, (nor, from memory, ones defined in postgresql.conf. I'm not able t

Re: [HACKERS] count(*) performance improvement ideas

2008-04-15 Thread Tom Lane
"Stephen Denne" <[EMAIL PROTECTED]> writes: > The custom variable class can also be used to aggregate the deltas within a > transaction, though there are some minor difficulties: > 1) They only store text > 2) You can only find out that a value has not been set by catching an > exception > 3) Th

Re: [HACKERS] count(*) performance improvement ideas

2008-04-15 Thread Stephen Denne
(There is a possible performance bug mentioned at the end of the email, the rest is further discussion regarding materialised views) I wrote > Pavan Deolasee wrote > > On Thu, Mar 20, 2008 at 3:24 AM, Stephen Denne > > <[EMAIL PROTECTED]> wrote: > > > > > > > > Pavan also refers to deferred tri

Re: [HACKERS] DROP DATABASE vs patch to not remove files right away

2008-04-15 Thread Andrew Dunstan
Tom Lane wrote: Alvaro Herrera <[EMAIL PROTECTED]> writes: Tom Lane wrote: I think that it should be coded to ignore ENOENT the same as the bgwriter does, and that it should press on and keep trying to delete things even if it gets a failure. Perhaps, if it gets ENOENT, r

Re: [HACKERS] DROP DATABASE vs patch to not remove files right away

2008-04-15 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> I think that it should be coded >> to ignore ENOENT the same as the bgwriter does, and that it should press >> on and keep trying to delete things even if it gets a failure. > Perhaps, if it gets ENOENT, record this fact -- and after

[HACKERS] Improving planner variable handling

2008-04-15 Thread Tom Lane
I've been thinking about how to improve the planner's poor handling of variables in outer-join situations. Here are some past examples for motivation: http://archives.postgresql.org/pgsql-hackers/2006-02/msg00154.php http://archives.postgresql.org/pgsql-general/2008-03/msg01440.php The reason wh

Re: [HACKERS] DROP DATABASE vs patch to not remove files right away

2008-04-15 Thread Alvaro Herrera
Tom Lane wrote: > I think that it should be coded > to ignore ENOENT the same as the bgwriter does, and that it should press > on and keep trying to delete things even if it gets a failure. Perhaps, if it gets ENOENT, record this fact -- and after rmtree returns, retry the whole thing. -- Alvar

Re: [HACKERS] pg_terminate_backend() issues

2008-04-15 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Here is a little different idea. Seems we want something more like: > > Yeah, I thought about building a set of macros that would have this > ability folded in, but it didn't seem like much notational advantage > given that you have

Re: [HACKERS] pg_terminate_backend() issues

2008-04-15 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Here is a little different idea. Seems we want something more like: Yeah, I thought about building a set of macros that would have this ability folded in, but it didn't seem like much notational advantage given that you have to write the cleanup routine

Re: [HACKERS] pg_terminate_backend() issues

2008-04-15 Thread Bruce Momjian
Tom Lane wrote: > I did a quick grep for PG_CATCH uses to see what we have along the lines > of this bug: > http://archives.postgresql.org/pgsql-hackers/2007-04/msg00218.php > > In current sources there are three places at risk: > > btbulkdelete, as noted in the above message > pg_start_backup

Re: [HACKERS] pg_terminate_backend() idea

2008-04-15 Thread Gregory Stark
"Bruce Momjian" <[EMAIL PROTECTED]> writes: > Gregory Stark wrote: > >> It seems to me we could replace all of the above with either SIGINT or USR1 >> and have a bunch of boolean flags in MyProc. I'm not sure of the implication >> for sinval processing of having to get a whole bunch of LWLocks tho

[HACKERS] DROP DATABASE vs patch to not remove files right away

2008-04-15 Thread Tom Lane
Over the last couple days I twice saw complaints like this during DROP DATABASE: WARNING: could not remove file or directory "base/80750/80825": No such file or directory WARNING: could not remove database directory "base/80750" I poked at it for awhile and was eventually able to extract a rep

Re: [HACKERS] pg_terminate_backend() issues

2008-04-15 Thread Tom Lane
I did a quick grep for PG_CATCH uses to see what we have along the lines of this bug: http://archives.postgresql.org/pgsql-hackers/2007-04/msg00218.php In current sources there are three places at risk: btbulkdelete, as noted in the above message pg_start_backup needs to reset forcePageWrites = f

Re: [HACKERS] pg_terminate_backend() issues

2008-04-15 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> I was able to get things to more or less work most of the time with >> three or four additional ugly hacks in postgres.c, but I still don't >> have any great confidence that there aren't windows where a terminate >> request wouldn't be

[HACKERS] pg_terminate_backend() issues

2008-04-15 Thread Bruce Momjian
Tom Lane wrote: > I wrote: > > All in all, this patch wasn't ready to apply without review. I'm > > currently looking to see whether it's salvageable or not. > > After further study, I've concluded that it is in fact not salvageable, > and I respectfully request that it be reverted. OK, reverted

Re: [HACKERS] Re: [COMMITTERS] pgsql: Add pg_terminate_backend() to allow terminating only a single

2008-04-15 Thread Tom Lane
I wrote: > All in all, this patch wasn't ready to apply without review. I'm > currently looking to see whether it's salvageable or not. After further study, I've concluded that it is in fact not salvageable, and I respectfully request that it be reverted. I was able to get things to more or less

Re: [HACKERS] Commit fest queue

2008-04-15 Thread Zdenek Kotala
Peter Eisentraut napsal(a): Am Dienstag, 15. April 2008 schrieb Zdenek Kotala: JavaDB and Firebird community use Jira Jira had already been rejected many years ago because it is not open source. Yeah, I know, main point was that it is similar to bugzila. Zdenek -- Sent via

Re: [HACKERS] WIP: Pg_upgrade - page layout converter (PLC) hook

2008-04-15 Thread Zdenek Kotala
Tom Lane napsal(a): Heikki Linnakangas <[EMAIL PROTECTED]> writes: Zdenek Kotala wrote: I attached patch which implemented page layout converter (PLC) hook. It is base stone for in-place upgrade. I agree it's an important piece of the puzzle, but not the most complicated one by far. In fac

Re: [HACKERS] pulling libpqtypes from queue

2008-04-15 Thread Andrew Chernow
Merlin Moncure wrote: Maybe if there was PQinitGlobalHooks so that all PGconn structs created would inherit the hooks automatically...this allows per conn initialization (if desired) and global initialization which is often easier. As I understand this, no locking is required, except the init f

Re: [HACKERS] Commit fest status

2008-04-15 Thread Decibel!
On Apr 11, 2008, at 2:33 PM, Tom Lane wrote: Bruce Momjian <[EMAIL PROTECTED]> writes: Tom Lane wrote: In short, I think it's time to declare our first commit fest done. OK, todo updated, but what about the "Maintaining cluster order on insert" idea? http://momjian.us/cgi-bin/pgpatch

Re: [HACKERS] WIP: Pg_upgrade - page layout converter (PLC) hook

2008-04-15 Thread Zdenek Kotala
Thanks for your comment. See my comments inline: Heikki Linnakangas napsal(a): Zdenek Kotala wrote: I attached patch which implemented page layout converter (PLC) hook. It is base stone for in-place upgrade. I agree it's an important piece of the puzzle, but not the most complicated one by f

Re: [HACKERS] Re: [COMMITTERS] pgsql: Add pg_terminate_backend() to allow terminating only a single

2008-04-15 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Tom Lane wrote: > >> A more interesting question is what makes you think that taking > >> ProcArrayLock here has any value whatsoever. > > > I took the lock so I would be sure the PGPROC array was the matching pid > > and not some oth

Re: [HACKERS] pulling libpqtypes from queue

2008-04-15 Thread Merlin Moncure
On Tue, Apr 15, 2008 at 3:13 PM, Andrew Chernow <[EMAIL PROTECTED]> wrote: > Tom Lane wrote: > > Andrew Chernow <[EMAIL PROTECTED]> writes: > > > > > Installing it per-conn doesn't get you anything. pqtypes has already > been linked in. If you use PQexec and PQgetvalue, the pqtypes code pretty >

Re: [HACKERS] pulling libpqtypes from queue

2008-04-15 Thread Andrew Chernow
Tom Lane wrote: Andrew Chernow <[EMAIL PROTECTED]> writes: Installing it per-conn doesn't get you anything. pqtypes has already been linked in. If you use PQexec and PQgetvalue, the pqtypes code pretty much does nothing. So, a per-conn install seems redundant. You are installing the same f

Re: [HACKERS] pulling libpqtypes from queue

2008-04-15 Thread Tom Lane
Andrew Chernow <[EMAIL PROTECTED]> writes: > Installing it per-conn doesn't get you anything. pqtypes has already > been linked in. If you use PQexec and PQgetvalue, the pqtypes code > pretty much does nothing. So, a per-conn install seems redundant. You > are installing the same function po

Re: [HACKERS] Re: [COMMITTERS] pgsql: Add pg_terminate_backend() to allow terminating only a single

2008-04-15 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> A more interesting question is what makes you think that taking >> ProcArrayLock here has any value whatsoever. > I took the lock so I would be sure the PGPROC array was the matching pid > and not some other pid that was created betwee

Re: [HACKERS] pulling libpqtypes from queue

2008-04-15 Thread Andrew Chernow
Merlin Moncure wrote: For posterity, here are our objections to hooking libpq: *) Is there any other plausible scenario of another use for hooking into libpq events? (this is rhetorical...we don't think there is.) We think that there is a better way to integrate libpqtypes with libpq so maybe t

Re: [HACKERS] pulling libpqtypes from queue

2008-04-15 Thread Merlin Moncure
On Tue, Apr 15, 2008 at 11:51 AM, Alvaro Herrera <[EMAIL PROTECTED]> wrote: > Andrew Chernow escribió: > > Maybe we'll get enough support in the future to get our stubs into core. > > Until then, you'll have to patch libpq. We plan to provide binary > > patches for the major platforms. You wo

Re: [HACKERS] Re: [COMMITTERS] pgsql: Add pg_terminate_backend() to allow terminating only a single

2008-04-15 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Alvaro Herrera wrote: > >> I wonder if it's OK to grab an LWLock in a signal handler. > > > I am not in a signal handler there --- pg_terminate_backend() happens > > for the person requesting the termination, not the terminated backen

Re: [HACKERS] Re: [COMMITTERS] pgsql: Add pg_terminate_backend() to allow terminating only a single

2008-04-15 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Alvaro Herrera wrote: >> I wonder if it's OK to grab an LWLock in a signal handler. > I am not in a signal handler there --- pg_terminate_backend() happens > for the person requesting the termination, not the terminated backend > that gets the signal. A

[HACKERS] pg_terminate_backend() idea

2008-04-15 Thread Bruce Momjian
Gregory Stark wrote: > >> > Add pg_terminate_backend() to allow terminating only a single session. > > I'm interested in this because I was already looking for a solution to the > "out of signals" problem we have. > > I think we could expand this by having a bunch of boolean flags, one each for >

Re: [HACKERS] Commit fest queue

2008-04-15 Thread Peter Eisentraut
Am Dienstag, 15. April 2008 schrieb Zdenek Kotala: > JavaDB and Firebird community use Jira Jira had already been rejected many years ago because it is not open source. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgres

Re: [HACKERS] MSVC build broken with perl 5.10

2008-04-15 Thread Andrew Dunstan
Zeugswetter Andreas OSB SD wrote: Magnus Hagander wrote: I just tried the MSVC build on a system with ActiveState Perl 5.10, and it doesn't work. Some quick debugging before I downgraded to 5.8 showed that this regexp in Project.pm line 262: my $replace_re = qr{^([^:

Re: [HACKERS] Problem with site doc search

2008-04-15 Thread Richard Huxton
Oleg Bartunov wrote: Sergey Karpov prepared contrib/extend_parser, which we intend to use for indexing pg-related documents. It handles '_' properly, so if anybody interested, we could post it. Also, it can be useful for playing, since it's standalone contrib module. Does it make sense to back

Re: [HACKERS] Lessons from commit fest

2008-04-15 Thread Joshua D. Drake
On Tue, 15 Apr 2008 12:12:24 -0400 Alvaro Herrera <[EMAIL PROTECTED]> wrote: > Tom Lane wrote: > > > I tend to just fix this stuff while committing, rather than lecture > > the submitters about it, but it undoubtedly is a time sink. > > Lesson learned: a useful task for another reviewer to do is

Re: [HACKERS] WIP: Pg_upgrade - page layout converter (PLC) hook

2008-04-15 Thread Tom Lane
Heikki Linnakangas <[EMAIL PROTECTED]> writes: > Zdenek Kotala wrote: >> I attached patch which implemented page layout converter (PLC) hook. It >> is base stone for in-place upgrade. > I agree it's an important piece of the puzzle, but not the most > complicated one by far. In fact, it's not ev

Re: [HACKERS] [COMMITTERS] pgsql: Add pg_terminate_backend() to allow terminating only a single

2008-04-15 Thread Gregory Stark
"Bruce Momjian" <[EMAIL PROTECTED]> writes: >> > Log Message: >> > --- >> > Add pg_terminate_backend() to allow terminating only a single session. I'm interested in this because I was already looking for a solution to the "out of signals" problem we have. I think we could expand this by

Re: [HACKERS] Lessons from commit fest

2008-04-15 Thread Alvaro Herrera
Tom Lane wrote: > I tend to just fix this stuff while committing, rather than lecture the > submitters about it, but it undoubtedly is a time sink. Lesson learned: a useful task for another reviewer to do is to grab the patch, fix the style issues, and post the fixed version. That way, the "high

Re: [HACKERS] Problem with site doc search

2008-04-15 Thread Oleg Bartunov
Sergey Karpov prepared contrib/extend_parser, which we intend to use for indexing pg-related documents. It handles '_' properly, so if anybody interested, we could post it. Also, it can be useful for playing, since it's standalone contrib module. Oleg On Tue, 15 Apr 2008, Richard Huxton wrote:

Re: [HACKERS] Lessons from commit fest

2008-04-15 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> A general comment is that in stuff I review, I frequently spend a lot of >> time trying to make the patch "look like it belongs", that is make it >> reasonably well-integrated with the surrounding code. This is important >> because a

Re: [HACKERS] Problem with site doc search

2008-04-15 Thread Oleg Bartunov
On Tue, 15 Apr 2008, Magnus Hagander wrote: I didn't do anything, but possibly it got fixed by a different upgrade at some point, and the recrawling of the sites. Magnus, we have parser for indexing pgdocs, do you need it ? //Magnus Bruce Momjian wrote: I just searched for pg_standby and

Re: [HACKERS] WIP: Pg_upgrade - page layout converter (PLC) hook

2008-04-15 Thread Heikki Linnakangas
Zdenek Kotala wrote: I attached patch which implemented page layout converter (PLC) hook. It is base stone for in-place upgrade. I agree it's an important piece of the puzzle, but not the most complicated one by far. How will you deal with catalog changes for example? I'm going to assume that

Re: [HACKERS] pulling libpqtypes from queue

2008-04-15 Thread Alvaro Herrera
Andrew Chernow escribió: > Maybe we'll get enough support in the future to get our stubs into core. > Until then, you'll have to patch libpq. We plan to provide binary > patches for the major platforms. You won't have to patch the guts of > pqtypes though because that is dynamically loade

Re: [HACKERS] stack smashing detected

2008-04-15 Thread Gregory Stark
"Ana Carolina Brito de Almeida" <[EMAIL PROTECTED]> writes: > Hi! > > I'm trying test a version extended of Postgresql, but when I run a command > after 9 times, I receive this message in psql: > ***stack smashing detected*** This string does not occur in Postgres. There must be more going on tha

Re: [HACKERS] Lessons from commit fest

2008-04-15 Thread Alvaro Herrera
Tom Lane wrote: > A general comment is that in stuff I review, I frequently spend a lot of > time trying to make the patch "look like it belongs", that is make it > reasonably well-integrated with the surrounding code. This is important > because a code base that too obviously consists of layers

Re: [HACKERS] pulling libpqtypes from queue

2008-04-15 Thread Andrew Chernow
Martijn van Oosterhout wrote: On Tue, Apr 15, 2008 at 11:24:43AM -0400, Andrew Chernow wrote: libpqtypes had a superclassing concept (not much discussed on the lists) where you could introduce new type handlers that wrapped existing ones and was desgined exactly for things like this. keep an ey

Re: [HACKERS] [SQL] rule for update view that updates/inserts into 2 tables

2008-04-15 Thread Martijn van Oosterhout
On Tue, Apr 15, 2008 at 11:27:15AM -0400, Chad Showalter wrote: > I don't need to define the view the way I did in my example. I do need the > view to have fields that map to fields in my_audit_table in order to do an > insert into that table with values from the insert statement. Right. > Here

Re: [HACKERS] stack smashing detected

2008-04-15 Thread Tom Lane
"Ana Carolina Brito de Almeida" <[EMAIL PROTECTED]> writes: > I'm trying test a version extended of Postgresql, but when I run a command > after 9 times, I receive this message in psql: > ***stack smashing detected*** > And Log said that postgres terminated with signal 6. > I increased buffer to 12

Re: [HACKERS] pulling libpqtypes from queue

2008-04-15 Thread Martijn van Oosterhout
On Tue, Apr 15, 2008 at 11:24:43AM -0400, Andrew Chernow wrote: > >libpqtypes had a superclassing concept (not much discussed on the > >lists) where you could introduce new type handlers that wrapped > >existing ones and was desgined exactly for things like this. keep an > >eye on our upcoming pgf

Re: [HACKERS] Lessons from commit fest

2008-04-15 Thread Tom Lane
Gregory Stark <[EMAIL PROTECTED]> writes: > I don't think we know what a "typical review" really looks like. A general comment is that in stuff I review, I frequently spend a lot of time trying to make the patch "look like it belongs", that is make it reasonably well-integrated with the surroundin

Re: [HACKERS] [SQL] rule for update view that updates/inserts into 2 tables

2008-04-15 Thread Chad Showalter
Robins and Martijn, Thanks for the help. My main objective here was to be able to perform both an update and an insert in one call (wanted to reduce database roundtrips, and speed up my program), and I am using the view solely to allow me to do this.What both of you have pointed out is th

Re: [HACKERS] pulling libpqtypes from queue

2008-04-15 Thread Andrew Chernow
Merlin Moncure wrote: On Tue, Apr 15, 2008 at 10:48 AM, <[EMAIL PROTECTED]> wrote: On Tue, Apr 15, 2008 at 09:48:37AM -0400, Merlin Moncure wrote: > On Tue, Apr 15, 2008 at 9:36 AM, Alvaro Herrera > <[EMAIL PROTECTED]> wrote: > > I expect you intend to get at least the hooks in, right? >

Re: [HACKERS] Idle idea for improving concurrency of LISTEN/NOTIFY

2008-04-15 Thread Bruce Momjian
Added to TODO: o Improve LISTEN concurrency http://archives.postgresql.org/pgsql-hackers/2008-02/msg01106.php --- Tom Lane wrote: > Sooner or later we ought to completely reimplement LISTEN/NOTIFY, > but

Re: [HACKERS] [PATCHES] Avahi support for Postgresql

2008-04-15 Thread Alvaro Herrera
Bruce Momjian wrote: > Alvaro Herrera wrote: > > Mathias Hasselmann wrote: > > > > > The patches were in my initial mail, but now I've also uploaded them to > > > my personal site for convenience: > > > > > > http://taschenorakel.de/files/pgsql-avahi-support/ > > > > Hmm, a quick look at the t

Re: [HACKERS] pulling libpqtypes from queue

2008-04-15 Thread Merlin Moncure
On Tue, Apr 15, 2008 at 10:48 AM, <[EMAIL PROTECTED]> wrote: > On Tue, Apr 15, 2008 at 09:48:37AM -0400, Merlin Moncure wrote: > > On Tue, Apr 15, 2008 at 9:36 AM, Alvaro Herrera > > <[EMAIL PROTECTED]> wrote: > > > > I expect you intend to get at least the hooks in, right? > > > > not like

Re: [HACKERS] [PATCHES] Avahi support for Postgresql

2008-04-15 Thread Bruce Momjian
Alvaro Herrera wrote: > Mathias Hasselmann wrote: > > > The patches were in my initial mail, but now I've also uploaded them to > > my personal site for convenience: > > > > http://taschenorakel.de/files/pgsql-avahi-support/ > > Hmm, a quick look at the third patch reveals that it is using t

Re: [HACKERS] Problem with site doc search

2008-04-15 Thread Richard Huxton
Magnus Hagander wrote: Did you ever post the code to anybody other than Gevik? If not, please send it to pgsql-www and someone can give it a quick look-over (perhaps Oleg can help us there?) Will do. -- Richard Huxton Archonet Ltd -- Sent via pgsql-hackers mailing list (pgsql-hackers@post

Re: [HACKERS] pulling libpqtypes from queue

2008-04-15 Thread tomas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Tue, Apr 15, 2008 at 09:48:37AM -0400, Merlin Moncure wrote: > On Tue, Apr 15, 2008 at 9:36 AM, Alvaro Herrera > <[EMAIL PROTECTED]> wrote: [...] > > I expect you intend to get at least the hooks in, right? > > not likely. Keep in mind, this is

Re: [HACKERS] Problem with site doc search

2008-04-15 Thread Magnus Hagander
Richard Huxton wrote: > Bruce Momjian wrote: > > Magnus Hagander wrote: > >> I didn't do anything, but possibly it got fixed by a different > >> upgrade at some point, and the recrawling of the sites. > > > > Oops, maybe it isn't fixed. I tried "pg_standby" and it seemed to > > work but "pg" and "

Re: [HACKERS] Problem with site doc search

2008-04-15 Thread Richard Huxton
Bruce Momjian wrote: Magnus Hagander wrote: I didn't do anything, but possibly it got fixed by a different upgrade at some point, and the recrawling of the sites. Oops, maybe it isn't fixed. I tried "pg_standby" and it seemed to work but "pg" and "standby" returns the same results. Is that co

Re: [HACKERS] pgwin32_safestat weirdness

2008-04-15 Thread Magnus Hagander
Tom Lane wrote: > Magnus Hagander <[EMAIL PROTECTED]> writes: > > Shouldn't be too hard to do, but I keep thinking it'd be cleaner to > > just not do the redefine when building libpq. It means we'd add a > > define like BUILDING_LIBPQ or something to the libpq Makefile, and > > exclude the redefine

Re: [HACKERS] pgwin32_safestat weirdness

2008-04-15 Thread Tom Lane
Magnus Hagander <[EMAIL PROTECTED]> writes: > Shouldn't be too hard to do, but I keep thinking it'd be cleaner to > just not do the redefine when building libpq. It means we'd add a > define like BUILDING_LIBPQ or something to the libpq Makefile, and > exclude the redefine if set. +1 for that gen

Re: [HACKERS] Problem with site doc search

2008-04-15 Thread Bruce Momjian
Magnus Hagander wrote: > I didn't do anything, but possibly it got fixed by a different upgrade > at some point, and the recrawling of the sites. Oops, maybe it isn't fixed. I tried "pg_standby" and it seemed to work but "pg" and "standby" returns the same results. Is that correct? How do I test

Re: [HACKERS] Problem with site doc search

2008-04-15 Thread Magnus Hagander
I didn't do anything, but possibly it got fixed by a different upgrade at some point, and the recrawling of the sites. //Magnus Bruce Momjian wrote: > > I just searched for pg_standby and it looks like it is fixed now. > >

Re: [HACKERS] Problem with site doc search

2008-04-15 Thread Bruce Momjian
I just searched for pg_standby and it looks like it is fixed now. --- Gurjeet Singh wrote: > On Tue, Mar 25, 2008 at 3:01 AM, Magnus Hagander <[EMAIL PROTECTED]> > wrote: > > > Gurjeet Singh wrote: > > > On Thu, Mar 6, 2008

Re: [HACKERS] stack smashing detected

2008-04-15 Thread Merlin Moncure
On Tue, Apr 15, 2008 at 9:48 AM, Ana Carolina Brito de Almeida <[EMAIL PROTECTED]> wrote: > Hi! > > I'm trying test a version extended of Postgresql, but when I run a command > after 9 times, I receive this message in psql: > ***stack smashing detected*** > And Log said that postgres terminated wit

Re: [HACKERS] Lessons from commit fest

2008-04-15 Thread Tom Lane
Gregory Stark <[EMAIL PROTECTED]> writes: > One thing I found is that I'm not sure what to do if I don't find any changes > to propose. I tend to assume that means I just don't understand the code well > enough and end up just not posting anything. It's still worth adding an annotation to the wiki

Re: [HACKERS] Re: [COMMITTERS] pgsql: Add pg_terminate_backend() to allow terminating only a single

2008-04-15 Thread Bruce Momjian
Alvaro Herrera wrote: > Bruce Momjian wrote: > > Log Message: > > --- > > Add pg_terminate_backend() to allow terminating only a single session. > > I wonder if it's OK to grab an LWLock in a signal handler. I am not in a signal handler there --- pg_terminate_backend() happens for the per

[HACKERS] Re: [COMMITTERS] pgsql: Add pg_terminate_backend() to allow terminating only a single

2008-04-15 Thread Alvaro Herrera
Bruce Momjian wrote: > Log Message: > --- > Add pg_terminate_backend() to allow terminating only a single session. I wonder if it's OK to grab an LWLock in a signal handler. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting

[HACKERS] stack smashing detected

2008-04-15 Thread Ana Carolina Brito de Almeida
Hi! I'm trying test a version extended of Postgresql, but when I run a command after 9 times, I receive this message in psql: ***stack smashing detected*** And Log said that postgres terminated with signal 6. I increased buffer to 120MB and the linux buffer (shmmax) to 2GB. What value can I put to

Re: [HACKERS] pulling libpqtypes from queue

2008-04-15 Thread Bruce Momjian
Alvaro Herrera wrote: > Andrew Chernow escribi?: > > > > This patch has been lingering around since Aug 2007. It has matured a > > lot and now calls libpq home. Unfortunately, ISTM that there is limited > > support for our proposal. We either pitched to the wrong crowd or > > pqtypes doesn

Re: [HACKERS] pulling libpqtypes from queue

2008-04-15 Thread Merlin Moncure
On Tue, Apr 15, 2008 at 9:36 AM, Alvaro Herrera <[EMAIL PROTECTED]> wrote: > Andrew Chernow escribió: > > This patch has been lingering around since Aug 2007. It has matured a > > lot and now calls libpq home. Unfortunately, ISTM that there is limited > > support for our proposal. We either p

Re: [HACKERS] MSVC build broken with perl 5.10

2008-04-15 Thread Zeugswetter Andreas OSB SD
Magnus Hagander wrote: > I just tried the MSVC build on a system with ActiveState Perl 5.10, and > it doesn't work. Some quick debugging before I downgraded to 5.8 showed > that this regexp in Project.pm line 262: > my $replace_re = qr{^([^:\n\$]+\.c)\s*:\s*(?:%\s*: )?\$(\([^\)]+\))\/(.*)\/[^\

Re: [HACKERS] pulling libpqtypes from queue

2008-04-15 Thread Alvaro Herrera
Andrew Chernow escribió: > > This patch has been lingering around since Aug 2007. It has matured a > lot and now calls libpq home. Unfortunately, ISTM that there is limited > support for our proposal. We either pitched to the wrong crowd or > pqtypes doesn't have the mass appeal we expecte

[HACKERS] pulling libpqtypes from queue

2008-04-15 Thread Andrew Chernow
This patch has been lingering around since Aug 2007. It has matured a lot and now calls libpq home. Unfortunately, ISTM that there is limited support for our proposal. We either pitched to the wrong crowd or pqtypes doesn't have the mass appeal we expected. With that said, we are consider

Re: [HACKERS] Lessons from commit fest

2008-04-15 Thread Gregory Stark
"Stephen Frost" <[EMAIL PROTECTED]> writes: > * Tom Lane ([EMAIL PROTECTED]) wrote: >> One problem with this fest was that a whole lot of the patches *weren't* >> trivial; if they had been they'd not have gotten put off till 8.4. So >> there weren't that many that I wanted to let go in without lo

Re: [HACKERS] Lessons from commit fest

2008-04-15 Thread Zdenek Kotala
Martijn van Oosterhout napsal(a): On Mon, Apr 14, 2008 at 05:15:51PM -0400, Bruce Momjian wrote: So when/how do those discussions get resolved? [ shrug... ] You can't force ideas to happen on a schedule. I need is to know if they are ideas worthy of TODO. One thing I would like is if larger

Re: [HACKERS] Lessons from commit fest

2008-04-15 Thread Stephen Frost
* Tom Lane ([EMAIL PROTECTED]) wrote: > One problem with this fest was that a whole lot of the patches *weren't* > trivial; if they had been they'd not have gotten put off till 8.4. So > there weren't that many that I wanted to let go in without looking at > them. I guess that's just another way

[HACKERS] WIP: Pg_upgrade - page layout converter (PLC) hook

2008-04-15 Thread Zdenek Kotala
I attached patch which implemented page layout converter (PLC) hook. It is base stone for in-place upgrade. How it works: When PLC module is loaded, then for each page which does not have native page version conversion routine is called. Buffer is mark as a dirty and upgraded page is insert

Re: [HACKERS] printTable API (was: Show INHERIT in \du)

2008-04-15 Thread Martijn van Oosterhout
On Tue, Apr 15, 2008 at 06:11:32PM +1000, Brendan Jurd wrote: > Now my question is, how do I indicate that a second version of the > patch has been submitted on the wiki? Should I leave the primary link > pointing at the original submission, or update it to point at this > message? I'd say add a

Re: [PATCHES] [HACKERS] Show INHERIT in \du

2008-04-15 Thread Brendan Jurd
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Sun, Apr 13, 2008 at 6:11 PM, Brendan Jurd wrote: > I've written a patch which implements the same \du behaviour as my > previous patch, but using the new printTable API New versions of this patch, including changes made to the printTable API in

Re: [HACKERS] printTable API (was: Show INHERIT in \du)

2008-04-15 Thread Brendan Jurd
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Mon, Apr 14, 2008 at 6:03 AM, Alvaro Herrera wrote: > Looks cool -- on a first read, I think you should add some more code > comments at the top of each function specifying whether the texts need > to be translated by the caller or done by the f

Re: [HACKERS] Cached Query Plans

2008-04-15 Thread Florian Weimer
* Dawid Kuroczko: > Right now the only way of getting such information from PostgreSQL > is by logging all queries and analyzing logs. The current_query > column of pg_stat_activity is useless as the (prepared) queries are > usually so short lived that you will see one execution out of > thousand

Re: [HACKERS] pgwin32_safestat weirdness

2008-04-15 Thread Magnus Hagander
Tom Lane wrote: > Magnus Hagander <[EMAIL PROTECTED]> writes: > > Is there not a (3) which has it included in all frontend code > > *except* libpq? Do we have a define to do that off? > > Offhand I can't think of one. > > > In libpq, it's only used in one place to check if a file is present, > >

Re: [HACKERS] pgwin32_safestat weirdness

2008-04-15 Thread Magnus Hagander
Tom Lane wrote: > Andrew Dunstan <[EMAIL PROTECTED]> writes: > > I would be quite happy with that, but before we go down that path > > I'd like to know why the MSVC builds aren't failing now from this > > when the MinGW builds are. > > Maybe the MSVC linker is willing to bind libpq's call to a saf