Re: [HACKERS] Can't t compile current HEAD

2008-05-14 Thread Pavan Deolasee
On Thu, May 15, 2008 at 10:00 AM, Pavel Stehule <[EMAIL PROTECTED]> wrote: > Hello > > I got some errors: > > Works for me. I am on the same platform (FC 8). If you have CVS updated, did you use -d option to get the new directories added to the repository ? I see a new include/portability director

[HACKERS] Confusing message in log file

2008-05-14 Thread Gurjeet Singh
Hi All, I changed the postgresql.conf file (of an 8.2.4 server), and issued relaod using pg_reload_config(). Following are the messages I see in the log files: May 14 21:38:40 sfphotodb001 postgres[29658]: [19-1] 2008-05-14 21:38:40 PDTLOG: received SIGHUP, reloading configuration files May

[HACKERS] Can't t compile current HEAD

2008-05-14 Thread Pavel Stehule
Hello I got some errors: In file included from gistget.c:20: ../../../../src/include/pgstat.h:15:36: error: portability/instr_time.h: není souborem ani adresářem In file included from gistget.c:20: ../../../../src/include/pgstat.h:326: error: expected specifier-qualifier-list before 'instr_time'

Re: [HACKERS] missing $PostgreSQL:$

2008-05-14 Thread Andrew Dunstan
Alvaro Herrera wrote: Andrew Dunstan wrote: Here's a very early cut. Tell me what extra intelligence you want and I'll work something up. It certainly looks to me like many of these should have markers. There are probably some other files we should be checking, too. I suggest a

Re: [HACKERS] missing $PostgreSQL:$

2008-05-14 Thread Alvaro Herrera
Andrew Dunstan wrote: > Here's a very early cut. Tell me what extra intelligence you want and > I'll work something up. It certainly looks to me like many of these > should have markers. There are probably some other files we should be > checking, too. I suggest adding -name "*.mk" and excl

Re: [HACKERS] [rfc,patch] PL/Proxy in core

2008-05-14 Thread Josh Berkus
On Wednesday 14 May 2008 13:29, Marko Kreen wrote: > - SGML documentation. > - Makefile review. > - Integrate regression tests into main test framework. Has PL/proxy been tested on other OSes? FreeBSD/Solaris/Windows? -- --Josh Josh Berkus PostgreSQL @ Sun San Francisco -- Sent via pgsql-hac

[HACKERS] Permissions restrictions for function call statistics?

2008-05-14 Thread Tom Lane
The just-committed patch for tracking function call stats allows anyone connected to a given database to see all function-call stats that have been collected within that database. I am wondering whether we need to clamp down on that at all. Knowing the runtime of a function is sometimes considere

Re: [HACKERS] missing $PostgreSQL:$

2008-05-14 Thread Andrew Dunstan
Tom Lane wrote: Bruce Momjian <[EMAIL PROTECTED]> writes: Andrew Dunstan wrote: Do we have a script that goes looking for such files? Do we need one? I don't think we have one but it would be nice to have. Only if it's bright enough to know about files that we inte

Re: [HACKERS] WAL file naming sequence definition

2008-05-14 Thread Simon Riggs
On Wed, 2008-05-14 at 14:25 -0700, Andrew Hammond wrote: > I'd confirmation on how WAL files are named. I'm trying to write a > tool which can tell me when we are missing a WAL file from the > sequence. I initially thought that the file names were monotonically > incrementing hexadecimal numbers. T

Re: [HACKERS] What to do with inline warnings?

2008-05-14 Thread Martijn van Oosterhout
On Wed, May 14, 2008 at 08:25:10PM +0100, Gregory Stark wrote: > The Linux kernel does have some macros meant to mark unlikely branches > (usually assertion failures) but I'm not sure how they work. And Gcc also has > a few optimizations which are driven by profiling data but I it doesn't sound > l

[HACKERS] WAL file naming sequence definition

2008-05-14 Thread Andrew Hammond
I'd confirmation on how WAL files are named. I'm trying to write a tool which can tell me when we are missing a WAL file from the sequence. I initially thought that the file names were monotonically incrementing hexadecimal numbers. This doesn't appear to be the case. 000101B700FD

Re: [HACKERS] bug in localized \df+ output

2008-05-14 Thread Bruce Momjian
Alvaro Herrera wrote: > So, in conclusion, the problem is that the environment is bogus, but I'm > not sure if something needs to be told to psql about that. FYI, psql is computing character lengths based on the client encoding set by psql. -- Bruce Momjian <[EMAIL PROTECTED]>http://m

[HACKERS] [rfc,patch] PL/Proxy in core

2008-05-14 Thread Marko Kreen
Please consider this mail as submission of PL/Proxy into core. Documentation: https://developer.skype.com/SkypeGarage/DbProjects/PlProxy Previous submission with overview: http://archives.postgresql.org/pgsql-hackers/2007-03/msg01763.php - The code has changed rather little compared to fir

Re: [HACKERS] bug in localized \df+ output

2008-05-14 Thread Alvaro Herrera
Alvaro Herrera wrote: > I'm seeing this: > > Liste des fonctions > -[ RECORD 1 > ]+ > Schéma | public > Nom | tg_backlink_a > Type de données du ré

Re: [HACKERS] What to do with inline warnings?

2008-05-14 Thread Tom Lane
Gregory Stark <[EMAIL PROTECTED]> writes: > Fwiw, these two call sites are only for when HeapTupleSatisfiesMVCC finds a > tuples which has been moved away by VACUUM FULL... The latter for when it > finds such a tuple but the VACUUM FULL aborted. > It seems quite likely that the compiler is actuall

Re: [HACKERS] What to do with inline warnings?

2008-05-14 Thread Gregory Stark
"Martijn van Oosterhout" <[EMAIL PROTECTED]> writes: > On Wed, May 14, 2008 at 12:45:49PM -0400, Tom Lane wrote: >> > tqual.c: In function ‘HeapTupleSatisfiesVacuum’: >> > tqual.c:88: error: inlining failed in call to ‘SetHintBits’: call is >> > unlikely and code size would grow >> > tqua

Re: [HACKERS] What to do with inline warnings?

2008-05-14 Thread Gregory Stark
"Martijn van Oosterhout" <[EMAIL PROTECTED]> writes: > On Wed, May 14, 2008 at 12:45:49PM -0400, Tom Lane wrote: >> > tqual.c: In function ‘HeapTupleSatisfiesVacuum’: >> > tqual.c:88: error: inlining failed in call to ‘SetHintBits’: call is >> > unlikely and code size would grow >> > tqua

Re: [HACKERS] missing $PostgreSQL:$

2008-05-14 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Andrew Dunstan wrote: >> Do we have a script that goes looking for such files? Do we need one? > I don't think we have one but it would be nice to have. Only if it's bright enough to know about files that we intentionally don't put $PostgreSQL$ into ...

Re: [HACKERS] missing $PostgreSQL:$

2008-05-14 Thread Bruce Momjian
Andrew Dunstan wrote: > > I have just noticed that pg_standby.c is missing a $PostgreSQL:$ line. > > Do we have a script that goes looking for such files? Do we need one? I don't think we have one but it would be nice to have. -- Bruce Momjian <[EMAIL PROTECTED]>http://momjian.us

[HACKERS] missing $PostgreSQL:$

2008-05-14 Thread Andrew Dunstan
I have just noticed that pg_standby.c is missing a $PostgreSQL:$ line. Do we have a script that goes looking for such files? Do we need one? cheers andrew -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mail

Re: [HACKERS] What to do with inline warnings?

2008-05-14 Thread Martijn van Oosterhout
On Wed, May 14, 2008 at 12:45:49PM -0400, Tom Lane wrote: > > tqual.c: In function ‘HeapTupleSatisfiesVacuum’: > > tqual.c:88: error: inlining failed in call to ‘SetHintBits’: call is > > unlikely and code size would grow > > tqual.c:1057: error: called from here > > tqual.c:88: error: inl

Re: [HACKERS] Re: [COMMITTERS] pgsql: Improve logic for finding object files on OBJS lines in contrib

2008-05-14 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > Peter Eisentraut wrote: >> For the record, I'd be interested in trying out cmake. > Then let's talk about it at the developer's meeting. Is there anything that will be useful to say unless someone's done some experiments to look at?

Re: [HACKERS] Re: [COMMITTERS] pgsql: Improve logic for finding object files on OBJS lines in contrib

2008-05-14 Thread Magnus Hagander
Alvaro Herrera wrote: > Peter Eisentraut wrote: > > Am Freitag, 9. Mai 2008 schrieb Magnus Hagander: > > > Right. The easiest way if you're building something for scratch > > > is to use a system that natively supports msvc, such as cmake. > > > But that means a complete replacement of the build sy

Re: [HACKERS] Placement for a /port sort of include file?

2008-05-14 Thread Alvaro Herrera
Tom Lane wrote: > Since the function-call-statistics patch is going to need the > "instr_time" stuff that's currently in src/include/executor/instrument.h, > I was looking at splitting that out into its own include file. My first > thought about where to put instr_time.h was under src/include/port

[HACKERS] Placement for a /port sort of include file?

2008-05-14 Thread Tom Lane
Since the function-call-statistics patch is going to need the "instr_time" stuff that's currently in src/include/executor/instrument.h, I was looking at splitting that out into its own include file. My first thought about where to put instr_time.h was under src/include/port/, since it's basically

Re: [HACKERS] What to do with inline warnings?

2008-05-14 Thread Tom Lane
Peter Eisentraut <[EMAIL PROTECTED]> writes: > What do we do with warnings generated by -Winline? I believe we just put that in to see how many places inlining was being done or not. If you want to compile with -Werror you'd better take it out. > tqual.c: In function ‘HeapTupleSatisfiesVacuumâ

Re: [HACKERS] Re: [COMMITTERS] pgsql: Improve logic for finding object files on OBJS lines in contrib

2008-05-14 Thread Alvaro Herrera
Peter Eisentraut wrote: > Am Freitag, 9. Mai 2008 schrieb Magnus Hagander: > > Right. The easiest way if you're building something for scratch is to > > use a system that natively supports msvc, such as cmake. But that means > > a complete replacement of the build system, which is certainly > > "so

Re: [HACKERS] how to perform silent installation on linux and solaris

2008-05-14 Thread Peter Eisentraut
Am Mittwoch, 14. Mai 2008 schrieb ranjit singh: > I have been trying to perform silent installation of postgres on linux and > solaris …..please help me with this apt-get|yum install postgresql >/dev/null or thereabouts ... -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To

Re: [HACKERS] [COMMITTERS] pgsql: Improve logic for finding object files on OBJS lines in contrib

2008-05-14 Thread Andrew Dunstan
Peter Eisentraut wrote: Am Freitag, 9. Mai 2008 schrieb Tom Lane: Alvaro Herrera <[EMAIL PROTECTED]> writes: Andrew Dunstan wrote: Log Message: --- Improve logic for finding object files on OBJS lines in contrib Makefiles. If this unbreaks buildfarm mastodon, apply eve

Re: [HACKERS] Re: [COMMITTERS] pgsql: Improve logic for finding object files on OBJS lines in contrib

2008-05-14 Thread Peter Eisentraut
Am Freitag, 9. Mai 2008 schrieb Magnus Hagander: > Right. The easiest way if you're building something for scratch is to > use a system that natively supports msvc, such as cmake. But that means > a complete replacement of the build system, which is certainly > "somewhat invasive".. ;-) For the re

[HACKERS] What to do with inline warnings?

2008-05-14 Thread Peter Eisentraut
What do we do with warnings generated by -Winline? I see this now: gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Winline -Wdeclaration-after-statement -Wendif-labels -fno-strict-aliasing -fwrapv -g -Werror -I../../../../src/include -D_GNU_SOURCE -I/usr/include/libxml2 -c -o tuplesort.o

Re: [HACKERS] [COMMITTERS] pgsql: Improve logic for finding object files on OBJS lines in contrib

2008-05-14 Thread Peter Eisentraut
Am Freitag, 9. Mai 2008 schrieb Tom Lane: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > Andrew Dunstan wrote: > >> Log Message: > >> --- > >> Improve logic for finding object files on OBJS lines in contrib > >> Makefiles. If this unbreaks buildfarm mastodon, apply everywhere. > > > > I s

Re: [HACKERS] psql \? help display

2008-05-14 Thread Bruce Momjian
Patch applied, matching attached output. More suggestions welcomed. --- Bruce Momjian wrote: > Shane Ambler wrote: > > Bruce Momjian wrote: > > > Alvaro Herrera wrote: > > >> Bruce Momjian wrote: > > >>> I promised to revie

[HACKERS] CVS HEAD warnings fixed

2008-05-14 Thread Bruce Momjian
A few warnings have crept into CVS HEAD; the attached patch fixes them. -- Bruce Momjian <[EMAIL PROTECTED]>http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + Index: src/bin/scripts/commo

Re: [HACKERS] Execution Plan Cost

2008-05-14 Thread Luis Vargas
The read-only plan of the query (SELECT $1 > 5) is prepared, so there is not parsing or planning. Any insight into what operations account for the executor startup/shutdown time? Thanks a lot, Luis Vargas On May 8 2008, Tom Lane wrote: Luis Vargas <[EMAIL PROTECTED]> writes: At the backe

Re: [HACKERS] [PATCHES] stored procedure stats in collector

2008-05-14 Thread Tom Lane
[ redirecting to pghackers for wider discussion ] Martin Pihlak <[EMAIL PROTECTED]> writes: >> What I think we should do about that is forget tracking getrusage()'s >> user/system/real time and just track elapsed time. > I find the utime/stime quite useful, compared with the actual time it > enab

Re: [HACKERS] Syntax decisions for pl/pgsql RAISE extension

2008-05-14 Thread Tom Lane
"Zeugswetter Andreas OSB sIT" <[EMAIL PROTECTED]> writes: > Other db's go with SQLCODE and SQLSTATE. > Would SQLCODE be better than ERRCODE ? No, because SQLCODE has a specific meaning, and it's *not* either a condition name or a SQLSTATE --- it's the old SQL89-era error code numbering. I think

[HACKERS] how to perform silent installation on linux and solaris

2008-05-14 Thread ranjit singh
Hi All I have been trying to perform silent installation of postgres on linux and solaris …..please help me with this Thanks and Regards Ranjeet Singh

Re: [HACKERS] Syntax decisions for pl/pgsql RAISE extension

2008-05-14 Thread Zeugswetter Andreas OSB sIT
> So right now I'm thinking I like my original proposal > http://archives.postgresql.org/pgsql-hackers/2008-05/msg00357.php > with the exception that we should go with > SQLSTATE 'xyzzy' > as the syntax in EXCEPTION lists. Also I'm willing to go with > ERRCODE rather than CODE as the name o