Re: [HACKERS] foreign_data test fails with non-C locale

2009-02-01 Thread Zdenek Kotala
Andrew Dunstan píše v so 31. 01. 2009 v 17:08 -0500: > > Zdenek Kotala wrote: > >> PL-check gives the diff below on PLTCL tests under en_US locale. I guess > >> the simplest answer is to add an alternative result file. > >> > > > > Yes, I thought about add locale suffix for alternative resu

[HACKERS] new buildfarm client code feature release

2009-02-01 Thread Andrew Dunstan
There is a new release of the buildfarm client code. It can be downloaded from http://pgfoundry.org/frs/download.php/2069/build-farm-3_2.tgz Features: . Add --find-typedefs option . Add checking in different locales . Add port for release 8.4, bug fixes: . remove XP_EXIT_FIX hack that neve

Re: [HACKERS] add_path optimization

2009-02-01 Thread Robert Haas
On Sun, Feb 1, 2009 at 3:25 PM, Grzegorz Jaskiewicz wrote: > I don't like the fact that you hardcoded that here. I know that you are > trying to pass on few calls in one go here, but still... ugly. Well, I think you'll find that using a dynamically sized data structure destroys the possibility o

Re: [HACKERS] add_path optimization

2009-02-01 Thread Grzegorz Jaskiewicz
disclaimer: I don't know that bit of postgresql code, in fact - this is the first time I see it. *** a/src/backend/optimizer/path/joinpath.c --- b/src/backend/optimizer/path/joinpath.c *** *** 473,478 match_unsorted_outer(PlannerInfo *root, --- 473,481 if

Re: [HACKERS] adding stuff to parser, question

2009-02-01 Thread Joshua Tolley
On Sun, Feb 01, 2009 at 12:12:47AM +, Grzegorz Jaskiewicz wrote: > On 1 Feb 2009, at 00:05, Joshua Tolley wrote: >> to add new syntax, you might consider writing a function instead. This >> function might take parameters such as the privilege to grant and the >> user to >> grant it to, and be

Re: [HACKERS] add_path optimization

2009-02-01 Thread Robert Haas
On Sun, Feb 1, 2009 at 1:34 PM, Jaime Casanova wrote: > On Sat, Jan 31, 2009 at 11:37 PM, Robert Haas wrote: >> I've been doing some benchmarking and profiling on the PostgreSQL >> query analyzer, and it seems that (at least for the sorts of queries >> that I typically run) the dominant cost is a

Re: [HACKERS] add_path optimization

2009-02-01 Thread Jaime Casanova
On Sat, Jan 31, 2009 at 11:37 PM, Robert Haas wrote: > I've been doing some benchmarking and profiling on the PostgreSQL > query analyzer, and it seems that (at least for the sorts of queries > that I typically run) the dominant cost is add_path(). I've been able > to find two optimizations that

Re: [HACKERS] add_path optimization

2009-02-01 Thread Robert Haas
On Sun, Feb 1, 2009 at 12:03 PM, David Fetter wrote: > On Sat, Jan 31, 2009 at 11:37:39PM -0500, Robert Haas wrote: >> I've been doing some benchmarking and profiling on the PostgreSQL >> query analyzer, and it seems that (at least for the sorts of queries >> that I typically run) the dominant cos

Re: [HACKERS] add_path optimization

2009-02-01 Thread David Fetter
On Sat, Jan 31, 2009 at 11:37:39PM -0500, Robert Haas wrote: > I've been doing some benchmarking and profiling on the PostgreSQL > query analyzer, and it seems that (at least for the sorts of queries > that I typically run) the dominant cost is add_path(). I've been > able to find two optimization

Re: [HACKERS] Updated backslash consistency patch

2009-02-01 Thread Grzegorz Jaskiewicz
On 1 Feb 2009, at 14:21, Stephen Frost wrote: So if you have alot of roles granted, and even a couple attributes, it gets ugly.. true. I thought perhaps you guys want to go for table chart USER\t PERM1\t PERM2\t PERM3 foo\to\tx\tx\o bar\tx\to\to\x Personaly that would work for me,

Re: [HACKERS] Updated backslash consistency patch

2009-02-01 Thread Stephen Frost
* David Fetter (da...@fetter.org) wrote: > On Sun, Feb 01, 2009 at 04:54:08AM +, Grzegorz Jaskiewicz wrote: > > On 23 Jan 2009, at 00:03, Tom Lane wrote: > >> Stephen Frost writes: > >>> Seeing this list reminded me of a pet-peeve.. \du and \dg > >>> actually show the same info, that's fine,

Re: [HACKERS] adding stuff to parser, question

2009-02-01 Thread Martijn van Oosterhout
On Sun, Feb 01, 2009 at 10:25:29AM +, Gregory Stark wrote: > > removing it from keywords.c and adding it to unserserved_keywords crowd > > didn't > > make it... so I'll stick with keywords.c for timebeing. > > I'm sorry if I was unclear. It needs to be in keywords.c but can probably be > mar

Re: [HACKERS] How to get SE-PostgreSQL acceptable

2009-02-01 Thread Stephen Frost
* KaiGai Kohei (kai...@kaigai.gr.jp) wrote: > Don't say patch too large. :D Those are include files that are changing.. People do understand that adding a column to a catalog can introduce alot of changed lines. Stephen signature.asc Description: Digital signature

Re: [HACKERS] Hot standby, recovery infra

2009-02-01 Thread Simon Riggs
On Sat, 2009-01-31 at 22:41 +0200, Heikki Linnakangas wrote: > > I like this way because it means we might in the future get Startup > > process to perform post-recovery actions also. > > Yeah, it does. Do you have something in mind already? Yes, but nothing that needs to be discussed yet. --

Re: [HACKERS] Updated backslash consistency patch

2009-02-01 Thread Grzegorz Jaskiewicz
On 1 Feb 2009, at 11:07, Grzegorz Jaskiewicz wrote: On 1 Feb 2009, at 10:58, David Fetter wrote: I think Stephen meant that they should add a column to the output. Stephen? it's already there. oh sorry, column - as in psql printout's column yeah, doable too - lemme see if I can do it

Re: [HACKERS] How to get SE-PostgreSQL acceptable

2009-02-01 Thread KaiGai Kohei
KaiGai Kohei wrote: Andrew Dunstan wrote: KaiGai Kohei wrote: One melancholic thing is adding a member into pg_proc. It defines more than 2000 of entries which I have to modify correctly. :( Is there any script to help it? Last time I added a column to a large catalog, I used a perl sc

Re: [HACKERS] Updated backslash consistency patch

2009-02-01 Thread Grzegorz Jaskiewicz
On 1 Feb 2009, at 10:58, David Fetter wrote: I think Stephen meant that they should add a column to the output. Stephen? it's already there. try: psql -E \du ;] -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql

Re: [HACKERS] adding stuff to parser, question

2009-02-01 Thread Gregory Stark
Grzegorz Jaskiewicz writes: > On 31 Jan 2009, at 17:17, Gregory Stark wrote: >> >> I don't see any reason offhand why it should have to be a reserved word >> though. You should be able to make it an UNRESERVED_KEYWORD. Oh, and you'll >> want to add it to the list of tokens in unreserved_keyword

Re: [HACKERS] Updated backslash consistency patch

2009-02-01 Thread David Fetter
On Sun, Feb 01, 2009 at 04:54:08AM +, Grzegorz Jaskiewicz wrote: > > On 23 Jan 2009, at 00:03, Tom Lane wrote: > >> Stephen Frost writes: >>> Seeing this list reminded me of a pet-peeve.. \du and \dg >>> actually show the same info, that's fine, but neither of them show >>> the rolcanlogin va

Re: [HACKERS] adding stuff to parser, question

2009-02-01 Thread Grzegorz Jaskiewicz
On 1 Feb 2009, at 10:25, Gregory Stark wrote: I'm sorry if I was unclear. It needs to be in keywords.c but can probably be marked as UNRESERVED_KEYWORD there rather than RESERVED_KEYWORD. In other words there are two places where you have to indicate whether it's reserved or not, keyword

Re: [HACKERS] Hot standby, recovery infra

2009-02-01 Thread Simon Riggs
On Sat, 2009-01-31 at 22:32 +0200, Heikki Linnakangas wrote: > If you poison your WAL archive with a XLOG_CRASH_RECOVERY record, > recovery will never be able to proceed over that point. There would have > to be a switch to ignore those records, at the very least. Definitely in assert mode onl