Re: [HACKERS] Partitioning option for COPY

2009-11-24 Thread Simon Riggs
On Tue, 2009-11-24 at 17:30 +0900, Itagaki Takahiro wrote: > Hannu Krosing wrote: > > > Even though this patch will not get in, most of the effort in developing > > it is not actual coding, but familiarizing yourself with the other code > > involved. > > I just edited a wiki page for this discu

Re: [HACKERS] [PATCH 4/4] Add tests to dblink covering use of COPY TO FUNCTION

2009-11-24 Thread Pavel Stehule
Hello I thing, so this patch is maybe good idea. I am missing better function specification. Specification by name isn't enough - we can have a overloaded functions. This syntax doesn't allow to use explicit cast - from my personal view, the syntax is ugly - with type specification we don't need t

Re: [HACKERS] [GENERAL] Updating column on row update

2009-11-24 Thread Thom Brown
2009/11/24 Hannu Krosing > On Sun, 2009-11-22 at 18:51 -0500, Tom Lane wrote: > > Craig Ringer writes: > > > I do think this comes up often enough that a built-in trigger "update > > > named column with result of expression on insert" trigger might be > > > desirable. > > > > There's something o

Re: [HACKERS] [PATCH 4/4] Add tests to dblink covering use of COPY TO FUNCTION

2009-11-24 Thread Daniel Farina
On Tue, Nov 24, 2009 at 12:38 AM, Hannu Krosing wrote: > COPY func(rowtype) FROM stdin; I didn't consider rowtype...I did consider a type list, such as: COPY func(typea, typeb, typec) FROM ... Which would then operate just like a table, but be useless for the data-cleaning case, and would not a

Re: [HACKERS] [PATCH 4/4] Add tests to dblink covering use of COPY TO FUNCTION

2009-11-24 Thread Daniel Farina
On Tue, Nov 24, 2009 at 12:29 AM, Hannu Krosing wrote: > COPY stdin TO udf(); If stdin becomes (is?) a legitimate source of records, then this patch will Just Work. The patch is already quite useful in the COPY (SELECT ...) TO FUNCTION ... scenario. > COPY udf() FROM stdin; This is unaddressed

Re: [HACKERS] [GENERAL] Updating column on row update

2009-11-24 Thread Hannu Krosing
On Sun, 2009-11-22 at 18:51 -0500, Tom Lane wrote: > Craig Ringer writes: > > I do think this comes up often enough that a built-in trigger "update > > named column with result of expression on insert" trigger might be > > desirable. > > There's something of the sort in contrib already, I believe

Re: [HACKERS] [PATCH 4/4] Add tests to dblink covering use of COPY TO FUNCTION

2009-11-24 Thread Hannu Krosing
On Mon, 2009-11-23 at 16:25 -0800, Daniel Farina wrote: > On Mon, Nov 23, 2009 at 4:20 PM, Tom Lane wrote: > > pgsql-hackers had some preliminary discussions a couple months back > > on refactoring COPY to allow things like this --- see the thread > > starting here: > > http://archives.postgresql.

Re: [HACKERS] Partitioning option for COPY

2009-11-24 Thread Itagaki Takahiro
Hannu Krosing wrote: > Even though this patch will not get in, most of the effort in developing > it is not actual coding, but familiarizing yourself with the other code > involved. I just edited a wiki page for this discussion. I hope it can be a help. http://wiki.postgresql.org/wiki/Table_pa

Re: [HACKERS] [PATCH 4/4] Add tests to dblink covering use of COPY TO FUNCTION

2009-11-24 Thread Hannu Krosing
On Mon, 2009-11-23 at 18:31 -0500, Greg Smith wrote: > Robert Haas wrote: > > I'm fuzzy on what problem this is attempting to solve... as mentioned > > in the above guidelines, it's usually good to start with some design > > discussions before writing/submitting code. > This has been through some

Re: [HACKERS] Partitioning option for COPY

2009-11-24 Thread Hannu Krosing
On Mon, 2009-11-23 at 10:24 -0500, Emmanuel Cecchet wrote: > But it looks like it is a waste of everybody's time to continue this > discussion further. Just move the patch to the rejected patches and > let's wait for Itagaki's implementation. Emmanuel, please try to work together with Itagaki s

<    1   2