Re: [HACKERS] max_standby_delay considered harmful

2010-05-09 Thread Simon Riggs
On Sat, 2010-05-08 at 14:48 -0400, Bruce Momjian wrote: I think the consensus is to change this setting to a boolean. If you don't want to do it, I am sure we can find someone who will. You expect others to act on consensus and follow rules, yet ignore them yourself when it suits your

[HACKERS] 9.0b1: ERROR: btree index keys must be ordered by attribute

2010-05-09 Thread Ian Barwick
Hi I've just compiled the 9.0 beta1 source tarball and am testing my custom application against it (which has been running on PostgreSQL since 7.3 or so). The below statement results in the following error message: ERROR: btree index keys must be ordered by attribute evidently in relation

Re: [HACKERS] max_standby_delay considered harmful

2010-05-09 Thread Kevin Grittner
Bruce Momjian wrote: I think everyone agrees the current code is unusable, per Heikki's comment about a WAL file arriving after a period of no WAL activity I don't. I am curious to hear how many complaints we've had from alpha and beta testers of HS regarding this issue. I know that if

Re: [HACKERS] max_standby_delay considered harmful

2010-05-09 Thread Dimitri Fontaine
Tom Lane t...@sss.pgh.pa.us writes: I like the proposal of a boolean because it provides only the minimal feature set of two cases that are both clearly needed and easily implementable. Whatever we do later is certain to provide a superset of those two cases. If we do something else (and

Re: [HACKERS] max_standby_delay considered harmful

2010-05-09 Thread Florian Pflug
On May 9, 2010, at 13:59 , Dimitri Fontaine wrote: Tom Lane t...@sss.pgh.pa.us writes: I like the proposal of a boolean because it provides only the minimal feature set of two cases that are both clearly needed and easily implementable. Whatever we do later is certain to provide a superset

Re: [HACKERS] 9.0b1: ERROR: btree index keys must be ordered by attribute

2010-05-09 Thread David Fetter
On Sun, May 09, 2010 at 05:48:27PM +0900, Ian Barwick wrote: Hi I've just compiled the 9.0 beta1 source tarball and am testing my custom application against it (which has been running on PostgreSQL since 7.3 or so). The below statement results in the following error message: ERROR:

Re: [HACKERS] 9.0b1: ERROR: btree index keys must be ordered by attribute

2010-05-09 Thread Ian Barwick
2010/5/9 David Fetter da...@fetter.org: On Sun, May 09, 2010 at 05:48:27PM +0900, Ian Barwick wrote: Hi I've just compiled the 9.0 beta1 source tarball and am testing my custom application against it (which has been running on PostgreSQL since 7.3 or so). The below statement results in the

Re: [HACKERS] 9.0b1: ERROR: btree index keys must be ordered by attribute

2010-05-09 Thread Tom Lane
Ian Barwick barw...@gmail.com writes: 2010/5/9 David Fetter da...@fetter.org: A self-contained way to reproduce this, ideally small, would be fantastic :) s/fantastic/absolutely required to do anything with this report/ I will see if I can knock together a reproducible test case, might take

Re: [HACKERS] max_standby_delay considered harmful

2010-05-09 Thread Greg Stark
On Sun, May 9, 2010 at 4:00 AM, Greg Smith g...@2ndquadrant.com wrote:  The use cases are covered as best they can be without better support from expected future SR features like heartbeats and XID loopback. For what it's worth I think deferring these extra complications is a very useful

Re: [HACKERS] max_standby_delay considered harmful

2010-05-09 Thread Robert Haas
On Sun, May 9, 2010 at 12:47 PM, Greg Stark gsst...@mit.edu wrote: On Sun, May 9, 2010 at 4:00 AM, Greg Smith g...@2ndquadrant.com wrote:  The use cases are covered as best they can be without better support from expected future SR features like heartbeats and XID loopback. For what it's

Re: pg_start_backup and pg_stop_backup Re: [HACKERS] Re: [COMMITTERS] pgsql: Make CheckRequiredParameterValues() depend upon correct

2010-05-09 Thread Simon Riggs
On Sat, 2010-05-08 at 23:55 -0400, Robert Haas wrote: On Sat, May 8, 2010 at 10:40 PM, Tom Lane t...@sss.pgh.pa.us wrote: Bruce Momjian br...@momjian.us writes: Uh, did we decide that 'wal_keep_segments' was the best name for this GUC setting? I know we shipped beta1 using that name. I

Re: [HACKERS] max_standby_delay considered harmful

2010-05-09 Thread Simon Riggs
On Sat, 2010-05-08 at 20:57 -0400, Tom Lane wrote: Andres Freund and...@anarazel.de writes: On Sunday 09 May 2010 01:34:18 Bruce Momjian wrote: I think everyone agrees the current code is unusable, per Heikki's comment about a WAL file arriving after a period of no WAL activity, and look

Re: [HACKERS] max_standby_delay considered harmful

2010-05-09 Thread Simon Riggs
On Sun, 2010-05-09 at 16:10 +0200, Florian Pflug wrote: Adding pause/resume seems to introduce some non-trivial locking problems, though. How would you handle a pause request if the recovery process currently held a lock? (We are only talking about AccessExclusiveLocks here. No LWlocks are

Re: [HACKERS] max_standby_delay considered harmful

2010-05-09 Thread Dimitri Fontaine
Florian Pflug f...@phlo.org writes: The only remaining option is to continue applying WAL until you reach a point where no locks are held, then pause. But from a user's POV that is nearly indistinguishable from simply setting hot_standby_conflict_winner to in the first place I think. Not

Re: [HACKERS] max_standby_delay considered harmful

2010-05-09 Thread Florian Pflug
On May 9, 2010, at 21:04 , Simon Riggs wrote: On Sun, 2010-05-09 at 16:10 +0200, Florian Pflug wrote: Adding pause/resume seems to introduce some non-trivial locking problems, though. How would you handle a pause request if the recovery process currently held a lock? (We are only talking

Re: [HACKERS] max_standby_delay considered harmful

2010-05-09 Thread Robert Haas
On Sun, May 9, 2010 at 3:09 PM, Dimitri Fontaine dfonta...@hi-media.com wrote: Florian Pflug f...@phlo.org writes: The only remaining option is to continue applying WAL until you reach a point where no locks are held, then pause. But from a user's POV that is nearly indistinguishable from

Re: [HACKERS] max_standby_delay considered harmful

2010-05-09 Thread Simon Riggs
On Sun, 2010-05-09 at 16:01 -0400, Robert Haas wrote: The fact that Hot Standby has to take exclusive locks that can't be released until WAL replay has progressed to a certain point seems like a fairly serious wart. LOL And people lecture me about design. -- Simon Riggs

[HACKERS] List traffic

2010-05-09 Thread Simon Riggs
Traffic on the PostgreSQL lists is very high now and I freely admit that reading every email is simply not possible for me, even the ones that mention topics that keyword searches tell me are of potential interest. If anybody knows of a bug or suspected bug in my code, I have no problem in being

Re: [HACKERS] max_standby_delay considered harmful

2010-05-09 Thread Florian Pflug
On May 9, 2010, at 22:01 , Robert Haas wrote: On Sun, May 9, 2010 at 3:09 PM, Dimitri Fontaine dfonta...@hi-media.com wrote: Florian Pflug f...@phlo.org writes: The only remaining option is to continue applying WAL until you reach a point where no locks are held, then pause. But from a

Re: [HACKERS] max_standby_delay considered harmful

2010-05-09 Thread Andres Freund
On Monday 10 May 2010 00:25:44 Florian Pflug wrote: On May 9, 2010, at 22:01 , Robert Haas wrote: On Sun, May 9, 2010 at 3:09 PM, Dimitri Fontaine dfonta...@hi-media.com wrote: Florian Pflug f...@phlo.org writes: The only remaining option is to continue applying WAL until you reach a

Re: [HACKERS] 9.0b1: ERROR: btree index keys must be ordered by attribute

2010-05-09 Thread Ian Barwick
Hi 2010/5/10 Tom Lane t...@sss.pgh.pa.us: Ian Barwick barw...@gmail.com writes: 2010/5/9 David Fetter da...@fetter.org: A self-contained way to reproduce this, ideally small, would be fantastic :) s/fantastic/absolutely required to do anything with this report/ Yes, I appreciate that :) I

Re: [HACKERS] 9.0b1: ERROR: btree index keys must be ordered by attribute

2010-05-09 Thread Ian Barwick
2010/5/10 Ian Barwick barw...@gmail.com: SELECT ov.object_id    FROM object_version ov   WHERE ov.object_id = 1     AND ov.version ='0     AND ov.object_status_id = (     SELECT MAX(ov1.object_status_id)       FROM object_version ov1      WHERE ov1.object_id=ov.object_id        AND

Re: [HACKERS] max_standby_delay considered harmful

2010-05-09 Thread Robert Haas
On Sun, May 9, 2010 at 6:58 PM, Andres Freund and...@anarazel.de wrote: On Monday 10 May 2010 00:25:44 Florian Pflug wrote: On May 9, 2010, at 22:01 , Robert Haas wrote: On Sun, May 9, 2010 at 3:09 PM, Dimitri Fontaine dfonta...@hi-media.com wrote: Florian Pflug f...@phlo.org writes: The

Re: [HACKERS] 9.0b1: ERROR: btree index keys must be ordered by attribute

2010-05-09 Thread Tom Lane
Ian Barwick barw...@gmail.com writes: Apologies, slight cp error; correct version of query: SELECT ov.object_id FROM object_version ov WHERE ov.object_id = 1 AND ov.version =0 AND ov.object_status_id = ( SELECT MAX(ov1.object_status_id) FROM object_version ov1