Re: [HACKERS] warning message in standby

2010-06-29 Thread Fujii Masao
On Tue, Jun 15, 2010 at 11:35 AM, Fujii Masao masao.fu...@gmail.com wrote: On the other hand, I like immediate-panicking. And I don't want the standby to retry reconnecting the master infinitely. On second thought, the peremptory PANIC is not good for HA system. If the master unfortunately has

[HACKERS] Look-behind regular expressions

2010-06-29 Thread Thom Brown
Are there any plans to support look-behind and negative look-behind for regular expressions in future? Thanks Thom -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [PATCH] Re: [HACKERS] Adding xpath_exists function

2010-06-29 Thread Mike Fowler
Mike Fowler wrote: Bruce Momjian wrote: I have added this to the next commit-fest: https://commitfest.postgresql.org/action/commitfest_view?id=6 Thanks Bruce. Attached is a revised patch which changes the code slightly such that it uses an older version of the libxml library. I've

Re: [HACKERS] warning message in standby

2010-06-29 Thread Robert Haas
On Tue, Jun 29, 2010 at 3:55 AM, Fujii Masao masao.fu...@gmail.com wrote: On Tue, Jun 15, 2010 at 11:35 AM, Fujii Masao masao.fu...@gmail.com wrote: On the other hand, I like immediate-panicking. And I don't want the standby to retry reconnecting the master infinitely. On second thought, the

Re: [PATCH] Re: [HACKERS] Adding XMLEXISTS to the grammar

2010-06-29 Thread Mike Fowler
Mike Fowler wrote: Thanks again for your help Robert, turns out the fault was in the pg_proc entry (the 3 up there should've been a two!). Once I took the grammar out it was quickly obvious where I'd gone wrong. Attached is a patch with the revised XMLEXISTS function, complete with grammar

Re: [HACKERS] warning message in standby

2010-06-29 Thread Robert Haas
On Tue, Jun 29, 2010 at 6:59 AM, Robert Haas robertmh...@gmail.com wrote: On Tue, Jun 29, 2010 at 3:55 AM, Fujii Masao masao.fu...@gmail.com wrote: On Tue, Jun 15, 2010 at 11:35 AM, Fujii Masao masao.fu...@gmail.com wrote: On the other hand, I like immediate-panicking. And I don't want the

Re: [HACKERS] Keepalives win32

2010-06-29 Thread Robert Haas
On Mon, Jun 28, 2010 at 8:24 PM, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: On Mon, Jun 28, 2010 at 22:39, Tom Lane t...@sss.pgh.pa.us wrote: I had in mind just legislating that the defaults are the RFC values, none of this try to use the registry values in

Re: [HACKERS] warning message in standby

2010-06-29 Thread Kevin Grittner
Robert Haas robertmh...@gmail.com wrote: ...with this patch, following the above, you get: FATAL: invalid record in WAL stream HINT: Take a new base backup, or remove recovery.conf and restart in read-write mode. LOG: startup process (PID 6126) exited with exit code 1 LOG:

Re: [HACKERS] keepalives on MacOS X

2010-06-29 Thread Robert Haas
On Tue, Jun 29, 2010 at 12:42 AM, Tom Lane t...@sss.pgh.pa.us wrote: Yeah, a bit of rooting around in the Darwin sources shows that this value is used as a per-connection override for tcp_keepidle.  So it is a synonym.  Not sure if it's worth supporting when the other value can't be set too.  

Re: [HACKERS] Look-behind regular expressions

2010-06-29 Thread Tom Lane
Thom Brown thombr...@gmail.com writes: Are there any plans to support look-behind and negative look-behind for regular expressions in future? No. Or are you volunteering? regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] warning message in standby

2010-06-29 Thread Robert Haas
On Tue, Jun 29, 2010 at 10:21 AM, Kevin Grittner kevin.gritt...@wicourts.gov wrote: Robert Haas robertmh...@gmail.com wrote: ...with this patch, following the above, you get: FATAL:  invalid record in WAL stream HINT:  Take a new base backup, or remove recovery.conf and restart in

Re: [HACKERS] Look-behind regular expressions

2010-06-29 Thread Thom Brown
On 29 June 2010 15:40, Tom Lane t...@sss.pgh.pa.us wrote: Thom Brown thombr...@gmail.com writes: Are there any plans to support look-behind and negative look-behind for regular expressions in future? No.  Or are you volunteering? A n00b like me volunteer for that? It's more of a

Re: [HACKERS] warning message in standby

2010-06-29 Thread Kevin Grittner
Robert Haas robertmh...@gmail.com wrote: If someone is sloppy about how they copy the WAL files around, they could temporarily have a truncated file. Can you explain the scenario you're concerned about in more detail? If someone uses cp or scp to copy a WAL file from the pg_xlog

Re: [HACKERS] Keepalives win32

2010-06-29 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Mon, Jun 28, 2010 at 8:24 PM, Tom Lane t...@sss.pgh.pa.us wrote: What I was trying to say is I think we could dispense with the setsockopt() code path, and just always use the WSAIoctl() path anytime keepalives are turned on.  I don't know what

Re: [HACKERS] GSoC - code of implementation of materialized views

2010-06-29 Thread Robert Haas
2010/6/25 Pavel Baros baro...@seznam.cz: On http://github.com/pbaros/postgres can be seen changes and my attempt to implement materialized views. The first commit to the repository implements following: Materialized view can be created, dropped and used in SELECT statement. CREATE

Re: [HACKERS] Look-behind regular expressions

2010-06-29 Thread David E. Wheeler
On Jun 29, 2010, at 7:44 AM, Thom Brown wrote: No. Or are you volunteering? A n00b like me volunteer for that? It's more of a suggestion. N00bs gotta start somewhere… Best, David -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] GSoC - code of implementation of materialized views

2010-06-29 Thread Pavel Baroš
Robert Haas napsal(a): 2010/6/25 Pavel Baros baro...@seznam.cz: On http://github.com/pbaros/postgres can be seen changes and my attempt to implement materialized views. The first commit to the repository implements following: Materialized view can be created, dropped and used in SELECT

Re: [HACKERS] GSoC - code of implementation of materialized views

2010-06-29 Thread David Christensen
On Jun 29, 2010, at 3:31 PM, Pavel Baroš wrote: Robert Haas napsal(a): 2010/6/25 Pavel Baros baro...@seznam.cz: On http://github.com/pbaros/postgres can be seen changes and my attempt to implement materialized views. The first commit to the repository implements following:

Re: [HACKERS] Cannot cancel the change of a tablespace

2010-06-29 Thread Guillaume Lelarge
Le 23/06/2010 23:29, Guillaume Lelarge a écrit : Le 23/06/2010 22:54, Tom Lane a écrit : Robert Haas robertmh...@gmail.com writes: On Mon, Jun 21, 2010 at 12:46 PM, Guillaume Lelarge guilla...@lelarge.info wrote: I added a CHECK_FOR_INTERRUPTS call in the copy_relation_data(), copy_dir(),

Re: [HACKERS] Cannot cancel the change of a tablespace

2010-06-29 Thread Tom Lane
Guillaume Lelarge guilla...@lelarge.info writes: Still not sure what to do right now for this patch :) Put it on the commitfest list, if you didn't already. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

[HACKERS] Planner deficiencies with views that use windowing functions

2010-06-29 Thread Daniel Grace
I found some interesting discrepancies with the query planner when working with views (and presumably table subqueries) that contain windowing functions.  This is all tested on 9.0beta2, though I suspect 8.4 has the same limitations. The short version is: - If querying a windowing view and asking

Re: [HACKERS] Planner deficiencies with views that use windowing functions

2010-06-29 Thread Tom Lane
Daniel Grace dgr...@wingsnw.com writes: I found some interesting discrepancies with the query planner when working with views (and presumably table subqueries) that contain windowing functions. Yeah, there's next to no optimization for window functions ATM. This will probably get better over

Re: [HACKERS] Keepalives win32

2010-06-29 Thread Bruce Momjian
Tom Lane wrote: Robert Haas robertmh...@gmail.com writes: On Mon, Jun 28, 2010 at 8:24 PM, Tom Lane t...@sss.pgh.pa.us wrote: What I was trying to say is I think we could dispense with the setsockopt() code path, and just always use the WSAIoctl() path anytime keepalives are turned on. ?I

Re: [HACKERS] Propose Beta3 for July

2010-06-29 Thread Bruce Momjian
Josh Berkus wrote: Folks, There have been quite a number of fixes since Beta2. If we're going to make a summer release date at all, we need to get moving. Therefore, I propose that we set a beta3 release date for July 8th. That should give it enough space from the American Holiday.

Re: [HACKERS] GSoC - code of implementation of materialized views

2010-06-29 Thread Robert Haas
2010/6/29 David Christensen da...@endpoint.com: Do we see supporting the creation of a materialized view from a regular view, as in ALTER VIEW regular_view SET MATERIALIZED or some such? I'm not sure. I think we should focus our efforts on (1) getting it to work at all and then (2) improving

Re: [HACKERS] Cannot cancel the change of a tablespace

2010-06-29 Thread Bruce Momjian
Tom Lane wrote: Guillaume Lelarge guilla...@lelarge.info writes: Still not sure what to do right now for this patch :) Put it on the commitfest list, if you didn't already. So this is not something we want fixed for 9.0, as indicated by Simon? I don't see the patch on the commit-fest page

Re: [HACKERS] warning message in standby

2010-06-29 Thread Fujii Masao
On Tue, Jun 29, 2010 at 7:59 PM, Robert Haas robertmh...@gmail.com wrote: On Tue, Jun 29, 2010 at 3:55 AM, Fujii Masao masao.fu...@gmail.com wrote: On Tue, Jun 15, 2010 at 11:35 AM, Fujii Masao masao.fu...@gmail.com wrote: On the other hand, I like immediate-panicking. And I don't want the

Re: [HACKERS] Proposal for 9.1: WAL streaming from WAL buffers

2010-06-29 Thread Bruce Momjian
Simon Riggs wrote: On Mon, 2010-06-21 at 18:08 +0900, Fujii Masao wrote: The problem is not that the master streams non-fsync'd WAL, but that the standby can replay that. So I'm thinking that we can send non-fsync'd WAL safely if the standby makes the recovery wait until the master has

Re: [HACKERS] Cannot cancel the change of a tablespace

2010-06-29 Thread Robert Haas
On Tue, Jun 29, 2010 at 9:42 PM, Bruce Momjian br...@momjian.us wrote: Tom Lane wrote: Guillaume Lelarge guilla...@lelarge.info writes: Still not sure what to do right now for this patch :) Put it on the commitfest list, if you didn't already. So this is not something we want fixed for

Re: [HACKERS] warning message in standby

2010-06-29 Thread Robert Haas
On Tue, Jun 29, 2010 at 10:03 PM, Fujii Masao masao.fu...@gmail.com wrote: This is true. But what I'm concerned about is: 1. Backend writes and fsyncs the WAL to the disk 2. The WAL on the disk gets corrupted 3. Walsender reads and sends that corrupted WAL image 4. The master crashes because

Re: [HACKERS] Proposal for 9.1: WAL streaming from WAL buffers

2010-06-29 Thread Robert Haas
On Tue, Jun 29, 2010 at 10:06 PM, Bruce Momjian br...@momjian.us wrote: Simon Riggs wrote: On Mon, 2010-06-21 at 18:08 +0900, Fujii Masao wrote: The problem is not that the master streams non-fsync'd WAL, but that the standby can replay that. So I'm thinking that we can send non-fsync'd WAL

Re: [HACKERS] pg_archive_bypass

2010-06-29 Thread Bruce Momjian
Dimitri Fontaine wrote: Hi, I tend to consider it a bug that there's no known way under windows to use the same trick as under Unix by using '/usr/bin/true' as your archive command. And this Unix trick itself does feel like a hack. Also I'd very much like to be able to recommend (even if

Re: [HACKERS] keepalives on MacOS X

2010-06-29 Thread Fujii Masao
On Tue, Jun 29, 2010 at 11:28 PM, Robert Haas robertmh...@gmail.com wrote: On Tue, Jun 29, 2010 at 12:42 AM, Tom Lane t...@sss.pgh.pa.us wrote: Yeah, a bit of rooting around in the Darwin sources shows that this value is used as a per-connection override for tcp_keepidle.  So it is a synonym.  

Re: [HACKERS] Cannot cancel the change of a tablespace

2010-06-29 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Tue, Jun 29, 2010 at 9:42 PM, Bruce Momjian br...@momjian.us wrote: So this is not something we want fixed for 9.0, as indicated by Simon? I don't see the patch on the commit-fest page yet. I tend to think we should fix it for 9.0, but could be

Re: [HACKERS] Cannot cancel the change of a tablespace

2010-06-29 Thread Guillaume Lelarge
Le 30/06/2010 05:25, Tom Lane a écrit : Robert Haas robertmh...@gmail.com writes: On Tue, Jun 29, 2010 at 9:42 PM, Bruce Momjian br...@momjian.us wrote: So this is not something we want fixed for 9.0, as indicated by Simon? I don't see the patch on the commit-fest page yet. I tend to think