Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-10 Thread Andres Freund
On Fri, Jul 09, 2010 at 11:33:04PM -0400, Robert Haas wrote: On Fri, Jul 9, 2010 at 10:25 PM, Boxuan Zhai bxzhai2...@gmail.com wrote: Dear All, This is ZHAI BOXUAN, a student of gSoC 2010. My project is to add merge command in postgres. There is a more detailed instruction in readme. I

Re: [HACKERS] FYI: Ubuntu 10.04 lucid strange segfault

2010-07-10 Thread Yeb Havinga
On Fri, Jul 9, 2010 at 10:18 PM, Robert Haas robertmh...@gmail.com wrote: On Fri, Jul 9, 2010 at 4:10 PM, Yeb Havinga yebhavi...@gmail.com wrote: Joshua D. Drake wrote: On Fri, 2010-07-09 at 16:57 +0200, Yeb Havinga wrote: Hello list, Due to dependency requirements my development

Re: [PATCH] Re: [HACKERS] Issue: Deprecation of the XML2 module 'xml_is_well_formed' function

2010-07-10 Thread Mike Fowler
Robert Haas wrote: On Fri, Jul 9, 2010 at 4:06 PM, Peter Eisentraut pete...@gmx.net wrote: On ons, 2010-07-07 at 16:37 +0100, Mike Fowler wrote: Here's the patch to add the 'xml_is_well_formed' function. I suppose we should remove the function from contrib/xml2 at the same

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-10 Thread David Fetter
On Sat, Jul 10, 2010 at 11:52:31AM +0200, Andres Freund wrote: On Fri, Jul 09, 2010 at 11:33:04PM -0400, Robert Haas wrote: On Fri, Jul 9, 2010 at 10:25 PM, Boxuan Zhai bxzhai2...@gmail.com wrote: Dear All, This is ZHAI BOXUAN, a student of gSoC 2010. My project is to add merge

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-10 Thread Tom Lane
David Fetter da...@fetter.org writes: Please find enclosed a patch against git master as of 7b2668159bb4d0f5177a23d05bf7c2ab00bc0d75. It works up to make, but fails on make check. There seem to be about four different comment styles used in this patch, none of which match the project

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-10 Thread Robert Haas
On Jul 10, 2010, at 11:45 AM, Tom Lane t...@sss.pgh.pa.us wrote: David Fetter da...@fetter.org writes: Please find enclosed a patch against git master as of 7b2668159bb4d0f5177a23d05bf7c2ab00bc0d75. It works up to make, but fails on make check. There seem to be about four different comment

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-10 Thread David Fetter
On Sat, Jul 10, 2010 at 09:26:38AM -0700, David Fetter wrote: On Sat, Jul 10, 2010 at 11:52:31AM +0200, Andres Freund wrote: On Fri, Jul 09, 2010 at 11:33:04PM -0400, Robert Haas wrote: On Fri, Jul 9, 2010 at 10:25 PM, Boxuan Zhai bxzhai2...@gmail.com wrote: Dear All, This is

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-10 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: Though, if the worst problem with this patch is the formatting, we're doing *quite* well. Well, the worst problem with it is that it hasn't touched the interesting part, ie, what happens at execution time. I haven't seen a design for that, which means

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-10 Thread David Fetter
On Sat, Jul 10, 2010 at 01:18:49PM -0400, Tom Lane wrote: Robert Haas robertmh...@gmail.com writes: Though, if the worst problem with this patch is the formatting, we're doing *quite* well. Well, the worst problem with it is that it hasn't touched the interesting part, ie, what happens

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-10 Thread David Fetter
On Sat, Jul 10, 2010 at 10:39:02AM -0700, David Fetter wrote: On Sat, Jul 10, 2010 at 01:18:49PM -0400, Tom Lane wrote: Robert Haas robertmh...@gmail.com writes: Though, if the worst problem with this patch is the formatting, we're doing *quite* well. Well, the worst problem with it

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-10 Thread Tom Lane
David Fetter da...@fetter.org writes: By the way, make check fails here with attached initdb.log: creating system views ... FATAL: unrecognized token: false Hm, I'd suspect something fouled up in keyword recognition. Did you do a make clean and rebuild? BTW, this patch is still a few bricks

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-10 Thread Peter Eisentraut
On lör, 2010-07-10 at 09:26 -0700, David Fetter wrote: Please find enclosed a patch against git master as of 7b2668159bb4d0f5177a23d05bf7c2ab00bc0d75. It works up to make, but fails on make check. It looks like this implementation reaches about the same level of parser support as the stuff

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-10 Thread David Fetter
On Sat, Jul 10, 2010 at 01:53:53PM -0400, Tom Lane wrote: David Fetter da...@fetter.org writes: By the way, make check fails here with attached initdb.log: creating system views ... FATAL: unrecognized token: false Hm, I'd suspect something fouled up in keyword recognition. Did you do

Re: [HACKERS] ALTER TABLE SET STATISTICS requires AccessExclusiveLock

2010-07-10 Thread Bruce Momjian
Robert Haas wrote: On Wed, Jul 7, 2010 at 9:04 PM, C?dric Villemain cedric.villemain.deb...@gmail.com wrote: I assume this did not get done for 9.0. ?Do we want a TODO item? Yes. Added: ? ? ? ?Reduce locking required for ALTER commands I just faced production issue where it is

[HACKERS] Re: [COMMITTERS] pgsql: Add support for TCP keepalives on Windows, both for backend and

2010-07-10 Thread Bruce Momjian
Magnus Hagander wrote: An easy approximation would be to make the code #ifdef SIO_KEEPALIVE_VALS. That would fail if the mingw guys decide to provide the #define without adding the struct at the same time, but that seems moderately unlikely. Seems reasonable. I'll go do something along

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-10 Thread Tom Lane
David Fetter da...@fetter.org writes: On Sat, Jul 10, 2010 at 01:53:53PM -0400, Tom Lane wrote: BTW, this patch is still a few bricks shy of a load, since there's no kwlist.h change and so the new MERGE keyword couldn't possibly be recognized. More generally, I'm wondering why the original

Re: [HACKERS] Re: [COMMITTERS] pgsql: Add support for TCP keepalives on Windows, both for backend and

2010-07-10 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: Magnus Hagander wrote: That laves the questions of docs - right now the docs just say it works on windows. I guess we need to add some kind of disclaimer around that, but the fact is that for 99+% of our windows users it will work - since they use the

Re: [HACKERS] Re: [COMMITTERS] pgsql: Add support for TCP keepalives on Windows, both for backend and

2010-07-10 Thread Peter Eisentraut
On lör, 2010-07-10 at 16:23 -0400, Bruce Momjian wrote: Wow, how would they know if the binaries are MinGW compiled? Does it show in version()? Yes, I think so. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-10 Thread Andrew Dunstan
Tom Lane wrote: BTW, I notice that that page fails to mention anything about preferred window width. I believe the project standard is to make things readable in an 80-column window --- anyone have an objection to stating that explicitly? No, on the contrary, I'm in favor of stating

Re: [HACKERS] LLVM / clang

2010-07-10 Thread Peter Eisentraut
On fre, 2010-06-11 at 07:00 +0300, Peter Eisentraut wrote: The second problem is that the prototype check for accept() fails. This is because glibc defines the second argument to be a transparent union, apparently to make it look like a lot of things at once. clang apparently doesn't

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-10 Thread Peter Eisentraut
On lör, 2010-07-10 at 12:45 -0400, Tom Lane wrote: I believe the project standard is to make things readable in an 80-column window --- anyone have an objection to stating that explicitly? Is that what pgindent reformats it to? -- Sent via pgsql-hackers mailing list

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-10 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: On lör, 2010-07-10 at 12:45 -0400, Tom Lane wrote: I believe the project standard is to make things readable in an 80-column window --- anyone have an objection to stating that explicitly? Is that what pgindent reformats it to? pgindent tries to

Re: [HACKERS] patch (for 9.1) string functions

2010-07-10 Thread Erik Rijkers
contrib/stringfunc was missing this small change in contrib/Makefile, I think. With it, it installs and runs make check cleanly. Erik Rijkers stringfunc_fix.diff Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your