Re: [HACKERS] [GENERAL] 3rd time is a charm.....right sibling is not next child crash.

2010-08-28 Thread Tom Lane
I wrote: > it did occur to me that there is a simple way to ameliorate this > problem: we could rearrange the code in _bt_pagedel() so it checks for > this case before entering its critical section. Then, corruption of > this kind is at least only an ERROR not a PANIC. In particular, I propose th

Re: Interruptible sleeps (was Re: [HACKERS] CommitFest 2009-07: Yay, Kevin! Thanks, reviewers!)

2010-08-28 Thread Greg Smith
Tom Lane wrote: Greg Smith writes: ... The only clear case where this is always a win is when the system it totally idle. If you'll climb down off that horse for a moment: yeah, the idle case is *exactly* what they're complaining about. I wasn't on a horse here--I saw the specific c

Re: [HACKERS] multibyte charater set in levenshtein function

2010-08-28 Thread Alexander Korotkov
SELECT SUM(levenshtein(a, 'foo')) from words; SELECT SUM(levenshtein(a, 'Urbański')) FROM words; SELECT SUM(levenshtein(a, 'ańs')) FROM words; SELECT SUM(levenshtein(a, 'foo')) from words2; SELECT SUM(levenshtein(a, 'дом')) FROM words2; SELECT SUM(levenshtein(a, 'компьютер')) FROM words2; Before t

Re: [HACKERS] multibyte charater set in levenshtein function

2010-08-28 Thread Alexander Korotkov
Here is the patch which adds levenshtein_less_equal function. I'm going to add it to current commitfest. With best regards, Alexander Korotkov. On Tue, Aug 3, 2010 at 3:23 AM, Robert Haas wrote: > On Mon, Aug 2, 2010 at 5:07 PM, Alexander Korotkov > wrote: > > Now I think patch is as goo

Re: [HACKERS] [GENERAL] 3rd time is a charm.....right sibling is not next child crash.

2010-08-28 Thread Tom Lane
Alvaro Herrera writes: > Excerpts from Jeff Amiel's message of mar jun 08 09:26:25 -0400 2010: >> Jun 7 15:05:01 db-1 postgres[9334]: [ID 748848 local0.crit] [3989781-1] >> 2010-06-07 15:05:01.087 CDT9334PANIC: right sibling 169 of block 168 is >> not next child of 249 in index "sl_seqlog_

Re: [HACKERS] [JDBC] Trouble with COPY IN

2010-08-28 Thread James William Pye
On Aug 9, 2010, at 11:49 AM, Kris Jurka wrote: > Oh, duh. It's a server side copy not going through the client at all. Here's > a hopefully final patch. Trying it out... Works for me. I understand the resistance to the patch, but it would be quite nice to see this wart in the rear view. =\ --

Re: [HACKERS] multibyte charater set in levenshtein function

2010-08-28 Thread Robert Haas
On Aug 28, 2010, at 8:34 AM, Alexander Korotkov wrote: > Here is the patch which adds levenshtein_less_equal function. I'm going to > add it to current commitfest. Cool. Please submit some performance results comparing levenshtein in HEAD vs. levenshtein with this patch vs. levenshtein_less_equ

Re: [HACKERS] Git conversion progress report and call for testing assistance

2010-08-28 Thread Tom Lane
Magnus Hagander writes: > Should we consider actually removing the Log Message header and just > put the message right at the start? If there's no link first, that > would be fairly obvious, I think.. Either way (header or not) is OK by me. regards, tom lane -- Sent via

Re: [HACKERS] Git conversion progress report and call for testing assistance

2010-08-28 Thread Magnus Hagander
On Fri, Aug 27, 2010 at 22:02, Tom Lane wrote: > Magnus Hagander writes: >> On Fri, Aug 27, 2010 at 21:30, Tom Lane wrote: >>> OK, the list works now, but the commitdiff links in the messages do >>> not.  Looks like they are pointing at the wrong repository. > >> Well, actually, they point to th

Re: [HACKERS] refactoring comment.c

2010-08-28 Thread Martijn van Oosterhout
On Fri, Aug 27, 2010 at 09:35:55PM -0400, Tom Lane wrote: > Alvaro Herrera writes: > > Didn't we inject some smarts so that the compiler would notice that > > elog(ERROR) doesn't return? > > No. If you know a portable (as in "works on every compiler") way > to do that, we could talk. If only so

Re: [HACKERS] git: uh-oh

2010-08-28 Thread tomas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Wed, Aug 25, 2010 at 12:35:53PM -0400, Robert Haas wrote: > On Wed, Aug 25, 2010 at 12:02 PM, Michael Haggerty > wrote: [...] > > I must say, it is refreshing to have users who actually care about their > > conversion, as opposed to the usual ra