Re: [HACKERS] SSI bug?

2011-04-02 Thread Dan Ports
I think I see what is going on now. We are sometimes failing to set the commitSeqNo correctly on the lock. In particular, if a lock assigned to OldCommittedSxact is marked with InvalidSerCommitNo, it will never be cleared. The attached patch corrects this: TransferPredicateLocksToNewTarget should

Re: [HACKERS] Re: [COMMITTERS] pgsql: Support comments on FOREIGN DATA WRAPPER and SERVER objects.

2011-04-02 Thread Shigeru Hanada
2011/4/2 Robert Haas : > On Fri, Apr 1, 2011 at 11:57 AM, Thom Brown wrote: >> Should we also have support for comments on user mappings? > > Oh, bugger.  Yeah, probably. I'd work on this, if taking some days is OK. Regards, -- Shigeru Hanada -- Sent via pgsql-hackers mailing list (pgsql-hack

Re: [HACKERS] Process local hint bit cache

2011-04-02 Thread Tom Lane
Merlin Moncure writes: > On Thu, Mar 31, 2011 at 5:38 PM, Merlin Moncure wrote: >> working on exanding the cache to # xid > 1. > patch attached. this is essentially my original idea except it's > injected directly in to tqual.c as a kind of a expansion of the 'last > seen' concept. Because the

Re: [HACKERS] wal_buffers = -1 and SIGHUP

2011-04-02 Thread Tom Lane
Robert Haas writes: > On Thu, Mar 31, 2011 at 8:38 AM, Bernd Helmle wrote: >> This might be nitpicking (or i'm currently missing something), but i >> recognized that setting wal_buffers = -1 always triggers the following on >> reload, even if nothing to wal_buffers had changed: >> >> $ pg_ctl re

Re: [HACKERS] psql 9.1 alpha5: connection pointer is NULL

2011-04-02 Thread Tom Lane
Joseph Adams writes: > I couldn't reproduce this (using upstream source on Ubuntu). However, > I did find a little bug in libpq causing the connection handle to > become NULL in the event of an option parsing error. This bug has > been around since release 9.0.0, and may be unrelated to the prob

Re: [HACKERS] Bug in autovacuum.c?

2011-04-02 Thread Tom Lane
Robert Haas writes: > On Fri, Apr 1, 2011 at 5:48 PM, Bruce Momjian wrote: >> Agreed it is not worth it but I think we should at least C comment >> something.   I think at a minimum we should set it to >> FirstNormalTransactionId. > I think you should leave it well enough alone. Yes. The point

Re: [HACKERS] Another swing at JSON

2011-04-02 Thread Dimitri Fontaine
Tom Lane writes: > So, I'm interested in trying to improve this, but it looks like a > research project from here. True: I don't have a baked solution that we would just need to apply. The simplest idea I can think of is forcing make install before to build contribs so that PGXS works “normally”

Re: [HACKERS] Another swing at JSON

2011-04-02 Thread Dimitri Fontaine
Tom Lane writes: > Dimitri Fontaine writes: >> This and removing module_pathname in the control files to just use >> $libdir/contrib in the .sql files. That would set a better example to >> people who want to make their own extensions, as the general case is >> that those will not get into contr

Re: [HACKERS] Process local hint bit cache

2011-04-02 Thread Tom Lane
Merlin Moncure writes: > On Wed, Mar 30, 2011 at 2:35 PM, Merlin Moncure wrote: >> btw I haven't forgotten your idea to move TransactionIdInProgress >> Down. I think this is a good idea, and will experiment with it pre and >> post cache. The reason it's done in that order is to avoid race condit

Re: [HACKERS] 9.0.3 SIGFAULT on FreeBSD with dtrace

2011-04-02 Thread Tom Lane
Luca Ferrari writes: > I'm trying to compile PostgreSQL 9.0.3 on FreeBSD 8.1-stable, and I can make > it working if I compile without dtrace. However when I compile with --enable- > dtrace I'm unable to use the cluster and even initdb. You probably need to take that up with some FreeBSD dtrace h

Re: [HACKERS] Another swing at JSON

2011-04-02 Thread Tom Lane
Dimitri Fontaine writes: > This and removing module_pathname in the control files to just use > $libdir/contrib in the .sql files. That would set a better example to > people who want to make their own extensions, as the general case is > that those will not get into contrib. I'm not sure it's a

Re: [HACKERS] psql 9.1 alpha5: connection pointer is NULL

2011-04-02 Thread Joseph Adams
2011/4/2 Devrim GÜNDÜZ : > > I'm getting the following message after upgrading to Alpha5 on my Fedora > 14 box: > > $ psql -p 5433 > psql: connection pointer is NULL > > which comes from libpq. Server is running, and I can connect it to via > 9.0's psql. > > This is a regular RPM build. Am I doing

Re: [HACKERS] Another swing at JSON

2011-04-02 Thread Tom Lane
Andrew Dunstan writes: > On 03/30/2011 12:29 PM, Dimitri Fontaine wrote: >> Andrew Dunstan writes: >>> I think we're pretty much down to only fixing bugs now, for 9.1, and this >>> isn't a bug, however inconvenient it might be. >> It's not just inconvenient, it's setting a bad example for people

Re: [HACKERS] Transforming IN (...) to ORs, volatility

2011-04-02 Thread Tom Lane
Heikki Linnakangas writes: > We sometimes transform IN-clauses to a list of ORs: > postgres=# explain SELECT * FROM foo WHERE a IN (b, c); >QUERY PLAN > -- > Seq Scan on foo (cost=0.00..39.10 rows=19 width=12) > Fil

[HACKERS] Re: [COMMITTERS] pgsql: Escape greater than and less than characters in docs.

2011-04-02 Thread David Fetter
On Sat, Apr 02, 2011 at 02:09:29PM +, Heikki Linnakangas wrote: > Escape greater than and less than characters in docs. Should things like this (< and > with space around them, I'm thinking) be part of make maintainer-check? Cheers, David. -- David Fetter http://fetter.org/ Phone: +1 415 23

[HACKERS] Finding a flow when query is fired in postgresql

2011-04-02 Thread bschaudhari972
i edited postgreql file so that i can check the flow of .c files invoked when we fire a query but only what i am getting is just parse trees ,rewritten trees and plan but no names of .c files invoked... plz help me asap ...its very important for me. what additional changes are required to see the n

Re: [HACKERS] [DOCS] fixed doc bug in sepgsql.sgml

2011-04-02 Thread Heikki Linnakangas
On 02.04.2011 10:24, Susanne Ebrecht wrote: Hello, by accident we recognised that the author of sepgsql.sgml used < and > instead of < and > I just fixed it and here is the patch. Committed, and I also fixed one case of that in pg_basebackup docs. -- Heikki Linnakangas EnterpriseDB htt

Re: [HACKERS] corner case about replication and shutdown

2011-04-02 Thread Fujii Masao
On Fri, Apr 1, 2011 at 11:11 PM, Robert Haas wrote: > On Thu, Mar 31, 2011 at 11:12 PM, Fujii Masao wrote: >> Another simple fix is to make walsender send SIGUSR1 to postmaster >> so that it calls PostmasterStateMachine() in sigusr1_handler(), when it >> marks itself as walsender. The attached pa

[HACKERS] psql 9.1 alpha5: connection pointer is NULL

2011-04-02 Thread Devrim GÜNDÜZ
I'm getting the following message after upgrading to Alpha5 on my Fedora 14 box: $ psql -p 5433 psql: connection pointer is NULL which comes from libpq. Server is running, and I can connect it to via 9.0's psql. This is a regular RPM build. Am I doing something wrong, or? Regards, -- Devrim G

Re: [HACKERS] [DOCS] found a very confusing and maybe outdated sentence

2011-04-02 Thread Susanne Ebrecht
On 31.03.2011 18:13, Robert Haas wrote: On Tue, Mar 29, 2011 at 3:07 PM, Susanne Ebrecht wrote: Hello, It is in start.sgml. You can see it here: http://www.postgresql.org/docs/9.0/static/tutorial-accessdb.html The last two sentences on the page: " If PostgreSQL is installed correctly you c

[HACKERS] fixed doc bug in sepgsql.sgml

2011-04-02 Thread Susanne Ebrecht
Hello, by accident we recognised that the author of sepgsql.sgml used < and > instead of < and > I just fixed it and here is the patch. Susanne -- Susanne Ebrecht - 2ndQuadrant PostgreSQL Development, 24x7 Support, Training and Services www.2ndQuadrant.com diff --git a/doc/src/sgml/sepgsql.sg