Re: [HACKERS] inconvenient compression options in pg_basebackup

2011-05-20 Thread Peter Eisentraut
On fre, 2011-05-20 at 14:19 -0400, Magnus Hagander wrote: > > I suggest we add an argument-less option -z that means "compress", > and > > then -Z can be relegated to choosing the compression level. > > We can't just use -Z without a parameter for that? You can't portably have a command-line opt

Re: [HACKERS] exposing float8-as-value to PGXS/makefiles

2011-05-20 Thread Alvaro Herrera
Excerpts from Michael Glaesemann's message of vie may 20 15:07:27 -0400 2011: > > On May 20, 2011, at 12:51, Alvaro Herrera wrote: > > > Excerpts from Tom Lane's message of vie may 20 12:43:25 -0400 2011: > >> Alvaro Herrera writes: > >>> I was just messing around with a datatype that's based in

Re: [HACKERS] exposing float8-as-value to PGXS/makefiles

2011-05-20 Thread Michael Glaesemann
On May 20, 2011, at 12:51, Alvaro Herrera wrote: > Excerpts from Tom Lane's message of vie may 20 12:43:25 -0400 2011: >> Alvaro Herrera writes: >>> I was just messing around with a datatype that's based in int64 >>> representation. Pretty much everything (seems to) work cleanly, but one >>> pr

Re: [HACKERS] Review: psql include file using relative path

2011-05-20 Thread Gurjeet Singh
On Tue, May 17, 2011 at 2:43 PM, Robert Haas wrote: > On Sat, May 14, 2011 at 5:03 PM, Josh Kupershmidt > wrote: > > I had a chance to give this patch a look. This review is of the second > > patch posted by Gurjeet, at: > > > http://archives.postgresql.org/message-id/AANLkTi=yjb_a+ggt_pxmrqhbhy

Re: [HACKERS] Review: psql include file using relative path

2011-05-20 Thread Gurjeet Singh
Thanks a lot for the review. My responses are inline below. On Sat, May 14, 2011 at 5:03 PM, Josh Kupershmidt wrote: > I had a chance to give this patch a look. This review is of the second > patch posted by Gurjeet, at: > > http://archives.postgresql.org/message-id/AANLkTi=yjb_a+ggt_pxmrqhbhyid6

Re: [HACKERS] inconvenient compression options in pg_basebackup

2011-05-20 Thread Magnus Hagander
On Thu, May 19, 2011 at 17:56, Peter Eisentraut wrote: > There is no way to tell pg_basebackup to "just compress the thing in a > default way".  You have to pick some number and then write -Z8 or > something.  I suppose that interface was copied from pg_dump, but there > it's not that commonly use

Re: [HACKERS] adding a new column in IDENTIFY_SYSTEM

2011-05-20 Thread Magnus Hagander
On Tue, May 17, 2011 at 16:38, Jaime Casanova wrote: > On Mon, May 16, 2011 at 2:35 AM, Magnus Hagander wrote: >> On Mon, May 16, 2011 at 01:03, Jaime Casanova wrote: >>> On Thu, May 5, 2011 at 10:59 AM, Tom Lane wrote: Magnus Hagander writes: >> So even if people don't believe in the

Re: [HACKERS] exposing float8-as-value to PGXS/makefiles

2011-05-20 Thread Alvaro Herrera
Excerpts from Tom Lane's message of vie may 20 12:43:25 -0400 2011: > Alvaro Herrera writes: > > I was just messing around with a datatype that's based in int64 > > representation. Pretty much everything (seems to) work cleanly, but one > > problem I have is that I cannot build the correct CREATE

Re: [HACKERS] exposing float8-as-value to PGXS/makefiles

2011-05-20 Thread Tom Lane
Alvaro Herrera writes: > I was just messing around with a datatype that's based in int64 > representation. Pretty much everything (seems to) work cleanly, but one > problem I have is that I cannot build the correct CREATE TYPE sentence > in the .sql.in file to actually install the type, because t

[HACKERS] exposing float8-as-value to PGXS/makefiles

2011-05-20 Thread Alvaro Herrera
Hi, I was just messing around with a datatype that's based in int64 representation. Pretty much everything (seems to) work cleanly, but one problem I have is that I cannot build the correct CREATE TYPE sentence in the .sql.in file to actually install the type, because there's no easy way to figur

Re: [HACKERS] ts_rank

2011-05-20 Thread Robert Haas
On Thu, May 19, 2011 at 10:42 PM, Kevin Grittner wrote: > Robert Haas  wrote: >> Mark  wrote: > >>> Could somebody explain me on which methods is based ts_rank and >>> how it works?  I would appreciate some articles, if exist. > >> As far as I can tell, our documentation contains no useful >> info

Re: [HACKERS] asterisk (non)expansion in GROUP BY clause

2011-05-20 Thread Tom Lane
Peter Eisentraut writes: > Apparently, you can write this (an attempt at a convenient workaround > for lack of functional dependency tracking pre-9.1): > SELECT pg_class.* FROM pg_class GROUP BY pg_class.*; > It won't work: > ERROR: 42803: column "pg_class.relname" must appear in the GROUP BY

Re: [HACKERS] switch UNLOGGED to LOGGED

2011-05-20 Thread Leonardo Francalanci
> - the patch is missing the "send all table pages to the > standby" part; is there some code I can use as base? > I guess I have to generate some special log type that > is only "played" by standby servers. Maybe I could use log_newpage, but instead of XLOG_HEAP_NEWPAGE I could use something

Re: [HACKERS] switch UNLOGGED to LOGGED

2011-05-20 Thread Leonardo Francalanci
I'll try to sum up what I understood: 1) the standby keeps the lock, so no problem with stray files coming from the unlogged->logged log reply, as the table can't be read during the operation 2) calling ResetUnloggedRelations before ProcArrayApplyRecoveryInfo would remove the problem of the stra