Re: [HACKERS] pg_restore --no-post-data and --post-data-only

2011-12-08 Thread Josh Berkus
On 12/8/11 9:18 PM, Joachim Wieland wrote: > If you ask pg_restore to restore a section out of an archive which > doesn't have this section, there is no error and the command just > succeeds. This is what I expected and I think it's the right thing to > do but maybe others think that > there should

Re: [HACKERS] pg_restore --no-post-data and --post-data-only

2011-12-08 Thread Joachim Wieland
On Tue, Nov 15, 2011 at 6:14 PM, Andrew Dunstan wrote: > Updated version with pg_restore included is attached. The patch applies with some fuzz by now but compiles without errors or warnings. The feature just works, it is not adding a lot of new code, basically it parses the given options and th

Re: [HACKERS] [PATCH] PostgreSQL fails to build with 32bit MinGW-w64

2011-12-08 Thread NISHIYAMA Tomoaki
Hi, > FYI I've been testing with the attached patch. > We'll need to construct a configure test for HAVE_CRTDEFS_H. Isn't it enough to add the name in configure.in and run autoconf to update configure and autoheaders to update pg_config.h.in? The check of win32 before large file perhaps should a

Re: [HACKERS] [v9.2] Fix Leaky View Problem

2011-12-08 Thread Kohei KaiGai
2011/12/8 Robert Haas : > On Sat, Dec 3, 2011 at 3:19 AM, Kohei KaiGai wrote: >> I rebased my patch set. New functions in pg_proc.h prevented to apply >> previous revision cleanly. Here is no functional changes. > > I was thinking that my version of this (attached to an email from > earlier today)

[HACKERS] Note about bogus pg_amop entries for commutator operators

2011-12-08 Thread Tom Lane
While reviewing the SP-Gist patch I noticed an error that I've seen before, notably in the rangetypes patch: cross-type operators should not be included in an opclass merely because their commutators are. To be useful in an index opclass, an operator has to take the indexed column's datatype as its

Re: [HACKERS] fix for pg_upgrade

2011-12-08 Thread panam
OK, works now with the recent update. Thanks -- View this message in context: http://postgresql.1045698.n5.nabble.com/fix-for-pg-upgrade-tp3411128p5059777.html Sent from the PostgreSQL - hackers mailing list archive at Nabble.com. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresq

Re: [HACKERS] [PATCH] PostgreSQL fails to build with 32bit MinGW-w64

2011-12-08 Thread Andrew Dunstan
On 12/05/2011 06:27 PM, Andrew Dunstan wrote: $ cat regression.diffs *** C:/MinGW/msys/1.0/home/pgrunner/bf/root32/HEAD/pgsql/src/test/regress/expected/float8-exp-three-digits-win32.out Fri Nov 25 14:24:49 2011 --- C:/MinGW/msys/1.0/home/pgrunner/bf/root32/HEAD/pgsql/s

Re: [HACKERS] pg_dump --exclude-table-data

2011-12-08 Thread Andrew Dunstan
On 12/08/2011 11:13 AM, Robert Haas wrote: On Wed, Dec 7, 2011 at 10:19 PM, Andrew Dunstan wrote: I'm also a bit concerned about the relationship between this and the existing -s option. It seems odd that you use --schema-only to get the behavior database-wide, and --exclude-table-data to ge

Re: [HACKERS] pg_dump --exclude-table-data

2011-12-08 Thread Robert Haas
On Wed, Dec 7, 2011 at 10:19 PM, Andrew Dunstan wrote: >> I'm also a bit concerned about the relationship between this and the >> existing -s option.  It seems odd that you use --schema-only to get >> the behavior database-wide, and --exclude-table-data to get it for >> just one table.  Is there s

Re: [HACKERS] Lots of FSM-related fragility in transaction commit

2011-12-08 Thread Tom Lane
Heikki Linnakangas writes: > On 08.12.2011 08:20, Tom Lane wrote: >> So this is really a whole lot worse than our behavior was in pre-FSM >> days, and it needs to get fixed. > This bug was actually introduced only recently. Notice how the log says > "consistent recovery state reached at 0/5D71BA

Re: [HACKERS] Allow substitute allocators for PGresult.

2011-12-08 Thread Kyotaro HORIGUCHI
Hello, The documentation had slipped my mind. This is the patch to add the documentation of PGresult custom storage. It shows in section '31.19. Alternative result storage'. regards, -- Kyotaro Horiguchi NTT Open Source Software Center diff --git a/doc/src/sgml/libpq.sgml b/doc/src/sgml/l

Re: [HACKERS] Lots of FSM-related fragility in transaction commit

2011-12-08 Thread Heikki Linnakangas
On 08.12.2011 08:20, Tom Lane wrote: I thought that removing the unreadable file would let me restart, but after "rm 52860_fsm" and trying again to start the server, there's a different problem: LOG: database system was interrupted while in recovery at 2011-12-08 00:56:11 EST HINT: This proba