Re: [HACKERS] psql COPY vs. ON_ERROR_ROLLBACK, multi-command strings

2012-02-24 Thread Noah Misch
On Wed, Jan 25, 2012 at 06:25:46PM -0300, Alvaro Herrera wrote: > Excerpts from Noah Misch's message of s??b ene 14 12:40:02 -0300 2012: > > It has bothered me that psql's \copy ignores the ON_ERROR_ROLLBACK setting. > > Only SendQuery() takes note of ON_ERROR_ROLLBACK, and \copy, like all > > back

Re: [HACKERS] psql \i tab completion initialization problem on HEAD

2012-02-24 Thread Tom Lane
Peter van Hardenberg writes: > On Thu, Feb 23, 2012 at 4:15 PM, Tom Lane wrote: >>> Here's a reliable reproduction on my OS X laptop. >> OS X? Are you using GNU readline, or Apple's libedit? > I reproduced it with both, but if that news is surprising to you, I > can certainly re-test. Actuall

Re: [HACKERS] leakproof

2012-02-24 Thread Noah Misch
On Wed, Feb 22, 2012 at 06:30:37PM -0500, Tom Lane wrote: > Andrew Dunstan writes: > > On 02/22/2012 04:29 PM, Marc Munro wrote: > >> As the developer of veil I feel marginally qualified to bikeshed here: > >> how about "silent"? A silent function being one that will not blab. > > > I also made

Re: [HACKERS] Patch for BUG #6480, psql incorrect indent for inherited tables names with UTF-8 NLS

2012-02-24 Thread Alvaro Herrera
Excerpts from Sergey Burladyan's message of vie feb 24 19:43:10 -0300 2012: > > See http://archives.postgresql.org/pgsql-bugs/2012-02/msg00164.php > > This need function for count characters, not bytes. I find this pg_wcswidth > but > it is not used anywhere and broken. So, I fix it and also ch

Re: [HACKERS] Runtime SHAREDIR for testing CREATE EXTENSION

2012-02-24 Thread Maciek Sakrejda
On Fri, Feb 24, 2012 at 3:31 PM, Daniel Farina wrote: > Having been in this position once before in a different but similar > situation, there's one big caveat: initdb is *really* slow, so it is > really painful for people who write Postgres-linked code that is > compiled separately, whereby the i

Re: [HACKERS] Runtime SHAREDIR for testing CREATE EXTENSION

2012-02-24 Thread Daniel Farina
On Fri, Feb 24, 2012 at 6:31 PM, Andrew Dunstan wrote: > Really? Here's what I just got on a severely under-resourced SL6 VM: > > 1.5s doesn't seem terribly slow. You are right. Come to think of it, I do seem to recall that initdb got some speed improvements; these were in 8.3 days, I think. Her

Re: [HACKERS] Runtime SHAREDIR for testing CREATE EXTENSION

2012-02-24 Thread Andrew Dunstan
On 02/24/2012 06:31 PM, Daniel Farina wrote: On Fri, Feb 24, 2012 at 10:21 AM, Peter Eisentraut wrote: On fre, 2012-02-24 at 17:26 +0100, Sandro Santilli wrote: We don't initdb with PostGIS regression testing framework but I've considered doing it for this specific case and it stroke me that

Re: [HACKERS] [PATCH] Support for foreign keys with arrays

2012-02-24 Thread Noah Misch
Hi Marco, This version fixes everything I noted in my last review. Apart from corner cases I note, the patch is technically sound. I pose a few policy-type questions; comments from a broader audience would help those. On Mon, Feb 06, 2012 at 07:04:42PM +0100, Marco Nenciarini wrote: > Please fi

Re: [HACKERS] foreign key locks, 2nd attempt

2012-02-24 Thread Vik Reykja
On Thu, Feb 23, 2012 at 19:44, Kevin Grittner wrote: > One of the problems that Florian was trying to address is that > people often have a need to enforce something with a lot of > similarity to a foreign key, but with more subtle logic than > declarative foreign keys support. One example would

Re: [HACKERS] Checking pg_hba.conf in the child process

2012-02-24 Thread Tom Lane
Alvaro Herrera writes: > Excerpts from Bruce Momjian's message of vie feb 24 19:19:10 -0300 2012: >> In looking over our authentication code, I noticed that we create the >> child process before we check any of the pg_hba.conf file. Now, I >> realize we can't do authentication in the postmaster b

Re: [HACKERS] psql \i tab completion initialization problem on HEAD

2012-02-24 Thread Peter van Hardenberg
On Thu, Feb 23, 2012 at 4:15 PM, Tom Lane wrote: >> Here's a reliable reproduction on my OS X laptop. > > OS X?  Are you using GNU readline, or Apple's libedit? > I reproduced it with both, but if that news is surprising to you, I can certainly re-test. -- Peter van Hardenberg San Francisco, Ca

Re: [HACKERS] Command Triggers, patch v11

2012-02-24 Thread Thom Brown
On 24 February 2012 23:01, Thom Brown wrote: > On 24 February 2012 22:39, Thom Brown wrote: >> On 24 February 2012 22:32, Thom Brown wrote: >>> On 24 February 2012 22:04, Dimitri Fontaine wrote: Hi, Please find attached the latest version of the command triggers patch, in co

Re: [HACKERS] Runtime SHAREDIR for testing CREATE EXTENSION

2012-02-24 Thread Daniel Farina
On Fri, Feb 24, 2012 at 10:21 AM, Peter Eisentraut wrote: > On fre, 2012-02-24 at 17:26 +0100, Sandro Santilli wrote: >> We don't initdb with PostGIS regression testing framework >> but I've considered doing it for this specific case and it stroke me >> that even then we couldn't control SHAREDIR.

Re: [HACKERS] Command Triggers, patch v11

2012-02-24 Thread Thom Brown
On 24 February 2012 22:39, Thom Brown wrote: > On 24 February 2012 22:32, Thom Brown wrote: >> On 24 February 2012 22:04, Dimitri Fontaine wrote: >>> Hi, >>> >>> Please find attached the latest version of the command triggers patch, >>> in context diff format, with support for 79 commands and do

[HACKERS] Patch for BUG #6480, psql incorrect indent for inherited tables names with UTF-8 NLS

2012-02-24 Thread Sergey Burladyan
See http://archives.postgresql.org/pgsql-bugs/2012-02/msg00164.php This need function for count characters, not bytes. I find this pg_wcswidth but it is not used anywhere and broken. So, I fix it and also change it prototype for remove type casting. PS: Please help, next week release will be wit

Re: [HACKERS] Command Triggers, patch v11

2012-02-24 Thread Thom Brown
On 24 February 2012 22:32, Thom Brown wrote: > On 24 February 2012 22:04, Dimitri Fontaine wrote: >> Hi, >> >> Please find attached the latest version of the command triggers patch, >> in context diff format, with support for 79 commands and documentation >> about why only those, and with some li

Re: [HACKERS] Checking pg_hba.conf in the child process

2012-02-24 Thread Bruce Momjian
On Fri, Feb 24, 2012 at 07:27:06PM -0300, Alvaro Herrera wrote: > > Excerpts from Bruce Momjian's message of vie feb 24 19:19:10 -0300 2012: > > In looking over our authentication code, I noticed that we create the > > child process before we check any of the pg_hba.conf file. Now, I > > realize

Re: [HACKERS] Command Triggers, patch v11

2012-02-24 Thread Thom Brown
On 24 February 2012 22:04, Dimitri Fontaine wrote: > Hi, > > Please find attached the latest version of the command triggers patch, > in context diff format, with support for 79 commands and documentation > about why only those, and with some limitations explained. > > I also cleaned up the node f

Re: [HACKERS] pgsql_fdw, FDW for PostgreSQL server

2012-02-24 Thread Peter Eisentraut
Could we name this "postgresql_fdw" instead? We already have several ${productname}_fdw out there, and I don't want to get in the business of having to guess variant spellings. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://ww

Re: [HACKERS] Checking pg_hba.conf in the child process

2012-02-24 Thread Alvaro Herrera
Excerpts from Bruce Momjian's message of vie feb 24 19:19:10 -0300 2012: > In looking over our authentication code, I noticed that we create the > child process before we check any of the pg_hba.conf file. Now, I > realize we can't do authentication in the postmaster because of possible > delay,

[HACKERS] Checking pg_hba.conf in the child process

2012-02-24 Thread Bruce Momjian
In looking over our authentication code, I noticed that we create the child process before we check any of the pg_hba.conf file. Now, I realize we can't do authentication in the postmaster because of possible delay, and checking the user name and database name filters is just work that is better d

Re: [HACKERS] Finer Extension dependencies

2012-02-24 Thread Dimitri Fontaine
Hitoshi Harada writes: > I confirmed DROP EXTENSION is fixed now. In turn, it seems to me > "requires" doesn't work. My test ext2.control looks like: I'm very sorry about that. It's all about playing with pg_depend and I've failed to spend enough time on that very topic to send a patch that jus

Re: [HACKERS] Patch: add timing of buffer I/O requests

2012-02-24 Thread Jim Nasby
On 2/22/12 10:35 AM, Ants Aasma wrote: The reason why I didn't add write timings to relation stats is that I couldn't figure out what the semantics should be. It could be either "time spent waiting for this relations blocks to be written out" or "time spent waiting for some other relations blocks

[HACKERS] Cleanup of make_ctags

2012-02-24 Thread Bruce Momjian
Looking at our src/tools/make_ctags, it was using an option that was renamed and no longer documented since 2003; this applied patch uses the new option name. If anyone using a ctags that old, I will find a way to support both, but until then, I think we should just use the documented option. -

[HACKERS] Behavior of subselects in target lists and order by

2012-02-24 Thread amit sehas
If we have a query of the form: Select *, (Select * FROM T2 WHERE p2 = T1.p1) FROM T1 ORDER BY 1 WHERE p3 = 75 In the above query there is a subselect in the target list and the ORDERBY has an ordinal number which indicates order by column 1. Does this mean that the above query will return all

[HACKERS] COPY with hints, rebirth

2012-02-24 Thread Simon Riggs
A long time ago, in a galaxy far away, we discussed ways to speed up data loads/COPY. http://archives.postgresql.org/pgsql-hackers/2007-01/msg00470.php In particular, the idea that we could mark tuples as committed while we are still loading them, to avoid negative behaviour for the first reader.

Re: [HACKERS] Triggers with DO functionality

2012-02-24 Thread Christopher Browne
On Fri, Feb 24, 2012 at 2:55 PM, Kevin Grittner wrote: > Tom Lane wrote: > >> By default, a trigger function runs as the table owner, ie it's > implicitly SEC DEF >> to the table owner. > > Really?  That's certainly what I would *want*, but it's not what I've > seen. Yeah, not quite consistent w

Re: [HACKERS] Triggers with DO functionality

2012-02-24 Thread Kevin Grittner
Tom Lane wrote: > By default, a trigger function runs as the table owner, ie it's implicitly SEC DEF > to the table owner. Really? That's certainly what I would *want*, but it's not what I've seen. test=# create user bob; CREATE ROLE test=# create user ted; CREATE ROLE test=# alter database

Re: [HACKERS] Triggers with DO functionality

2012-02-24 Thread Peter Eisentraut
On fre, 2012-02-24 at 14:27 -0500, Tom Lane wrote: > (Thinks some more...) Actually, the point of SECURITY DEFINER on a > trigger function is to run as somebody other than the table owner, > to wit the function owner. And with an anonymous function there > couldn't be any other owner. So I guess

Re: [HACKERS] Triggers with DO functionality

2012-02-24 Thread Tom Lane
Peter Eisentraut writes: > On fre, 2012-02-17 at 16:46 -0500, Tom Lane wrote: >> But perhaps SECURITY DEFINER is a common enough need to justify >> including in this shorthand form. > According to the SQL standard, trigger actions run in security definer > mode. I would hope that we could go wit

Re: [HACKERS] Fix PL/Python metadata when there is no result

2012-02-24 Thread Peter Eisentraut
On fre, 2012-02-10 at 17:44 +0100, Jean-Baptiste Quenot wrote: > Thanks for the work on PLPython result metadata, it is very useful! I > just came across a crash when trying to access this metadata on the > result of an UPDATE, which obviously cannot return any tuple (unless > you specify a RETURN

Re: [HACKERS] Triggers with DO functionality

2012-02-24 Thread Peter Eisentraut
On fre, 2012-02-17 at 16:46 -0500, Tom Lane wrote: > But perhaps SECURITY DEFINER is a common enough need to justify > including in this shorthand form. According to the SQL standard, trigger actions run in security definer mode. I would hope that we could go with that by default for inline trigg

Re: [HACKERS] ISO8601 nitpicking

2012-02-24 Thread Daniel Farina
On Fri, Feb 24, 2012 at 4:45 AM, Peter Eisentraut wrote: > On tor, 2012-02-23 at 23:41 -0800, Daniel Farina wrote: >> As it turns out, evidence would suggests that the "ISO" output in >> Postgres isn't, unless there's an ISO standard for date and time that >> is referring to other than 8601. > > Y

Re: [HACKERS] proposal: copybytea command for psql

2012-02-24 Thread Peter Eisentraut
On tor, 2012-02-16 at 16:11 -0500, Andrew Dunstan wrote: > Oh, nice idea. say \g{bn} where b was for binary fetch/output and n > was for no recordseps etc? Why not set the record separator to ''? -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subs

Re: [HACKERS] Let's drop V2 protocol

2012-02-24 Thread Merlin Moncure
On Fri, Feb 24, 2012 at 10:46 AM, Tom Lane wrote: > I believe it's still somewhat common among JDBC users to force > V2-protocol connections as a workaround for over-eager prepared > statement planning.  Although I think the issue they're trying to dodge > will be fixed as of 9.2, that doesn't mea

Re: [HACKERS] Runtime SHAREDIR for testing CREATE EXTENSION

2012-02-24 Thread Peter Eisentraut
On fre, 2012-02-24 at 17:26 +0100, Sandro Santilli wrote: > We don't initdb with PostGIS regression testing framework > but I've considered doing it for this specific case and it stroke me > that even then we couldn't control SHAREDIR. I would always create a new instance using initdb for test run

Re: [HACKERS] Runtime SHAREDIR for testing CREATE EXTENSION

2012-02-24 Thread Peter Eisentraut
On fre, 2012-02-24 at 11:53 -0500, Tom Lane wrote: > > We have the same problem with testing extensions at build-time in > the > > Debian packages. The server's SHAREDIR /usr/share/postgresql/... is > > only writable by root, while the build is running as buildd user, so > > there is no way to do "

Re: [HACKERS] Let's drop V2 protocol

2012-02-24 Thread Tom Lane
Marko Kreen writes: > On Fri, Feb 24, 2012 at 11:46:19AM -0500, Tom Lane wrote: >> As for taking it out of libpq, I would vote against doing that as long >> as we have pg_dump support for pre-7.4 servers. Now, I think it would >> be entirely reasonable to kill pg_dump's support for pre-7.3 server

Re: [HACKERS] Let's drop V2 protocol

2012-02-24 Thread Marko Kreen
On Fri, Feb 24, 2012 at 11:46:19AM -0500, Tom Lane wrote: > As for taking it out of libpq, I would vote against doing that as long > as we have pg_dump support for pre-7.4 servers. Now, I think it would > be entirely reasonable to kill pg_dump's support for pre-7.3 servers, > because that would si

Re: [HACKERS] Format of raw files

2012-02-24 Thread Alvaro Herrera
Excerpts from Rosario Borda's message of vie feb 24 09:47:01 -0300 2012: > Good morning to all. First I apologize for my English. > After a HD crash I have recovered a portion of the data in binary > files of postgres, carving it from the HD. But I do not know the > format of these files, and find

Re: [HACKERS] Runtime SHAREDIR for testing CREATE EXTENSION

2012-02-24 Thread Tom Lane
Christoph Berg writes: > Re: Sandro Santilli 2012-02-22 <20120222101656.GB6125@gnash> >> I'm not really looking for "inline extensions". >> I do want to install the extension objects somewhere, just NOT >> in the PostgreSQL builtin SHAREDIR but in an arbitrary staging >> directory to use for QA th

Re: [HACKERS] Let's drop V2 protocol

2012-02-24 Thread Tom Lane
Marko Kreen writes: > On Fri, Feb 24, 2012 at 4:26 PM, Merlin Moncure wrote: >> I think it's plausible that very old client libraries could connect to >> a modern server.  But it's pretty unlikely to have a 9.2 app contact >> an ancient server IMO. > We can drop it from libpq but keep the serve

Re: [HACKERS] Format of raw files

2012-02-24 Thread Christopher Browne
On Fri, Feb 24, 2012 at 7:47 AM, Rosario Borda wrote: > Good morning to all. First I apologize for my English. > After a HD crash I have recovered a portion of the data in binary > files of postgres, carving it from the HD. But I do not know the > format of these files, and find difficult to trans

Re: [HACKERS] Runtime SHAREDIR for testing CREATE EXTENSION

2012-02-24 Thread Sandro Santilli
On Thu, Feb 23, 2012 at 06:53:05PM -0800, Daniel Farina wrote: > On Tue, Feb 21, 2012 at 1:34 PM, Dimitri Fontaine > wrote: > > Sandro Santilli writes: > > Please see the "inline extension" thread where answers to your problem > > have been discussed. > > I'm pretty sure Sandro is hacking PostGI

Re: [HACKERS] Runtime SHAREDIR for testing CREATE EXTENSION

2012-02-24 Thread Sandro Santilli
On Fri, Feb 24, 2012 at 09:59:12AM +0100, Christoph Berg wrote: > Re: Sandro Santilli 2012-02-22 <20120222101656.GB6125@gnash> > > I'm not really looking for "inline extensions". > > I do want to install the extension objects somewhere, just NOT > > in the PostgreSQL builtin SHAREDIR but in an arbi

Re: [HACKERS] [v9.2] Add GUC sepgsql.client_label

2012-02-24 Thread Yeb Havinga
On 2012-02-23 12:17, Kohei KaiGai wrote: 2012/2/20 Yeb Havinga: On 2012-02-05 10:09, Kohei KaiGai wrote: The attached part-1 patch moves related routines from hooks.c to label.c because of references to static variables. The part-2 patch implements above mechanism. I took a short look at this

Re: [HACKERS] incompatible pointer types with newer zlib

2012-02-24 Thread Tom Lane
Peter Eisentraut writes: > On tor, 2012-02-23 at 10:17 -0500, Tom Lane wrote: >> void * seems entirely reasonable given the two different usages, but >> I would be happier if the patch added explicit casts whereever FH is >> set to or used as one of these two types. > That would add about 70 cast

Re: [HACKERS] Speed dblink using alternate libpq tuple storage

2012-02-24 Thread Marko Kreen
On Tue, Feb 14, 2012 at 01:39:06AM +0200, Marko Kreen wrote: > I tried imaging some sort of getFoo() style API for fetching in-flight > row data, but I always ended up with "rewrite libpq" step, so I feel > it's not productive to go there. > > Instead I added simple feature: rowProcessor can retur

[HACKERS] Format of raw files

2012-02-24 Thread Rosario Borda
Good morning to all. First I apologize for my English. After a HD crash I have recovered a portion of the data in binary files of postgres, carving it from the HD. But I do not know the format of these files, and find difficult to translate it and / or import. Many thanks for your attention, and fo

Re: [HACKERS] Re: pg_stat_statements normalisation without invasive changes to the parser (was: Next steps on pg_stat_statements normalisation)

2012-02-24 Thread Peter Geoghegan
On 21 February 2012 01:48, Tom Lane wrote: > you're proposing to move the error pointer to the "42", and that does > not seem like an improvement, especially not if it only happens when the > cast subject is a simple constant rather than an expression. 2008's commit a2794623d292f7bbfe3134d1407281

Re: [HACKERS] [v9.2] Add GUC sepgsql.client_label

2012-02-24 Thread Yeb Havinga
On 2012-02-24 15:17, Yeb Havinga wrote: I don't know what's fishy about the mgrid user and root that causes c0.c1023 to be absent. more info: In shells started in a x environment under Xvnc, id -Z shows the system_u and c0.c1023 absent. In shells started from the ssh daemon, the id -Z matc

Re: [HACKERS] Let's drop V2 protocol

2012-02-24 Thread Marko Kreen
On Fri, Feb 24, 2012 at 4:26 PM, Merlin Moncure wrote: > On Fri, Feb 24, 2012 at 7:52 AM, Marko Kreen wrote: >> So could we like, uh, not do it and simply drop the V2 code? > > I think it's plausible that very old client libraries could connect to > a modern server.  But it's pretty unlikely to h

Re: [HACKERS] Let's drop V2 protocol

2012-02-24 Thread Merlin Moncure
On Fri, Feb 24, 2012 at 7:52 AM, Marko Kreen wrote: > On Fri, Feb 24, 2012 at 02:11:45PM +0200, Marko Kreen wrote: >> On Fri, Feb 24, 2012 at 07:53:14PM +0900, Kyotaro HORIGUCHI wrote: >> > - I have no idea how to do test for protocol 2... >> >> I have a urge to test with "rm fe-protocol2.c"... >

Re: [HACKERS] [v9.2] Add GUC sepgsql.client_label

2012-02-24 Thread Yeb Havinga
On 2012-02-24 14:20, Kohei KaiGai wrote: It seems to me you try to expand categories of the client. The log saids sepgsql_setcon() tries to switch to "...:s0:c0.c15" from "...:s0". It is not an admitted operations because of increasion of categories. Yes I had my eye on the missing c0.c1023 be

Re: [HACKERS] Reviewing patch "URI connection string support for libpq"

2012-02-24 Thread Alex Shulgin
Harold Giménez writes: >I have interest in the URI connection string support patch[1], so I'm >in the process of reviewing it. I have a couple of comments and >questions: Hello, thank you for your interest and the review! >1. I see no tests in the patch. I'd like to start getti

[HACKERS] Let's drop V2 protocol

2012-02-24 Thread Marko Kreen
On Fri, Feb 24, 2012 at 02:11:45PM +0200, Marko Kreen wrote: > On Fri, Feb 24, 2012 at 07:53:14PM +0900, Kyotaro HORIGUCHI wrote: > > - I have no idea how to do test for protocol 2... > > I have a urge to test with "rm fe-protocol2.c"... Now I tested with 7.3.21 and the non-error case works fine.

Re: [HACKERS] [v9.2] Add GUC sepgsql.client_label

2012-02-24 Thread Kohei KaiGai
2012/2/24 Yeb Havinga : > On 2012-02-23 12:17, Kohei KaiGai wrote: >> >> 2012/2/20 Yeb Havinga: >> >>> So maybe this is because my start domain is not s0-s0:c0.c1023 >>> >>> However, when trying to run bash or psql in domain >>> unconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023 I get permission

Re: [HACKERS] WIP: URI connection string support for libpq

2012-02-24 Thread Florian Weimer
* Alex Shulgin: >> It's ugly, but it's standard practice, and seems better than a separate >> -d parameter (which sort of defeats the purpose of URIs). > > Hm, do you see anything what's wrong with "?dbname=other" if you don't > like a separate -d? It's not nice URI syntax, but it's better than a

Re: [HACKERS] WIP: URI connection string support for libpq

2012-02-24 Thread Alex Shulgin
Florian Weimer writes: > * Alex Shulgin: > >> Yeah, this is really appealing, however how do you tell if the part >> after the last slash is a socket directory name or a dbname? E.g: >> >> psql postgres:///path/to/different/socket/dir(default dbname) >> psql postgres:///path/to/differen

Re: [HACKERS] WIP: URI connection string support for libpq

2012-02-24 Thread Florian Weimer
* Alex Shulgin: > Yeah, this is really appealing, however how do you tell if the part > after the last slash is a socket directory name or a dbname? E.g: > > psql postgres:///path/to/different/socket/dir(default dbname) > psql postgres:///path/to/different/socket/dir/other (dbname=other

Re: [HACKERS] WIP: URI connection string support for libpq

2012-02-24 Thread Alex Shulgin
Greg Smith writes: Thank you for the review, Greg! > Given that, there really isn't a useful path forward that helps out > all those developers without supporting both prefixes. That's where > this left off before, I just wanted to emphasize how clear that need > seems now. OK, I've used the c

Re: [HACKERS] [v9.2] Add GUC sepgsql.client_label

2012-02-24 Thread Yeb Havinga
On 2012-02-23 12:17, Kohei KaiGai wrote: 2012/2/20 Yeb Havinga: So maybe this is because my start domain is not s0-s0:c0.c1023 However, when trying to run bash or psql in domain unconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023 I get permission denied. Distribution is FC15, sestatus SELinu

Re: [HACKERS] ISO8601 nitpicking

2012-02-24 Thread Peter Eisentraut
On tor, 2012-02-23 at 23:41 -0800, Daniel Farina wrote: > As it turns out, evidence would suggests that the "ISO" output in > Postgres isn't, unless there's an ISO standard for date and time that > is referring to other than 8601. Yes, ISO 9075, the SQL standard. This particular issue has been di

Re: [HACKERS] pg_stat_statements normalization: re-review

2012-02-24 Thread Daniel Farina
On Fri, Feb 24, 2012 at 3:14 AM, Daniel Farina wrote: > At ExecutorFinish (already hookable) all NodeKeys remembered by an > extension should be invalidated, as that memory is free and ready to > be used again. I think this statement is false; I thought it was true because *not* invalidating give

Re: [HACKERS] Speed dblink using alternate libpq tuple storage

2012-02-24 Thread Marko Kreen
On Fri, Feb 24, 2012 at 07:53:14PM +0900, Kyotaro HORIGUCHI wrote: > Hello, this is new version of the patch. > > > > By the way, I would like to ask you one question. What is the > > > reason why void* should be head or tail of the parameter list? > > > > Aesthetical reasons: > > I got it. Tha

Re: [HACKERS] pg_stat_statements normalization: re-review

2012-02-24 Thread Daniel Farina
On Thu, Feb 23, 2012 at 3:09 AM, Peter Geoghegan wrote: >> These have all been changed in the usual manner to support one new >> field, the queryId, on the toplevel Plan and Query nodes.  The queryId >> is 64-bit field copied from queries to plans to tie together plans "to >> be used by plugins" (

Re: [HACKERS] Speed dblink using alternate libpq tuple storage

2012-02-24 Thread Kyotaro HORIGUCHI
Hello, this is new version of the patch. > > By the way, I would like to ask you one question. What is the > > reason why void* should be head or tail of the parameter list? > > Aesthetical reasons: I got it. Thank you. > Last comment - if we drop the plan to make PQsetRowProcessorErrMsg() > u

Re: [HACKERS] Initial 9.2 pgbench write results

2012-02-24 Thread Simon Riggs
On Thu, Feb 23, 2012 at 11:59 PM, Robert Haas wrote: > this doesn't feel like the right time to embark on a bunch of new > engineering projects. IMHO this is exactly the right time to do full system tuning. Only when we have major projects committed can we move towards measuring things and corre

Re: [HACKERS] incompatible pointer types with newer zlib

2012-02-24 Thread Peter Eisentraut
On tor, 2012-02-23 at 10:17 -0500, Tom Lane wrote: > Peter Eisentraut writes: > > Fixing most of this is not difficult, see attached patch. The only > > ugliness is in pg_backup_archiver.h > > > FILE *FH; /* General purpose file handle */ > > > which is used throughout pg_dump

Re: [HACKERS] foreign key locks, 2nd attempt

2012-02-24 Thread Jeroen Vermeulen
On 2012-02-23 22:12, Noah Misch wrote: That alone would not simplify the patch much. INSERT/UPDATE/DELETE on the foreign side would still need to take some kind of tuple lock on the primary side to prevent primary-side DELETE. You then still face the complicated case of a tuple that's both loc

Re: [HACKERS] Runtime SHAREDIR for testing CREATE EXTENSION

2012-02-24 Thread Dimitri Fontaine
Daniel Farina writes: > I'm pretty sure Sandro is hacking PostGIS, so inline extensions are of > no help here. Sorry about the sloppy mention, one of the things under discussion (but out of scope for 9.2) in the inline extension thread is about where to store the shared objects and extension file

Re: [HACKERS] Misleading CREATE TABLE error

2012-02-24 Thread Peter Eisentraut
On tis, 2011-11-29 at 06:33 +0200, Peter Eisentraut wrote: > > > I'm not trying to inherit a relation, I'm trying to base a table on > > > it. As it happens, "cows" is a foreign table, which *is* a table, > > > just not a regular table. It might be useful to add support to clone > > > foreign tab

Re: [HACKERS] Runtime SHAREDIR for testing CREATE EXTENSION

2012-02-24 Thread Christoph Berg
Re: Sandro Santilli 2012-02-22 <20120222101656.GB6125@gnash> > I'm not really looking for "inline extensions". > I do want to install the extension objects somewhere, just NOT > in the PostgreSQL builtin SHAREDIR but in an arbitrary staging > directory to use for QA the extension before distributio