Re: [HACKERS] Draft release notes complete

2012-05-11 Thread Magnus Hagander
On Thu, May 10, 2012 at 6:28 PM, Peter Eisentraut pete...@gmx.net wrote: On tor, 2012-05-10 at 17:31 +0200, Magnus Hagander wrote: If people want the main docs building more often that's not really a problem other than time - we just need to decouple it from the buildfarm and run a separate

Re: [HACKERS] Draft release notes complete

2012-05-11 Thread Peter Eisentraut
On fre, 2012-05-11 at 09:26 +0200, Magnus Hagander wrote: On Thu, May 10, 2012 at 6:28 PM, Peter Eisentraut pete...@gmx.net wrote: On tor, 2012-05-10 at 17:31 +0200, Magnus Hagander wrote: If people want the main docs building more often that's not really a problem other than time - we just

Re: [HACKERS] PL/Python result set slicing broken in Python 3

2012-05-11 Thread Jan Urbański
On 10/05/12 19:45, Peter Eisentraut wrote: On lör, 2012-05-05 at 22:45 +0200, Jan Urbański wrote: Apparently once you implement PyMappingMethods.mp_subscript you can drop PySequenceMethods.sq_slice, but I guess there's no harm in keeping it (and I'm not sure it'd work on Python 2.3 with only

Re: [HACKERS] Draft release notes complete

2012-05-11 Thread Magnus Hagander
On Fri, May 11, 2012 at 9:55 AM, Peter Eisentraut pete...@gmx.net wrote: On fre, 2012-05-11 at 09:26 +0200, Magnus Hagander wrote: On Thu, May 10, 2012 at 6:28 PM, Peter Eisentraut pete...@gmx.net wrote: On tor, 2012-05-10 at 17:31 +0200, Magnus Hagander wrote: If people want the main docs

Re: [HACKERS] WalSndWakeup() and synchronous_commit=off

2012-05-11 Thread Simon Riggs
On 10 May 2012 20:51, Andres Freund and...@2ndquadrant.com wrote: I noticed that when synchronous_commit=off were not waking up the wal sender latch in xact.c:RecordTransactionCommit which leads to ugly delays of approx 7 seconds (1 + replication_timeout/10) with default settings. Given that

Re: [HACKERS] pgstat wait timeout just got a lot more common on Windows

2012-05-11 Thread Magnus Hagander
On Thu, May 10, 2012 at 6:52 PM, Tom Lane t...@sss.pgh.pa.us wrote: I wrote: Hence I think we oughta swap the order of those two array elements.  (Same issue in PGSemaphoreLock, btw, and I'm suspicious of pgwin32_select.) Oh ... while hacking win32 PGSemaphoreLock I saw that it has a

Re: [HACKERS] checkpointer code behaving strangely on postmaster -T

2012-05-11 Thread Simon Riggs
On 10 May 2012 16:14, Tom Lane t...@sss.pgh.pa.us wrote: Alvaro Herrera alvhe...@commandprompt.com writes: Excerpts from Tom Lane's message of jue may 10 02:27:32 -0400 2012: Alvaro Herrera alvhe...@alvh.no-ip.org writes: I noticed while doing some tests that the checkpointer process does not

Re: [HACKERS] Draft release notes complete

2012-05-11 Thread Cédric Villemain
Le jeudi 10 mai 2012 22:18:30, Alvaro Herrera a écrit : It's been said elsewhere that adding all this to the release notes as found on the official docs would be too bulky. How about having a second copy of the release notes that contains authorship info as proposed by Andrew? Then the docs

Re: [HACKERS] unite recovery.conf and postgresql.conf

2012-05-11 Thread Simon Riggs
On 10 May 2012 05:44, Josh Berkus j...@agliodbs.com wrote: I expect to revisit config directories before the first 9.3 CF, it will help multiple things I'd like to see happen.  Then we can circle back to the main unification job with a fairly clear path forward from there. Yeah, let's

Re: [HACKERS] Gsoc2012 idea, tablesample

2012-05-11 Thread Florian Pflug
Florian Pflug wrote: On May10, 2012, at 18:36 , Kevin Grittner wrote: Robert Haas wrote: I wonder if you could do this with something akin to the Bitmap Heap Scan machinery. Populate a TID bitmap with a bunch of randomly chosen TIDs, fetch them all in physical order and if you don't get

Re: [HACKERS] Draft release notes complete

2012-05-11 Thread Bruce Momjian
On Thu, May 10, 2012 at 08:46:56PM -0700, Robert Haas wrote: On May 10, 2012, at 4:19 PM, Andrew Dunstan and...@dunslane.net wrote: On 05/10/2012 06:15 PM, Tom Lane wrote: How about a hybrid: we continue to identify patch authors as now, that is with names attached to the feature/bugfix

Re: [HACKERS] Can pg_trgm handle non-alphanumeric characters?

2012-05-11 Thread MauMau
From: Kevin Grittner kevin.gritt...@wicourts.gov MauMau maumau...@gmail.com wrote: For information, what kind of breakage would occur? I imagined removing KEEPONLYALNUM would just accept non-alphanumeric characters and cause no harm to those who use only alphanumeric characters. This would

Re: [HACKERS] pgstat wait timeout just got a lot more common on Windows

2012-05-11 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: On Thu, May 10, 2012 at 6:52 PM, Tom Lane t...@sss.pgh.pa.us wrote: Oh ... while hacking win32 PGSemaphoreLock I saw that it has a *seriously* nasty bug: it does not reset ImmediateInterruptOK before returning. How is it that Windows machines aren't

Re: [HACKERS] problem/bug in drop tablespace?

2012-05-11 Thread Albe Laurenz
Michael Nolan wrote: I see one potential difference between your results and mine. When I rebuild the tablespace, I wind up with the same filename/OID as before, I'm not sure you do. Right. That's strange. Usually OIDs get incremented, so you shouldn't end up with the same OID for the new

Re: [HACKERS] Draft release notes complete

2012-05-11 Thread Andrew Dunstan
On 05/11/2012 08:56 AM, Bruce Momjian wrote: On Thu, May 10, 2012 at 08:46:56PM -0700, Robert Haas wrote: On May 10, 2012, at 4:19 PM, Andrew Dunstanand...@dunslane.net wrote: On 05/10/2012 06:15 PM, Tom Lane wrote: How about a hybrid: we continue to identify patch authors as now, that is

Re: [HACKERS] Gsoc2012 idea, tablesample

2012-05-11 Thread Florian Pflug
[ Sorry for the self-reply ] On May11, 2012, at 13:17 , Florian Pflug wrote: Actually, thinking more about this, if the approach sketched above turns out to work, then one might be able to get away without remembering previously computed TIDs, thus removing a lot of complexity. Say, for

Re: [HACKERS] Gsoc2012 idea, tablesample

2012-05-11 Thread Sandro Santilli
On Thu, May 10, 2012 at 02:30:35PM -0400, Robert Haas wrote: On Thu, May 10, 2012 at 2:07 PM, Kevin Grittner kevin.gritt...@wicourts.gov wrote: Ants Aasma a...@cybertec.at wrote: It seems to me that the simplest thing to do would be to lift the sampling done in analyze.c

Re: [HACKERS] Draft release notes complete

2012-05-11 Thread Bruce Momjian
On Fri, May 11, 2012 at 09:51:49AM -0400, Andrew Dunstan wrote: On 05/11/2012 08:56 AM, Bruce Momjian wrote: On Thu, May 10, 2012 at 08:46:56PM -0700, Robert Haas wrote: On May 10, 2012, at 4:19 PM, Andrew Dunstanand...@dunslane.net wrote: On 05/10/2012 06:15 PM, Tom Lane wrote: How

Re: [HACKERS] Gsoc2012 idea, tablesample

2012-05-11 Thread Kevin Grittner
Florian Pflug f...@phlo.org wrote: Maybe one can get rid of these sorts of problems by factoring in the expected density of the table beforehand and simply accepting that the results will be inaccurate if the statistics are outdated? One could, for example, simply pick N :=

Re: [HACKERS] Gsoc2012 idea, tablesample

2012-05-11 Thread Tom Lane
Florian Pflug f...@phlo.org writes: This all hinges on the ability to produce a sufficient accurate estimate of the TID density p_tup/p_tid, of course. I think that's the least of its problems. AFAICS this analysis ignores (1) the problem that the TID space is nonuniform, ie we don't know

Re: [HACKERS] Draft release notes complete

2012-05-11 Thread Bruce Momjian
On Fri, May 11, 2012 at 10:01:32AM -0400, Bruce Momjian wrote: On Fri, May 11, 2012 at 09:51:49AM -0400, Andrew Dunstan wrote: On 05/11/2012 08:56 AM, Bruce Momjian wrote: On Thu, May 10, 2012 at 08:46:56PM -0700, Robert Haas wrote: On May 10, 2012, at 4:19 PM, Andrew

Re: [HACKERS] problem/bug in drop tablespace?

2012-05-11 Thread Michael Nolan
On 5/11/12, Albe Laurenz laurenz.a...@wien.gv.at wrote: Michael Nolan wrote: I see one potential difference between your results and mine. When I rebuild the tablespace, I wind up with the same filename/OID as before, I'm not sure you do. Right. That's strange. Usually OIDs get

Re: [HACKERS] problem/bug in drop tablespace?

2012-05-11 Thread Michael Nolan
On 5/11/12, Michael Nolan htf...@gmail.com wrote: On 5/11/12, Albe Laurenz laurenz.a...@wien.gv.at wrote: Michael Nolan wrote: I see one potential difference between your results and mine. When I rebuild the tablespace, I wind up with the same filename/OID as before, I'm not sure you do.

Re: [HACKERS] Gsoc2012 idea, tablesample

2012-05-11 Thread Tom Lane
Kevin Grittner kevin.gritt...@wicourts.gov writes: Florian Pflug f...@phlo.org wrote: Maybe one can get rid of these sorts of problems by factoring in the expected density of the table beforehand and simply accepting that the results will be inaccurate if the statistics are outdated?

Re: [HACKERS] Draft release notes complete

2012-05-11 Thread Andrew Dunstan
On 05/11/2012 10:15 AM, Bruce Momjian wrote: On Fri, May 11, 2012 at 10:01:32AM -0400, Bruce Momjian wrote: On Fri, May 11, 2012 at 09:51:49AM -0400, Andrew Dunstan wrote: On 05/11/2012 08:56 AM, Bruce Momjian wrote: On Thu, May 10, 2012 at 08:46:56PM -0700, Robert Haas wrote: On May 10,

Re: [HACKERS] Draft release notes complete

2012-05-11 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: Let me add that I am concerned about the lack of objectivity in many of the suggestions in this thread. This has prompted me to think that the temptation of having names on these release note items is just too great, and that the names should be removed.

Re: [HACKERS] incorrect handling of the timeout in pg_receivexlog

2012-05-11 Thread Magnus Hagander
On Thursday, May 10, 2012, Fujii Masao wrote: On Thu, May 10, 2012 at 11:51 PM, Magnus Hagander mag...@hagander.netjavascript:; wrote: And taking this a step further - we *already* send these GUCs. Previous references to us not doing that were incorrect :-) So this should be a much

Re: [HACKERS] Gsoc2012 idea, tablesample

2012-05-11 Thread Kevin Grittner
Tom Lane t...@sss.pgh.pa.us wrote: If you're willing to accept that the quality of the results depends on having up-to-date stats, then I'd suggest (1) use the planner's existing technology to estimate the number of rows in the table; (2) multiply by sampling factor you want to get a

Re: [HACKERS] Gsoc2012 idea, tablesample

2012-05-11 Thread Robert Haas
On Fri, May 11, 2012 at 11:04 AM, Kevin Grittner kevin.gritt...@wicourts.gov wrote: We will be probing random page numbers 1..P for random tuple indexes 1..M.  So how many random probes by ctid does that require? The chance of a hit on each probe is ((T/P)/M) -- the average number of tuples

Re: [HACKERS] Gsoc2012 idea, tablesample

2012-05-11 Thread Tom Lane
Kevin Grittner kevin.gritt...@wicourts.gov writes: [ uniformly sample the TID space defined as (1..P, 1..M) ] Shouldn't that get us the randomly chosen sample we're looking for? Is there a problem you think this ignores? Not sure. The issue that I'm wondering about is that the line number

Re: [HACKERS] Gsoc2012 idea, tablesample

2012-05-11 Thread Kevin Grittner
Robert Haas robertmh...@gmail.com wrote: The trouble is, AFAICS, that you can't bound M very well without scanning the whole table. I mean, it's bounded by theoretical limit, but that's it. What would the theoretical limit be? (black size - page header size - minimum size of one tuple) /

Re: [HACKERS] Gsoc2012 idea, tablesample

2012-05-11 Thread Tom Lane
Kevin Grittner kevin.gritt...@wicourts.gov writes: Robert Haas robertmh...@gmail.com wrote: The trouble is, AFAICS, that you can't bound M very well without scanning the whole table. I mean, it's bounded by theoretical limit, but that's it. What would the theoretical limit be? (black size

Re: [HACKERS] incorrect handling of the timeout in pg_receivexlog

2012-05-11 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: How common *is* it to have a build that doesn't have integer timestamps these days? Does any of the binary builds do that at all, for example? If it's uncommon enough, I think we should just go with the easy way out... +1 for just rejecting a

Re: [HACKERS] Draft release notes complete

2012-05-11 Thread Andrew Dunstan
On 05/11/2012 05:32 AM, Magnus Hagander wrote: But in the interest of actually being productive - what *is* the usecase for needing a 5 minute turnaround time? I don't buy the check what a patch looks like, because that should be done *before* the commit, not after - so it's best verified by

Re: [HACKERS] Gsoc2012 idea, tablesample

2012-05-11 Thread Florian Pflug
On May11, 2012, at 17:20 , Robert Haas wrote: On Fri, May 11, 2012 at 11:04 AM, Kevin Grittner Since T cancels out of that equation, we don't need to worry about estimating it. Results will be correct for any value of M which is *at least* as large as the maximum tuple index in the table,

Re: [HACKERS] Gsoc2012 idea, tablesample

2012-05-11 Thread Kevin Grittner
Tom Lane t...@sss.pgh.pa.us wrote: Kevin Grittner kevin.gritt...@wicourts.gov writes: [ uniformly sample the TID space defined as (1..P, 1..M) ] Shouldn't that get us the randomly chosen sample we're looking for? Is there a problem you think this ignores? Not sure. The issue that I'm

Re: [HACKERS] Can pg_trgm handle non-alphanumeric characters?

2012-05-11 Thread Fujii Masao
On Fri, May 11, 2012 at 4:11 AM, Tom Lane t...@sss.pgh.pa.us wrote: Fujii Masao masao.fu...@gmail.com writes: On Fri, May 11, 2012 at 12:07 AM, MauMau maumau...@gmail.com wrote: Thanks for your explanation. Although I haven't understood it well yet, I'll consider what you taught. And I'll

Re: [HACKERS] Gsoc2012 idea, tablesample

2012-05-11 Thread Florian Pflug
On May11, 2012, at 16:03 , Kevin Grittner wrote: [more complex alternatives] I really think your first suggestion covers it perfectly; these more complex techniques don't seem necessary to me. The point of the more complex techniques (especially the algorithm in my second mail, the reply to

Re: [HACKERS] incorrect handling of the timeout in pg_receivexlog

2012-05-11 Thread Fujii Masao
On Sat, May 12, 2012 at 12:44 AM, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: How common *is* it to have a build that doesn't have integer timestamps these days? Does any of the binary builds do that at all, for example? If it's uncommon enough, I think we

Re: [HACKERS] [COMMITTERS] pgsql: Ensure age() returns a stable value rather than the latest value

2012-05-11 Thread Tom Lane
Simon Riggs si...@2ndquadrant.com writes: Ensure age() returns a stable value rather than the latest value Hm. This fixes the stability-within-transaction problem, but it's also introduced a change in the definition of age(), no? Previously, in an xact that had an XID, the age was measured

Re: [HACKERS] PL/perl elog(ERROR) Does not Abort Transaction

2012-05-11 Thread David E. Wheeler
On May 10, 2012, at 6:18 PM, Tom Lane wrote: I also tried this on a Fedora 16 box, which has $ perl -v This is perl 5, version 14, subversion 2 (v5.14.2) built for x86_64-linux-thread-multi Works fine there too... Hrm…I've also just replicated it on CentOS 6.2 with Perl 5.10.1:

Re: [HACKERS] PL/perl elog(ERROR) Does not Abort Transaction

2012-05-11 Thread Tom Lane
David E. Wheeler david.whee...@iovation.com writes: Hrm…I've also just replicated it on CentOS 6.2 with Perl 5.10.1: Interesting. Perhaps there is something funky in my configuration, though I tried a few different things and couldn't get it to change. Yeah. If Bruce and I don't see it on a

[HACKERS] Re: [COMMITTERS] pgsql: Ensure age() returns a stable value rather than the latest value

2012-05-11 Thread Simon Riggs
On 11 May 2012 17:13, Tom Lane t...@sss.pgh.pa.us wrote: Simon Riggs si...@2ndquadrant.com writes: Ensure age() returns a stable value rather than the latest value Hm.  This fixes the stability-within-transaction problem, but it's also introduced a change in the definition of age(), no?  

Re: [HACKERS] PL/perl elog(ERROR) Does not Abort Transaction

2012-05-11 Thread David E. Wheeler
On May 11, 2012, at 9:39 AM, Tom Lane wrote: Hrm∑I've also just replicated it on CentOS 6.2 with Perl 5.10.1: Interesting. Ah, it’s a psql configuration issue. I had replicated it on that box by connecting with psql on my Mac. When I SSHed to the box and used the psql there, I was *not*

Re: [HACKERS] Gsoc2012 idea, tablesample

2012-05-11 Thread Robert Haas
On Fri, May 11, 2012 at 11:36 AM, Kevin Grittner kevin.gritt...@wicourts.gov wrote: Robert Haas robertmh...@gmail.com wrote: The trouble is, AFAICS, that you can't bound M very well without scanning the whole table.  I mean, it's bounded by theoretical limit, but that's it. What would the

Re: [HACKERS] unite recovery.conf and postgresql.conf

2012-05-11 Thread Josh Berkus
A key requirement is to be able to drop in new config files without needing to $EDIT anything. Yes, absolutely. I want to move towards the idea that the majority of our users never edit postgresql.conf by hand. OK, its possible to put in lots of includeifexists for non-existent files just

Re: [HACKERS] WalSndWakeup() and synchronous_commit=off

2012-05-11 Thread Fujii Masao
On Fri, May 11, 2012 at 4:51 AM, Andres Freund and...@2ndquadrant.com wrote: diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c index ecb71b6..7a3224b 100644 --- a/src/backend/access/transam/xlog.c +++ b/src/backend/access/transam/xlog.c @@ -1906,6 +1906,10 @@

Re: [HACKERS] PL/perl elog(ERROR) Does not Abort Transaction

2012-05-11 Thread David E. Wheeler
On May 11, 2012, at 9:51 AM, David E. Wheeler wrote: \set ON_ERROR_ROLLBACK interactive So I guess it transparently rolls back a savepoint for the previous statement. I had forgotten I turned that on. Apologies for the noise. OTOH, might it be useful to have psql show some sort of

Re: [HACKERS] Gsoc2012 idea, tablesample

2012-05-11 Thread Kevin Grittner
Robert Haas robertmh...@gmail.com wrote: On Fri, May 11, 2012 at 11:36 AM, Kevin Grittner kevin.gritt...@wicourts.gov wrote: Robert Haas robertmh...@gmail.com wrote: The trouble is, AFAICS, that you can't bound M very well without scanning the whole table. I mean, it's bounded by theoretical

Re: [HACKERS] PL/perl elog(ERROR) Does not Abort Transaction

2012-05-11 Thread Tom Lane
David E. Wheeler da...@justatheory.com writes: On May 11, 2012, at 9:51 AM, David E. Wheeler wrote: \set ON_ERROR_ROLLBACK interactive So I guess it transparently rolls back a savepoint for the previous statement. I had forgotten I turned that on. Apologies for the noise. Ah-hah. OTOH,

Re: [HACKERS] WalSndWakeup() and synchronous_commit=off

2012-05-11 Thread Robert Haas
On Fri, May 11, 2012 at 1:09 PM, Fujii Masao masao.fu...@gmail.com wrote: Calling WalSndWakeup() while WALWriteLock is being held might cause another performance degradation. No? That definitely doesn't seem ideal - a lot of things can pile up behind WALWriteLock. I'm not sure how big a

Re: [HACKERS] Re: [COMMITTERS] pgsql: Ensure age() returns a stable value rather than the latest value

2012-05-11 Thread Tom Lane
Simon Riggs si...@2ndquadrant.com writes: On 11 May 2012 17:13, Tom Lane t...@sss.pgh.pa.us wrote: Hm. This fixes the stability-within-transaction problem, but it's also introduced a change in the definition of age(), no? Yeh, I thought about that. The likely difference between the old and

Re: [HACKERS] Re: [COMMITTERS] pgsql: Ensure age() returns a stable value rather than the latest value

2012-05-11 Thread Robert Haas
On Fri, May 11, 2012 at 1:28 PM, Tom Lane t...@sss.pgh.pa.us wrote: I'm not convinced this is the best thing, and I'm definitely not happy with changing the behavior of working cases (ie, behavior on the master) in the back branches. Anybody else have an opinion on this? I agree with you.

Re: [HACKERS] Gsoc2012 idea, tablesample

2012-05-11 Thread Greg Stark
On Fri, May 11, 2012 at 6:16 PM, Kevin Grittner kevin.gritt...@wicourts.gov wrote: MaxHeapTuplesPerPage? What about dead line pointers without corresponding tuples? Actually we don't allow there to be more than MaxHeapTuplesPerPage line pointers even if some of them are dead line pointers. I

Re: [HACKERS] WalSndWakeup() and synchronous_commit=off

2012-05-11 Thread Andres Freund
On Friday, May 11, 2012 07:20:26 PM Robert Haas wrote: On Fri, May 11, 2012 at 1:09 PM, Fujii Masao masao.fu...@gmail.com wrote: Calling WalSndWakeup() while WALWriteLock is being held might cause another performance degradation. No? That definitely doesn't seem ideal - a lot of things can

Re: [HACKERS] Draft release notes complete

2012-05-11 Thread Jeff Janes
On Thu, May 10, 2012 at 10:44 AM, Bruce Momjian br...@momjian.us wrote: On Thu, May 10, 2012 at 01:11:54PM +0100, Peter Geoghegan wrote: Why can't we call group commit group commit (and for that matter, index-only scans index-only scans), so that people will understand that we are now

Re: [HACKERS] Draft release notes complete

2012-05-11 Thread Peter Eisentraut
On fre, 2012-05-11 at 11:32 +0200, Magnus Hagander wrote: You are misinterpreting this. The reason Bruce's link was removed was that the other (official) build was set to run at the same frequency, so Bruce's build was exactly redundant. The requirement/aspiration to have a few minutes

Re: [HACKERS] Re: [COMMITTERS] pgsql: Ensure age() returns a stable value rather than the latest value

2012-05-11 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: ... I don't really see any particular merit in removing our own XID from the picture entirely: that changes the behavior more significantly for no particular benefit. The merit would be in keeping the function's definition simple. Anyway, let's see if

[HACKERS] Agenda For 3rd Cluster Hackers Summit, May 15th in Ottawa

2012-05-11 Thread Josh Berkus
Hackers, Replicators, Clusterers: The agenda and the list of attendees for the cluster-hackers summit has been set: http://wiki.postgresql.org/wiki/PgCon2012CanadaClusterSummit Please send me any corrections, changes or additions ASAP. Thanks you! -- Josh Berkus PostgreSQL Experts Inc.

Re: [HACKERS] WalSndWakeup() and synchronous_commit=off

2012-05-11 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: That definitely doesn't seem ideal - a lot of things can pile up behind WALWriteLock. I'm not sure how big a problem it would be in practice, but we generally make a practice of avoiding sending signals while holding LWLocks whenever possible...

Re: [HACKERS] WalSndWakeup() and synchronous_commit=off

2012-05-11 Thread Andres Freund
On Friday, May 11, 2012 08:36:24 PM Tom Lane wrote: Robert Haas robertmh...@gmail.com writes: That definitely doesn't seem ideal - a lot of things can pile up behind WALWriteLock. I'm not sure how big a problem it would be in practice, but we generally make a practice of avoiding sending

Re: [HACKERS] WalSndWakeup() and synchronous_commit=off

2012-05-11 Thread Tom Lane
Andres Freund and...@2ndquadrant.com writes: Its the only place though which knows whether its actually sensible to wakeup the walsender. We could make it return whether it wrote anything and do the wakeup at the callers. I count 4 different callsites which would be an annoying duplication

Re: [HACKERS] WalSndWakeup() and synchronous_commit=off

2012-05-11 Thread Simon Riggs
On 11 May 2012 19:45, Tom Lane t...@sss.pgh.pa.us wrote: Andres Freund and...@2ndquadrant.com writes: Its the only place though which knows whether its actually sensible to wakeup the walsender. We could make it return whether it wrote anything and do the wakeup at the callers. I count 4

Re: [HACKERS] checkpointer code behaving strangely on postmaster -T

2012-05-11 Thread Tom Lane
Alvaro Herrera alvhe...@commandprompt.com writes: Excerpts from Tom Lane's message of jue may 10 02:27:32 -0400 2012: Alvaro Herrera alvhe...@alvh.no-ip.org writes: I noticed while doing some tests that the checkpointer process does not recover very nicely after a backend crashes under

Re: [HACKERS] checkpointer code behaving strangely on postmaster -T

2012-05-11 Thread Alvaro Herrera
Excerpts from Tom Lane's message of vie may 11 16:50:01 -0400 2012: Yep, it's still there as far as I can tell. A backtrace from the checkpointer shows it's waiting on the latch. I'm confused about what you did here and whether this isn't just pilot error. If you run with -T then the

Re: [HACKERS] checkpointer code behaving strangely on postmaster -T

2012-05-11 Thread Tom Lane
Alvaro Herrera alvhe...@commandprompt.com writes: Excerpts from Tom Lane's message of vie may 11 16:50:01 -0400 2012: I'm confused about what you did here and whether this isn't just pilot error. The sequence of events is: postmaster -T crash a backend SIGINT postmaster SIGCONT all child

[HACKERS] WIP: parameterized function scan

2012-05-11 Thread Antonin Houska
Hello, following this short discussion http://archives.postgresql.org/message-id/4f5aa202.9020...@gmail.com I gave it one more try and hacked the optimizer so that function can become an inner relation in NL join, parametrized with values from the outer relation. I tried to explain my

Re: [HACKERS] problem/bug in drop tablespace?

2012-05-11 Thread Tom Lane
Albe Laurenz laurenz.a...@wien.gv.at writes: Michael Nolan wrote: I see one potential difference between your results and mine. When I rebuild the tablespace, I wind up with the same filename/OID as before, I'm not sure you do. Right. That's strange. Usually OIDs get incremented, so you

Re: [HACKERS] Re: [COMMITTERS] pgsql: Ensure age() returns a stable value rather than the latest value

2012-05-11 Thread Robert Haas
On Fri, May 11, 2012 at 2:17 PM, Tom Lane t...@sss.pgh.pa.us wrote: The merit would be in keeping the function's definition simple. True. It's not *much* simpler, but it is simpler. Anyway, let's see if breaking this down by cases clarifies anything. As I see it, there are three possible

Re: [HACKERS] problem/bug in drop tablespace?

2012-05-11 Thread Robert Haas
On Fri, May 11, 2012 at 7:55 PM, Tom Lane t...@sss.pgh.pa.us wrote: A larger question is whether we should start making pg_shdepend entries for table/index usage of non-default tablespaces, so that you couldn't DROP a tablespace that the catalogs think still has tables/indexes in it. I'm

Re: [HACKERS] Draft release notes complete

2012-05-11 Thread Robert Haas
On Fri, May 11, 2012 at 2:03 PM, Jeff Janes jeff.ja...@gmail.com wrote: On Thu, May 10, 2012 at 10:44 AM, Bruce Momjian br...@momjian.us wrote: On Thu, May 10, 2012 at 01:11:54PM +0100, Peter Geoghegan wrote: Why can't we call group commit group commit (and for that matter, index-only scans

Re: [HACKERS] problem/bug in drop tablespace?

2012-05-11 Thread Alvaro Herrera
Excerpts from Robert Haas's message of vie may 11 20:28:28 -0400 2012: On Fri, May 11, 2012 at 7:55 PM, Tom Lane t...@sss.pgh.pa.us wrote: A larger question is whether we should start making pg_shdepend entries for table/index usage of non-default tablespaces, so that you couldn't DROP a

Re: [HACKERS] problem/bug in drop tablespace?

2012-05-11 Thread Tom Lane
Alvaro Herrera alvhe...@commandprompt.com writes: Excerpts from Robert Haas's message of vie may 11 20:28:28 -0400 2012: I'm astonished we don't do that already. Seems inconsistent with other SQL object types - most obviously, schemas - and a potentially giant foot-gun. The original patch

Re: [HACKERS] problem/bug in drop tablespace?

2012-05-11 Thread Michael Nolan
On Fri, May 11, 2012 at 10:03 PM, Tom Lane t...@sss.pgh.pa.us wrote: Well, the question to me is exactly how much good it will do to stop deletion of the pg_tablespace entry, if the underlying files are gone. I'm having a hard time getting excited about expending cycles on that. There could