Re: [HACKERS] 64-bit API for large object

2012-10-07 Thread Amit Kapila
> On Sunday, October 07, 2012 1:25 PM Tatsuo Ishii wrote: > Amit, > > > Today when I tried to build the latest code on my windows m/c, I got > few errors from the checkin of this patch. > > > > lo_hton64 (due to -- unint32_t) > > .\src\interfaces\libpq\fe-lobj.c(1049) : error C2065: 'uint32_t' :

Re: [HACKERS] Rethinking placement of latch self-pipe initialization

2012-10-07 Thread Amit Kapila
On Sunday, October 07, 2012 10:58 PM Tom Lane wrote: > Sean Chittenden recently reported that 9.2 can crash after logging > "FATAL: pipe() failed" if the kernel is short of file descriptors: > http://archives.postgresql.org/pgsql-general/2012-10/msg00202.php > > The only match to that error text

Re: [HACKERS] Improving psql \ds

2012-10-07 Thread Tom Lane
Julien Tachoires writes: > About \ds behaviour, I think to add 2 columns : > - 'LastValue' > - 'Increment' That would make the command a great deal slower, since it would have to access each sequence to get that info. I don't object to adding such columns to \ds+, but I don't think it's a good i

Re: [HACKERS] Bugs in CREATE/DROP INDEX CONCURRENTLY

2012-10-07 Thread Greg Stark
On Sat, Oct 6, 2012 at 12:56 AM, Tom Lane wrote: > 1. These operations think they can use ordinary heap_update operations > to change pg_index entries when they don't have exclusive lock on the > parent table. I wonder if we need a manual that lists exhaustively what operations can be taken with

[HACKERS] Improving psql \ds

2012-10-07 Thread Julien Tachoires
Hi, I would like to work on psql \ds improvements. Here's my idea : - in src/bin/psql/describe.c, add a new function : listSequences(*pattern, verbose) wich will list sequences and remove code related to sequences from listTables() - in src/bin/psql/command.c, call listSequences() on \ds - about l

Re: [HACKERS] Visual Studio 2012 RC

2012-10-07 Thread Brar Piening
Noah Misch wrote: I'm marking this patch Waiting on Author, but the changes needed to get it Ready for Committer are fairly trivial. Thanks, nm Thanks for your review and sorry for my delayed response - I've been on vacation. I'll look into adressing your comments and suggestions within th

[HACKERS] Rethinking placement of latch self-pipe initialization

2012-10-07 Thread Tom Lane
Sean Chittenden recently reported that 9.2 can crash after logging "FATAL: pipe() failed" if the kernel is short of file descriptors: http://archives.postgresql.org/pgsql-general/2012-10/msg00202.php The only match to that error text is in initSelfPipe(). What I believe is happening is that InitP

Re: [HACKERS] plpgsql_check_function - rebase for 9.3

2012-10-07 Thread Andrew Dunstan
On 10/07/2012 11:25 AM, Tom Lane wrote: Selena Deckelmann writes: This also represents my inaugural use of pg_bsd_indent. I ran it on pl_check.c - which made things mostly better. Happy to try and fix it up more if someone can explain to me what (if anything) I did incorrectly when using it.

[HACKERS] windows warnings

2012-10-07 Thread Andrew Dunstan
I have just noticed the following warnings on currawong (MSVC): "d:\bf\root\HEAD\pgsql.1748\pgsql.sln" (default target) (1) -> (postgres target) -> .\src\backend\utils\adt\array_selfuncs.c(574): warning C4305: '=' : truncation from 'double' to 'float4' .\src\backend\optimizer\path\costsize.

Re: [HACKERS] Regarding identifying a foreign scan

2012-10-07 Thread Tom Lane
Atri Sharma writes: > Does that mean that using (some) global storage is the cause of the problem? If you're using global storage for state that needs to be replicated per-scan, yes, probably. But it's hard to be sure when you're being so vague about what you're doing. r

Re: [HACKERS] plpgsql_check_function - rebase for 9.3

2012-10-07 Thread Tom Lane
Selena Deckelmann writes: > This also represents my inaugural use of pg_bsd_indent. I ran it on > pl_check.c - which made things mostly better. Happy to try and fix it > up more if someone can explain to me what (if anything) I did > incorrectly when using it. It looks like you didn't give it a t

Re: [HACKERS] 64-bit API for large object

2012-10-07 Thread Tatsuo Ishii
Amit, > Today when I tried to build the latest code on my windows m/c, I got few > errors from the checkin of this patch. > > lo_hton64 (due to -- unint32_t) > .\src\interfaces\libpq\fe-lobj.c(1049) : error C2065: 'uint32_t' : > undeclared identifier > inv_seek (due to -- MAX_LARGE_OBJECT_SI