[HACKERS] Patch for checking file parameters to psql before password prompt

2012-12-02 Thread Alastair Turner
Patch for the changes discussed in http://archives.postgresql.org/pgsql-hackers/2010-10/msg00919.php attached (eventually ...) In summary: If the input file (-f) doesn't exist or the ouput or log files (-o and -l) can't be created psql exits before prompting for a password. Regards, Alastair.

Re: [HACKERS] [PATCH] Patch to fix a crash of psql

2012-12-02 Thread Tatsuo Ishii
I confirmed the problem. Also I confirmed your patch fixes the problem. In addition to this, all the tests in test/mb and test/regress are passed. Fix committed as you proposed(without any message I proposed). Thanks. -- Tatsuo Ishii SRA OSS, Inc. Japan English:

Re: [HACKERS] proposal: separate databases for contrib module testing

2012-12-02 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: I'd like to change the way we set the CONTRIB_TESTDB name for contrib modules. so that each module doesn't wipe out the previous module's test db. Personally I always thought that was a feature not a bug. If we give each one its own DB, there will

Re: [HACKERS] autovacuum truncate exclusive lock round two

2012-12-02 Thread Jan Wieck
Attached is a new patch that addresses most of the points raised in discussion before. 1) Most of the configuration variables are derived from deadlock_timeout now. The check for conflicting lock request interval is deadlock_timeout/10, clamped to 10ms. The try to acquire exclusive lock

Re: [HACKERS] proposal: separate databases for contrib module testing

2012-12-02 Thread Andrew Dunstan
On 12/02/2012 10:05 AM, Tom Lane wrote: Andrew Dunstan and...@dunslane.net writes: I'd like to change the way we set the CONTRIB_TESTDB name for contrib modules. so that each module doesn't wipe out the previous module's test db. Personally I always thought that was a feature not a bug. If

Re: [HACKERS] proposal: separate databases for contrib module testing

2012-12-02 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: On 12/02/2012 10:05 AM, Tom Lane wrote: Personally I always thought that was a feature not a bug. If we give each one its own DB, there will be a couple of dozen databases cluttering the installation at the end of make installcheck, and no

Re: [HACKERS] proposal: separate databases for contrib module testing

2012-12-02 Thread Andrew Dunstan
On 12/02/2012 11:29 AM, Tom Lane wrote: Andrew Dunstan and...@dunslane.net writes: On 12/02/2012 10:05 AM, Tom Lane wrote: Personally I always thought that was a feature not a bug. If we give each one its own DB, there will be a couple of dozen databases cluttering the installation at the

Re: [HACKERS] WIP: index support for regexp search

2012-12-02 Thread Alexander Korotkov
On Fri, Nov 30, 2012 at 6:23 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 30.11.2012 13:20, Alexander Korotkov wrote: On Thu, Nov 29, 2012 at 5:25 PM, Heikki Linnakangashlinnakangas@** vmware.com hlinnakan...@vmware.com wrote: Would it be safe to simply stop short the

Re: [HACKERS] WIP: index support for regexp search

2012-12-02 Thread Alexander Korotkov
On Sat, Dec 1, 2012 at 3:22 PM, Erik Rijkers e...@xs4all.nl wrote: On Fri, November 30, 2012 12:22, Alexander Korotkov wrote: Hi! On Thu, Nov 29, 2012 at 12:58 PM, er e...@xs4all.nl wrote: On Mon, November 26, 2012 20:49, Alexander Korotkov wrote: I ran the simple-minded tests

Re: [HACKERS] WIP: index support for regexp search

2012-12-02 Thread Tom Lane
Alexander Korotkov aekorot...@gmail.com writes: Nice idea to delay expanding colors to characters! Obviously, we should delay expanding inly alphanumerical characters. Because non-alphanumberical characters influence graph structure. Trying to implement... Uh, why would that be? Colors are

Re: [HACKERS] [PATCH 08/14] Store the number of subtransactions in xl_running_xacts separately from toplevel xids

2012-12-02 Thread Simon Riggs
On 15 November 2012 12:07, Simon Riggs si...@2ndquadrant.com wrote: On 14 November 2012 22:17, Andres Freund and...@2ndquadrant.com wrote: To avoid complicating logic we store both, the toplevel and the subxids, in -xip, first -xcnt toplevel ones, and then -subxcnt subxids. That looks good,

Re: [HACKERS] Materialized views WIP patch

2012-12-02 Thread Marko Tiikkaja
Hi Kevin, On Mon, 26 Nov 2012 22:24:33 +0100, Kevin Grittner kgri...@mail.com wrote: Marko Tiikkaja wrote: T2 sees an empty table As far as I know you are the first to notice this behavior. Thanks for pointing it out. I will take a look at the issue; I don't know whether it's something

Re: [HACKERS] Tablespaces in the data directory

2012-12-02 Thread Magnus Hagander
On Sat, Dec 1, 2012 at 6:56 PM, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: Someone just reported a problem when they had created a new tablespace inside the old data directory. I'm sure there can be other issues caused by this as well, but this is mainly a

Re: [HACKERS] Tablespaces in the data directory

2012-12-02 Thread Andrew Dunstan
On 12/02/2012 07:50 PM, Magnus Hagander wrote: On Sat, Dec 1, 2012 at 6:56 PM, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: Someone just reported a problem when they had created a new tablespace inside the old data directory. I'm sure there can be other

Re: [HACKERS] autovacuum stress-testing our system

2012-12-02 Thread Tomas Vondra
On 21.11.2012 19:02, Robert Haas wrote: On Sun, Nov 18, 2012 at 5:49 PM, Tomas Vondra t...@fuzzy.cz wrote: The two main changes are these: (1) The stats file is split into a common db file, containing all the DB Entries, and per-database files with tables/functions. The common file

Re: [HACKERS] Tablespaces in the data directory

2012-12-02 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: RIPEMD160 As there isn't (as far as I know at least) any actual *point* in creating a tablespace inside the main data directory, should we perhaps disallow this in CREATE TABLESPACE? Or at least throw a WARNING if one does it? Sure there is a point

Re: [HACKERS] [PATCH 11/14] Introduce wal decoding via catalog timetravel

2012-12-02 Thread Steve Singer
On 12-11-14 08:17 PM, Andres Freund wrote: I am getting errors like the following when I try to use either your test_decoding plugin or my own (which does even less than yours) LOG: database system is ready to accept connections LOG: autovacuum launcher started WARNING: connecting to

[HACKERS] [PATCH] Patch to fix libecpg.so for isinf missing

2012-12-02 Thread Jiang Guiqing
hi isinf() is not build to libecpg.so if build and install postgresql by source on solaris9. (isinf() is not contained within solaris9 system.) bash-2.05$ nm /usr/local/pgsql/lib/libecpg.so | grep isinf [215] | 0| 0|FUNC |GLOB |0|UNDEF |isinf It(isinf missing) will

Re: [HACKERS] Patch for removng unused targets

2012-12-02 Thread Etsuro Fujita
Sorry for the delay. I've reviewed the patch. It was applied successfully, and it worked well for tests I did including the example you showed. I think it's worth the work, but I'm not sure you go about it in the right way. (I feel the patch decreases code readability more than it gives an

Re: [HACKERS] WIP: index support for regexp search

2012-12-02 Thread Erik Rijkers
On Sun, December 2, 2012 19:07, Alexander Korotkov wrote: I've attached a similar test re-run that compares HEAD with patch versions 0.6, and 0.7. Thanks! Did you write scripts for automated testing? I would be nice if you share them. Sure, here they are. The perl program does depend a