Re: [HACKERS] INSERT...ON DUPLICATE KEY IGNORE

2013-09-02 Thread Peter Geoghegan
On Sun, Sep 1, 2013 at 4:06 AM, Andres Freund wrote: >> We're looking for the first duplicate. So it would probably be okay >> for the IGNORE case to not bother retrying and re-locking if the other >> transaction committed (which, at least very broadly speaking, is the >> likely outcome). > > Hm.

Re: [HACKERS] backup.sgml-cmd-v003.patch

2013-09-02 Thread Karl O. Pinc
On 09/02/2013 10:56:54 PM, Karl O. Pinc wrote: > I have frobbed your to adjust the indentation and > line-wrap style. Oops. Somehow left a \ out of this. Anyhow, you get the idea. Karl Free Software: "You don't pay back, you pay forward." -- Robert A. Heinlein -- Sent

Re: [HACKERS] Further XLogInsert scaling tweaking

2013-09-02 Thread Bruce Momjian
On Mon, Sep 2, 2013 at 10:14:03AM +0300, Heikki Linnakangas wrote: > diff --git a/src/backend/access/transam/xlog.c > b/src/backend/access/transam/xlog.c > index 39c58d0..28e62ea 100644 > --- a/src/backend/access/transam/xlog.c > +++ b/src/backend/access/transam/xlog.c > @@ -428,8 +428,14 @@ type

Re: [HACKERS] dynamic shared memory

2013-09-02 Thread Noah Misch
On Tue, Sep 03, 2013 at 12:52:22AM +0200, Andres Freund wrote: > On 2013-09-01 12:07:04 -0400, Noah Misch wrote: > > On Sun, Sep 01, 2013 at 05:08:38PM +0200, Andres Freund wrote: > > > On 2013-09-01 09:24:00 -0400, Noah Misch wrote: > > > > The difficulty depends on whether processes other than th

Re: [HACKERS] Extension Templates S03E11

2013-09-02 Thread Michael Paquier
On Tue, Sep 3, 2013 at 4:20 AM, David Fetter wrote: > On Mon, Sep 02, 2013 at 02:32:16AM -0400, Peter Eisentraut wrote: >> On Thu, 2013-08-29 at 12:16 +0200, Dimitri Fontaine wrote: >> > Here's v14 of the patch with pg_upgrade support fixed, so that the >> > automated setup that Peter built is abl

Re: [HACKERS] [9.4] Make full_page_writes only settable on server start?

2013-09-02 Thread Peter Geoghegan
On Mon, Sep 2, 2013 at 7:10 PM, Jeff Davis wrote: > I'd like to submit a patch to just make it into a PGC_POSTMASTER and > remove the code to support changing it. Makes sense to me. I wonder, is anyone really running in production with full_page_writes off? I talked to someone a while ago who us

[HACKERS] [9.4] Make full_page_writes only settable on server start?

2013-09-02 Thread Jeff Davis
There is a significant amount of code supporting the changing of full_page_writes while the server is running, including an XLOG_FPW_CHANGE wal record. But I don't see the use-case; surely almost nobody changes this on a running server, because either your filesystem guarantees atomic page writes f

Re: [HACKERS] dynamic shared memory

2013-09-02 Thread Robert Haas
On Mon, Sep 2, 2013 at 6:52 PM, Andres Freund wrote: > Not sure whether you mean non-windows EXEC_BACKEND isn't going to be > supported for much longer or that it already has problems. I'm not sure what Noah was getting at, but I have used EXEC_BACKEND twice now during development, in situations

Re: [HACKERS] 9.3 RC1 psql encoding reporting inconsistently?

2013-09-02 Thread David Johnston
Tom Lane-2 wrote > Michael Nolan < > htfoot@ > > writes: >> This is 9.3 RC1 on a Fedora 7 system. Why does \l report the encoding >> as SQL_ASCII and \set report it as UTF8? > > psql sets client_encoding based on its environment (LANG or related > variables). That's been true for some time ---

Re: [HACKERS] [v9.4] row level security

2013-09-02 Thread Bruce Momjian
On Fri, Aug 30, 2013 at 04:24:06PM -0400, Stephen Frost wrote: > > The scenario I'm worried about is where somebody says "hey, Postgres has > > RLS now, I can rely on that to hide my sooper sekrit data from other users > > in the same database", and later they have a security breach through some >

Re: [HACKERS] ENABLE/DISABLE CONSTRAINT NAME

2013-09-02 Thread David Johnston
Jeff Davis-8 wrote > Is there any semantic difference between marking a constraint as > DISABLED and simply dropping it? Or does it just make it easier to > re-add it later? I cannot answer the question but if there is none then the main concern I'd have is capturing "meta-information" about WHY s

Re: [HACKERS] [v9.4] row level security

2013-09-02 Thread Bruce Momjian
On Sun, Sep 1, 2013 at 11:05:58AM -0700, Josh Berkus wrote: > > Security community also concludes it is not avoidable nature as long > > as human can observe system behavior and estimate something, thus, > > security evaluation criteria does not require eliminate covert-channels > > or does not pa

Re: [HACKERS] 9.3 RC1 psql encoding reporting inconsistently?

2013-09-02 Thread Tom Lane
Michael Nolan writes: > This is 9.3 RC1 on a Fedora 7 system. Why does \l report the encoding > as SQL_ASCII and \set report it as UTF8? psql sets client_encoding based on its environment (LANG or related variables). That's been true for some time --- since 9.1, according to a quick check.

[HACKERS] 9.3 RC1 psql encoding reporting inconsistently?

2013-09-02 Thread Michael Nolan
This is 9.3 RC1 on a Fedora 7 system. Why does \l report the encoding as SQL_ASCII and \set report it as UTF8? psql (9.3rc1) Type "help" for help. postgres=# \l List of databases Name Owner Encoding Collate Ctype Access privileges - - --

Re: [HACKERS] dynamic shared memory

2013-09-02 Thread Andres Freund
Hi Noah! On 2013-09-01 12:07:04 -0400, Noah Misch wrote: > On Sun, Sep 01, 2013 at 05:08:38PM +0200, Andres Freund wrote: > > On 2013-09-01 09:24:00 -0400, Noah Misch wrote: > > > The difficulty depends on whether processes other than the segment's > > > creator > > > will attach anytime or only

Re: [HACKERS] ENABLE/DISABLE CONSTRAINT NAME

2013-09-02 Thread Jeff Davis
On Fri, 2013-08-30 at 09:57 +0800, wangs...@highgo.com.cn wrote: > Hi hackers, > >In order to achieve enable/disable constraint name,I made ​​a few > modifications to the code. > >First, someone used to build the constraints while building > table. Then inserting data must follo

Re: [HACKERS] INSERT...ON DUPLICATE KEY IGNORE

2013-09-02 Thread Peter Geoghegan
On Mon, Sep 2, 2013 at 6:25 AM, Craig Ringer wrote: > It'll be yet another way for people to get upsert wrong, of course. > They'll use a wCTE with RETURNING REJECTS to do an UPDATE of the rejects > w/o locking the table against writes first. Documenting this pitfall > should be enough, though. M

Re: [HACKERS] [GENERAL] currval and DISCARD ALL

2013-09-02 Thread Fabrízio de Royes Mello
On 19-08-2013 16:10, Boszormenyi Zoltan wrote: I am reviewing your patch. Thanks... * Is the patch in a patch format which has context? (eg: context diff format) Yes. * Does it apply cleanly to the current git master? Almost. No rejects, no fuzz, only offset for some files. * Does it i

Re: [HACKERS] Extension Templates S03E11

2013-09-02 Thread David Fetter
On Mon, Sep 02, 2013 at 02:32:16AM -0400, Peter Eisentraut wrote: > On Thu, 2013-08-29 at 12:16 +0200, Dimitri Fontaine wrote: > > Here's v14 of the patch with pg_upgrade support fixed, so that the > > automated setup that Peter built is able to have at it! > > Fails cpluspluscheck: > > In file i

Re: [HACKERS] Freezing without write I/O

2013-09-02 Thread Jeff Davis
On Fri, 2013-08-30 at 20:34 +0200, Andres Freund wrote: > I have a quick question: The reason I'd asked about the status of the > patch was that I was thinking about the state of the "forensic freezing" > patch. After a quick look at your proposal, we still need to freeze in > some situations (old

Re: [HACKERS] Next CFM?

2013-09-02 Thread David Fetter
On Mon, Sep 02, 2013 at 12:00:02PM -0500, Josh Berkus wrote: > Hackers, > > We need a Commit Fest manager for the September CF. I'm not going > to do it; this month is a heavy travel month for me (3 conferences > and a wedding). > > For help, here's the Commitfest Checklist Mike and I assembled:

Re: [HACKERS] max freeze age query in docs

2013-09-02 Thread Andrew Dunstan
On 09/02/2013 02:26 PM, Andres Freund wrote: On 2013-09-02 14:20:57 -0400, Andrew Dunstan wrote: On 09/02/2013 01:30 PM, Tom Lane wrote: Andrew Dunstan writes: Yes, possibly, but we can't do that now, but I would like to fix the docs now. If you want this in 9.3.0 it needs to be committed i

Re: [HACKERS] max freeze age query in docs

2013-09-02 Thread Andres Freund
On 2013-09-02 14:20:57 -0400, Andrew Dunstan wrote: > > On 09/02/2013 01:30 PM, Tom Lane wrote: > >Andrew Dunstan writes: > >>Yes, possibly, but we can't do that now, but I would like to fix the > >>docs now. > >If you want this in 9.3.0 it needs to be committed in the next couple of > >hours. >

Re: [HACKERS] max freeze age query in docs

2013-09-02 Thread Andrew Dunstan
On 09/02/2013 01:30 PM, Tom Lane wrote: Andrew Dunstan writes: Yes, possibly, but we can't do that now, but I would like to fix the docs now. If you want this in 9.3.0 it needs to be committed in the next couple of hours. FWIW, the idea seemed generally sane to me, but I'd suggest not depend

Re: [HACKERS] max freeze age query in docs

2013-09-02 Thread Tom Lane
Andrew Dunstan writes: > Yes, possibly, but we can't do that now, but I would like to fix the > docs now. If you want this in 9.3.0 it needs to be committed in the next couple of hours. FWIW, the idea seemed generally sane to me, but I'd suggest not depending on reltoastrelid being zero when an

Re: [HACKERS] max freeze age query in docs

2013-09-02 Thread Andrew Dunstan
On 09/01/2013 10:33 PM, Josh Berkus wrote: Maybe for bonus points we'd print out the schema (e.g. by selectting c.oid::regclass instead of c.relname), and also include materialized views which are omitted from the query altogether. Given the importance of this, maybe we need to have it as part

[HACKERS] Next CFM?

2013-09-02 Thread Josh Berkus
Hackers, We need a Commit Fest manager for the September CF. I'm not going to do it; this month is a heavy travel month for me (3 conferences and a wedding). For help, here's the Commitfest Checklist Mike and I assembled: https://wiki.postgresql.org/wiki/CommitFest_Checklist Mind you, Peter E.

Re: [HACKERS] INSERT...ON DUPLICATE KEY IGNORE

2013-09-02 Thread Craig Ringer
On 08/31/2013 06:40 AM, Josh Berkus wrote: >> > 3) RETURNING is expanded - "RETURNING REJECTS *" is now possible where >> > that makes sense. > Oh, nifty! OK, now I can *really* use this feature. Absolutely; especially combined with COPY to a staging TEMPORARY or UNLOGGED table. It'll be yet ano

Re: [HACKERS] Extension Templates S03E11

2013-09-02 Thread Dimitri Fontaine
Peter Eisentraut writes: > Fails cpluspluscheck: Turns out I'm discovering that particular check, thanks! I could reproduce and fix the error locally after being led to the command ./src/tools/pginclude/cpluspluscheck. So please find v15 of the patch attached to this email, that passes all previ

Re: [HACKERS] psql and pset without any arguments

2013-09-02 Thread Gilles Darold
Patch added to current open commitfest under the Client section with title: "Call \pset without any arguments displays current status of all printing options" Status: Need review. Let me know if it should not be there. Regards, Le 29/06/2013 01:08, Gilles Darold a écrit : > Hi, > > I was lo

[HACKERS] Further XLogInsert scaling tweaking

2013-09-02 Thread Heikki Linnakangas
Now that I've had a little break from the big XLogInsert scaling patch, I went back to do some testing and profiling of it. I saw a lot of contention on the first access of RedoRecPtr and force/fullPageWrites, which made me realize that I put those variables right next to the heavily-contended