Re: [HACKERS] GiST support for inet datatypes

2013-12-22 Thread David Fetter
On Tue, Dec 17, 2013 at 08:58:13PM +0200, Emre Hasegeli wrote: > Hi, > > Attached patch adds GiST support to the inet datatypes with two new > operators. Overlaps operator can be used with exclusion constraints. > Is adjacent to operator is just the negator of it. Index uses only > the network bit

Re: [HACKERS] [bug fix] pg_ctl always uses the same event source

2013-12-22 Thread Amit Kapila
On Fri, Dec 20, 2013 at 5:26 PM, MauMau wrote: > From: "Amit Kapila" >> >> Few other points: >> >> - >> 1. >> #ifdef WIN32 >> /* Get event source from postgresql.conf for eventlog output */ >> get_config_value("event_source", event_source, sizeof(event_source)); >> #endif

Re: [HACKERS] Issue with PGC_BACKEND parameters

2013-12-22 Thread Amit Kapila
> I had observed one problem with PGC_BACKEND parameters while testing patch > for ALTER SYSTEM command. > Problem statement: If I change PGC_BACKEND parameters directly in > postgresql.conf and then do pg_reload_conf() and reconnect, it will > still show the old value. > Detaile

Re: [HACKERS] XML Issue with DTDs

2013-12-22 Thread Robert Haas
On Fri, Dec 20, 2013 at 8:16 PM, Florian Pflug wrote: > On Dec20, 2013, at 18:52 , Robert Haas wrote: >> On Thu, Dec 19, 2013 at 6:40 PM, Florian Pflug wrote: >>> Solving this seems a bit messy, unfortunately. First, I think we need to >>> have some XMLOPTION value which is a superset of all th

Re: [HACKERS] [PATCH] Make various variables read-only (const)

2013-12-22 Thread Robert Haas
On Fri, Dec 20, 2013 at 12:01 PM, Oskari Saarenmaa wrote: > This allows the variables to be moved from .data to .rodata section which > means that more data can be shared by processes and makes sure that nothing > can accidentally overwrite the read-only definitions. On a x86-64 Linux > system th

Re: [HACKERS] row security roadmap proposal

2013-12-22 Thread Robert Haas
On Wed, Dec 18, 2013 at 10:21 PM, Craig Ringer wrote: > My main worry was that it requires the user to build everything > manually, and is potentially error prone as a result. To address that we > can build convenience features (label security, ACL types and operators, > etc) on top of the same in

Re: [HACKERS] CLUSTER FREEZE

2013-12-22 Thread Robert Haas
On Sun, Dec 8, 2013 at 10:51 AM, Peter Eisentraut wrote: > On Tue, 2013-11-19 at 18:24 +0100, Andres Freund wrote: >> On 2013-11-19 12:23:30 -0500, Robert Haas wrote: >> > On Mon, Nov 18, 2013 at 11:45 AM, Andres Freund >> > wrote: >> > >> Yes, we probably should make a decision, unless Robert's

Re: [HACKERS] preserving forensic information when we freeze

2013-12-22 Thread Robert Haas
On Fri, Dec 20, 2013 at 8:01 AM, Andres Freund wrote: > On 2013-12-20 07:58:46 -0500, Robert Haas wrote: >> I think the immediate problem is to decide whether this patch ought to >> make the xmin column display the result of GetXmin() or GetRawXmin(). >> Thoughts on that? > > I slightly favor GetR

Re: [HACKERS] INSERT...ON DUPLICATE KEY LOCK FOR UPDATE

2013-12-22 Thread Peter Geoghegan
On Fri, Dec 20, 2013 at 11:59 PM, Peter Geoghegan wrote: > I think that the way forward is to refine my design in order to > upgrade locks from exclusive buffer locks to something else, managed > by the lock manager but perhaps through an additional layer of > indirection. As previously outlined,

Re: [HACKERS] PoC: Partial sort

2013-12-22 Thread Alexander Korotkov
On Sat, Dec 14, 2013 at 6:30 PM, Jeremy Harris wrote: > On 14/12/13 12:54, Andres Freund wrote: > >> On 2013-12-14 13:59:02 +0400, Alexander Korotkov wrote: >> >>> Currently when we need to get ordered result from table we have to choose >>> one of two approaches: get results from index in exact

Re: [HACKERS] PoC: Partial sort

2013-12-22 Thread Alexander Korotkov
On Sun, Dec 22, 2013 at 8:12 PM, Martijn van Oosterhout wrote: > On Sun, Dec 22, 2013 at 07:38:05PM +0400, Alexander Korotkov wrote: > > Hi! > > > > Next revision. It expected to do better work with optimizer. It > introduces > > presorted_keys argument of cost_sort function which represent number

Re: [HACKERS] WITHIN GROUP patch

2013-12-22 Thread Tom Lane
I wrote: > ... So my reaction to this example is not > that we should hack the behavior for plain ordered-set aggregates, > but that we ought to find a rule that allows result-collation > determination for hypotheticals. We speculated upthread about > "merge the collations normally, but ignore inp

Re: [HACKERS] WITHIN GROUP patch

2013-12-22 Thread Tom Lane
Andrew Gierth writes: > The examples I've thought of which would return collatable types are > all ones that would be implemented as plain ordered set functions even > if their logic was in some sense hypothetical. For example you could > envisage a value_prec(x) within group (order by y) that ret

Re: [HACKERS] PoC: Partial sort

2013-12-22 Thread Martijn van Oosterhout
On Sun, Dec 22, 2013 at 07:38:05PM +0400, Alexander Korotkov wrote: > Hi! > > Next revision. It expected to do better work with optimizer. It introduces > presorted_keys argument of cost_sort function which represent number of > keys already sorted in Path. Then this function uses estimate_num_gro

Re: [HACKERS] ALTER SYSTEM SET command to change postgresql.conf parameters

2013-12-22 Thread Amit Kapila
On Sun, Dec 22, 2013 at 3:01 PM, Fujii Masao wrote: > I found the bug of ALTER SYSTEM SET patch. The procedure to reproduce > it is here. > > $ psql > =# ALTER SYSTEM SET shared_buffers = '512MB'; > ALTER SYSTEM > =# \q > $ pg_ctl -D data reload > server signaled > 2013-12-22 18:24:13 JST LOG: re

Re: [HACKERS] WITHIN GROUP patch

2013-12-22 Thread Andrew Gierth
> "Tom" == Tom Lane writes: Tom> I eventually decided that we were overthinking this problem. At Tom> least for regular ordered-set aggregates, we can just deem that Tom> the collation of the aggregate is indeterminate unless all the Tom> inputs (both direct and aggregated) agree on the

Re: [HACKERS] [bug fix] multibyte messages are displayed incorrectly on the client

2013-12-22 Thread MauMau
From: "Noah Misch" Better to attack that directly. Arrange to apply any client_encoding named in the startup packet earlier, before authentication. This relates to the TODO item "Let the client indicate character encoding of database names, user names, and passwords". (I expect such an ende

Re: [HACKERS] ALTER SYSTEM SET command to change postgresql.conf parameters

2013-12-22 Thread Fujii Masao
On Fri, Dec 20, 2013 at 2:35 AM, Fujii Masao wrote: > On Thu, Dec 19, 2013 at 2:21 PM, Tatsuo Ishii wrote: >>> I found that the psql tab-completion for ALTER SYSTEM SET has not been >>> implemented yet. >>> Attached patch does that. Barring any objections, I will commit this patch. >> >> Good cat