Re: [HACKERS] gaussian distribution pgbench

2014-02-23 Thread Fabien COELHO
Gaussian Pgbench v8 patch by Mitsumasa KONDO review patch v9. * The purpose of the patch is to allow a pgbench script to draw from normally distributed or exponentially distributed integer values instead of uniformly distributed. This is a valuable contribution to enable pgbench to

[HACKERS] Should PostgresMain() do a LWLockReleaseAll()?

2014-02-23 Thread Andres Freund
Hi, Currently the error handling of normal backends only does a LWLockReleaseAll() once CurrentTransactionState-state != TRANS_DEFAULT because it's called in AbortTransaction(). There's pretty damn few places that fiddle with lwlocks outside of a transaction command, but I still do wonder whether

[HACKERS] often PREPARE can generate high load (and sometimes minutes long unavailability)

2014-02-23 Thread Pavel Stehule
Hello I got a example of code, that generate relatively high load with minimal connections. This code is +/- bad - it repeatedly generate prepare statement, but somewhere uses prepared statements as protections against SQL injections and they can use same use case. Pseudocode (I can send a test

Re: [HACKERS] often PREPARE can generate high load (and sometimes minutes long unavailability)

2014-02-23 Thread Jeff Janes
On Sun, Feb 23, 2014 at 11:04 AM, Pavel Stehule pavel.steh...@gmail.comwrote: Hello I got a example of code, that generate relatively high load with minimal connections. This code is +/- bad - it repeatedly generate prepare statement, but somewhere uses prepared statements as protections

Re: [HACKERS] Should PostgresMain() do a LWLockReleaseAll()?

2014-02-23 Thread Tom Lane
Andres Freund and...@2ndquadrant.com writes: Currently the error handling of normal backends only does a LWLockReleaseAll() once CurrentTransactionState-state != TRANS_DEFAULT because it's called in AbortTransaction(). There's pretty damn few places that fiddle with lwlocks outside of a

Re: [HACKERS] often PREPARE can generate high load (and sometimes minutes long unavailability)

2014-02-23 Thread Pavel Stehule
2014-02-23 20:35 GMT+01:00 Jeff Janes jeff.ja...@gmail.com: On Sun, Feb 23, 2014 at 11:04 AM, Pavel Stehule pavel.steh...@gmail.comwrote: Hello I got a example of code, that generate relatively high load with minimal connections. This code is +/- bad - it repeatedly generate prepare

Re: [HACKERS] often PREPARE can generate high load (and sometimes minutes long unavailability)

2014-02-23 Thread Pavel Stehule
2014-02-23 20:35 GMT+01:00 Jeff Janes jeff.ja...@gmail.com: On Sun, Feb 23, 2014 at 11:04 AM, Pavel Stehule pavel.steh...@gmail.comwrote: Hello I got a example of code, that generate relatively high load with minimal connections. This code is +/- bad - it repeatedly generate prepare

Re: [BUGS] Re: [HACKERS] Re: BUG #9210: PostgreSQL string store bug? not enforce check with correct characterSET/encoding

2014-02-23 Thread Tom Lane
Noah Misch n...@leadboat.com writes: On Fri, Feb 21, 2014 at 05:20:06PM -0500, Tom Lane wrote: ... However, I think there's a case to be made for adding the additional pg_verify_mbstr() calls in the back branches. We've been promising since around 8.3 that invalidly encoded data can't get

Re: [HACKERS] Should PostgresMain() do a LWLockReleaseAll()?

2014-02-23 Thread Andres Freund
On 2014-02-23 14:48:12 -0500, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: Currently the error handling of normal backends only does a LWLockReleaseAll() once CurrentTransactionState-state != TRANS_DEFAULT because it's called in AbortTransaction(). There's pretty damn few

Re: [HACKERS] often PREPARE can generate high load (and sometimes minutes long unavailability)

2014-02-23 Thread Andres Freund
Hi, On 2014-02-23 20:04:39 +0100, Pavel Stehule wrote: There is relative few very long ProcArrayLocks lwlocks This issue is very pathologic on fast computers with more than 8 CPU. This issue was detected after migration from 8.4 to 9.2. (but tested with same result on 9.0) I see it on

Re: [HACKERS] SSL: better default ciphersuite

2014-02-23 Thread Marko Kreen
On Sat, Feb 22, 2014 at 08:31:14PM -0500, Peter Eisentraut wrote: On 2/2/14, 7:16 AM, Marko Kreen wrote: On Thu, Dec 12, 2013 at 04:32:07PM +0200, Marko Kreen wrote: Attached patch changes default ciphersuite to HIGH:MEDIUM:+3DES:!aNULL and also adds documentation about reasoning for it.

Re: [HACKERS] GiST support for inet datatypes

2014-02-23 Thread Andreas Karlsson
On 02/06/2014 06:14 PM, Emre Hasegeli wrote: Third versions of the patches attached. They are rebased to the HEAD. In this versions, the bitncommon function is changed. sys/socket.h included to network_gist.c to be able to compile it on FreeBSD. Geometric mean calculation for partial bucket

Re: [HACKERS] jsonb and nested hstore

2014-02-23 Thread Josh Berkus
Teodor, Oleg: Some bitrot on the nested-hstore patch on current HEAD, possibly due to the recent update release? josh@radegast:~/git/pg94$ patch -p1 -i nested-hstore-10.patch patching file contrib/hstore/.gitignore patching file contrib/hstore/Makefile patching file contrib/hstore/crc32.c

Re: contrib/cache_scan (Re: [HACKERS] What's needed for cache-only table scan?)

2014-02-23 Thread Haribabu Kommi
On Fri, Feb 21, 2014 at 2:19 AM, Kohei KaiGai kai...@kaigai.gr.jp wrote: Hello, The attached patch is a revised one for cache-only scan module on top of custom-scan interface. Please check it. Thanks for the revised patch. Please find some minor comments. 1. memcpy(dest, tuple,

Re: [HACKERS] [review] PostgreSQL Service on Windows does not start if data directory given is relative path

2014-02-23 Thread Rajeev rastogi
On 22 February 2014 06:16, MauMau Wrote: Thanks for reviewing again. Please make small cosmetic changes so that make_absolute_path() follows the style of other parts. Then I'll make this ready for committer. (1) Add the function name in the comment as in: /* * make_absolute_path *

Re: [HACKERS] jsonb and nested hstore

2014-02-23 Thread Josh Berkus
All, Here's a draft cleanup on the JSON section of the Datatype docs. Since there's been a bunch of incremental patches on this, I just did a diff against HEAD. I looked over json-functions a bit, but am not clear on what needs to change there; the docs are pretty similar to other sections of

[HACKERS] varchar_transform

2014-02-23 Thread Mohsen SM
when did use varchar_transform function? src/backend/uitls/adt/varchar.c.