Re: [HACKERS] New Event Trigger: table_rewrite

2014-11-19 Thread Alvaro Herrera
Michael Paquier wrote: 1) Couldn't this paragraph be reworked? para +The literaltable_rewrite/ event occurs just before a table is going to +get rewritten by the commands literalALTER TABLE/literal. While other +control statements are available to rewrite a table, +

Re: [HACKERS] Bugfix and new feature for PGXS

2014-11-19 Thread Peter Eisentraut
On 6/18/13 9:52 AM, Cédric Villemain wrote: 0006-Fix-suggested-layout-for-extension.patch I have committed this patch. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] On partitioning

2014-11-19 Thread Amit Langote
Robert, I thought putting the partition boundaries into pg_inherits was a strange choice. I'd put it in pg_class, or in pg_partition if we decide to create that. Hmm, yeah I guess we are better off using pg_inherits for just saying that a partition is an inheritance child. Other details

Re: [HACKERS] GIN pageinspect functions

2014-11-19 Thread Michael Paquier
On Wed, Nov 19, 2014 at 7:01 AM, Peter Geoghegan p...@heroku.com wrote: On Tue, Nov 4, 2014 at 7:26 AM, Amit Kapila amit.kapil...@gmail.com wrote: I think these functions will be quite useful for debugging purpose and we already have similar function's for other index (btree). This patch has

[HACKERS] Nitpicky doc corrections for BRIN functions of pageinspect

2014-11-19 Thread Michael Paquier
Hi all, Just a small thing I noticed while looking at pageinspect.sgml, the set of SQL examples related to BRIN indexes uses lower-case characters for reserved keywords. This has been introduced by 7516f52. Patch is attached. Regards, -- Michael diff --git a/doc/src/sgml/pageinspect.sgml

Re: [HACKERS] Nitpicky doc corrections for BRIN functions of pageinspect

2014-11-19 Thread Peter Geoghegan
On Wed, Nov 19, 2014 at 8:02 PM, Michael Paquier michael.paqu...@gmail.com wrote: Just a small thing I noticed while looking at pageinspect.sgml, the set of SQL examples related to BRIN indexes uses lower-case characters for reserved keywords. This has been introduced by 7516f52. Patch is

Re: [HACKERS] Bugfix and new feature for PGXS

2014-11-19 Thread Peter Eisentraut
On 1/31/14 9:28 PM, Bruce Momjian wrote: On Fri, Jan 31, 2014 at 09:28:06PM -0500, Andrew Dunstan wrote: On 01/31/2014 09:19 PM, Bruce Momjian wrote: On Thu, Oct 10, 2013 at 11:00:30PM -0400, Andrew Dunstan wrote: On 10/10/2013 09:35 PM, Peter Eisentraut wrote: On Tue, 2013-10-08 at 10:04

Re: [HACKERS] What exactly is our CRC algorithm?

2014-11-19 Thread Abhijit Menon-Sen
At 2014-11-19 19:12:22 +0200, hlinnakan...@vmware.com wrote: But pg_xlogdump's way of using the CRC isn't necessarily representative of how the backend uses it. It's probably pretty close to WAL replay in the server, but even there the server might be hurt more by the extra cache used by the

Re: [HACKERS] group locking: incomplete patch, just for discussion

2014-11-19 Thread Amit Kapila
On Wed, Nov 19, 2014 at 9:33 PM, Robert Haas robertmh...@gmail.com wrote: On Tue, Nov 18, 2014 at 4:40 AM, Jeff Davis pg...@j-davis.com wrote: To reiterate the basic problem here, if we do nothing at all about the lock manager, a parallel backend can stall trying to grab an

Re: [HACKERS] alternative model for handling locking in parallel groups

2014-11-19 Thread Amit Kapila
On Wed, Nov 19, 2014 at 8:56 PM, Robert Haas robertmh...@gmail.com wrote: On Tue, Nov 18, 2014 at 8:53 AM, Amit Kapila amit.kapil...@gmail.com wrote: Won't this be addressed because both updates issued from myfunc() are considered as separate commands, so w.r.t lock it should behave as 2

Re: [HACKERS] INSERT ... ON CONFLICT {UPDATE | IGNORE}

2014-11-19 Thread Anssi Kääriäinen
On Wed, 2014-11-19 at 16:52 -0800, Peter Geoghegan wrote: Someone mentioned to me privately that they weren't sure that the question of whether or not RETURNING only projected actually inserted tuples was the right one. Also, I think someone else mentioned this a few months back. I'd like to

[HACKERS] T_CustomScan on ExplainTargetRel

2014-11-19 Thread Kouhei Kaigai
Hello, The attached obvious patch adds T_CustomScan on case-switch of ExplainTargetRel() that was oversight. It looked like working, but what it did was just printing referenced name, instead of table name. postgres=# explain select ctid, * from t0 hoge where ctid '(50,0)'::tid;

Re: [HACKERS] T_CustomScan on ExplainTargetRel

2014-11-19 Thread Kouhei Kaigai
BTW, I published the 'ctidscan' module below as an example of custom-scan. https://github.com/kaigai/ctidscan -- NEC OSS Promotion Center / PG-Strom Project KaiGai Kohei kai...@ak.jp.nec.com -Original Message- From: pgsql-hackers-ow...@postgresql.org

Re: [HACKERS] pg_basebackup vs. Windows and tablespaces

2014-11-19 Thread Amit Kapila
On Wed, Nov 19, 2014 at 11:46 PM, Robert Haas robertmh...@gmail.com wrote: On Tue, Nov 18, 2014 at 9:19 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Right, but they provide same functionality as symlinks and now we are even planing to provide this feature for both linux and windows as

<    1   2