On 12/19/2014 11:30 AM, Petr Jelinek wrote:
as promised I am sending code-comment patch that explains the use of
commit timestamps + nodeid C api for the conflict resolution, comments
welcome.
That's a little bit better, but I have to say I'm still not impressed.
There are so many implicit
On 2014-12-29 12:06:07 +0200, Heikki Linnakangas wrote:
That's a little bit better, but I have to say I'm still not impressed. There
are so many implicit assumptions in the system. The first assumption is that
a 32-bit node id is sufficient.
Seriously? Are we going to build facilities for
On 29/12/14 11:16, Andres Freund wrote:
On 2014-12-29 12:06:07 +0200, Heikki Linnakangas wrote:
That's a little bit better, but I have to say I'm still not impressed. There
are so many implicit assumptions in the system. The first assumption is that
a 32-bit node id is sufficient.
Seriously?
On 12/29/2014 12:39 PM, Petr Jelinek wrote:
On 29/12/14 11:16, Andres Freund wrote:
On 2014-12-29 12:06:07 +0200, Heikki Linnakangas wrote:
To be honest, I think this patch should be reverted. Instead, we should
design a system where extensions can define their own SLRUs to store
additional
On 12/26/2014 09:31 AM, Fujii Masao wrote:
Hi,
While reviewing FPW compression patch, I found that allocate_recordbuf()
always returns TRUE though its source code comment says that FALSE is
returned if out of memory. Its return value is checked in two places, but
which is clearly useless.
Hi.
I've changed pgaudit to work as you suggested.
A quick note on the implementation: pgaudit was already installing an
ExecutorCheckPerms_hook anyway; I adapted code from ExecRTECheckPerms
to check if the audit role has been granted any of the permissions
required for the operation.
This
On 2014-12-29 12:50:23 +0200, Heikki Linnakangas wrote:
On 12/29/2014 12:39 PM, Petr Jelinek wrote:
On 29/12/14 11:16, Andres Freund wrote:
On 2014-12-29 12:06:07 +0200, Heikki Linnakangas wrote:
To be honest, I think this patch should be reverted. Instead, we should
design a system where
Hi,
On 2014-12-25 11:57:29 +0530, Abhijit Menon-Sen wrote:
-extern pg_crc32 pg_comp_crc32c(pg_crc32 crc, const void *data, size_t len);
+extern void pg_init_comp_crc32c(void);
How about pg_choose_crc_impl() or something?
+extern pg_crc32 (*pg_comp_crc32c)(pg_crc32 crc, const void *data,
At 2014-12-29 13:22:28 +0100, and...@2ndquadrant.com wrote:
How about pg_choose_crc_impl() or something?
Done.
_sb8? Unless I miss something it's not slice by 8 but rather bytewise?
This is meant to apply on top of the earlier patches I posted to
implement slice-by-8. I'll attach both here.
Merlin Moncure mmonc...@gmail.com wrote:
On Fri, Dec 26, 2014 at 12:38 PM, Kevin Grittner kgri...@ymail.com wrote:
Tom Lane t...@sss.pgh.pa.us wrote:
Just for starters, a 40XXX error report will fail to provide the
duplicated key's value. This will be a functional regression,
Not if, as is
On Mon, Dec 29, 2014 at 8:03 AM, Kevin Grittner kgri...@ymail.com wrote:
Merlin Moncure mmonc...@gmail.com wrote:
On Fri, Dec 26, 2014 at 12:38 PM, Kevin Grittner kgri...@ymail.com
wrote:
Tom Lane t...@sss.pgh.pa.us wrote:
Just for starters, a 40XXX error report will fail to provide the
2014-12-29 14:38 GMT+07:00 Jeff Davis pg...@j-davis.com:
Just jumping into this patch now. Do we think this is worth changing the
signature of functions in array.h, which might be used from a lot of
third-party code? We might want to provide new functions to avoid a
breaking change.
V6
Merlin Moncure mmonc...@gmail.com wrote:
Well, I'm arguing that duplicate key errors are not serialization
failures unless it's likely the insertion would succeed upon a retry;
a proper insert, not an upsert. If that's the case with what you're
proposing, then it makes sense to me. But
Craig Ringer cr...@2ndquadrant.com wrote:
I don't see how that'd necessarily correctly identify the
query/queries in the other tx that're involved, though.
Perhaps I'm thinking in terms of more complicated serialization
failures?
Yeah, it might be possible to provide useful information
On Mon, Dec 29, 2014 at 9:09 AM, Kevin Grittner kgri...@ymail.com wrote:
Merlin Moncure mmonc...@gmail.com wrote:
In other words, the current behavior is:
txn A,B begin
txn A inserts
txn B inserts over A, locks, waits
txn A commits. B aborts with duplicate key error
What I'm proposing is
On Mon, Dec 29, 2014 at 3:31 PM, Merlin Moncure mmonc...@gmail.com wrote:
In that case: we don't agree. How come duplicate key errors would be
reported as serialization failures but not RI errors (for example,
inserting a record pointing to another record which a concurrent
transaction
Hey,
There are times where I would need more informations on the autovacuum
processes.
I'd love to know what each worker is currently doing. I can get something
like this from the pg_stat_activity view but it doesn't give me as much
informations as the WorkerInfoData struct.
I'd also love to
Guillaume Lelarge guilla...@lelarge.info writes:
All in all, I want to get informations that are typically stored in shared
memory, handled by the autovacuum launcher and autovacuum workers. I first
thought I could get that by writing some C functions embedded in an
extension. But it doesn't
2014-12-29 17:03 GMT+01:00 Tom Lane t...@sss.pgh.pa.us:
Guillaume Lelarge guilla...@lelarge.info writes:
All in all, I want to get informations that are typically stored in
shared
memory, handled by the autovacuum launcher and autovacuum workers. I
first
thought I could get that by
On Mon, Dec 29, 2014 at 9:44 AM, Greg Stark st...@mit.edu wrote:
On Mon, Dec 29, 2014 at 3:31 PM, Merlin Moncure mmonc...@gmail.com wrote:
In that case: we don't agree. How come duplicate key errors would be
reported as serialization failures but not RI errors (for example,
inserting a record
Merlin Moncure mmonc...@gmail.com wrote:
Serialization errors only exist as a concession to concurrency
and performance. Again, they should be returned as sparsely as
possible because they provide absolutely (as Tom pointed
out) zero detail to the application.
That is false. They provide
[combining replies -- nikita, better not to top-post (FYI)]
I'm sorry. I don't know what you mean. I just replied to an email.
To prove your statement, you need to demonstrate how a transaction left
the database in a bad state given concurrent activity without counting
failures.
1.
I believe, the objections expressed in this thread miss a very important
point of all this: the isolation property (the I in ACID) is violated.
Here’s a quote from the Wikipedia article on ACID
http://en.wikipedia.org/wiki/ACID:
The isolation property ensures that the concurrent execution of
Alvaro Herrera wrote:
Patch 0005 adds getObjectIdentityParts(), which returns the object
identity in arrays that can be passed to pg_get_object_address. This
part needs slight revisions so I'm not sure I will be able to push
tomorrow.
Here's a fresh version of this patch. I chose to add a
(The changes in the regression test are bogus, BTW; I didn't care enough
to get them fixed before sorting out the rest of the mess.)
--
Álvaro Herrerahttp://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training Services
commit
Adrian Klaver adrian.kla...@aklaver.com writes:
So it seems you can turn ON_ERROR_ROLLBACK on with either 1 or 'on', but you
can only turn it off with 'off'.
With ON_ERROR_STOP 1/on and 0/off both seem to work.
Is this expected?
on_error_stop_hook() uses ParseVariableBool, while
On Sun, Dec 28, 2014 at 12:31 PM, Michael Paquier michael.paqu...@gmail.com
wrote:
Hi all,
While reviewing another patch, I have noticed that
recovery_min_apply_delay can have a negative value. And the funny part is
that we actually attempt to apply a delay even in this case, per se this
On Mon, Dec 29, 2014 at 10:47 AM, Nikita Volkov nikita.y.vol...@mail.ru wrote:
[combining replies -- nikita, better not to top-post (FYI)]
[combining replied again]
I'm sorry. I don't know what you mean. I just replied to an email.
http://www.idallen.com/topposting.html
To prove your
On 12/29/2014 09:55 AM, Tom Lane wrote:
Adrian Klaver adrian.kla...@aklaver.com writes:
So it seems you can turn ON_ERROR_ROLLBACK on with either 1 or 'on', but you
can only turn it off with 'off'.
With ON_ERROR_STOP 1/on and 0/off both seem to work.
Is this expected?
Given the lack
Magnus,
Thanks for the feedback.
BACKUP - allows role to perform pg_dump* backups of whole database.
I'd suggest it's called DUMP if that's what it allows, to keep it separate
from the backup parts.
Makes sense to me.
That seems really bad names, IMHO. Why? Because we use WAL and XLOG
Merlin Moncure mmonc...@gmail.com wrote:
On Mon, Dec 29, 2014 at 10:53 AM, Kevin Grittner kgri...@ymail.com wrote:
The semantics are so imprecise that Tom argued that we should
document that transactions should be retried from the start when
you get the duplicate key error, since it *might*
On Sat, Dec 27, 2014 at 08:05:42PM -0500, Robert Haas wrote:
On Wed, Dec 24, 2014 at 11:20 AM, Andres Freund and...@2ndquadrant.com
wrote:
I just verified that I can still reproduce the problem:
# aligned case (max_connections=401)
afreund@axle:~$ pgbench -P 1 -h /tmp/ -p5440 postgres
[errata]
Kevin Grittner kgri...@ymail.com wrote:
Quoting from the peer-reviewed paper presented in Istanbul[1]:
That should have been [3], not [1].
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
Adam,
* Adam Brightwell (adam.brightw...@crunchydatasolutions.com) wrote:
I'd suggest it's called DUMP if that's what it allows, to keep it separate
from the backup parts.
Makes sense to me.
I'm fine calling it 'DUMP', but for different reasons.
We have no (verifiable) idea what client
Here's a patch that tweaks the grammar to use TypeName in COMMENT,
SECURITY LABEL, and DROP for the type and domain cases. The required
changes in the code are pretty minimal, thankfully. Note the slight
changes to the new object_address test also.
I think I'm pretty much done with this now, so
On 12/28/14, 2:56 AM, Craig Ringer wrote:
On 12/25/2014 02:35 AM, Euler Taveira wrote:
Hi,
Currently the same message goes to server log and client app. Sometimes
it bothers me since I have to analyze server logs and discovered that
lc_messages is set to pt_BR and to worse things that
On 12/28/14, 2:45 PM, Peter Geoghegan wrote:
On Sun, Dec 28, 2014 at 12:37 PM, Jeff Davis pg...@j-davis.com wrote:
Do others have similar numbers? I'm quite surprised at how little
work_mem seems to matter for these plans (HashJoin might be a different
story though). I feel like I made a
Hi Jeff,
On Mon, Dec 29, 2014 at 2:29 PM, Jeff Janes jeff.ja...@gmail.com wrote:
Using the vallock2 version of V1.8, using the test I previously described, I
get some all-null rows, which my code should never create. Also, the index
and table don't agree, in this example I find 3 all-null
On 2014-12-29 16:59:05 -0500, Bruce Momjian wrote:
I am glad someone else considers this important.
I do consider it important. I just considered the lwlock scalability
more important...
Andres reported the above 2x pgbench difference in February, but no
action was taken as everyone felt
All,
On Sat, Dec 27, 2014 at 6:31 PM, Noah Misch n...@leadboat.com wrote:
On Sat, Dec 27, 2014 at 06:26:02PM -0500, Tom Lane wrote:
Stephen Frost sfr...@snowman.net writes:
* Tom Lane (t...@sss.pgh.pa.us) wrote:
Plan C (remove CATUPDATE altogether) also has some merit. But adding
a
On 12/29/14, 10:53 AM, Kevin Grittner wrote:
Merlin Moncure mmonc...@gmail.com wrote:
Serialization errors only exist as a concession to concurrency
and performance. Again, they should be returned as sparsely as
possible because they provide absolutely (as Tom pointed
out) zero detail to the
-BEGIN PGP SIGNED MESSAGE-
Hash: RIPEMD160
I am working on enhancing the ping() method of DBD::Pg. The goal of that
is for a user to be able to determine if the connection to the database
is still valid. The basic way we do this is to send a simple SELECT via
PQexec and then check for
On 12/29/14, 4:01 PM, Stephen Frost wrote:
Adam,
* Adam Brightwell (adam.brightw...@crunchydatasolutions.com) wrote:
I'd suggest it's called DUMP if that's what it allows, to keep it separate
from the backup parts.
Makes sense to me.
I'm fine calling it 'DUMP', but for different reasons.
Greg == Greg Sabino Mullane g...@turnstep.com writes:
Greg I am working on enhancing the ping() method of DBD::Pg. The
Greg goal of that is for a user to be able to determine if the
Greg connection to the database is still valid. The basic way we do
Greg this is to send a simple SELECT via
Jim,
* Jim Nasby (jim.na...@bluetreble.com) wrote:
On 12/29/14, 4:01 PM, Stephen Frost wrote:
That said, a 'DUMP' privilege which allows the user to dump the contents
of the entire database is entirely reasonable. We need to be clear in
the documentation though- such a 'DUMP' privilege is
Adam,
* Adam Brightwell (adam.brightw...@crunchydatasolutions.com) wrote:
Given this discussion, I have attached a patch that removes CATUPDATE for
review/discussion.
Thanks!
One of the interesting behaviors (or perhaps not) is how 'pg_class_aclmask'
handles an invalid role id when checking
On 12/30/2014 06:39 AM, Jim Nasby wrote:
How much of this issue is caused by trying to machine-parse log files?
Is a better option to improve that case, possibly doing something like
including a field in each line that tells you the encoding for that entry?
That'd be absolutely ghastly. You
On 12/29/14, 6:43 PM, Greg Sabino Mullane wrote:
I am working on enhancing the ping() method of DBD::Pg. The goal of that
is for a user to be able to determine if the connection to the database
is still valid.
This is actually a VERY common thing for monitoring frameworks to do.
Currently,
On 12/29/14, 7:22 PM, Stephen Frost wrote:
One other point is that this shouldn't imply any other privileges, imv.
I'm specifically thinking of BYPASSRLS- that's independently grantable
and therefore should be explicitly set, if it's intended. Things
should work 'sanely' with any combination
On Mon, Dec 29, 2014 at 2:29 PM, Jeff Janes jeff.ja...@gmail.com wrote:
I've attached an example output of querying via index and via full table
scan, and also the pageinspect output of the blocks which have the 3 rows,
in case that is helpful.
You might have also included output from
Hi.
I'm re-attaching the two patches as produced by format-patch. I haven't
listed any reviewers. It's either just Andres, or maybe a lot of people.
Is anyone in a position to try out the patches on MSVC and see if they
build and work sensibly, please? (Otherwise it may be better to remove
those
On Mon, Dec 29, 2014 at 9:12 PM, Peter Geoghegan p...@heroku.com wrote:
On Mon, Dec 29, 2014 at 2:29 PM, Jeff Janes jeff.ja...@gmail.com wrote:
Using the vallock2 version of V1.8, using the test I previously
described, I
get some all-null rows, which my code should never create. Also, the
52 matches
Mail list logo
