Re: [HACKERS] improving speed of make check-world

2015-03-08 Thread Michael Paquier
On Sun, Mar 8, 2015 at 10:46 PM, Michael Paquier wrote: > Speaking of which, attached is a patch rewritten in-line with those > comments, simplifying a bit the whole at the same time. Note this > patch changes ecpgcheck as it should be patched, but as ecpgcheck test > is broken even on HEAD, I'll

Re: [HACKERS] improving speed of make check-world

2015-03-08 Thread Michael Paquier
On Sun, Mar 8, 2015 at 10:22 PM, Peter Eisentraut wrote: > On 2/24/15 3:06 AM, Michael Paquier wrote: >> On Sun, Feb 15, 2015 at 11:01 AM, Peter Eisentraut wrote: >>> Here is an updated patch. >> >> Nice patch. This is going to save a lot of resources. >> >> An update of vcregress.pl is necessary.

Re: [HACKERS] polymorphic types - enforce casting to most common type automatically

2015-03-08 Thread Pavel Stehule
2015-03-08 19:31 GMT+01:00 Pavel Stehule : > Hi > > I am sending a proof concept. Current implementation is not suboptimal - I > wrote this code for demonstration of current issues, and checking possible > side effects of changes in this patch. > I am sorry - typo " Current implementation (patch)

Re: [HACKERS] [REVIEW] Re: Compression of full-page-writes

2015-03-08 Thread Fujii Masao
On Mon, Feb 16, 2015 at 9:08 PM, Andres Freund wrote: > On 2015-02-16 20:55:20 +0900, Michael Paquier wrote: >> On Mon, Feb 16, 2015 at 8:30 PM, Syed, Rahila >> wrote: >> >> > >> > Regarding the sanity checks that have been added recently. I think that >> > they are useful but I am suspecting as

Re: [HACKERS] TABLESAMPLE patch

2015-03-08 Thread Amit Kapila
On Sat, Mar 7, 2015 at 10:37 PM, Petr Jelinek wrote: > > On 05/03/15 09:21, Amit Kapila wrote: >> >> On Tue, Feb 17, 2015 at 3:29 AM, Petr Jelinek > > wrote: >> > >> > >> > I didn't add the whole page visibility caching as the tuple ids we >> get from sampling metho

Re: [HACKERS] Join push-down support for foreign tables

2015-03-08 Thread Ashutosh Bapat
On Mon, Mar 9, 2015 at 5:46 AM, Kouhei Kaigai wrote: > Hi Ashutosh, > > Thanks for finding out what we oversight. > Here is still a problem because the new 'relids' field is not updated > on setrefs.c (scanrelid is incremented by rtoffset here). > It is easy to shift the bitmapset by rtoffset, ho

[HACKERS] Rethinking the parameter access hooks for plpgsql's benefit

2015-03-08 Thread Tom Lane
We already knew that plpgsql's setup_param_list() is a bit of a performance hog. Trying to improve that was the primary motivation behind commit f4e031c662a6b600b786c4849968a099c58fcce7 (the bms_next_member business), though that was just micro-optimization rather than any fundamental rethink of h

Re: [HACKERS] Bootstrap DATA is a pita

2015-03-08 Thread Andrew Dunstan
On 03/08/2015 10:11 PM, Alvaro Herrera wrote: Tom Lane wrote: Andres Freund writes: And even if it turns out to actually be bothersome, you can help yourself by passing -U 5/setting diff.context = 5 or something like that. Um. Good luck with getting every patch submitter to do that. Can we

Re: [HACKERS] Bootstrap DATA is a pita

2015-03-08 Thread Alvaro Herrera
Tom Lane wrote: > Andres Freund writes: > > And even if it turns out to actually be bothersome, you can help > > yourself by passing -U 5/setting diff.context = 5 or something like > > that. > > Um. Good luck with getting every patch submitter to do that. Can we do it centrally somehow? -- Á

Re: [HACKERS] Strange debug message of walreciver?

2015-03-08 Thread Tatsuo Ishii
> On Sun, Mar 8, 2015 at 8:13 PM, Tatsuo Ishii wrote: >> >> > On Sat, Mar 7, 2015 at 10:18 PM, Tatsuo Ishii > wrote: >> >> >> >> When I set log_min_messages to debug5 and looked into walreciver log, >> >> I saw this: >> >> >> >> 3600 2015-03-08 09:47:38 JST DEBUG: sendtime 2015-03-08 >> > 09:47:

Re: [HACKERS] Strange debug message of walreciver?

2015-03-08 Thread Fabrízio de Royes Mello
On Sun, Mar 8, 2015 at 8:13 PM, Tatsuo Ishii wrote: > > > On Sat, Mar 7, 2015 at 10:18 PM, Tatsuo Ishii wrote: > >> > >> When I set log_min_messages to debug5 and looked into walreciver log, > >> I saw this: > >> > >> 3600 2015-03-08 09:47:38 JST DEBUG: sendtime 2015-03-08 > > 09:47:38.31493+09

Re: [HACKERS] Join push-down support for foreign tables

2015-03-08 Thread Kouhei Kaigai
Hi Ashutosh, Thanks for finding out what we oversight. Here is still a problem because the new 'relids' field is not updated on setrefs.c (scanrelid is incremented by rtoffset here). It is easy to shift the bitmapset by rtoffset, however, I also would like to see another approach. My idea adds 'L

Re: [HACKERS] Clamping reulst row number of joins.

2015-03-08 Thread Tom Lane
I wrote: >> Stephen Frost writes: >>> I've certainly seen and used values() constructs in joins for a variety >>> of reasons and I do think it'd be worthwhile for the planner to know how >>> to pull up a VALUES construct. > I spent a bit of time looking at this, and realized that the blocker > is

Re: [HACKERS] Strange debug message of walreciver?

2015-03-08 Thread Tatsuo Ishii
> On Sat, Mar 7, 2015 at 10:18 PM, Tatsuo Ishii wrote: >> >> When I set log_min_messages to debug5 and looked into walreciver log, >> I saw this: >> >> 3600 2015-03-08 09:47:38 JST DEBUG: sendtime 2015-03-08 > 09:47:38.31493+09 receipttime 2015-03-08 09:47:38.315027+09 replication > apply delay -

[HACKERS] PATCH: pgbench - logging aggregated info and transactions at the same time

2015-03-08 Thread Tomas Vondra
Hi, another thing that I find annoying on pgbench is that you can either log aggregated summary (per interval) or detailed transaction info (possibly sampled), but not both at the same time. That's annoying because what I generally use the aggregated info, but sometimes the transaction info would

[HACKERS] PATCH: pgbench - merging transaction logs

2015-03-08 Thread Tomas Vondra
Hi there, attached is a patch implementing merging of pgbench logs. These logs are written by each thread, so with N threads you get N files with names pgbench_log.PID pgbench_log.PID.1 ... pgbench_log.PID.N Before analyzing these logs, these files need to be combined. I usually

Re: [HACKERS] MD5 authentication needs help -SCRAM

2015-03-08 Thread Josh Berkus
All, Since SCRAM has been brought up a number of times here, I thought I'd loop in the PostgreSQL contributor who is co-author of the SCRAM standard to see if he has anything to say about implementing SCRAM as a built-in auth method for Postgres. Abhijit? -- Josh Berkus PostgreSQL Experts Inc.

Re: [HACKERS] New functions

2015-03-08 Thread Воронин Дмитрий
Sorry, 3 functions. 08.03.2015, 22:16, "Dmitry Voronin" : > Hello, > > I make an a patch, which adds 4 functions to sslinfo extension module: > 1) ssl_extension_names() --- get short names of X509v3 extensions from client > certificate and it's values; 2) ssl_extension_value(text) --- get value o

[HACKERS] New functions

2015-03-08 Thread Dmitry Voronin
Hello, I make an a patch, which adds 4 functions to sslinfo extension module:1) ssl_extension_names() --- get short names of X509v3 extensions from client certificate and it's values; 2) ssl_extension_value(text) --- get value of extension from certificate (argument --- short name of extension); 3)

Re: [HACKERS] polymorphic types - enforce casting to most common type automatically

2015-03-08 Thread Pavel Stehule
Hi I am sending a proof concept. Current implementation is not suboptimal - I wrote this code for demonstration of current issues, and checking possible side effects of changes in this patch. The basic problem is strong restrictive implementation of polymorphic types - now these types doesn't all

Re: [HACKERS] Bootstrap DATA is a pita

2015-03-08 Thread Tom Lane
Stephen Frost writes: > * Andrew Dunstan (and...@dunslane.net) wrote: >> On 03/07/2015 05:46 PM, Andres Freund wrote: >>> On 2015-03-07 16:43:15 -0600, Jim Nasby wrote: Semi-related... if we put some special handling in some places for bootstrap mode, couldn't most catalog objects

Re: [HACKERS] Bootstrap DATA is a pita

2015-03-08 Thread Tom Lane
Andres Freund writes: > On 2015-03-04 10:25:58 -0500, Robert Haas wrote: >> Another advantage of this is that it would probably make git less >> likely to fumble a rebase. If there are lots of places in the file >> where we have the same 10 lines in a row with occasional variations, >> rebasing a

Re: [HACKERS] Bootstrap DATA is a pita

2015-03-08 Thread Andres Freund
On 2015-03-04 10:25:58 -0500, Robert Haas wrote: > Another advantage of this is that it would probably make git less > likely to fumble a rebase. If there are lots of places in the file > where we have the same 10 lines in a row with occasional variations, > rebasing a patch could easily pick the

Re: [HACKERS] get_object_address support for additional object types

2015-03-08 Thread Stephen Frost
Alvaro, * Alvaro Herrera (alvhe...@2ndquadrant.com) wrote: > This is extracted from the DDL deparse series. These patches add > get_object_address support for the following object types: > > - user mappings > - default ACLs > - operators and functions of operator families I took a (relatively q

Re: [HACKERS] Wrong error message in REINDEX command

2015-03-08 Thread Tom Lane
Sawada Masahiko writes: > I got wrong error message when I did REINDEX SYSTEM command in > transaction as follows. > It should say "ERROR: REINDEX SYSTEM cannot run inside a transaction block" > Attached patch fixes it. Hm, yeah, looks like ReindexObject() has a similar disease internally (not t

Re: [HACKERS] improving speed of make check-world

2015-03-08 Thread Peter Eisentraut
On 2/24/15 3:06 AM, Michael Paquier wrote: > On Sun, Feb 15, 2015 at 11:01 AM, Peter Eisentraut wrote: >> Here is an updated patch. > > Nice patch. This is going to save a lot of resources. > > An update of vcregress.pl is necessary. This visibly just consists in > updating the options that have

Re: [HACKERS] In-core regression tests for replication, cascading, archiving, PITR, etc.

2015-03-08 Thread Michael Paquier
On Mon, Dec 2, 2013 at 7:07 PM, Andres Freund wrote: > On 2013-12-02 18:45:37 +0900, Michael Paquier wrote: >> On Mon, Dec 2, 2013 at 6:24 PM, Heikki Linnakangas >> wrote: >> > +1. The need for such a test suite has been mentioned every single time >> > that >> > a bug or new feature related to