Re: [HACKERS] PL/pgSQL, RAISE and error context

2015-07-07 Thread Heikki Linnakangas
On 01/26/2015 05:14 PM, Tom Lane wrote: Pavel Stehule pavel.steh...@gmail.com writes: 2015-01-26 14:02 GMT+01:00 Marko Tiikkaja ma...@joh.to: I am thinking, so solution /* if we are doing RAISE, don't report its location */ if (estate-err_text == raise_skip_msg) return;

Re: [HACKERS] FPW compression leaks information

2015-07-07 Thread Heikki Linnakangas
On 07/07/2015 04:15 PM, Stephen Frost wrote: * Fujii Masao (masao.fu...@gmail.com) wrote: On Thu, Apr 16, 2015 at 4:26 PM, Michael Paquier michael.paqu...@gmail.com wrote: + the compression ratio of a full page image gives a hint of what is + the existing data of this page.

Re: [HACKERS] creating extension including dependencies

2015-07-07 Thread Fujii Masao
On Mon, Jun 15, 2015 at 7:50 AM, Petr Jelinek p...@2ndquadrant.com wrote: Hi, I am getting tired installing manually required extensions manually. I was wondering if we might want to add option to CREATE SEQUENCE that would allow automatic creation of the extensions required by the extension

Re: [HACKERS] FPW compression leaks information

2015-07-07 Thread Stephen Frost
* Fujii Masao (masao.fu...@gmail.com) wrote: On Thu, Apr 16, 2015 at 4:26 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Wed, Apr 15, 2015 at 9:42 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Wed, Apr 15, 2015 at 9:20 PM, Michael Paquier michael.paqu...@gmail.com

Re: [HACKERS] 9.5 alpha: some small comments on BRIN and btree_gin

2015-07-07 Thread Marc Mamin
-Original Message- From: Josh Berkus [mailto:j...@agliodbs.com] Sent: Dienstag, 7. Juli 2015 02:04 On 07/06/2015 12:20 AM, Marc Mamin wrote: There seems to be no fence against useless BRIN indexes that would allow a fallback on a table scan. But the time overhead remind

Re: [HACKERS] replication slot restart_lsn initialization

2015-07-07 Thread Andres Freund
On 2015-07-07 06:41:55 -0700, Gurjeet Singh wrote: There seems to be a misplaced not operator ! in that if statement, as well. That sucks :( The MacOS gcc binary is actually clang, and its output is too noisy [1], which is probably why I might have missed warning if any. Which version of

Re: [HACKERS] PL/pgSQL, RAISE and error context

2015-07-07 Thread Merlin Moncure
On Tue, Jul 7, 2015 at 8:13 AM, Heikki Linnakangas hlinn...@iki.fi wrote: On 01/26/2015 05:14 PM, Tom Lane wrote: Pavel Stehule pavel.steh...@gmail.com writes: 2015-01-26 14:02 GMT+01:00 Marko Tiikkaja ma...@joh.to: I am thinking, so solution /* if we are doing RAISE, don't report

Re: [HACKERS] pg_dump quietly ignore missing tables - is it bug?

2015-07-07 Thread Fujii Masao
On Sat, May 23, 2015 at 1:41 AM, Pavel Stehule pavel.steh...@gmail.com wrote: 2015-05-22 18:34 GMT+02:00 Tom Lane t...@sss.pgh.pa.us: Oleksandr Shulgin oleksandr.shul...@zalando.de writes: I think this is a bit over-engineered (apart from the fact that processSQLNamePattern is also used

Re: [HACKERS] Set of patch to address several Coverity issues

2015-07-07 Thread Michael Paquier
On Wed, Jul 8, 2015 at 12:54 AM, Andres Freund and...@anarazel.de wrote: On 2015-07-07 16:17:47 +0900, Michael Paquier wrote: 2) Potential pointer dereference in plperl.c, fixed by 0002 (sent previously here = CAB7nPqRBCWAXTLw0yBR=bk94cryxu8twvxgyyoxautw08ok...@mail.gmail.com). This is

Re: [HACKERS] Improving test coverage of extensions with pg_dump

2015-07-07 Thread Michael Paquier
On Wed, Jul 8, 2015 at 1:32 AM, Heikki Linnakangas hlinn...@iki.fi wrote: Hmm. I think it'd be better to put the tables_fk extension into src/test/modules, and the test case under src/test/tables_fk/t/. I'm inclined to think of this as a test case for an extension that contains a table, which

Re: [HACKERS] [BUGS] BUG #13126: table constraint loses its comment

2015-07-07 Thread Michael Paquier
On Tue, Jul 7, 2015 at 6:24 PM, Petr Jelinek p...@2ndquadrant.com wrote: On 2015-07-04 13:45, Michael Paquier wrote: On Fri, Jul 3, 2015 at 11:59 PM, Petr Jelinek wrote: Well for indexes you don't really need to add the new AT command, as IndexStmt has char *idxcomment which it will

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-07 Thread Michael Paquier
On Mon, Jul 6, 2015 at 11:52 PM, Joe Conway m...@joeconway.com wrote: That explains why the first example works while the second does not. I'm not sure how hard it would be to fix that, but it appears that that is where we should focus. Wouldn't it be fine if we drop some of the functions

Re: [HACKERS] More logging for autovacuum

2015-07-07 Thread Gurjeet Singh
On Tue, Jul 7, 2015 at 11:20 AM, Sawada Masahiko sawada.m...@gmail.com wrote: On Sat, Jul 4, 2015 at 2:30 PM, Amit Kapila amit.kapil...@gmail.com wrote: On Thu, Jul 2, 2015 at 4:41 AM, Gurjeet Singh gurj...@singh.im wrote: log_min_messages acts as a single gate for everything headed for the

Re: [HACKERS] Freeze avoidance of very large table.

2015-07-07 Thread Amit Kapila
On Tue, Jul 7, 2015 at 5:19 PM, Amit Kapila amit.kapil...@gmail.com wrote: On Thu, Jul 2, 2015 at 9:00 PM, Sawada Masahiko sawada.m...@gmail.com wrote: Thank you for bug report, and comments. Fixed version is attached, and source code comment is also updated. Please review it. I

Re: [HACKERS] Freeze avoidance of very large table.

2015-07-07 Thread Sawada Masahiko
So I don't understand why you have two separate calls to visibilitymap_clear() Surely the logic should be to clear both bits at the same time? Yes, you're right. all-frozen bit should be cleared at the same time as clearing all-visible bit. 1. Both bits unset ~(VISIBILITYMAP_ALL_VISIBLE |

Re: [HACKERS] Comfortably check BackendPID with psql

2015-07-07 Thread Andres Freund
On 2015-07-07 10:17:39 -0400, Tom Lane wrote: I would s/pid/process ID/ in the docs. PID is not a particularly user-friendly term, and it's even less so if you fail to upper-case it. We have both pid and PID in a bunch of places in the docs, and pid in the ones that seem more likely to be

Re: [HACKERS] FPW compression leaks information

2015-07-07 Thread Stephen Frost
* Fujii Masao (masao.fu...@gmail.com) wrote: On Tue, Jul 7, 2015 at 10:31 PM, Stephen Frost sfr...@snowman.net wrote: I'm not following. If we don't want the information to be available to everyone then we need to limit it, and right now the only way to do that is to restrict it to

Re: [HACKERS] [PATCH] Add missing \ddp psql command

2015-07-07 Thread Fujii Masao
On Tue, Jul 7, 2015 at 11:08 PM, Fujii Masao masao.fu...@gmail.com wrote: On Tue, Jul 7, 2015 at 10:44 PM, David Christensen da...@endpoint.com wrote: On Jul 7, 2015, at 3:53 AM, Fujii Masao masao.fu...@gmail.com wrote: On Tue, Jul 7, 2015 at 2:11 AM, David Christensen da...@endpoint.com

Re: [HACKERS] PL/pgSQL, RAISE and error context

2015-07-07 Thread Heikki Linnakangas
On 07/07/2015 04:56 PM, Merlin Moncure wrote: On Tue, Jul 7, 2015 at 8:13 AM, Heikki Linnakangas hlinn...@iki.fi wrote: On 01/26/2015 05:14 PM, Tom Lane wrote: Pavel Stehule pavel.steh...@gmail.com writes: 2015-01-26 14:02 GMT+01:00 Marko Tiikkaja ma...@joh.to: I am thinking, so solution

<    1   2