Re: [HACKERS] Fix to expose a GUC variable, Log_disconnections, to outside of postgres.c

2015-07-08 Thread Satoshi Nagayasu
On 2015/07/09 15:30, Heikki Linnakangas wrote: > On 07/09/2015 07:19 AM, Satoshi Nagayasu wrote: >> >> On 2015/07/09 13:06, Tom Lane wrote: >>> Satoshi Nagayasu writes: I just found that Log_disconnections value has not been exposed to outside of postgres.c. Despite that, Log_conn

Re: [HACKERS] optimizing vacuum truncation scans

2015-07-08 Thread Jeff Janes
On Wed, Jul 8, 2015 at 9:46 PM, Haribabu Kommi wrote: > On Mon, Jun 29, 2015 at 3:54 PM, Jeff Janes wrote: > > > > Attached is a patch that implements the vm scan for truncation. It > > introduces a variable to hold the last blkno which was skipped during the > > forward portion. Any blocks af

Re: [HACKERS] Fix to expose a GUC variable, Log_disconnections, to outside of postgres.c

2015-07-08 Thread Heikki Linnakangas
On 07/09/2015 07:19 AM, Satoshi Nagayasu wrote: > > On 2015/07/09 13:06, Tom Lane wrote: >> Satoshi Nagayasu writes: >>> I just found that Log_disconnections value has not been >>> exposed to outside of postgres.c. >>> Despite that, Log_connections has already been exposed. >> >> Why would an ext

[HACKERS] Comment nitpicking in predicate_refuted_by_recurse()

2015-07-08 Thread Amit Langote
Attached find patch that makes certain comments in predicate_refuted_by_recurse() clearer, for example: -* AND-clause R=> AND-clause if A refutes any of B's items +* AND-clause A R=> AND-clause B if A refutes any of B's items The comment above the function is written using the lat

Re: [HACKERS] Implementation of global temporary tables?

2015-07-08 Thread Pavel Stehule
2015-07-09 7:32 GMT+02:00 Zhaomo Yang : > > I am not sure, if it is not useless work. > > I don't understand why an implementation taking approach 2.a would be > useless. As I said, its performance will be no worse than current temp > tables and it will provide a lot of convenience to users who n

Re: [HACKERS] copy.c handling for RLS is insecure

2015-07-08 Thread Noah Misch
On Wed, Jul 08, 2015 at 10:55:47AM -0400, Stephen Frost wrote: > It's interesting to consider that COPY purportedly operates under the > SELECT privilege, yet fails to respect on-select rules. In released branches, COPY consistently refuses to operate directly on a view. (There's no (longer?) such

Re: [HACKERS] Solaris testers wanted for strxfrm() behavior

2015-07-08 Thread Noah Misch
On Sat, Jun 27, 2015 at 11:57:30AM -0700, Peter Geoghegan wrote: > On Sat, Jun 27, 2015 at 9:51 AM, Noah Misch wrote: > > PostgreSQL 9.5 adds a strxfrm() call in bttext_abbrev_convert(), which does > > not account for the Solaris bug. I wish to determine whether that bug is > > still relevant tod

Re: [HACKERS] Waits monitoring

2015-07-08 Thread Haribabu Kommi
On Thu, Jul 9, 2015 at 1:52 AM, Ildus Kurbangaliev wrote: > Hello. > > Currently, PostgreSQL offers many metrics for monitoring. However, detailed > monitoring of waits is still not supported yet. Such monitoring would > let dba know how long backend waited for particular event and therefore > ide

Re: [HACKERS] Freeze avoidance of very large table.

2015-07-08 Thread Sawada Masahiko
On Thu, Jul 9, 2015 at 4:31 AM, Jeff Janes wrote: > On Fri, Jul 3, 2015 at 1:25 AM, Sawada Masahiko > wrote: >> >> On Fri, Jul 3, 2015 at 1:23 AM, Simon Riggs wrote: >> > On 2 July 2015 at 16:30, Sawada Masahiko wrote: >> > >> >> >> >> Also, the flags of each heap page header might be set PD_AL

Re: [HACKERS] optimizing vacuum truncation scans

2015-07-08 Thread Haribabu Kommi
On Mon, Jun 29, 2015 at 3:54 PM, Jeff Janes wrote: > > Attached is a patch that implements the vm scan for truncation. It > introduces a variable to hold the last blkno which was skipped during the > forward portion. Any blocks after both this blkno and after the last > inspected nonempty page (

[HACKERS] obsolete comment in elog.h

2015-07-08 Thread Pavel Stehule
Hi the comment about NOTICE level in elog.h is obsolete Regards Pavel diff --git a/src/include/utils/elog.h b/src/include/utils/elog.h new file mode 100644 index 8e90661..7684717 *** a/src/include/utils/elog.h --- b/src/include/utils/elog.h *** *** 33,40 * client rega

Re: [HACKERS] Fix to expose a GUC variable, Log_disconnections, to outside of postgres.c

2015-07-08 Thread Satoshi Nagayasu
On 2015/07/09 13:06, Tom Lane wrote: > Satoshi Nagayasu writes: >> I just found that Log_disconnections value has not been >> exposed to outside of postgres.c. >> Despite that, Log_connections has already been exposed. > > Why would an external module need to touch either one? To check settings

Re: [HACKERS] Fix to expose a GUC variable, Log_disconnections, to outside of postgres.c

2015-07-08 Thread Tom Lane
Satoshi Nagayasu writes: > I just found that Log_disconnections value has not been > exposed to outside of postgres.c. > Despite that, Log_connections has already been exposed. Why would an external module need to touch either one? regards, tom lane -- Sent via pgsql-h

[HACKERS] Fix to expose a GUC variable, Log_disconnections, to outside of postgres.c

2015-07-08 Thread Satoshi Nagayasu
Hi, I just found that Log_disconnections value has not been exposed to outside of postgres.c. Despite that, Log_connections has already been exposed. So, I'd like to add attached fix to touch the Log_disconnections value in other modules. Any comments? Regards, -- NAGAYASU Satoshi commit afff

Re: [HACKERS] Memory Accounting v11

2015-07-08 Thread David Rowley
On 7 July 2015 at 20:23, David Rowley wrote: > On 7 July 2015 at 18:59, Jeff Davis wrote: > >> >> > > One other thing that I don't remember seeing discussed would be to >> > just store a List in each context which would store all of the >> > mem_allocated's that need to be updated during each al

Re: [HACKERS] Improving log capture of TAP tests with IPC::Run

2015-07-08 Thread Michael Paquier
On Thu, Jul 9, 2015 at 12:49 AM, Heikki Linnakangas wrote: >>> Looking at the manual page of Test::More, it looks like you could change >>> where the perl script's STDOUT and STDERR point to, because Test::More >>> takes >>> a copy of them (when? at program startup I guess..). That would be much >>

Re: [HACKERS] Freeze avoidance of very large table.

2015-07-08 Thread Jim Nasby
On 7/8/15 8:31 AM, Simon Riggs wrote: I understood. So I will place bunch of test like src/test/module/visibilitymap_test, which contains some tests regarding this feature, and gather them into one patch. Please place it in core. I see value in having a diagnostic function for

Re: [HACKERS] PL/pgSQL, RAISE and error context

2015-07-08 Thread Pavel Stehule
2015-07-08 23:46 GMT+02:00 Merlin Moncure : > On Wed, Jul 8, 2015 at 4:39 PM, Pavel Stehule > wrote: > > 2015-07-08 8:35 GMT+02:00 Pavel Stehule : > >> > >> > >> > >> 2015-07-07 18:15 GMT+02:00 Merlin Moncure : > >>> > >>> On Tue, Jul 7, 2015 at 9:04 AM, Pavel Stehule > > >>> wrote: > >>> >> It

Re: [HACKERS] PL/pgSQL, RAISE and error context

2015-07-08 Thread Merlin Moncure
On Wed, Jul 8, 2015 at 4:39 PM, Pavel Stehule wrote: > 2015-07-08 8:35 GMT+02:00 Pavel Stehule : >> >> >> >> 2015-07-07 18:15 GMT+02:00 Merlin Moncure : >>> >>> On Tue, Jul 7, 2015 at 9:04 AM, Pavel Stehule >>> wrote: >>> >> It doesn't have to if the behavior is guarded with a GUC. I just >>> >>

Re: [HACKERS] PL/pgSQL, RAISE and error context

2015-07-08 Thread Pavel Stehule
2015-07-08 8:35 GMT+02:00 Pavel Stehule : > > > 2015-07-07 18:15 GMT+02:00 Merlin Moncure : > >> On Tue, Jul 7, 2015 at 9:04 AM, Pavel Stehule >> wrote: >> >> It doesn't have to if the behavior is guarded with a GUC. I just >> >> don't understand what all the fuss is about. The default behavior

Re: [HACKERS] PL/pgSQL, RAISE and error context

2015-07-08 Thread Pavel Stehule
Hi here is initial version of reduced patch. It is small code, but relative big (although I expected bigger) change in tests. if these changes are too big, then we have to introduce a plpgsql GUC plpgsql.client_min_context and plpgsql.log_min_client. These GUC overwrite global setting for plpgsql

[HACKERS] Postmaster's handing of startup-process crash is busted

2015-07-08 Thread Tom Lane
My Salesforce colleagues observed a failure mode in which a bug in the crash recovery logic caused the startup process to get a SEGV while trying to recover after a backend crash. The postmaster should have given up at that point, but instead it kept on respawning the startup process, which of cou

Re: [HACKERS] Hashable custom types

2015-07-08 Thread Paul Ramsey
On July 8, 2015 at 1:36:49 PM, Tom Lane (t...@sss.pgh.pa.us) wrote: Paul Ramsey writes:  >> UNION will preferentially glom onto the btree equality operator, if memory   >> serves. If that isn't also the hash equality operator, things won't work   >> pleasantly.   > So… what does that mean for typ

Re: [HACKERS] Hashable custom types

2015-07-08 Thread Tom Lane
Paul Ramsey writes: >> UNION will preferentially glom onto the btree equality operator, if memory >> serves. If that isn't also the hash equality operator, things won't work >> pleasantly. > So… what does that mean for types that have both btree and hash equality > operators? Don’t all

Re: [HACKERS] Hashable custom types

2015-07-08 Thread Paul Ramsey
> It still says I lack the secret sauce... > ERROR: could not implement recursive UNION > DETAIL: All column datatypes must be hashable. UNION will preferentially glom onto the btree equality operator, if memory serves. If that isn't also the hash equality operator, things won't work p

Re: [HACKERS] Hashable custom types

2015-07-08 Thread Tom Lane
Paul Ramsey writes: > On Fri, Apr 25, 2014 at 4:54 PM, Peter Geoghegan wrote: >> On Fri, Apr 25, 2014 at 4:47 PM, Paul Ramsey >> wrote: >>> Is it possible to make custom types hashable? There's no hook in the >>> CREATE TYPE call for a hash function, but can one be hooked up >>> somewhere else?

Re: [HACKERS] Hashable custom types

2015-07-08 Thread Paul Ramsey
On Fri, Apr 25, 2014 at 4:54 PM, Peter Geoghegan wrote: > On Fri, Apr 25, 2014 at 4:47 PM, Paul Ramsey > wrote: >> Is it possible to make custom types hashable? There's no hook in the >> CREATE TYPE call for a hash function, but can one be hooked up >> somewhere else? In an operator? > > See 35.

Re: [HACKERS] Freeze avoidance of very large table.

2015-07-08 Thread Jeff Janes
On Fri, Jul 3, 2015 at 1:25 AM, Sawada Masahiko wrote: > On Fri, Jul 3, 2015 at 1:23 AM, Simon Riggs wrote: > > On 2 July 2015 at 16:30, Sawada Masahiko wrote: > > > >> > >> Also, the flags of each heap page header might be set PD_ALL_FROZEN, > >> as well as all-visible > > > > > > Is it possib

Re: [HACKERS] Fillfactor for GIN indexes

2015-07-08 Thread Heikki Linnakangas
In dataPlaceToPageLeaf-function: if (append) { /* * Even when appending, trying to append more items than will fit is * not completely free, because we will merge the new items and old * items into an array belo

Re: [HACKERS] configure can't detect proper pthread flags

2015-07-08 Thread Tom Lane
Heikki Linnakangas writes: > The only scenario where you might now get warnings if we switch to > upstream version, and didn't before, is if one of the flags makes > pthreads to work, but also creates compiler warnings, while another flag > later in the list would make it work without warnings.

Re: [HACKERS] configure can't detect proper pthread flags

2015-07-08 Thread Heikki Linnakangas
On 07/08/2015 04:38 PM, Tom Lane wrote: Heikki Linnakangas writes: I suggest that we revert that work-around for that GCC bug, and stop testing the pthread flags as soon as we find one that works. OK ... Then we can also remove the test for whether the compiler produces any warnings. Don'

Re: [HACKERS] [PATCH] libpq: Allow specifying multiple host names to try to connect to

2015-07-08 Thread Robbie Harwood
Steve Singer writes: > On 04/19/2015 11:18 AM, Mikko Tiihonen wrote: >> >> Hi, >> >> >> I would like allow specifying multiple host names for libpq to try to >> connecting to. This is currently only supported if the host name >> resolves to multiple addresses. Having the support for it without

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-08 Thread Joe Conway
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/08/2015 08:51 AM, Corey Huinker wrote: > Questions: Would moving rowtype to the first parameter resolve the > parameter ambiguity issue? Not for the existing functions but with new functions I don't think it matters. You would know to always ign

[HACKERS] Waits monitoring

2015-07-08 Thread Ildus Kurbangaliev
Hello. Currently, PostgreSQL offers many metrics for monitoring. However, detailed monitoring of waits is still not supported yet. Such monitoring would let dba know how long backend waited for particular event and therefore identify bottlenecks. This functionality is very useful, especially fo

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-08 Thread Corey Huinker
On Wed, Jul 8, 2015 at 11:29 AM, Merlin Moncure wrote: > On Wed, Jul 8, 2015 at 10:12 AM, Joe Conway wrote: > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA1 > > > > On 07/07/2015 10:22 PM, Michael Paquier wrote: > >> On Mon, Jul 6, 2015 at 11:52 PM, Joe Conway > >> wrote: > >>> That explai

Re: [HACKERS] Improving log capture of TAP tests with IPC::Run

2015-07-08 Thread Heikki Linnakangas
On 07/08/2015 11:26 AM, Michael Paquier wrote: On Wed, Jul 8, 2015 at 6:10 AM, Heikki Linnakangas wrote: * whenever a test case is reported as success/fail. Just to be sure, does this concern the "ok/not ok" messages printed out by each test run? Or is it a custom message that you have in min

Re: [HACKERS] Determine operator from it's function

2015-07-08 Thread Jim Nasby
On 7/4/15 12:33 AM, Tom Lane wrote: Jim Nasby writes: On 7/3/15 2:33 AM, Heikki Linnakangas wrote: On 07/03/2015 01:20 AM, Jim Nasby wrote: Is there a way to determine the operator that resulted in calling the operator function? I thought fcinfo->flinfo->fn_expr might get set to the OpExpr, b

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-08 Thread Merlin Moncure
On Wed, Jul 8, 2015 at 10:12 AM, Joe Conway wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 07/07/2015 10:22 PM, Michael Paquier wrote: >> On Mon, Jul 6, 2015 at 11:52 PM, Joe Conway >> wrote: >>> That explains why the first example works while the second does >>> not. I'm not sur

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-08 Thread Pavel Stehule
2015-07-08 17:12 GMT+02:00 Joe Conway : > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 07/07/2015 10:22 PM, Michael Paquier wrote: > > On Mon, Jul 6, 2015 at 11:52 PM, Joe Conway > > wrote: > >> That explains why the first example works while the second does > >> not. I'm not sure how h

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-08 Thread Joe Conway
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/07/2015 10:22 PM, Michael Paquier wrote: > On Mon, Jul 6, 2015 at 11:52 PM, Joe Conway > wrote: >> That explains why the first example works while the second does >> not. I'm not sure how hard it would be to fix that, but it >> appears that that

Re: [HACKERS] copy.c handling for RLS is insecure

2015-07-08 Thread Stephen Frost
Noah, * Noah Misch (n...@leadboat.com) wrote: > On Tue, Dec 02, 2014 at 11:32:27AM -0500, Stephen Frost wrote: > > * Robert Haas (robertmh...@gmail.com) wrote: > > > On Thu, Nov 27, 2014 at 2:03 AM, Stephen Frost wrote: > > > > Alright, I've done the change to use the RangeVar from CopyStmt, but

Re: [HACKERS] Re: [HACKERS] GSoC 2015 proposal: Improve the performance of “ALTER TABLE .. SET LOGGED / UNLOGGED” statement

2015-07-08 Thread Andres Freund
On 2015-07-08 10:58:51 -0300, Fabrízio de Royes Mello wrote: > Think in an ETL job that can be use an unlogged table to improve the load > performance, but this job create a "large table" and to guarantee the data > consistency you need to transform it into a regular table, and with the > current i

[HACKERS] Re: [HACKERS] Re: [HACKERS] GSoC 2015 proposal: Improve the performance of “ALTER TABLE .. SET LOGGED / UNLOGGED” statement

2015-07-08 Thread Fabrízio de Royes Mello
On Wed, Jul 8, 2015 at 10:53 AM, Andres Freund wrote: > > On 2015-07-03 08:18:09 -0300, Fabrízio de Royes Mello wrote: > > *** ALTER TABLE changes > > ... > > Without going into the specifics of this change: Are we actually sure > this feature warrants the complexity it'll introduce? I'm really ra

Re: [HACKERS] Re: [HACKERS] GSoC 2015 proposal: Improve the performance of “ALTER TABLE .. SET LOGGED / UNLOGGED” statement

2015-07-08 Thread Andres Freund
On 2015-07-03 08:18:09 -0300, Fabrízio de Royes Mello wrote: > *** ALTER TABLE changes > ... Without going into the specifics of this change: Are we actually sure this feature warrants the complexity it'll introduce? I'm really rather doubtful. -- Sent via pgsql-hackers mailing list (pgsql-hack

[HACKERS] Re: [HACKERS] GSoC 2015 proposal: Improve the performance of “ALTER TABLE .. SET LOGGED / UNLOGGED” statement

2015-07-08 Thread Fabrízio de Royes Mello
On Wed, Jul 8, 2015 at 3:20 AM, Ashutosh Bapat < ashutosh.ba...@enterprisedb.com> wrote: > >> >> My intention for the 6th step is all recorded to wal, so if a crash occurs the recovery process clean the mess. >> > > AFAIU, PostgreSQL recovery is based on "redo"ing WAL. What you described earlier, "

Re: [HACKERS] [PATCH] libpq: Allow specifying multiple host names to try to connect to

2015-07-08 Thread Steve Singer
On 04/19/2015 11:18 AM, Mikko Tiihonen wrote: Hi, I would like allow specifying multiple host names for libpq to try to connecting to. This is currently only supported if the host name resolves to multiple addresses. Having the support for it without complex dns setup would be much easier.

Re: [HACKERS] Freeze avoidance of very large table.

2015-07-08 Thread Amit Kapila
On Tue, Jul 7, 2015 at 5:37 PM, Simon Riggs wrote: > On 6 July 2015 at 17:28, Simon Riggs wrote: > > I think we need something for pg_upgrade to rewrite existing VMs. >> Otherwise a large read only database would suddenly require a massive >> revacuum after upgrade, which seems bad. That can wai

Re: [HACKERS] configure can't detect proper pthread flags

2015-07-08 Thread Tom Lane
Heikki Linnakangas writes: > I suggest that we revert that work-around for that GCC bug, and stop > testing the pthread flags as soon as we find one that works. OK ... > Then we can > also remove the test for whether the compiler produces any warnings. Don't see how that follows? > AFAICS,

Re: [HACKERS] Freeze avoidance of very large table.

2015-07-08 Thread Simon Riggs
On 7 July 2015 at 18:45, Sawada Masahiko wrote: > On Wed, Jul 8, 2015 at 12:37 AM, Andres Freund wrote: > > On 2015-07-07 16:25:13 +0100, Simon Riggs wrote: > >> I don't think pg_freespacemap is the right place. > > > > I agree that pg_freespacemap sounds like an odd location. > > > >> I'd prefe

Re: [HACKERS] Implementation of global temporary tables?

2015-07-08 Thread Zhaomo Yang
> more global temp tables are little bit comfortable for developers, I'd like to emphasize this point. This feature does much more than saving a developer from issuing a CREATE TEMP TABLE statement in every session. Here are two common use cases and I'm sure there are more. (1) Imagine in a web a

Re: [HACKERS] New functions

2015-07-08 Thread Michael Paquier
On Wed, Jul 8, 2015 at 9:15 PM, Дмитрий Воронин wrote: > > > 07.07.2015, 18:34, "Michael Paquier" : > >> Speaking of which, I have rewritten the patch as attached. This looks >> way cleaner than the previous version submitted. Dmitry, does that >> look fine for you? >> I am switching this patc

Re: [HACKERS] psql tabcomplete - minor bugfix - tabcomplete for SET ROLE TO xxx

2015-07-08 Thread Pavel Stehule
2015-07-02 11:03 GMT+02:00 Heikki Linnakangas : > On 05/29/2015 10:41 AM, Pavel Stehule wrote: > >> 2015-05-29 9:28 GMT+02:00 Jeevan Chalke : >> >> I agree with Peter that "We don't tab-complete everything we possibly >>> could", but using tabs after "SET ROLE TO " provides "DEFAULT" as an >>> op

Re: [HACKERS] New functions

2015-07-08 Thread Дмитрий Воронин
07.07.2015, 18:34, "Michael Paquier" : >  Speaking of which, I have rewritten the patch as attached. This looks >  way cleaner than the previous version submitted. Dmitry, does that >  look fine for you? >  I am switching this patch as "Waiting on Author". >  Regards, >  -- >  Michael Michael,

Re: [HACKERS] PL/pgSQL, RAISE and error context

2015-07-08 Thread Merlin Moncure
On Wed, Jul 8, 2015 at 1:35 AM, Pavel Stehule wrote: > > > 2015-07-07 18:15 GMT+02:00 Merlin Moncure : >> >> On Tue, Jul 7, 2015 at 9:04 AM, Pavel Stehule >> wrote: >> >> It doesn't have to if the behavior is guarded with a GUC. I just >> >> don't understand what all the fuss is about. The defa

Re: [HACKERS] expose confirmed_flush for replication slots

2015-07-08 Thread Marko Tiikkaja
On 2015-07-08 14:57, I wrote: Adding this one to the next commit fest, but any feedback welcome in the meanwhile. Forgot to change PG_GET_REPLICATION_SLOTS_COLS; fixed in the attached patch. .m diff --git a/src/backend/catalog/system_views.sql b/src/backend/catalog/system_views.sql index e82

[HACKERS] expose confirmed_flush for replication slots

2015-07-08 Thread Marko Tiikkaja
Hi, I had some trouble today with a misbehaving logical replication client which had confirmed a flush of an LSN far into the future. Debugging it was a bit of a pain for a number of reasons, but I think the most important one was that confirmed_flush isn't exposed in pg_stat_replication_slo

Re: [HACKERS] pg_receivexlog --create-slot-if-not-exists

2015-07-08 Thread Cédric Villemain
Le 07/07/2015 14:55, Andres Freund a écrit : > On 2015-06-19 17:21:25 +0200, Cédric Villemain wrote: >>> To make slot usage in pg_receivexlog easier, should we add >>> --create-slot-if-not-exists? That'd mean you could run the same command >>> the first and later invocation. >> >> +1 (with a shorte

Re: [HACKERS] Bypassing SQL lexer and parser

2015-07-08 Thread Данила Поярков
06.07.2015, 20:28, "Guillaume Lelarge" :> That sounds a lot like a background worker.Thank a lot! That's exactly what I was looking for. 07.07.2015, 03:29, "Jim Nasby" :> There is support for plugging into the parser and executor, so that> might be a possibility, but...For now, it's the key questio

[HACKERS] more-helpful-izing a debug message

2015-07-08 Thread Marko Tiikkaja
Hi, One of the debug messages related to logical replication could be more helpful than it currently is. The attached patch reorders the two operations to make it so. Please consider patching and back-patching. .m diff --git a/src/backend/replication/logical/logical.c b/src/backend/replic

Re: [HACKERS] Set of patch to address several Coverity issues

2015-07-08 Thread Andres Freund
On 2015-07-08 14:11:59 +0900, Michael Paquier wrote: > Arg... I thought I triggered a couple of weeks a problem in this code > path when desc->arg_arraytype[i] is InvalidOid with argtypes == NULL. > Visibly I did something wrong... > > Speaking of which, shouldn't this thing at least use OidIsVali

Re: [HACKERS] configure can't detect proper pthread flags

2015-07-08 Thread Heikki Linnakangas
On 03/21/2015 01:06 AM, Max Filippov wrote: On Fri, Mar 20, 2015 at 3:43 PM, Max Filippov wrote: Ok, one more attempt: maybe instead of checking that stderr is empty we could check that stderr has changed in the presence of the option that we test? The patch: http://www.postgresql.org/message

Re: [HACKERS] Improving log capture of TAP tests with IPC::Run

2015-07-08 Thread Michael Paquier
On Wed, Jul 8, 2015 at 6:10 AM, Heikki Linnakangas wrote: > On 06/25/2015 07:14 AM, Michael Paquier wrote: >> >> After looking at the issues with the TAP test suite that hamster faced >> a couple of days ago, which is what has been discussed on this thread: >> http://www.postgresql.org/message-id/

Re: [HACKERS] Implementation of global temporary tables?

2015-07-08 Thread Pavel Stehule
Hi 2015-07-08 9:08 GMT+02:00 Zhaomo Yang : > > more global temp tables are little bit comfortable for developers, > I'd like to emphasize this point. This feature does much more than saving > a developer from issuing a CREATE TEMP TABLE statement in every session. > Here are two common use case

Re: [HACKERS] RFC: replace pg_stat_activity.waiting with something more descriptive

2015-07-08 Thread Amit Kapila
On Tue, Jul 7, 2015 at 12:57 PM, Fujii Masao wrote: > > On Tue, Jun 30, 2015 at 10:30 PM, Amit Kapila wrote: > > I have still not added documentation and have not changed anything for > > waiting column in pg_stat_activity as I think before that we need to > > finalize > > the user interface. Ap