Re: [HACKERS] Test code is worth the space

2015-08-15 Thread Noah Misch
On Fri, Aug 14, 2015 at 12:47:49PM +0100, Simon Riggs wrote: > On 13 August 2015 at 00:31, Robert Haas wrote: > > On Wed, Aug 12, 2015 at 7:20 PM, Tom Lane wrote: > > > We've talked about having some sort of second rank of tests that > > > people wouldn't necessarily run before committing, and th

Re: [HACKERS] Test code is worth the space

2015-08-15 Thread Noah Misch
On Wed, Aug 12, 2015 at 06:46:19PM +0100, Greg Stark wrote: > On Wed, Aug 12, 2015 at 3:10 AM, Noah Misch wrote: > > Committers press authors to delete tests more often than we press them to > > resubmit with more tests. No wonder so many patches have insufficient > > tests; > > we treat those p

Re: [HACKERS] Raising our compiler requirements for 9.6

2015-08-15 Thread Noah Misch
On Sun, Aug 16, 2015 at 05:58:17AM +0200, Andres Freund wrote: > On 2015-08-15 23:50:09 -0400, Noah Misch wrote: > > On Sun, Aug 16, 2015 at 02:03:01AM +0200, Andres Freund wrote: > > > On 2015-08-15 12:47:09 -0400, Noah Misch wrote: > > > > $ make -s PROFILE='-O0 -DPG_FORCE_DISABLE_INLINE=1' > > >

Re: [HACKERS] Raising our compiler requirements for 9.6

2015-08-15 Thread Andres Freund
On 2015-08-15 23:50:09 -0400, Noah Misch wrote: > On Sun, Aug 16, 2015 at 02:03:01AM +0200, Andres Freund wrote: > > On 2015-08-15 12:47:09 -0400, Noah Misch wrote: > > > $ make -s PROFILE='-O0 -DPG_FORCE_DISABLE_INLINE=1' > > > pg_resetxlog.o: In function `fastgetattr': > > > /data/nmisch/src/pg/p

Re: [HACKERS] Raising our compiler requirements for 9.6

2015-08-15 Thread Noah Misch
On Sun, Aug 16, 2015 at 02:03:01AM +0200, Andres Freund wrote: > On 2015-08-15 12:47:09 -0400, Noah Misch wrote: > > $ make -s PROFILE='-O0 -DPG_FORCE_DISABLE_INLINE=1' > > pg_resetxlog.o: In function `fastgetattr': > > /data/nmisch/src/pg/postgresql/src/bin/pg_resetxlog/../../../src/include/access

Re: [HACKERS] Autonomous Transaction is back

2015-08-15 Thread Noah Misch
On Sat, Aug 15, 2015 at 10:20:55PM -0300, Alvaro Herrera wrote: > Noah Misch wrote: > > > In today's scenarios, the later query cannot commit unless the suspended > > query > > also commits. (Changing that is the raison d'ĂȘtre of autonomous > > transactions.) If the autonomous transaction can i

Re: [HACKERS] Autonomous Transaction is back

2015-08-15 Thread Alvaro Herrera
Noah Misch wrote: > In today's scenarios, the later query cannot commit unless the suspended query > also commits. (Changing that is the raison d'ĂȘtre of autonomous > transactions.) If the autonomous transaction can interact with uncommitted > work in a way that other backends could not, crazy t

Re: [HACKERS] Raising our compiler requirements for 9.6

2015-08-15 Thread Andres Freund
On 2015-08-15 12:47:09 -0400, Noah Misch wrote: > Atomics were a miner's canary for pademelon's trouble with post-de6fd1c > inlining. Expect pademelon to break whenever a frontend-included file gains > an inline function that calls a backend function. Atomics were the initial > examples, but this

Re: [HACKERS] CREATE POLICY and RETURNING

2015-08-15 Thread Zhaomo Yang
Stephen, If no NEW or OLD is used, what happens? Or would you have > to always specify OLD/NEW for UPDATE, and then what about for the other > policies, and the FOR ALL policies? I should be clearer with references to OLD/NEW. SELECT Predicates cannot reference any of them. INSERT predicates ca

Re: [HACKERS] Autonomous Transaction is back

2015-08-15 Thread Noah Misch
On Fri, Aug 07, 2015 at 11:26:08AM -0400, Robert Haas wrote: > On Thu, Aug 6, 2015 at 11:04 PM, Merlin Moncure wrote: > > I don't necessarily disagree with what you're saying, but it's not > > clear to me what the proposed behavior is. Since the AT can commit > > before the outer, ISTM *any* ungr

[HACKERS] Potential GIN vacuum bug

2015-08-15 Thread Jeff Janes
When ginbulkdelete gets called for the first time in a VACUUM(i.e. stats == NULL), one of the first things it does is call ginInsertCleanup to get rid of the pending list. It does this in lieu of vacuuming the pending list. This is important because if there are any dead tids still in the Pendin

Re: [HACKERS] Small improvement to get_base_rel_indexes()

2015-08-15 Thread Tom Lane
David Rowley writes: > Attached is a small patch which improves the way get_base_rel_indexes() > works. > The current version creates a new bitmapset on each recursion level then > bms_joins() to the one on the next level up each time. I understand that > this will patch will have about a 0 net p

Re: [HACKERS] Raising our compiler requirements for 9.6

2015-08-15 Thread Tom Lane
Andres Freund writes: > On August 15, 2015 6:47:09 PM GMT+02:00, Noah Misch wrote: >> That gave me new respect for STATIC_IF_INLINE. While it does add >> tedious work to the task of introducing a new batch of inline >> functions, the work is completely mechanical. Anyone can write it; >> anyone

Re: [HACKERS] Raising our compiler requirements for 9.6

2015-08-15 Thread Andres Freund
On August 15, 2015 6:47:09 PM GMT+02:00, Noah Misch wrote: >On Tue, Aug 11, 2015 at 01:04:48PM +0200, Andres Freund wrote: >> On 2015-08-05 15:46:36 +0200, Andres Freund wrote: >> > Here's a conversion for fastgetattr() and heap_getattr(). > >> In my opinion this drastically increases readability

Re: [HACKERS] Raising our compiler requirements for 9.6

2015-08-15 Thread Noah Misch
On Tue, Aug 11, 2015 at 01:04:48PM +0200, Andres Freund wrote: > On 2015-08-05 15:46:36 +0200, Andres Freund wrote: > > Here's a conversion for fastgetattr() and heap_getattr(). > In my opinion this drastically increases readability and thus should be > applied. Atomics were a miner's canary for

Re: [HACKERS] [RFC] allow 'semester' in functions EXTRACT, DATE_PART, TO_CHAR and so on.

2015-08-15 Thread David Fetter
On Fri, Aug 14, 2015 at 10:06:22PM -0300, Dickson S. Guedes wrote: > 2015-08-14 21:32 GMT-03:00 Gavin Flower : > ... > > So semesters don't appear to align with normal half year boundaries. > > Interesting links, thanks! > > Which sounds better for a native English: 'half', 'halfyear'? > > For e

[HACKERS] Add support for RADIUS passwords longer than 16 octets

2015-08-15 Thread Marko Tiikkaja
Hi, The attached patch adds support for RADIUS passwords longer than 16 octets. .m *** a/src/backend/libpq/auth.c --- b/src/backend/libpq/auth.c *** *** 2168,2173 CheckCertAuth(Port *port) --- 2168,2174 #define RADIUS_VECTOR_LENGTH 16 #define RADIUS_HEADER_LENGTH 20

Re: [HACKERS] replication slot restart_lsn initialization

2015-08-15 Thread Michael Paquier
On Fri, Aug 14, 2015 at 4:54 PM, Andres Freund wrote: > On 2015-08-14 16:44:44 +0900, Michael Paquier wrote: >> Commit 6fcd8851, which is the result of this thread, is not touching >> the replication protocol at all. This looks like an oversight to me: >> we should be a maximum consistent between

[HACKERS] Small improvement to get_base_rel_indexes()

2015-08-15 Thread David Rowley
Attached is a small patch which improves the way get_base_rel_indexes() works. The current version creates a new bitmapset on each recursion level then bms_joins() to the one on the next level up each time. I understand that this will patch will have about a 0 net performance improvement, but I th

Re: [HACKERS] Test code is worth the space

2015-08-15 Thread Petr Jelinek
On 2015-08-15 03:35, Jim Nasby wrote: I setup a simple example of this with 64 variations of TAP tests, BLKSZ and WAL blocksize. Unfortunately to make this work you have to commit a .travis.yml file to your fork. build: https://travis-ci.org/decibel/postgres/builds/75692344 .travis.yml: https:/