Re: [HACKERS] Test code is worth the space

2015-08-16 Thread Noah Misch
On Wed, Aug 12, 2015 at 06:46:19PM +0100, Greg Stark wrote: On Wed, Aug 12, 2015 at 3:10 AM, Noah Misch n...@leadboat.com wrote: Committers press authors to delete tests more often than we press them to resubmit with more tests. No wonder so many patches have insufficient tests; we

Re: [HACKERS] Test code is worth the space

2015-08-16 Thread Noah Misch
On Fri, Aug 14, 2015 at 12:47:49PM +0100, Simon Riggs wrote: On 13 August 2015 at 00:31, Robert Haas robertmh...@gmail.com wrote: On Wed, Aug 12, 2015 at 7:20 PM, Tom Lane t...@sss.pgh.pa.us wrote: We've talked about having some sort of second rank of tests that people wouldn't

Re: [HACKERS] Raising our compiler requirements for 9.6

2015-08-16 Thread Noah Misch
On Fri, Aug 14, 2015 at 08:40:13PM +0200, Andres Freund wrote: On 2015-08-06 12:29:15 -0300, Alvaro Herrera wrote: + * lockdefs.h + * Frontend exposed parts of postgres' low level lock mechanism I actually think the split came out to work far better than I'd anticipated.

Re: [HACKERS] Management of simple_eval_estate for plpgsql DO blocks

2015-08-16 Thread Simon Riggs
On 14 August 2015 at 17:42, Tom Lane t...@sss.pgh.pa.us wrote: The simplest fix for this would be to give up on the idea that DO blocks use private simple_eval_estates, and make them use the shared one. However, that would result in intra-transaction memory bloat for transactions executing

Re: [HACKERS] TAP tests are badly named

2015-08-16 Thread Noah Misch
On Fri, Aug 14, 2015 at 09:31:43AM -0400, Andrew Dunstan wrote: On 08/14/2015 09:27 AM, Andrew Dunstan wrote: The code is rearranged a little, and an incorrect piece of code setting $ENV{PERL5LIB} is fixed (in the case where it was previously empty it would have added a spurious ; and

Re: [HACKERS] Raising our compiler requirements for 9.6

2015-08-16 Thread Tom Lane
Andres Freund and...@anarazel.de writes: On 2015-08-15 23:50:09 -0400, Noah Misch wrote: Solaris Studio 12.3 (newest version as of Oct 2014) still does that when optimization is disabled, and I place sufficient value on keeping inlining enabled for such a new compiler. Ah, that's cool. I was

Re: [HACKERS] Test code is worth the space

2015-08-16 Thread Greg Stark
On Sun, Aug 16, 2015 at 7:33 AM, Noah Misch n...@leadboat.com wrote: When I've just spent awhile implementing a behavior change, the test diffs are a comforting sight. They confirm that the test suite exercises the topic I just changed. Furthermore, most tests today do not qualify under this

Re: [HACKERS] TAP tests are badly named

2015-08-16 Thread Michael Paquier
On Mon, Aug 17, 2015 at 7:15 AM, Noah Misch n...@leadboat.com wrote: On Sun, Aug 16, 2015 at 05:08:56PM -0400, Andrew Dunstan wrote: On 08/16/2015 02:23 PM, Noah Misch wrote: -sub tapcheck +sub tap_check { - InstallTemp(); + die Tap tests not enabled in configuration + unless

[HACKERS] Error message with plpgsql CONTINUE

2015-08-16 Thread Jim Nasby
Calling CONTINUE with a label that's not a loop produces an error message with no context info [1]. This is because of rc = exec_stmt_block(estate, func-action); if (rc != PLPGSQL_RC_RETURN) { estate.err_stmt = NULL; estate.err_text =

Re: [HACKERS] TAP tests are badly named

2015-08-16 Thread Noah Misch
On Sun, Aug 16, 2015 at 05:08:56PM -0400, Andrew Dunstan wrote: On 08/16/2015 02:23 PM, Noah Misch wrote: -sub tapcheck +sub tap_check { - InstallTemp(); + die Tap tests not enabled in configuration + unless $config-{tap_tests}; I endorse Heikki's argument for having omitted the

Re: [HACKERS] TAP tests are badly named

2015-08-16 Thread Andrew Dunstan
On 08/16/2015 02:23 PM, Noah Misch wrote: -sub tapcheck +sub tap_check { - InstallTemp(); + die Tap tests not enabled in configuration + unless $config-{tap_tests}; I endorse Heikki's argument for having omitted the configuration flag: