Re: [HACKERS] GIN data corruption bug(s) in 9.6devel

On Tue, Apr 26, 2016 at 08:22:03PM +0300, Teodor Sigaev wrote: > >>Check my reasoning: In version 4 I added a remebering of tail of pending > >>list into blknoFinish variable. And when we read page which was a tail on > >>cleanup start then we sets cleanupFinish variable and after cleaning that > >

Re: [HACKERS] Re: [COMMITTERS] Re: pgsql: Convert contrib/seg's bool-returning SQL functions to V1 call co

Michael Paquier writes: > On Wed, Apr 27, 2016 at 10:53 PM, Tom Lane wrote: >> Now, if VS2015 actually has broken bool-returning V0, the argument for >> keeping it going becomes a lot weaker. But at this point I suspect >> strongly that that's not what happened but rather we've got a faulty >> b

Re: [HACKERS] Re: [COMMITTERS] Re: pgsql: Convert contrib/seg's bool-returning SQL functions to V1 call co

On Wed, Apr 27, 2016 at 10:53 PM, Tom Lane wrote: > Now, if VS2015 actually has broken bool-returning V0, the argument for > keeping it going becomes a lot weaker. But at this point I suspect > strongly that that's not what happened but rather we've got a faulty > bool cast there, which if true i

Re: [HACKERS] Shared memory and processes

On Thu, Apr 28, 2016 at 12:24 PM, wrote: >> From: Michael Paquier [mailto:michael.paqu...@gmail.com] >> Another thing that you may want to look at is DSM (dynamic shared memory), >> with its interface in dsm.h. An example of use is in >> src/test/modules/test_shm_mq. > > Yes, that is useful. I'm

Re: [HACKERS] Optimization for updating foreign tables in Postgres FDW

On Wed, Apr 27, 2016 at 12:16 PM, Etsuro Fujita wrote: > On 2016/04/26 21:45, Etsuro Fujita wrote: >> While re-reviewing the fix, I noticed that since PQcancel we added to >> pgfdw_xact_callback to cancel a DML pushdown query isn't followed by a >> ROLLBACK, the connection to the remote server wil

Re: [HACKERS] pgindent

On Wed, Apr 27, 2016 at 6:10 PM, Tom Lane wrote: > Robert Haas writes: >> On Wed, Apr 27, 2016 at 2:23 PM, Tom Lane wrote: >>> Um, we normally take the buildfarm's list of typedefs, not anything >>> manually created. > >> Well, we can still do that, but I don't see much advantage in it. It >> j

Re: [HACKERS] Shared memory and processes

> From: Michael Paquier [mailto:michael.paqu...@gmail.com] > > Does Postgres provide a convenient way for one process to pass data to > > another using shared memory? > > If you are talking about enabling the use of shared memory by 3rd-part > plugins or modules, there is shmem_startup_hook for th

Re: [HACKERS] Shared memory and processes

> From: Thomas Munro [mailto:thomas.mu...@enterprisedb.com] > > Does Postgres provide a convenient way for one process to pass data to > > another using shared memory? > > 1. Look at ShmemInitStruct, ShmemInitHash (as in hash table), ShmemInitQueue > in storage/shmem.h. These use memory that is

Re: [HACKERS] Fix for OpenSSL error queue bug

Alvaro Herrera writes: > Peter Geoghegan wrote: >> I'm not sure if project policy around backpatching (that commit >> messages and so on should match exactly) has anything to say about the >> case where backpatching follows several weeks after commit to the >> master branch. > There is no value i

Re: [HACKERS] Parallel build with MSVC

On Wed, Apr 27, 2016 at 5:15 PM, Christian Ullrich wrote: > OK then, hopefully last round attached. Thanks. Those are fine in my view. It is hard to tell if a committer is going to have a look at that soon, so I think that it would be wiser to add that to the next CF so as those patches don't fal

Re: [HACKERS] Make PG's "NOT NULL"s and attnotnull ("is_nullable") conform to SQL-2011

Vitaly Burovoy wrote: Hi, > But before starting working on it I had a look at the SQL-2011 > standard (ISO/IEC 9075-2)[3] and found that: > > 1. A name for a "NOT NULL" constraint can be given by a table > definition (subcl. 11.4, "Format"->"column constraint definition"). > 2. The standard spl

Re: [HACKERS] Fix for OpenSSL error queue bug

Peter Geoghegan wrote: > I'm not sure if project policy around backpatching (that commit > messages and so on should match exactly) has anything to say about the > case where backpatching follows several weeks after commit to the > master branch. There is no value in providing exact message match

Re: [HACKERS] Shared memory and processes

On Thu, Apr 28, 2016 at 9:56 AM, wrote: > Does Postgres provide a convenient way for one process to pass data to > another using shared memory? If you are talking about enabling the use of shared memory by 3rd-part plugins or modules, there is shmem_startup_hook for this purpose. Another thing t

Re: [HACKERS] EXPLAIN VERBOSE with parallel Aggregate

On 28 April 2016 at 04:08, Robert Haas wrote: > On Tue, Apr 26, 2016 at 11:38 PM, David Rowley >> The patch looks good. The only other thing I thought about was perhaps >> it would be a good idea to re-add the sanity checks in execQual.c. >> Patch for that is attached. >> >> I removed the aggoutpu

Re: [HACKERS] Shared memory and processes

On Thu, Apr 28, 2016 at 12:56 PM, wrote: > Does Postgres provide a convenient way for one process to pass data to > another using shared memory? 1. Look at ShmemInitStruct, ShmemInitHash (as in hash table), ShmemInitQueue in storage/shmem.h. These use memory that is mapped at the same address

[HACKERS] Shared memory and processes

Does Postgres provide a convenient way for one process to pass data to another using shared memory? Regards David M Bennett FACS _ Andl - A New Database Language - andl.org

Re: [HACKERS] Add jsonb_compact(...) for whitespace-free jsonb to text

On Sun, Apr 24, 2016 at 3:02 PM, Sehrope Sarkuni wrote: > Attached is a *very* work in progress patch that adds a > jsonb_compact(jsonb)::text function. It generates a text representation > without extra whitespace but does not yet try to enforce a stable order of > the properties within a jsonb

Re: [HACKERS] Re: [COMMITTERS] pgsql: Modify the isolation tester so that multiple sessions can wait.

=?UTF-8?Q?Mikael_Kjellstr=c3=b6m?= writes: > And that seems to have done the trick. I started a manual run of HEAD > on curculio and now it's green on the build farm. > Thanks! Thank *you*, for putting up a buildfarm member that caught this bug. regards, tom lane --

Re: [HACKERS] Add jsonb_compact(...) for whitespace-free jsonb to text

On Sun, Apr 24, 2016 at 3:02 PM, Sehrope Sarkuni wrote: > It'd be nice to have a stable text representation of a jsonb value with > minimal whitespace. The latter would also save a few bytes per record in > text output formats, on the wire, and in backups (ex: COPY ... TO STDOUT). > ​ > Attached

Re: [HACKERS] Re: [COMMITTERS] pgsql: Modify the isolation tester so that multiple sessions can wait.

On 2016-04-28 00:15, Tom Lane wrote: Thomas Munro writes: Also happens on OpenBSD 5.8. Isn't this a classic case where memmove is called for? Replacing the memcpy at line 617 with memmove makes the tests run successfully, but at first glance the other two instances of memcpy in run_permutati

Re: [HACKERS] Re: [COMMITTERS] pgsql: Modify the isolation tester so that multiple sessions can wait.

Thomas Munro writes: >> Also happens on OpenBSD 5.8. Isn't this a classic case where memmove >> is called for? Replacing the memcpy at line 617 with memmove makes >> the tests run successfully, but at first glance the other two >> instances of memcpy in run_permutation should also be changed to

Re: [HACKERS] pgindent

Robert Haas writes: > On Wed, Apr 27, 2016 at 2:23 PM, Tom Lane wrote: >> Um, we normally take the buildfarm's list of typedefs, not anything >> manually created. > Well, we can still do that, but I don't see much advantage in it. It > just churns the file to the extent that manual review of th

Re: [HACKERS] Support for N synchronous standby servers - take 2

Kyotaro HORIGUCHI writes: > Sorry, I have attached an empty patch. This is another one that should > be with content. I pushed this after whacking it around some, and cleaning up some sort-of-related problems in the syncrep parser/lexer. There remains a point that I'm not very happy about, which

Re: [HACKERS] Re: [COMMITTERS] pgsql: Modify the isolation tester so that multiple sessions can wait.

On Thu, Apr 28, 2016 at 8:46 AM, Thomas Munro wrote: > On Thu, Apr 28, 2016 at 7:02 AM, Alvaro Herrera > wrote: >> Robert Haas wrote: >> >>> That looks like malloc() returned NULL. I noticed when writing that >>> patch that isolationtester has never had any checks for malloc >>> returning NULL,

Re: [HACKERS] WIP: Covering + unique indexes.

On 4/27/16 5:08 PM, Peter Geoghegan wrote: > So, in case it needs to be > said, I'll say it: You've chosen a very ambitious set of projects to > work on, by any standard. I think it's a good thing that you've been > ambitious, and I don't suggest changing that, since I think that you > have commen

Re: [HACKERS]

On Sat, Jan 30, 2016 at 11:06:10PM -0800, Vitaly Burovoy wrote: > Hackers, > > I've just found a little bug: extracting "epoch" from the last 30 > years before Postgres' "+Infinity" leads an integer overflow: > > postgres=# SELECT x::timestamptz, extract(epoch FROM x::timestamptz) > postgres-# FR

Re: [HACKERS] Returning 'Infinity'::TIMESTAMPTZ from "to_timestamp" function

FYI, I show this as fixed in 9.6: test=> SELECT to_timestamp('Infinity'::float); to_timestamp -- infinity (1 row) --- On Sun, Nov 8, 2015 at 09:15:16PM -0800, Vitaly Bu

Re: [HACKERS] pgindent

On Wed, Apr 27, 2016 at 05:01:14PM -0400, Bruce Momjian wrote: > On Wed, Apr 27, 2016 at 02:54:35PM -0400, Robert Haas wrote: > > On Wed, Apr 27, 2016 at 2:23 PM, Tom Lane wrote: > > > Robert Haas writes: > > >> I think it's about time for us to run pgindent. I did a trial run > > >> today of pg

Re: [HACKERS] Patch: typo, s/espaced/escaped/

On Wed, Mar 16, 2016 at 05:10:57PM +0300, Aleksander Alekseev wrote: > There is a typo in one word in this commit: > > http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=9a206d063c410df7cd5da01b169b23bff413fef5 > > Patch attached. This patch has been applied by Teodor. Thanks. -

Re: [HACKERS] WIP: Covering + unique indexes.

On Tue, Apr 12, 2016 at 9:14 AM, Anastasia Lubennikova wrote: > Sooner or later, I'd like to see this patch finished. Me, too. > For now, it has two complaints: > - support of expressions as included columns. > Frankly, I don't understand, why it's a problem of the patch. > The patch is already

Re: [HACKERS] Parallel indicators not written by pg_get_functiondef

On Wed, Apr 27, 2016 at 3:02 AM, Feike Steenbergen wrote: > This patch is redundant as of commit > 2ac3be2e763d9b971352819f285dd51519e0aeb9 > > (Ashutosh Sharma diagnosed and patched the same problem) Oops. I completely failed to notice this prior report. Sorry about that. -- Robert Haas Ente

Re: [HACKERS] Add jsonb_compact(...) for whitespace-free jsonb to text

* Merlin Moncure (mmonc...@gmail.com) wrote: > On Tue, Apr 26, 2016 at 11:49 AM, Stephen Frost wrote: > > As I mentioned to Sehrope on IRC, at least for my 2c, if you want a > > compact JSON format to reduce the amount of traffic over the wire or to > > do things with on the client side, we should

Re: [HACKERS] pgindent

On Wed, Apr 27, 2016 at 02:54:35PM -0400, Robert Haas wrote: > On Wed, Apr 27, 2016 at 2:23 PM, Tom Lane wrote: > > Robert Haas writes: > >> I think it's about time for us to run pgindent. I did a trial run > >> today of pgindent today and came up with the attached patch for > >> typedefs.list,

Re: [HACKERS] Re: [COMMITTERS] pgsql: Modify the isolation tester so that multiple sessions can wait.

On Thu, Apr 28, 2016 at 7:02 AM, Alvaro Herrera wrote: > Robert Haas wrote: > >> That looks like malloc() returned NULL. I noticed when writing that >> patch that isolationtester has never had any checks for malloc >> returning NULL, which is bad, and probably worth fixing, but I didn't >> choose

Re: [HACKERS] pg_dump dump catalog ACLs

Alvaro, On Wednesday, April 27, 2016, Alvaro Herrera wrote: > Stephen Frost wrote: > > > The current challenge I've been trying to find a solution to is testing > the > > extension handling. Only core extensions (plpgsql, plperl, etc) are > > available when the TAP tests are running for pg_dump,

Re: [HACKERS] Bogus cleanup code in PostgresNode.pm

Michael Paquier wrote: > On Tue, Apr 26, 2016 at 2:24 PM, Tom Lane wrote: > > Now, whether using END is really an improvement is a separate question. > > I have the impression that END calls happen in a better-defined order, > > but I'm not a perl monk. > > For the archive's sake, 08af9219 is the

Re: [HACKERS] pg_dump dump catalog ACLs

Stephen Frost wrote: > The current challenge I've been trying to find a solution to is testing the > extension handling. Only core extensions (plpgsql, plperl, etc) are > available when the TAP tests are running for pg_dump, it seems. I certainly > don't want to add a testing extension in such a w

[HACKERS] Re: [COMMITTERS] pgsql: Modify the isolation tester so that multiple sessions can wait.

Robert Haas wrote: > That looks like malloc() returned NULL. I noticed when writing that > patch that isolationtester has never had any checks for malloc > returning NULL, which is bad, and probably worth fixing, but I didn't > choose to stop and fix it at that time. I didn't actually check clos

Re: [HACKERS] pgindent

On Wed, Apr 27, 2016 at 2:23 PM, Tom Lane wrote: > Robert Haas writes: >> I think it's about time for us to run pgindent. I did a trial run >> today of pgindent today and came up with the attached patch for >> typedefs.list, which I'd like to commit more or less immediately, >> barring objection

[HACKERS] Re: [COMMITTERS] pgsql: Modify the isolation tester so that multiple sessions can wait.

On Wed, Apr 27, 2016 at 1:51 PM, Alvaro Herrera wrote: > Robert Haas wrote: >> Modify the isolation tester so that multiple sessions can wait. > > Mikael was kind enough to set up an OpenBSD 5.9 buildfarm member, and > it's been failing in isolationtester. (I kindly accepted my suggestion > to pu

[HACKERS] Re: [COMMITTERS] pgsql: Modify the isolation tester so that multiple sessions can wait.

Robert Haas wrote: > Modify the isolation tester so that multiple sessions can wait. Mikael was kind enough to set up an OpenBSD 5.9 buildfarm member, and it's been failing in isolationtester. (I kindly accepted my suggestion to put it to run even though it is failing so that we could look at the

Re: [HACKERS] Timeline following for logical slots

On 2016-04-27 14:21:53 -0400, Robert Haas wrote: > > Considering that pg_recvlogical was introduced mostly as a way to test > > logical decoding features, I think this is a serious oversight and we > > should patch it. I suppose we could leave it for 9.7, thought I admit I > > would prefer it to i

Re: [HACKERS] pgindent

Robert Haas writes: > I think it's about time for us to run pgindent. I did a trial run > today of pgindent today and came up with the attached patch for > typedefs.list, which I'd like to commit more or less immediately, > barring objections. Um, we normally take the buildfarm's list of typedef

Re: [HACKERS] Timeline following for logical slots

On Tue, Apr 26, 2016 at 4:35 PM, Alvaro Herrera wrote: > Craig Ringer wrote: >> The reason the new src/test/recovery/ tests don't notice this is that using >> pg_recvlogical from the TAP tests is currently pretty awkward. >> pg_recvlogical has no way to specify a stop-point or return when there's

Re: [HACKERS] 9.6 and fsync=off

On Wed, Apr 27, 2016 at 11:04 AM, Craig Ringer wrote:>> I'd suggest something like >> >> #fsync = on # flush data to disk for crash >> safety >> # (turning this off can cause >> # unrecovera

Re: [HACKERS] Rename max_parallel_degree?

Robert Haas wrote: > Of course, we could make this value 1-based rather than 0-based, as > Peter Geoghegan suggested a while back. But as I think I said at the > time, I think that's more misleading than helpful. The leader > participates in the parallel plan, but typically does far less

Re: [HACKERS] EXPLAIN VERBOSE with parallel Aggregate

On Tue, Apr 26, 2016 at 11:38 PM, David Rowley wrote: > On 27 April 2016 at 15:12, Robert Haas wrote: >> On Tue, Apr 26, 2016 at 10:57 PM, David Rowley >> wrote: >>> On 27 April 2016 at 14:30, Robert Haas wrote: On Tue, Apr 26, 2016 at 9:56 PM, Robert Haas wrote: > On Tue, Apr 26, 201

Re: [HACKERS] Show dropped users' backends in pg_stat_activity

On Thu, Apr 7, 2016 at 11:22:08PM +0300, Oskari Saarenmaa wrote: > 24.03.2016, 18:03, Tom Lane kirjoitti: > >Robert Haas writes: > >>I am not really in favor of half-fixing this. If we can't > >>conveniently wait until a dropped role is completely out of the > >>system, then I don't see a lot of

Re: [HACKERS] Suspicious behaviour on applying XLOG_HEAP2_VISIBLE.

On Wed, Apr 27, 2016 at 12:03 PM, Andres Freund wrote: > On 2016-04-27 11:59:39 -0400, Robert Haas wrote: >> Masahiko Sawada posted a patch that fixes the problem for him, which >> does not involve any new WAL record type. It also seems to be fixing >> the problem in a way that is clean and consi

Re: [HACKERS] Suspicious behaviour on applying XLOG_HEAP2_VISIBLE.

On 2016-04-27 11:59:39 -0400, Robert Haas wrote: > Masahiko Sawada posted a patch that fixes the problem for him, which > does not involve any new WAL record type. It also seems to be fixing > the problem in a way that is clean and consistent with what we've done > elsewhere. It only fixes one sy

Re: [HACKERS] pgindent

On Wed, Apr 27, 2016 at 11:57 AM, Bruce Momjian wrote: > On Wed, Apr 27, 2016 at 11:51:42AM -0400, Robert Haas wrote: >> >> It mostly just adds new typedefs that have >> >> appeared over the last year, but it also realphabetizes the file - >> >> some things that were added incrementally seem to ha

Re: [HACKERS] Suspicious behaviour on applying XLOG_HEAP2_VISIBLE.

On Wed, Apr 27, 2016 at 11:51 AM, Andres Freund wrote: > On 2016-04-27 14:27:33 +0900, Michael Paquier wrote: >> On Wed, Apr 27, 2016 at 12:25 AM, Robert Haas wrote: >> > In other words, I think Masahiko Sawada's patch in the original post >> > is pretty much right on target, except that we don't

Re: [HACKERS] pgindent

On Wed, Apr 27, 2016 at 11:51:42AM -0400, Robert Haas wrote: > >> It mostly just adds new typedefs that have > >> appeared over the last year, but it also realphabetizes the file - > >> some things that were added incrementally seem to have ended up in > >> what is, at least according to what sort

Re: [HACKERS] pgindent

On Wed, Apr 27, 2016 at 10:57 AM, Bruce Momjian wrote: > Agreed. Sounds like a good plan --- a better plan than I have used in > the past. Thinking about this a bit more, what I am inclined to do is: 1. Run pgindent. 2. Read the diff and revert any changes that look icky. 3. Commit the rest.

Re: [HACKERS] pgindent

On Wed, Apr 27, 2016 at 11:45 AM, Andres Freund wrote: > Yes, that makes sense. That way other can easily look at "their" code, > to see whether it can be made more pgindent resistant ;) Right. >> It mostly just adds new typedefs that have >> appeared over the last year, but it also realphabetiz

Re: [HACKERS] Suspicious behaviour on applying XLOG_HEAP2_VISIBLE.

On 2016-04-27 14:27:33 +0900, Michael Paquier wrote: > On Wed, Apr 27, 2016 at 12:25 AM, Robert Haas wrote: > > In other words, I think Masahiko Sawada's patch in the original post > > is pretty much right on target, except that we don't need to do that > > always, but rather only in the FPI case

Re: [HACKERS] pgindent

On 2016-04-27 10:51:55 -0400, Robert Haas wrote: > I think it's about time for us to run pgindent. Sounds reasonable. > I did a trial run > today of pgindent today and came up with the attached patch for > typedefs.list, which I'd like to commit more or less immediately, > barring objections. Ye

Re: [HACKERS] Support for N synchronous standby servers - take 2

Kyotaro HORIGUCHI writes: > Sorry, I have attached an empty patch. This is another one that should > be with content. I started to review this, and in passing came across this gem in syncrep_scanner.l: /* * flex emits a yy_fatal_error() function that it calls in response to * critical error

Re: [HACKERS] 9.6 and fsync=off

On 27 April 2016 at 21:44, Tom Lane wrote: > Petr Jelinek writes: > > +1 (Abhijit's wording with data loss changed to data corruption) > > I'd suggest something like > > #fsync = on # flush data to disk for crash > safety > # (t

[HACKERS] pgindent

I think it's about time for us to run pgindent. I did a trial run today of pgindent today and came up with the attached patch for typedefs.list, which I'd like to commit more or less immediately, barring objections. It mostly just adds new typedefs that have appeared over the last year, but it al

Re: [HACKERS] pgindent

On Wed, Apr 27, 2016 at 10:51:55AM -0400, Robert Haas wrote: > I think it's about time for us to run pgindent. I did a trial run > today of pgindent today and came up with the attached patch for > typedefs.list, which I'd like to commit more or less immediately, > barring objections. It mostly ju

Re: [HACKERS] Removing faulty hyperLogLog merge function

On Wed, Apr 27, 2016 at 1:37 AM, Michael Paquier wrote: >> I haven't followed this issue all that closely, but to me it seems >> pretty clear. If the function is brand new to 9.6, buggy, and not even >> used anywhere, I cannot imagine why we would leave it in the tree. > > +1. We should definitely

Re: [HACKERS] Re: [COMMITTERS] Re: pgsql: Convert contrib/seg's bool-returning SQL functions to V1 call co

On Wed, Apr 27, 2016 at 9:53 AM, Tom Lane wrote: > Robert Haas writes: >> Let's add a GUC allow_oldstyle_functions with a default of off, and >> make fetch_finfo_record() throw an ERROR in the infofunc == NULL case >> unless allow_oldstyle_functions = on. > > This is not about "V0 calling convent

Re: [HACKERS] Re: [COMMITTERS] Re: pgsql: Convert contrib/seg's bool-returning SQL functions to V1 call co

Robert Haas writes: > Let's add a GUC allow_oldstyle_functions with a default of off, and > make fetch_finfo_record() throw an ERROR in the infofunc == NULL case > unless allow_oldstyle_functions = on. This is not about "V0 calling convention is awful". It isn't, really, unless you need to deal

Re: [HACKERS] 9.6 and fsync=off

Petr Jelinek writes: > +1 (Abhijit's wording with data loss changed to data corruption) I'd suggest something like #fsync = on # flush data to disk for crash safety # (turning this off can cause

Re: [HACKERS] Add jsonb_compact(...) for whitespace-free jsonb to text

On Tue, Apr 26, 2016 at 11:49 AM, Stephen Frost wrote: > * Ryan Pedela (rped...@datalanche.com) wrote: >> On Sun, Apr 24, 2016 at 4:02 PM, Sehrope Sarkuni wrote: >> > The default text representation of jsonb adds whitespace in between >> > key/value pairs (after the colon ":") and after successiv

Re: [HACKERS] Add jsonb_compact(...) for whitespace-free jsonb to text

On 26 April 2016 at 12:49, Stephen Frost wrote: > * Ryan Pedela (rped...@datalanche.com) wrote: > > On Sun, Apr 24, 2016 at 4:02 PM, Sehrope Sarkuni > wrote: > > > The default text representation of jsonb adds whitespace in between > > > key/value pairs (after the colon ":") and after successive

Re: [HACKERS] pg_dump dump catalog ACLs

Noah, On Wednesday, April 27, 2016, Noah Misch wrote: > A later thought: > > On Mon, Apr 25, 2016 at 12:39:09AM -0400, Stephen Frost wrote: > > src/bin/pg_dump: make check > > > > implemented using the TAP testing system. There are a total of 360 > > tests, generally covering: > > > > Various i

[HACKERS] Re: [COMMITTERS] Re: pgsql: Convert contrib/seg's bool-returning SQL functions to V1 call co

On Tue, Apr 26, 2016 at 10:59 PM, Tom Lane wrote: > Andres Freund writes: >> I don't understand why we don't just drop V0. It makes debugging harder, >> exploitation easier (call arbitrary functions), and really has no >> features making it desirable. > > What's the argument that it makes debuggi

[HACKERS] Processes and caches in postgresql

Hi, hackers. There's a couple of questions about processes. I found EXEC_BACKEND flag, while reading the code. As I understood, it exists because we have to emulate fork() on WIN32. And also it allows to debug the same behavior on Linux. Is it right? Are there any other use cases? Another questi

Re: [HACKERS] 9.6 and fsync=off

Here's a patch just to help things along. -- Abhijit diff --git a/src/backend/utils/misc/postgresql.conf.sample b/src/backend/utils/misc/postgresql.conf.sample index f3e3de0..353de2e 100644 --- a/src/backend/utils/misc/postgresql.conf.sample +++ b/src/backend/utils/misc/postgresql.conf.sample @@ -

Re: [HACKERS] 9.6 and fsync=off

On 27/04/16 12:53, Magnus Hagander wrote: On Wed, Apr 27, 2016 at 12:43 PM, Abhijit Menon-Sen mailto:a...@2ndquadrant.com>> wrote: At 2016-04-27 17:58:08 +0800, cr...@2ndquadrant.com wrote: > > #fsync = on # turns force

Re: [HACKERS] 9.6 and fsync=off

On Wed, Apr 27, 2016 at 12:43 PM, Abhijit Menon-Sen wrote: > At 2016-04-27 17:58:08 +0800, cr...@2ndquadrant.com wrote: > > > > #fsync = on # turns forced synchronization > on or off > > I suggest:# provide crash safety by > flushing dis

Re: [HACKERS] 9.6 and fsync=off

At 2016-04-27 17:58:08 +0800, cr...@2ndquadrant.com wrote: > > #fsync = on # turns forced synchronization on or > off I suggest:# provide crash safety by flushing disk writes # (Disabling this c

[HACKERS] 9.6 and fsync=off

Hi all After helping clean up the mess from another user who turned fsync=off because they read (bad) tuning advice that it was faster, I'd really like to change the config file comment. Really. #fsync = on # turns forced synchronization on or off Now, we can't renam

Re: [HACKERS] Parallel build with MSVC

* From: Michael Paquier [mailto:michael.paqu...@gmail.com] > On Wed, Apr 27, 2016 at 4:06 PM, Christian Ullrich > wrote: > > * From: Michael Paquier [mailto:michael.paqu...@gmail.com] > >> vcbuild also supports /m. Wouldn't it make sense to have a environment > >> variable flag for it as well?

Re: [HACKERS] psql :: support for \ev viewname and \sv viewname

[Looking back over old threads] On 22 July 2015 at 22:00, Dean Rasheed wrote: > This appears to be missing support for view options (WITH CHECK OPTION > and security_barrier), so editing a view with either of those options > will cause them to be stripped off. It seems like this issue was never

Re: [HACKERS] Parallel build with MSVC

On Wed, Apr 27, 2016 at 4:06 PM, Christian Ullrich wrote: > * From: Michael Paquier [mailto:michael.paqu...@gmail.com] >> Why is that? Your patch just has a look at argv[0] to see if that's a >> debug or release build. > > Sorry, forgot to fix that. I originally used Getopt in build.pl, then > re

Re: [HACKERS] Parallel build with MSVC

* From: Michael Paquier [mailto:michael.paqu...@gmail.com] > On Tue, Apr 26, 2016 at 10:09 PM, Christian Ullrich > wrote: > > -build DEBUG > +build -c DEBUG > > To build just a single project, for example psql, run the commands: > > build psql > -build DEBUG psql > +build -c DEBUG psq

Re: [HACKERS] Parallel indicators not written by pg_get_functiondef

This patch is redundant as of commit 2ac3be2e763d9b971352819f285dd51519e0aeb9 (Ashutosh Sharma diagnosed and patched the same problem) On 15 April 2016 at 14:13, Michael Paquier wrote: > On Fri, Apr 15, 2016 at 8:48 PM, Feike Steenbergen > wrote: > > pg_get_functiondef(oid) does not return the