Re: [HACKERS] Speed up Clog Access by increasing CLOG buffers

2016-09-17 Thread Amit Kapila
On Sat, Sep 17, 2016 at 11:25 PM, Tomas Vondra wrote: > On 09/17/2016 07:05 AM, Amit Kapila wrote: >> >> On Sat, Sep 17, 2016 at 9:17 AM, Tomas Vondra >> wrote: >>> >>> On 09/14/2016 05:29 PM, Robert Haas wrote: > > ... Sure,

Re: [HACKERS] Parallel sec scan in plpgsql

2016-09-17 Thread Amit Kapila
On Fri, Sep 16, 2016 at 8:48 PM, Alex Ignatov wrote: > > On 16.09.2016 16:50, Amit Kapila wrote: >> >> >> Can you try by setting force_parallel_mode = off;? I think it is >> sending the whole function execution to worker due to >> force_parallel_mode. >> >> > > No

Re: [HACKERS] WIP: About CMake v2

2016-09-17 Thread Peter Eisentraut
On 9/16/16 9:33 AM, Michael Paquier wrote: > I am no cmake guru yet, but VPATH builds are supported out of the box, > which is cool. > > Your patch recommends to build with cmake after creating build/, now I > would expect most users to run cmake from the root folder. My understanding is that

Re: [HACKERS] [bug fix] pg_recvlogical is missing in the Windows installation

2016-09-17 Thread Michael Paquier
On Sun, Sep 18, 2016 at 7:01 AM, MauMau wrote: > pg_recvlogical is not included in the Windows client installation, > which is performed by running "install client". The > attached patch based on HEAD fixes this. I confirmed nothing else is > missing in the client

[HACKERS] [bug fix] pg_recvlogical is missing in the Windows installation

2016-09-17 Thread MauMau
Hello, pg_recvlogical is not included in the Windows client installation, which is performed by running "install client". The attached patch based on HEAD fixes this. I confirmed nothing else is missing in the client installation. Regards MauMau (= Takayuki Tsunakawa)

Re: [HACKERS] Tuplesort merge pre-reading

2016-09-17 Thread Peter Geoghegan
On Sat, Sep 17, 2016 at 9:41 AM, Heikki Linnakangas wrote: > Ok. I'll probably read through it myself once more some time next week, and > also have a first look at your actual parallel sorting patch. Have a good > trip! Thanks! It will be good to get away for a while. I'd be

Re: [HACKERS] Speed up Clog Access by increasing CLOG buffers

2016-09-17 Thread Tomas Vondra
On 09/17/2016 07:05 AM, Amit Kapila wrote: On Sat, Sep 17, 2016 at 9:17 AM, Tomas Vondra wrote: On 09/14/2016 05:29 PM, Robert Haas wrote: ... Sure, but you're testing at *really* high client counts here. Almost nobody is going to benefit from a 5% improvement

Re: [HACKERS] WIP: About CMake v2

2016-09-17 Thread Yury Zhuravlev
Andres Freund wrote: It's way too likely that we end up releasing with multiple buildsystems that way. If we fail in the CMake integration we can easily remove all CMake files before code freeze. I hope step by step CMake integration better way for current situation. But I do not insist,

Re: [HACKERS] Tuplesort merge pre-reading

2016-09-17 Thread Heikki Linnakangas
On 09/17/2016 07:27 PM, Peter Geoghegan wrote: On Wed, Sep 14, 2016 at 10:43 AM, Heikki Linnakangas wrote: Addressed all your comments one way or another, new patch attached. So, it's clear that this isn't ready today. As I mentioned, I'm going away for a week now. I ask

Re: [HACKERS] Tuplesort merge pre-reading

2016-09-17 Thread Peter Geoghegan
On Wed, Sep 14, 2016 at 10:43 AM, Heikki Linnakangas wrote: > Addressed all your comments one way or another, new patch attached. So, it's clear that this isn't ready today. As I mentioned, I'm going away for a week now. I ask that you hold off on committing this until I return,

Re: [HACKERS] OpenSSL 1.1 breaks configure and more

2016-09-17 Thread Andreas Karlsson
On 09/16/2016 04:11 PM, Christoph Berg wrote: Thanks for the patch! I just tried to apply it to 9.2. There was a conflict in configure.in which was trivial to resolve. Another conflict in contrib/pgcrypto/pgcrypto.c was not applicable because the code doesn't seem to exist (didn't try very

Re: [HACKERS] Rename max_parallel_degree?

2016-09-17 Thread Amit Kapila
On Fri, Sep 16, 2016 at 11:54 PM, Robert Haas wrote: > > + /* > +* We need a write barrier to make sure the update of > +* parallel_terminate_count is done before the store to in_use > +*/ > > Does the order actually matter here? > I think so.