Re: [HACKERS] proposal: multiple psql option -c

2015-07-16 Thread Fabrízio de Royes Mello
ct datname from pg_databases" postgres | \ > xargs -n 1 -P 3 psql -c "..." -c "..." > > Ideas, notes, comments? > Why you want it if we already have the -f option that cover this use case? Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira

[HACKERS] Re: [HACKERS] Re: [HACKERS] GSoC 2015 proposal: Improve the performance of “ALTER TABLE .. SET LOGGED / UNLOGGED” statement

2015-07-09 Thread Fabrízio de Royes Mello
On Thu, Jul 9, 2015 at 10:56 AM, Andres Freund wrote: > > On 2015-07-09 10:39:35 -0300, Fabrízio de Royes Mello wrote: > > If the "wal_level=minimal" we don't need to force the wal log of the > > contents. If the "wal_level != minimal" we need just to x

[HACKERS] Re: [HACKERS] Re: [HACKERS] GSoC 2015 proposal: Improve the performance of “ALTER TABLE .. SET LOGGED / UNLOGGED” statement

2015-07-09 Thread Fabrízio de Royes Mello
On Wed, Jul 8, 2015 at 11:37 AM, Andres Freund wrote: > > On 2015-07-08 10:58:51 -0300, Fabrízio de Royes Mello wrote: > > Think in an ETL job that can be use an unlogged table to improve the load > > performance, but this job create a "large table" and to guarantee

[HACKERS] Re: [HACKERS] Re: [HACKERS] GSoC 2015 proposal: Improve the performance of “ALTER TABLE .. SET LOGGED / UNLOGGED” statement

2015-07-08 Thread Fabrízio de Royes Mello
On Wed, Jul 8, 2015 at 10:53 AM, Andres Freund wrote: > > On 2015-07-03 08:18:09 -0300, Fabrízio de Royes Mello wrote: > > *** ALTER TABLE changes > > ... > > Without going into the specifics of this change: Are we actually sure > this feature warrants the complexity

[HACKERS] Re: [HACKERS] GSoC 2015 proposal: Improve the performance of “ALTER TABLE .. SET LOGGED / UNLOGGED” statement

2015-07-08 Thread Fabrízio de Royes Mello
e executed in two phases: 1) Before the replay checking just the datafiles with the init fork (_init) 2) After the replay checking the datafiles with the stamped init fork ( _init_XID, or something else) Is this reasonable? Regards, -- Fabrízio de Royes Mello Consultoria/Coaching P

[HACKERS] Re: [HACKERS] GSoC 2015 proposal: Improve the performance of “ALTER TABLE .. SET LOGGED / UNLOGGED” statement

2015-07-07 Thread Fabrízio de Royes Mello
On Fri, Jul 3, 2015 at 9:29 AM, Ashutosh Bapat < ashutosh.ba...@enterprisedb.com> wrote: > > > On Fri, Jul 3, 2015 at 4:48 PM, Fabrízio de Royes Mello < fabriziome...@gmail.com> wrote: >> >> >> On Thu, Apr 2, 2015 at 3:24 PM, Robert Haas wrote: >> >

[HACKERS] Re: [HACKERS] GSoC 2015 proposal: Improve the performance of “ALTER TABLE .. SET LOGGED / UNLOGGED” statement

2015-07-03 Thread Fabrízio de Royes Mello
On Thu, Apr 2, 2015 at 3:24 PM, Robert Haas wrote: > > On Wed, Mar 25, 2015 at 9:46 PM, Fabrízio de Royes Mello > wrote: > > http://www.postgresql.org/message-id/ca+tgmozm+-0r7h0edpzzjbokvvq+gavkchmno4fypveccw-...@mail.gmail.com > > I like the idea of the feature a lot, but

Re: [HACKERS] Add CINE for ALTER TABLE ... ADD COLUMN

2015-06-25 Thread Fabrízio de Royes Mello
On Wed, Jun 24, 2015 at 3:36 PM, Alvaro Herrera wrote: > > Fabrízio de Royes Mello wrote: > > > Another rebased version. > > There are a number of unrelated whitespace changes in this patch; also > please update the comment on top of check_for_column_name_collision. >

Re: [HACKERS] Add CINE for ALTER TABLE ... ADD COLUMN

2015-06-24 Thread Fabrízio de Royes Mello
On Thu, Apr 23, 2015 at 12:05 PM, Fabrízio de Royes Mello < fabriziome...@gmail.com> wrote: > > > On Wed, Apr 22, 2015 at 3:48 PM, Payal Singh wrote: > > > > The following review has been posted through the commitfest application: > > make installcheck-worl

Re: [HACKERS] Change pg_cancel_*() to ignore current backend

2015-05-22 Thread Fabrízio de Royes Mello
to add a second parameter and -1 to break backward compatibility with the "default = true". Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog: http://fabriziomello.github.io >> Linkedin: http://br.li

Re: [HACKERS] Missing "-i / --ignore-version" in pg_dump help

2015-05-22 Thread Fabrízio de Royes Mello
On Fri, May 22, 2015 at 9:20 AM, Fujii Masao wrote: > > On Fri, May 22, 2015 at 8:59 PM, Fabrízio de Royes Mello > wrote: > > Hi all, > > > > There are some reason to "-i, --ignore-version" option doesn't appear in > > pg_dump help? > > Be

[HACKERS] Missing "-i / --ignore-version" in pg_dump help

2015-05-22 Thread Fabrízio de Royes Mello
Hi all, There are some reason to "-i, --ignore-version" option doesn't appear in pg_dump help? Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog: http://fabriziomello.github.io >> Linkedin: http:/

[HACKERS] Add some spaces to "ALTER TABLE" doc

2015-05-22 Thread Fabrízio de Royes Mello
Hi all, The attached add some spaces to better visualization of the "ALTER TABLE" doc. Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog: http://fabriziomello.github.io >> Linkedin: http://br.l

Re: [HACKERS] Change pg_cancel_*() to ignore current backend

2015-05-20 Thread Fabrízio de Royes Mello
On Wed, May 20, 2015 at 2:40 AM, Jim Nasby wrote: > > On 5/19/15 9:19 PM, Fabrízio de Royes Mello wrote: >> >> We could add a second parameter to the current functions: >> allow_own_pid DEFAULT false. To me that seems better than an >> entirely separate

Re: [HACKERS] Change pg_cancel_*() to ignore current backend

2015-05-19 Thread Fabrízio de Royes Mello
function we create that >> should do this; while changing the pg_cancel_* functions to operate more >> safely. >> > > We could add a second parameter to the current functions: allow_own_pid > DEFAULT false. To me that seems better than an entirely separate set of

Re: [HACKERS] Proposal : REINDEX xxx VERBOSE

2015-05-13 Thread Fabrízio de Royes Mello
)" if the verbose options is not setted. Maybe change: + +pg_rusage_init(&ru0); to + +if (options & REINDEXOPT_VERBOSE) +pg_rusage_init(&ru0); Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog: http://fabriziomello.github.io >> Linkedin: http://br.linkedin.com/in/fabriziomello >> Twitter: http://twitter.com/fabriziomello >> Github: http://github.com/fabriziomello

Re: [HACKERS] Proposal : REINDEX xxx VERBOSE

2015-05-08 Thread Fabrízio de Royes Mello
On Fri, May 8, 2015 at 4:23 PM, Fabrízio de Royes Mello < fabriziome...@gmail.com> wrote: > > > On Thu, May 7, 2015 at 7:55 PM, Sawada Masahiko wrote: > > > > On 5/7/15, Sawada Masahiko wrote: > > > On Wed, May 6, 2015 at 5:42 AM, Robert Haas > > >

Re: [HACKERS] Proposal : REINDEX xxx VERBOSE

2015-05-08 Thread Fabrízio de Royes Mello
rted only once for each function it appears in COMPLETE_WITH_LIST(list_REINDEX); ^ tab-complete.c:169:22: note: in definition of macro ‘COMPLETE_WITH_LIST’ completion_charpp = list; \ ^ make[3]: *** [tab-complete.o] Error 1 make[3]: *** Waiting fo

Re: [HACKERS] deparsing utility commands

2015-05-08 Thread Fabrízio de Royes Mello
tation updates before this is push-able. > > Here is a complete version. Barring serious problems, I intend to > commit this on Monday. > You forgot to attach the patches! Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br

Re: [HACKERS] add -s to vacuumdb

2015-05-05 Thread Fabrízio de Royes Mello
to add --system and --schema options also. Regards, [1] http://www.postgresql.org/message-id/CAFcNs+pHJLmLM9n=b6aofv3xppwhq+znnejv9ukvpnszyeg...@mail.gmail.com -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog: http://fabriziomello.github.io >> Linkedin: http://br.linkedin.com/in/fabriziomello >> Twitter: http://twitter.com/fabriziomello >> Github: http://github.com/fabriziomello

Re: [HACKERS] psql :: support for \ev viewname and \sv viewname

2015-05-04 Thread Fabrízio de Royes Mello
the "\ev" subcommand in psql. Unfortunately we didn't go ahead with this work. :-( I'll do some reviews. Regards, [1] http://softwarelivre.org/fisl13?lang=en [2] https://github.com/lhcezar/postgres/commit/b4bfc3b17b4a32850d6035165209b2b82746190a -- Fabrízio d

Re: [HACKERS] cache invalidation for PL/pgsql functions

2015-05-01 Thread Fabrízio de Royes Mello
t PLs may have decided to cache, nonwithstanding the fact that they > all cache basically the same stuff using basically the same method. I > think the PL interface will need to be extended in some way to support > a new callback. > > IMHO we need a way to DISCARD run a cleanup code

Re: [HACKERS] Proposal : REINDEX xxx VERBOSE

2015-04-30 Thread Fabrízio de Royes Mello
. > Attached patch is modified syntax as > REINDEX [VERBOSE] { INDEX | ... } name > > Thought? > Looks good to me. Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog: http://fabriziomello.github.io >&g

Re: [HACKERS] Can pg_dump make use of CURRENT/SESSION_USER

2015-04-29 Thread Fabrízio de Royes Mello
On Wed, Apr 29, 2015 at 1:14 PM, Alvaro Herrera wrote: > > Fabrízio de Royes Mello wrote: > > > > Looking at the patch again I realize the code is very ugly, so I'll rework > > the patch. > > Yes, I think get_object_address should figure out what to do w

Re: [HACKERS] Can pg_dump make use of CURRENT/SESSION_USER

2015-04-28 Thread Fabrízio de Royes Mello
On Tue, Apr 28, 2015 at 1:07 PM, Fabrízio de Royes Mello < fabriziome...@gmail.com> wrote: > > > On Tue, Apr 28, 2015 at 9:38 AM, Robert Haas wrote: > > > > On Sat, Apr 25, 2015 at 8:05 AM, Fabrízio de Royes Mello > > wrote: > > >

Re: [HACKERS] Can pg_dump make use of CURRENT/SESSION_USER

2015-04-28 Thread Fabrízio de Royes Mello
On Tue, Apr 28, 2015 at 9:38 AM, Robert Haas wrote: > > On Sat, Apr 25, 2015 at 8:05 AM, Fabrízio de Royes Mello > wrote: > >> >> > If we ever implement something like > >> >> > > >> >> > COMMENT ON CURRENT_DATABASE IS ... >

Re: [HACKERS] PL/pgSQL, RAISE and error context

2015-04-27 Thread Fabrízio de Royes Mello
On Sun, Apr 26, 2015 at 4:19 AM, Pavel Stehule wrote: > > Hi > > I reduced this patch, little bit cleaned - now it is based on plpgsql GUC display_context_min_messages - like client_min_messages, log_min_messages. > What you think just "context_min_messages" ? Regar

Re: [HACKERS] Can pg_dump make use of CURRENT/SESSION_USER

2015-04-25 Thread Fabrízio de Royes Mello
On Wed, Mar 18, 2015 at 2:24 PM, Robert Haas wrote: > > On Wed, Mar 18, 2015 at 1:23 PM, Fabrízio de Royes Mello > wrote: > >> > If we ever implement something like > >> > > >> > COMMENT ON CURRENT_DATABASE IS ... > >> > > >> &g

Re: [HACKERS] Add CINE for ALTER TABLE ... ADD COLUMN

2015-04-23 Thread Fabrízio de Royes Mello
gt; > The new status of this patch is: Waiting on Author > The patch needs a "rebase". Done! Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog: http://fabriziomello.github.io >> Linkedin: htt

Re: [HACKERS] Doubt about AccessExclusiveLock in ALTER TABLE .. SET ( .. );

2015-04-10 Thread Fabrízio de Royes Mello
On Tue, Apr 7, 2015 at 10:57 PM, Fabrízio de Royes Mello < fabriziome...@gmail.com> wrote: > > > On Tue, Apr 7, 2015 at 10:15 PM, Alvaro Herrera wrote: > > > > Fabrízio de Royes Mello wrote: > > > On Mon, Apr 6, 2015 at 12:53 AM, Alvaro Herrera <

Re: [HACKERS] Removal of FORCE option in REINDEX

2015-04-07 Thread Fabrízio de Royes Mello
onger worth keeping supporting > it. > Thought? > > +1 -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog: http://fabriziomello.github.io >> Linkedin: http://br.linkedin.com/in/fabriziomello >> Twit

Re: [HACKERS] Doubt about AccessExclusiveLock in ALTER TABLE .. SET ( .. );

2015-04-07 Thread Fabrízio de Royes Mello
On Tue, Apr 7, 2015 at 10:15 PM, Alvaro Herrera wrote: > > Fabrízio de Royes Mello wrote: > > On Mon, Apr 6, 2015 at 12:53 AM, Alvaro Herrera < alvhe...@2ndquadrant.com> > > wrote: > > > > > > Fabrízio de Royes Mello wrote: > > > > > >

Re: [HACKERS] Doubt about AccessExclusiveLock in ALTER TABLE .. SET ( .. );

2015-04-07 Thread Fabrízio de Royes Mello
On Mon, Apr 6, 2015 at 12:53 AM, Alvaro Herrera wrote: > > Fabrízio de Royes Mello wrote: > > > Ok guys. The attached patch refactor the reloptions adding a new field > > "lockmode" in "relopt_gen" struct and a new method to determine the > > requ

Re: [HACKERS] Proposal : REINDEX xxx VERBOSE

2015-04-07 Thread Fabrízio de Royes Mello
On Tue, Apr 7, 2015 at 1:04 PM, Sawada Masahiko wrote: > > On Tue, Apr 7, 2015 at 10:12 PM, Fabrízio de Royes Mello > wrote: > > > > On Tue, Apr 7, 2015 at 7:22 AM, Sawada Masahiko > > wrote: > >> > >> Thank you for your reviewing. > >> I m

Re: [HACKERS] Proposal : REINDEX xxx VERBOSE

2015-04-07 Thread Fabrízio de Royes Mello
On Tue, Apr 7, 2015 at 7:22 AM, Sawada Masahiko wrote: > > Thank you for your reviewing. > I modified the patch and attached latest version patch(v7). > Please have a look it. > Looks good to me. Attached patch (v8) just fix a tab indentation in gram.y. Regards, -- Fabrízio

Re: [HACKERS] Proposal : REINDEX xxx VERBOSE

2015-04-06 Thread Fabrízio de Royes Mello
d = REINDEX_OBJECT_DATABASE; + n->kind = $2; n->name = $3; n->relation = NULL; + n->verbose = $5; $$ = (Node *)n; } ; 2) The documentation was updated and is accor

Re: [HACKERS] Doubt about AccessExclusiveLock in ALTER TABLE .. SET ( .. );

2015-04-05 Thread Fabrízio de Royes Mello
On Wed, Apr 1, 2015 at 1:45 AM, Noah Misch wrote: > > On Tue, Mar 31, 2015 at 01:17:03PM -0400, Robert Haas wrote: > > On Tue, Mar 31, 2015 at 9:11 AM, Fabrízio de Royes Mello > > wrote: > > > Attached a very WIP patch to reduce lock level when setting autovacuum >

[HACKERS] Re: [HACKERS] GSoC 2015 proposal: Improve the performance of “ALTER TABLE .. SET LOGGED / UNLOGGED” statement

2015-04-05 Thread Fabrízio de Royes Mello
On Thu, Apr 2, 2015 at 3:24 PM, Robert Haas wrote: > > On Wed, Mar 25, 2015 at 9:46 PM, Fabrízio de Royes Mello > wrote: > > http://www.postgresql.org/message-id/ca+tgmozm+-0r7h0edpzzjbokvvq+gavkchmno4fypveccw-...@mail.gmail.com > > I like the idea of the feature a lot, but

Re: [HACKERS] Doubt about AccessExclusiveLock in ALTER TABLE .. SET ( .. );

2015-03-31 Thread Fabrízio de Royes Mello
On Mon, Mar 30, 2015 at 8:14 PM, Fabrízio de Royes Mello < fabriziome...@gmail.com> wrote: > > > > On Mon, Mar 30, 2015 at 7:41 PM, Jim Nasby wrote: > > > > On 3/27/15 2:23 PM, Fabrízio de Royes Mello wrote: > >> > >> Hi all, > >> > &

Re: [HACKERS] Doubt about AccessExclusiveLock in ALTER TABLE .. SET ( .. );

2015-03-30 Thread Fabrízio de Royes Mello
On Mon, Mar 30, 2015 at 7:41 PM, Jim Nasby wrote: > > On 3/27/15 2:23 PM, Fabrízio de Royes Mello wrote: >> >> Hi all, >> >> I'm tweaking some autovacuum settings in a table with high write usage >> but with ALTER TABLE .. SET ( .. ) this task was

[HACKERS] Doubt about AccessExclusiveLock in ALTER TABLE .. SET ( .. );

2015-03-27 Thread Fabrízio de Royes Mello
ion to set reloptions if we just touch in pg_class tuples (RowExclusiveLock) ? Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog: http://fabriziomello.github.io >> Linkedin: http://br.linkedin.com/in/fabriziomello &g

[HACKERS] GSoC 2015 proposal: Improve the performance of “ALTER TABLE .. SET LOGGED / UNLOGGED” statement

2015-03-25 Thread Fabrízio de Royes Mello
/09 for final evaluation and maybe will be committed to 9.6 version (webpage don’t created yet) August 18 - August 21 * do the adjustments based on the community feedback during the commitfest 2015/09 * final mentor review ** About the proponent ** Fabrízio de Royes Mello e-mail: fabriziome

Re: [HACKERS] Error with index on unlogged table

2015-03-25 Thread Fabrízio de Royes Mello
On Wed, Mar 25, 2015 at 12:46 PM, Fabrízio de Royes Mello < fabriziome...@gmail.com> wrote: > > > On Wed, Mar 25, 2015 at 10:53 AM, Andres Freund wrote: > > > > > Did you check whether a similar bug was made in other places of > > 85b506bb? Could you additional

Re: [HACKERS] Error with index on unlogged table

2015-03-25 Thread Fabrízio de Royes Mello
tely this is very nasty. Sorry! > Did you check whether a similar bug was made in other places of > 85b506bb? Could you additionally add a regression test to this end? > Seems like something worth testing. > I'm checking it and adding some regression tests. Regards, -- Fabrízio de R

Re: [HACKERS] Order of enforcement of CHECK constraints?

2015-03-24 Thread Fabrízio de Royes Mello
On Tue, Mar 24, 2015 at 4:28 PM, Fabrízio de Royes Mello < fabriziome...@gmail.com> wrote: > > > > On Mon, Mar 23, 2015 at 12:33 PM, Tom Lane wrote: > > > > =?UTF-8?Q?Fabr=C3=ADzio_de_Royes_Mello?= writes: > > > On Fri, Mar 20, 2015 at 4:37 PM, Tom Lane

Re: [HACKERS] Order of enforcement of CHECK constraints?

2015-03-24 Thread Fabrízio de Royes Mello
>0); ALTER TABLE fabrizio=# alter table foo add constraint bb check(b>0); ALTER TABLE fabrizio=# insert into foo values (0,0); ERROR: new row for relation "foo" violates check constraint "aa" DETAIL: Failing row contains (0, 0). Regards, -- Fabrízio de Royes Mell

Re: [HACKERS] Order of enforcement of CHECK constraints?

2015-03-23 Thread Fabrízio de Royes Mello
onscan = systable_beginscan(conrel, ConstraintRelidIndexId, true, + conscan = systable_beginscan(conrel, ConstraintNameNspIndexId, true, Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog: http://fabriziomello.github.io >>

Re: [HACKERS] Order of enforcement of CHECK constraints?

2015-03-20 Thread Fabrízio de Royes Mello
suggesting that this would > become documented behavior? > I think they should be executed in alphabetical order like triggers. Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog: http://fabriziomello.git

Re: [HACKERS] Can pg_dump make use of CURRENT/SESSION_USER

2015-03-18 Thread Fabrízio de Royes Mello
lready is one. But that would have nothing to do with the proposed > patch anyway, because the bits of syntax in question are not expressions > and you should not try to turn them into things that would call functions. > Yeah... I'll focus on the current scope. Thanks, -- Fabr

Re: [HACKERS] Can pg_dump make use of CURRENT/SESSION_USER

2015-03-18 Thread Fabrízio de Royes Mello
On Wed, Mar 18, 2015 at 3:13 PM, Robert Haas wrote: > > On Wed, Mar 18, 2015 at 2:09 PM, Fabrízio de Royes Mello > wrote: > > Just one last doubt. Do we expose a new function called "current_database" > > like "current_catalog", "current_user",

Re: [HACKERS] Can pg_dump make use of CURRENT/SESSION_USER

2015-03-18 Thread Fabrízio de Royes Mello
On Wed, Mar 18, 2015 at 2:42 PM, Fabrízio de Royes Mello < fabriziome...@gmail.com> wrote: > > > > On Wed, Mar 18, 2015 at 2:24 PM, Robert Haas wrote: > > > > On Wed, Mar 18, 2015 at 1:23 PM, Fabrízio de Royes Mello > > wrote: > >

Re: [HACKERS] Can pg_dump make use of CURRENT/SESSION_USER

2015-03-18 Thread Fabrízio de Royes Mello
On Wed, Mar 18, 2015 at 2:24 PM, Robert Haas wrote: > > On Wed, Mar 18, 2015 at 1:23 PM, Fabrízio de Royes Mello > wrote: > >> > If we ever implement something like > >> > > >> > COMMENT ON CURRENT_DATABASE IS ... > >> > > >> &g

Re: [HACKERS] Can pg_dump make use of CURRENT/SESSION_USER

2015-03-18 Thread Fabrízio de Royes Mello
IN DATABASE current_database ... > > because that will let us dump per-database user options too.) > > +1 for both of those ideas. > Can you explain more about this idea? Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.co

Re: [HACKERS] Strange debug message of walreciver?

2015-03-08 Thread Fabrízio de Royes Mello
. > > > Maybe we should check before and return zero from GetReplicationApplyDelay. > > The attached patch implement it. > > Your patch regards 0 replication apply delay in the case above which > is confusing if the delay is actually 0. > > What about something like this

Re: [HACKERS] Strange debug message of walreciver?

2015-03-07 Thread Fabrízio de Royes Mello
03-08 00:17:21.45018-03 receipttime 2015-03-08 00:17:21.450294-03 replication apply delay -1936495702 ms transfer latency 0 ms Maybe we should check before and return zero from GetReplicationApplyDelay. The attached patch implement it. Regards, -- Fabrízio de Royes Mello Consulto

[HACKERS] Add CINE for ALTER TABLE ... ADD COLUMN

2015-02-26 Thread Fabrízio de Royes Mello
Hi all, This simple patch add CINE for ALTER TABLE ... ADD COLUMN. So now we can: ALTER TABLE foo ADD COLUMN IF NOT EXISTS c1 integer; and/or ... ALTER TABLE foo ADD COLUMN IF NOT EXISTS c1 integer, ADD COLUMN c2 integer; Regards, -- Fabrízio de Royes Mello Consultoria/Coaching

Re: [HACKERS] GSoC idea - Simulated annealing to search for query plans

2015-02-26 Thread Fabrízio de Royes Mello
call somebody demo'ing a simulated-annealing GEQO replacement > > at PGCon a couple years back. It never got to the point of being a > > submitted patch though. > > Yea, it was Jan Urbański (CCed). > And the project link: https://github.com/wulczer/saio Regards, -- Fabrízi

Re: [HACKERS] Index-only scans for GiST.

2015-02-12 Thread Fabrízio de Royes Mello
; >> >> * Documentation is missing. > > > Anastasia provided a documentation patch in the first email. > Yeah, but it's a good practice send all the patches together. Will make the life of the reviewers better ;-) Regards, -- Fabrízio de Royes Mello Con

Re: [HACKERS] [pgsql-advocacy] GSoC 2015 - mentors, students and admins.

2015-02-10 Thread Fabrízio de Royes Mello
student or a mentor. > I'm interested to participate as student again. Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog: http://fabriziomello.github.io >> Linkedin: http://br.linkedin.com/in/fabriziomello

Re: [HACKERS] Proposal : REINDEX xxx VERBOSE

2015-02-03 Thread Fabrízio de Royes Mello
to keep that with REINDEX. Either REINDEX (options) {INDEX | ...} or REINDEX {INDEX | ...} (options). > Makes sense... +1 Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog: http://fabriziomello.github.io >> Li

Re: [HACKERS] Proposal : REINDEX xxx VERBOSE

2015-02-03 Thread Fabrízio de Royes Mello
BLE) hoge_table; > > i.g., I will add following syntax format, > REINDEX ( { INDEX | TABLE | SCHEMA | SYSTEM | DATABASE } , [VERBOSE] ) > name [FORCE]; > > Thought? > I don't think the keyworks INDEX, TABLE, SCHEMA, SYSTEM and DATABASE are options... they are part of the comman

Re: [HACKERS] Providing catalog view to pg_hba.conf file - Patch submission

2015-01-29 Thread Fabrízio de Royes Mello
lete new SQL syntax to manipulate HBA entries like we did with ALTER SYSTEM. It's just some thoughts about it. Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog: http://fabriziomello.github.io >> Linkedin: http

Re: [HACKERS] TODO : Allow parallel cores to be used by vacuumdb [ WIP ]

2015-01-29 Thread Fabrízio de Royes Mello
tgres | 17 MB | > pg_catalog | pg_statistic| table | postgres | 928 kB | > pg_catalog | pg_operator | table | postgres | 552 kB | > pg_catalog | pg_collation| table | postgres | 232 kB | > > > There are a warn

Re: [HACKERS] Providing catalog view to pg_hba.conf file - Patch submission

2015-01-28 Thread Fabrízio de Royes Mello
ut I'm thinking about this patch and would not be interesting to have a FDW to manipulate the hba file? Imagine if we are able to manipulate the HBA file using INSERT/UPDATE/DELETE. Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.b

Re: [HACKERS] event trigger test exception message

2015-01-04 Thread Fabrízio de Royes Mello
owed.'; > > Quite apart from any other reason, the "Sir" does seem a bit sexist - we > have no idea of the gender of the reader. Probably just 'sorry, no rewrite > allowed' would suffice. > > +1 -- Fabrízio de Royes Mello Consultoria/Coaching Postgre

Re: [HACKERS] Parallel Seq Scan

2015-01-01 Thread Fabrízio de Royes Mello
ome if user has registered bgworker before we could > start parallel plan execution. > > Can we check the number of free bgworkers slots to set the max workers? Regards, Fabrízio Mello > -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http:/

Re: [HACKERS] recovery_min_apply_delay with a negative value

2014-12-29 Thread Fabrízio de Royes Mello
is condition recoveryApplyDelay@xlog.c: > /* nothing to do if no delay configured */ > if (recovery_min_apply_delay == 0) > return false; > Shouldn't we simply leave if recovery_min_apply_delay is lower 0, and not only equal to 0? > Seems reasonable. Rega

Re: [HACKERS] Proposal "VACUUM SCHEMA"

2014-12-23 Thread Fabrízio de Royes Mello
Em terça-feira, 23 de dezembro de 2014, Jim Nasby escreveu: > On 12/23/14, 8:54 AM, Fabrízio de Royes Mello wrote: > >> > Right now a lot of people just work around this with things like DO >> blocks, but as mentioned elsewhere in the thread that fails for commands

Re: [HACKERS] Proposal "VACUUM SCHEMA"

2014-12-23 Thread Fabrízio de Royes Mello
On Mon, Dec 22, 2014 at 8:02 PM, Jim Nasby wrote: > > On 12/21/14, 8:55 PM, Fabrízio de Royes Mello wrote: >> >> > And why that, but not >> > say schema-wide ANALYZE, CLUSTER, TRUNCATE, ... >> > >> >> +

Re: [HACKERS] Proposal "VACUUM SCHEMA"

2014-12-22 Thread Fabrízio de Royes Mello
ea. > > +1. > Then to simplify can we allow the "--table" option of vacuumdb act similar to the "--table" option of pg_dump?? Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog: http://fabr

Re: [HACKERS] Proposal "VACUUM SCHEMA"

2014-12-21 Thread Fabrízio de Royes Mello
Em segunda-feira, 22 de dezembro de 2014, Jim Nasby < jim.na...@bluetreble.com> escreveu: > On 12/21/14, 3:30 PM, Fabrízio de Royes Mello wrote: > >> >> On Sun, Dec 21, 2014 at 5:18 PM, Tom Lane > t...@sss.pgh.pa.us>> wrote: >> > &g

Re: [HACKERS] Proposal "VACUUM SCHEMA"

2014-12-21 Thread Fabrízio de Royes Mello
ing > why we need to encourage manual vacuuming. IMHO we will not encourage manual vacuuming, just give more flexibility to users. > And why that, but not > say schema-wide ANALYZE, CLUSTER, TRUNCATE, ... > +1. I can write patches for each of this maintenance statement too. Regar

[HACKERS] Proposal "VACUUM SCHEMA"

2014-12-21 Thread Fabrízio de Royes Mello
] { [ table_name ] | SCHEMA schema_name } Also I'll add a new option to "vacuumdb" client: -S, --schema=SCHEMA I can work on this feature to 2015/02 CF. Thoughts? -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog: htt

Re: [HACKERS] pgbench -f and vacuum

2014-12-21 Thread Fabrízio de Royes Mello
+if (result == NULL) +{ +PQclear(res); +return false; +} + +if (*result == 't') +{ +PQclear(res); +return false;/* table does not exist */ +} To simplify isn't better this way? if (result == NULL || *result == 't') { PQc

Re: [HACKERS] Commitfest problems

2014-12-18 Thread Fabrízio de Royes Mello
d feather me for suggesting this at all..) but it might > be along the same lines as Bruce's PgLife.. > +1 Here in Brazil we need a better way to proof our contributions an involvement with the PostgreSQL Community. Regards, -- Fabrízio de Royes Mello Consultoria/

Re: [HACKERS] CINE in CREATE TABLE AS ... and CREATE MATERIALIZED VIEW ...

2014-12-13 Thread Fabrízio de Royes Mello
Em sábado, 13 de dezembro de 2014, Andrew Dunstan escreveu: > > On 11/03/2014 07:35 AM, Fabrízio de Royes Mello wrote: > >> On Mon, Nov 3, 2014 at 3:12 AM, Rushabh Lathia > <mailto:rushabh.lat...@gmail.com>> wrote: >> > >> > Patch looks good, assig

[HACKERS] Fix typo um vacuumdb tests

2014-12-10 Thread Fabrízio de Royes Mello
Hi all, A little typo in vacuumdb tests. Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog: http://fabriziomello.github.io >> Linkedin: http://br.linkedin.com/in/fabriziomello >> Twitter: http://twitter.com

Re: [HACKERS] Proposal : REINDEX SCHEMA

2014-12-09 Thread Fabrízio de Royes Mello
Maybe we can mention matviews on REINDEX SCHEMA docs, what do you think? Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog: http://fabriziomello.github.io >> Linkedin: http://br.linkedin.com/in/fabriziomello &

Re: [HACKERS] changing primary key col(s) with minimal impact

2014-12-03 Thread Fabrízio de Royes Mello
constraint? > > Thanks for any thoughts/comments. > Hi Joe, I already did something like it once, but to rebuild a bloated PK index with minimal locks. I still waiting for 'REINDEX CONCURRENTLY' :-) At that time I didn't have no trouble with this approach. Regards, -- Fa

Re: [HACKERS] no test programs in contrib

2014-11-26 Thread Fabrízio de Royes Mello
allcheck, installcheck-world, > check-world: they all run the additional tests now. For buildfarm, the > client code will need to be updated to have a new stage for > src/test/modules running "make check". > > I haven't touched MSVC yet. > > Opinions on this

Re: [HACKERS] [GSoC2014] Patch ALTER TABLE ... SET LOGGED

2014-11-15 Thread Fabrízio de Royes Mello
ch it: > > the parent relation always has the same persistence as its indexes. > > There was an argument for doing it this way that only applies if this > patch went in, but I can't remember now what it was. > > Anyway I pushed the patch after some slight ad

Re: [HACKERS] Defining dedicated macro to grab a relation's persistence

2014-11-11 Thread Fabrízio de Royes Mello
ore readable, so I'm not a > fan of further extending the scheme. Consistency with some other common > accessors is an argument though. > What you meant is "relation->rd_rel->relpersistence" is more readable than "RelationGetPersistence(relation)" ?? Regards,

Re: [HACKERS] [GSoC2014] Patch ALTER TABLE ... SET LOGGED

2014-11-10 Thread Fabrízio de Royes Mello
On Thu, Nov 6, 2014 at 3:42 AM, Michael Paquier wrote: > > On Sat, Sep 13, 2014 at 11:02 PM, Fabrízio de Royes Mello > wrote: > > Patch rebased and added to commitfest [1]. > It looks like a good thing to remove ATChangeIndexesPersistence, this > puts the persistence switch

Re: [HACKERS] CREATE IF NOT EXISTS INDEX

2014-11-06 Thread Fabrízio de Royes Mello
On Thu, Nov 6, 2014 at 7:49 AM, Fujii Masao wrote: > > On Sat, Nov 1, 2014 at 1:56 AM, Fabrízio de Royes Mello > wrote: > > > > On Fri, Oct 31, 2014 at 2:46 PM, Adam Brightwell > > wrote: > >> > >> All, > >> > >> FWIW, I've

Re: [HACKERS] Patch: add recovery_timeout option to control timeout of restore_command nonzero status code

2014-11-03 Thread Fabrízio de Royes Mello
On Mon, Nov 3, 2014 at 7:25 PM, Alexey Vasiliev wrote: > > > > > Mon, 3 Nov 2014 19:18:51 -0200 от Fabrízio de Royes Mello < fabriziome...@gmail.com>: > > > > > > > > Should I change my patch and send it by email? And also as I un

Re: [HACKERS] Re[2]: [HACKERS] Patch: add recovery_timeout option to control timeout of restore_command nonzero status code

2014-11-03 Thread Fabrízio de Royes Mello
it-fest using the "Patch" comment type. Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog: http://fabriziomello.github.io >> Linkedin: http://br.linkedin.com/in/fabriziomello >> Twitter: htt

Re: [HACKERS] CINE in CREATE TABLE AS ... and CREATE MATERIALIZED VIEW ...

2014-11-03 Thread Fabrízio de Royes Mello
On Mon, Nov 3, 2014 at 3:12 AM, Rushabh Lathia wrote: > > Patch looks good, assigning to committer. > Thanks for your review! -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog: http://fabriziomello.github

Re: [HACKERS] CREATE IF NOT EXISTS INDEX

2014-10-31 Thread Fabrízio de Royes Mello
t; Thanks for your review! Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog: http://fabriziomello.github.io >> Linkedin: http://br.linkedin.com/in/fabriziomello >> Twitter: http://twitter.com/fabriziomello >> Github: http://github.com/fabriziomello

Re: [HACKERS] CINE in CREATE TABLE AS ... and CREATE MATERIALIZED VIEW ...

2014-10-30 Thread Fabrízio de Royes Mello
gt;" unicode_border_linestyle|unicode_column_linestyle|unicode_header_linestyle})\n")); > > > Why above changes reqired ? > Same previous mistake. Fixed. > 3) This patch adding IF NOT EXIST_S for CREATE TABLE AS and CREATE MATERIALI

Re: [HACKERS] CREATE IF NOT EXISTS INDEX

2014-10-30 Thread Fabrízio de Royes Mello
On Thu, Oct 30, 2014 at 12:11 PM, Fujii Masao wrote: > > On Tue, Oct 7, 2014 at 2:42 AM, Fabrízio de Royes Mello > wrote: > > On Mon, Oct 6, 2014 at 11:13 AM, Marti Raudsepp wrote: > >> > >> On Mon, Oct 6, 2014 at 4:27 PM, Fa

Re: [HACKERS] Proposal : REINDEX SCHEMA

2014-10-23 Thread Fabrízio de Royes Mello
> Attached new regression test. Isn't better join the two patches in just one? Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog: http://fabriziomello.github.io >> Linkedin: http://br.linkedin.com/in/fa

Re: [HACKERS] Simplify calls of pg_class_aclcheck when multiple modes are used

2014-10-21 Thread Fabrízio de Royes Mello
ered at all. That patch is attached. >> > +1 for those tests. > > +1 Fabrízio Mello -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog: http://fabriziomello.github.io >> Linkedin: http://br.linkedin.com/in/fabrizio

Re: [HACKERS] Proposal : REINDEX SCHEMA

2014-10-20 Thread Fabrízio de Royes Mello
On Mon, Oct 20, 2014 at 11:24 AM, Sawada Masahiko wrote: > > On Mon, Oct 20, 2014 at 9:41 AM, Fabrízio de Royes Mello > wrote: > > > > > > On Sun, Oct 19, 2014 at 10:37 PM, Fabrízio de Royes Mello > > wrote: > >> > >> > >>

Re: [HACKERS] Proposal : REINDEX SCHEMA

2014-10-19 Thread Fabrízio de Royes Mello
On Sun, Oct 19, 2014 at 10:37 PM, Fabrízio de Royes Mello < fabriziome...@gmail.com> wrote: > > > On Sun, Oct 19, 2014 at 1:02 PM, Sawada Masahiko wrote: > > > > On Fri, Oct 17, 2014 at 4:32 AM, Fabrízio de Royes Mello > > wrote: > > > On Wed, Oct 15, 20

Re: [HACKERS] Proposal : REINDEX SCHEMA

2014-10-19 Thread Fabrízio de Royes Mello
On Sun, Oct 19, 2014 at 1:02 PM, Sawada Masahiko wrote: > > On Fri, Oct 17, 2014 at 4:32 AM, Fabrízio de Royes Mello > wrote: > > On Wed, Oct 15, 2014 at 11:41 AM, Sawada Masahiko > > wrote: > >> > >> On Mon, Oct 13, 2014 at 11:16 PM, Robert Haas > >

Re: [HACKERS] Proposal : REINDEX SCHEMA

2014-10-16 Thread Fabrízio de Royes Mello
do_database) objectOid = MyDatabaseId else objectOid = get_namespace_oid(objectName, false); ... insead of ... + /* Get OID of object for result */ + objectOid = (do_database) ? MyDatabaseId : get_namespace_oid(objectName, false); > 001_Add_schema_option_to_reindexdb_v1.pa

Re: [HACKERS] CINE in CREATE TABLE AS ... and CREATE MATERIALIZED VIEW ...

2014-10-14 Thread Fabrízio de Royes Mello
On Wed, Oct 1, 2014 at 9:17 AM, Fabrízio de Royes Mello < fabriziome...@gmail.com> wrote: > > Hi all, > > We already have IF NOT EXISTS for CREATE TABLE. There are some reason to don't have to CREATE TABLE AS and CREATE MATERIALIZED VIEW?? > Patch attached to add CINE s

Re: [HACKERS] Proposal : REINDEX SCHEMA

2014-10-13 Thread Fabrízio de Royes Mello
On Mon, Oct 13, 2014 at 5:39 AM, Sawada Masahiko wrote: > > On Mon, Oct 13, 2014 at 1:25 PM, Fabrízio de Royes Mello > wrote: > > On Sun, Oct 12, 2014 at 2:27 PM, Stephen Frost wrote: > >> > >> * Alvaro Herrera (alvhe...@2ndquadrant.com) wrote: > >>

Re: [HACKERS] Proposal : REINDEX SCHEMA

2014-10-12 Thread Fabrízio de Royes Mello
\"%s\" does not hava any table", + schema->relname))); 5) Missing of regression tests, please add it to src/test/regress/sql/create_index.sql 6) You need to add psql complete tabs 7) I think we can add "-S / --schema" option do reindexdb

Re: [HACKERS] pg_dump refactor patch to remove global variables

2014-10-11 Thread Fabrízio de Royes Mello
On Sat, Oct 11, 2014 at 10:15 PM, Alvaro Herrera wrote: > > Fabrízio de Royes Mello wrote: > > On Sat, Oct 11, 2014 at 2:56 PM, Alvaro Herrera < alvhe...@2ndquadrant.com> > > wrote: > > > > > Here's the complete patch in case anyone is wondering. &g

<    1   2   3   4   5   >