Re: [HACKERS][REVIEW] macaddr 64 bit (EUI-64) datatype support

2017-02-05 Thread Haribabu Kommi
On Wed, Feb 1, 2017 at 6:27 AM, Vitaly Burovoy wrote: > Hello, > > I've reviewed the patch[1]. > > Result of testing: > > make installcheck-world: tested, passed > Implements feature: tested, passed > Spec compliant: tested, passed > Documentation:

Re: [HACKERS] [WIP]Vertical Clustered Index (columnar store extension)

2017-02-05 Thread Haribabu Kommi
On Fri, Feb 3, 2017 at 8:28 PM, Konstantin Knizhnik < k.knizh...@postgrespro.ru> wrote: > On 30.12.2016 06:55, Haribabu Kommi wrote: > > > Hi All, > > Fujitsu was interested in developing a columnar storage extension with > minimal > changes the server backend. >

Re: [HACKERS] macaddr 64 bit (EUI-64) datatype support

2017-01-31 Thread Haribabu Kommi
On Tue, Jan 31, 2017 at 4:13 PM, Vitaly Burovoy <vitaly.buro...@gmail.com> wrote: > On 1/27/17, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > > Updated patches are attached. > > > Hello, > > I'm almost ready to mark it as Ready for committer. > The fina

Re: [HACKERS] Multi-tenancy with RLS

2017-01-30 Thread Haribabu Kommi
On Mon, Dec 5, 2016 at 4:31 PM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > > > On Mon, Oct 3, 2016 at 3:11 PM, Michael Paquier <michael.paqu...@gmail.com > > wrote: > >> On Tue, Jul 19, 2016 at 3:42 PM, Haribabu Kommi >> <kommi.harib...@gmail.co

Re: [HACKERS] pg_hba_file_settings view patch

2017-01-30 Thread Haribabu Kommi
On Tue, Jan 31, 2017 at 10:04 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Haribabu Kommi <kommi.harib...@gmail.com> writes: > > On Mon, Jan 30, 2017 at 5:18 PM, Michael Paquier < > michael.paqu...@gmail.com> > > wrote: > >> #define USER_AUTH_LAST uaPee

Re: [HACKERS] Parallel bitmap heap scan

2017-01-30 Thread Haribabu Kommi
On Fri, Jan 27, 2017 at 5:32 PM, Dilip Kumar wrote: > On Tue, Jan 24, 2017 at 10:18 AM, Dilip Kumar > wrote: > > I have changed as per the comments. 0002 and 0003 are changed, 0001 is > > still the same. > > 2 days back my colleague Rafia, reported

Re: [HACKERS] pg_hba_file_settings view patch

2017-01-30 Thread Haribabu Kommi
On Mon, Jan 30, 2017 at 5:18 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Mon, Jan 30, 2017 at 11:20 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > On Sun, Jan 29, 2017 at 9:18 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > >> t

Re: [HACKERS] pg_hba_file_settings view patch

2017-01-29 Thread Haribabu Kommi
On Sun, Jan 29, 2017 at 9:18 AM, Tom Lane wrote: > I wrote: > > I spent awhile hacking on this, and made a lot of things better, but > > I'm still very unhappy about the state of the comments. > > I made another pass over this, working on the comments and the docs, > and

Re: [HACKERS] pg_hba_file_settings view patch

2017-01-27 Thread Haribabu Kommi
On Sat, Jan 28, 2017 at 5:47 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Haribabu Kommi <kommi.harib...@gmail.com> writes: > > On Fri, Jan 27, 2017 at 1:36 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > >> It might make sense to proceed by writing a separate patch t

Re: [HACKERS] macaddr 64 bit (EUI-64) datatype support

2017-01-27 Thread Haribabu Kommi
On Fri, Jan 27, 2017 at 6:10 PM, Kuntal Ghosh <kuntalghosh.2...@gmail.com> wrote: > On Wed, Jan 25, 2017 at 6:00 PM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > > Corrected as suggested. > > > > Updated patch attached. There is no change in t

Re: [HACKERS] macaddr 64 bit (EUI-64) datatype support

2017-01-27 Thread Haribabu Kommi
On Thu, Jan 26, 2017 at 9:42 PM, Vitaly Burovoy <vitaly.buro...@gmail.com> wrote: > On 1/25/17, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > > On Wed, Jan 25, 2017 at 6:43 PM, Vitaly Burovoy < > vitaly.buro...@gmail.com> > > wrote: > > > I'

Re: [HACKERS] pg_hba_file_settings view patch

2017-01-27 Thread Haribabu Kommi
On Fri, Jan 27, 2017 at 1:36 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Haribabu Kommi <kommi.harib...@gmail.com> writes: > > This patch currently doesn't have the code for reporting the two log > > messages that can occur in tokenize_file function. To support

Re: [HACKERS] New SQL counter statistics view (pg_stat_sql)

2017-01-26 Thread Haribabu Kommi
On Tue, Jan 24, 2017 at 3:59 PM, Dilip Kumar wrote: > > Overall patch looks fine to me and marking it "ready for committer". > > There is two design decision, which I leave it for committer's decision. > > 1. EXECUTE statement should show only as EXECUTE count, not the >

Re: [HACKERS] Parallel Index Scans

2017-01-26 Thread Haribabu Kommi
On Mon, Jan 23, 2017 at 5:07 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Fri, Jan 20, 2017 at 7:29 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > > > On Thu, Jan 19, 2017 at 1:18 AM, Amit Kapila <amit.kapil...@gmail.com> > >

Re: [HACKERS] pg_hba_file_settings view patch

2017-01-26 Thread Haribabu Kommi
On Thu, Jan 26, 2017 at 4:32 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Ashutosh Bapat <ashutosh.ba...@enterprisedb.com> writes: > > On Wed, Jan 25, 2017 at 9:58 AM, Haribabu Kommi > > <kommi.harib...@gmail.com> wrote: > >> All the ereport message

Re: [HACKERS] macaddr 64 bit (EUI-64) datatype support

2017-01-25 Thread Haribabu Kommi
On Wed, Jan 25, 2017 at 6:43 PM, Vitaly Burovoy <vitaly.buro...@gmail.com> wrote: > On 1/23/17, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > > The patch is split into two parts. > > 1. Macaddr8 datatype support > > 2. Contrib module support. >

Re: [HACKERS] pg_hba_file_settings view patch

2017-01-24 Thread Haribabu Kommi
On Tue, Jan 24, 2017 at 6:17 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Mon, Jan 23, 2017 at 5:13 PM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > On Sat, Jan 21, 2017 at 8:01 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > >> * I'm

Re: [HACKERS] pg_hba_file_settings view patch

2017-01-24 Thread Haribabu Kommi
b.com> wrote: > >> On Mon, Jan 23, 2017 at 1:43 PM, Haribabu Kommi > >> <kommi.harib...@gmail.com> wrote: > >>> > >>> > >>> On Sat, Jan 21, 2017 at 8:01 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > >>>> > >>

Re: [HACKERS] macaddr 64 bit (EUI-64) datatype support

2017-01-23 Thread Haribabu Kommi
On Mon, Jan 23, 2017 at 6:29 PM, Kuntal Ghosh <kuntalghosh.2...@gmail.com> wrote: > On Thu, Jan 19, 2017 at 7:46 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > > > Updated patch attached. > > > I've looked at the updated patch. There are sti

Re: [HACKERS] Parallel bitmap heap scan

2017-01-23 Thread Haribabu Kommi
On Mon, Jan 23, 2017 at 3:42 PM, Dilip Kumar wrote: > On Thu, Jan 19, 2017 at 12:26 AM, Robert Haas > wrote: > >> Patch 0001 and 0003 required to rebase on the latest head. 0002 is > >> still the same. > > > > I've committed the first half of 0001.

Re: [HACKERS] pg_hba_file_settings view patch

2017-01-23 Thread Haribabu Kommi
On Sat, Jan 21, 2017 at 8:01 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Haribabu Kommi <kommi.harib...@gmail.com> writes: > > [ pg_hba_rules_10.patch ] > > I took a quick look over this. > Thanks for the review. > * I'm not exactly convinced that the way

Re: [HACKERS] [WIP]Vertical Clustered Index (columnar store extension)

2017-01-19 Thread Haribabu Kommi
On Wed, Jan 18, 2017 at 2:25 PM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 12/29/16 10:55 PM, Haribabu Kommi wrote: > > Fujitsu was interested in developing a columnar storage extension with > > minimal > > changes the server backend.

Re: [HACKERS] Parallel Index Scans

2017-01-19 Thread Haribabu Kommi
On Thu, Jan 19, 2017 at 1:18 AM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Wed, Jan 18, 2017 at 6:25 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > > > > > On Mon, Jan 16, 2017 at 11:11 PM, Amit Kapila

Re: [HACKERS] pg_hba_file_settings view patch

2017-01-19 Thread Haribabu Kommi
On Thu, Jan 19, 2017 at 11:28 PM, Ashutosh Bapat < ashutosh.ba...@enterprisedb.com> wrote: > On Thu, Jan 19, 2017 at 1:26 PM, Michael Paquier > <michael.paqu...@gmail.com> wrote: > > On Thu, Jan 19, 2017 at 4:25 PM, Haribabu Kommi > > <kommi.harib...@gmail.c

Re: [HACKERS] pg_hba_file_settings view patch

2017-01-18 Thread Haribabu Kommi
On Thu, Jan 19, 2017 at 4:08 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Wed, Jan 18, 2017 at 4:11 PM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > updated patch attached. > > Thanks for the new version. > > > Added tap tests patch

Re: [HACKERS] Parallel Index Scans

2017-01-18 Thread Haribabu Kommi
On Wed, Jan 18, 2017 at 6:55 PM, Rahila Syed wrote: > >+ /* Check if the scan for current scan keys is finished */ > >+ if (so->arrayKeyCount < btscan->btps_arrayKeyCount) > >+ *status = false; > > >I didn't clearly understand, in which scenario the arrayKeyCount is less

Re: [HACKERS] macaddr 64 bit (EUI-64) datatype support

2017-01-18 Thread Haribabu Kommi
On Sat, Jan 14, 2017 at 6:28 PM, Kuntal Ghosh <kuntalghosh.2...@gmail.com> wrote: > On Mon, Jan 9, 2017 at 1:45 PM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: > > Updated patch is attached. > > > I've a few comments about the patch. > Thanks for the

Re: [HACKERS] pg_hba_file_settings view patch

2017-01-17 Thread Haribabu Kommi
On Tue, Jan 17, 2017 at 5:24 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Tue, Jan 17, 2017 at 10:19 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > On Tue, Jan 10, 2017 at 6:35 PM, Michael Paquier < > michael.paqu...@gmail.com> >

Re: [HACKERS] New SQL counter statistics view (pg_stat_sql)

2017-01-17 Thread Haribabu Kommi
On Sat, Jan 14, 2017 at 2:58 AM, Dilip Kumar wrote: > On Wed, Jan 11, 2017 at 7:47 PM, Dilip Kumar > wrote: > > +void > > +pgstat_count_sqlstmt(const char *commandTag) > > +{ > > + PgStat_SqlstmtEntry *htabent; > > + bool found; > > + > > + if

Re: [HACKERS] Parallel Index Scans

2017-01-17 Thread Haribabu Kommi
On Mon, Jan 16, 2017 at 11:11 PM, Amit Kapila wrote: > > Changed as per suggestion. > > > I have also rebased the optimizer/executor support patch > (parallel_index_opt_exec_support_v4.patch) and added a test case in > it. Thanks for the patch. Here are comments found

Re: [HACKERS] [WIP]Vertical Clustered Index (columnar store extension)

2017-01-16 Thread Haribabu Kommi
On Sun, Jan 8, 2017 at 2:01 PM, Jim Nasby <jim.na...@bluetreble.com> wrote: > On 12/29/16 9:55 PM, Haribabu Kommi wrote: > >> The tuples which don't have multiple copies or frozen data will be moved >> from WOS to ROS periodically by the background worker process or aut

Re: [HACKERS] [WIP]Vertical Clustered Index (columnar store extension)

2017-01-16 Thread Haribabu Kommi
On Sun, Jan 8, 2017 at 4:20 AM, Bruce Momjian <br...@momjian.us> wrote: > On Fri, Dec 30, 2016 at 02:55:39PM +1100, Haribabu Kommi wrote: > > > > Hi All, > > > > Fujitsu was interested in developing a columnar storage extension with > minimal > > change

Re: [HACKERS] pg_hba_file_settings view patch

2017-01-16 Thread Haribabu Kommi
On Tue, Jan 10, 2017 at 6:35 PM, Michael Paquier wrote: > On Thu, Jan 5, 2017 at 1:58 PM, Michael Paquier > wrote: > > Could you hold on a bit to commit that? I'd like to look at it in more > > details. At quick glance, there is for example

Re: [HACKERS] pg_stat_lwlock wait time view

2017-01-09 Thread Haribabu Kommi
[ Re sending to Hackers as the earlier mail failed to deliver to Hackers mailing list] On Mon, Jan 9, 2017 at 4:13 PM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > > > On Thu, Aug 25, 2016 at 2:46 PM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: > >>

Re: [HACKERS] macaddr 64 bit (EUI-64) datatype support

2017-01-09 Thread Haribabu Kommi
On Fri, Jan 6, 2017 at 3:51 PM, Vitaly Burovoy <vitaly.buro...@gmail.com> wrote: > On 1/4/17, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > > On Tue, Nov 29, 2016 at 8:36 PM, Haribabu Kommi < > kommi.harib...@gmail.com> > > wrote: > >> Updated

Re: [HACKERS] pg_hba_file_settings view patch

2017-01-08 Thread Haribabu Kommi
On Tue, Nov 29, 2016 at 9:15 PM, Ashutosh Bapat < ashutosh.ba...@enterprisedb.com> wrote: > Here's backtrace and some debugging information > Program terminated with signal 11, Segmentation fault. > #0 0x007f96cd in shm_mq_sendv (mqh=0x121e998, > iov=0x7ffc9b7b79f0, iovcnt=2, nowait=1

Re: [HACKERS] macaddr 64 bit (EUI-64) datatype support

2017-01-04 Thread Haribabu Kommi
On Tue, Nov 29, 2016 at 8:36 PM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > > > On Sat, Nov 26, 2016 at 4:48 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > >> Haribabu Kommi <kommi.harib...@gmail.com> writes: >> > Currently the

Re: [HACKERS] gettimeofday is at the end of its usefulness?

2017-01-03 Thread Haribabu Kommi
On Fri, Dec 30, 2016 at 1:02 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Haribabu Kommi <kommi.harib...@gmail.com> writes: > > Attached a patch that replaces most of the getimeofday function calls, > > except timeofday(user callable) and GetCurrentTimest

Re: [HACKERS] pg_hba_file_settings view patch

2017-01-03 Thread Haribabu Kommi
On Tue, Nov 29, 2016 at 9:15 PM, Ashutosh Bapat < ashutosh.ba...@enterprisedb.com> wrote: > Here's backtrace and some debugging information > Program terminated with signal 11, Segmentation fault. > #0 0x007f96cd in shm_mq_sendv (mqh=0x121e998, > iov=0x7ffc9b7b79f0, iovcnt=2, nowait=1

Re: [HACKERS] commitfest 2016-11 status summary

2016-12-05 Thread Haribabu Kommi
On Tue, Dec 6, 2016 at 12:59 AM, Stephen Frost <sfr...@snowman.net> wrote: > * Amit Kapila (amit.kapil...@gmail.com) wrote: > > On Mon, Dec 5, 2016 at 11:56 AM, Michael Paquier > > <michael.paqu...@gmail.com> wrote: > > > On Mon, Dec 5, 2016 at 2:50 PM, Haribab

Re: [HACKERS] Indirect indexes

2016-12-05 Thread Haribabu Kommi
On Tue, Dec 6, 2016 at 4:55 AM, Alvaro Herrera <alvhe...@2ndquadrant.com> wrote: > Haribabu Kommi wrote: > > > Closed in 2016-11 commitfest with "returned with feedback" status. > > What feedback? Sorry, I was not able to find that there is no feedback on

Re: [HACKERS] Transactions involving multiple postgres foreign servers

2016-12-04 Thread Haribabu Kommi
On Mon, Dec 5, 2016 at 4:42 PM, Ashutosh Bapat < ashutosh.ba...@enterprisedb.com> wrote: > On Mon, Dec 5, 2016 at 11:04 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > > > > > On Fri, Nov 11, 2016 at 5:38 PM, Masahiko Sawada <sawada.m...@g

Re: [HACKERS] commitfest 2016-11 status summary

2016-12-04 Thread Haribabu Kommi
Hi All, The commitfest status summary at the end of commitfest. Needs review: 0 Waiting on author: 0 Ready for Commiter: 0 Commited: 41 Moved to next CF: 79 Rejected: 7 Returned with feedback: 20 TOTAL: 147 Overall progress of completion - 46% (doesn't include "moved to next CF") Micheal, I

Re: [HACKERS] Indirect indexes

2016-12-04 Thread Haribabu Kommi
On Sun, Nov 13, 2016 at 4:28 AM, Andres Freund wrote: > Hi, > > On 2016-11-01 01:43:31 -0300, Alvaro Herrera wrote: > > Alvaro Herrera wrote: > > > I propose we introduce the concept of "indirect indexes". > > > > This is a WIP non-functional patch for indirect indexes. I've

Re: [HACKERS] delta relations in AFTER triggers

2016-12-04 Thread Haribabu Kommi
On Wed, Nov 23, 2016 at 10:02 AM, Jim Nasby wrote: > On 11/21/16 3:49 AM, Craig Ringer wrote: > >> After going through that experience, I now agree with Kevin: an >>> > interface where a new SPI interface lets PLs push a named tuplestore >>> > into the SPI connection to

Re: [HACKERS] Transactions involving multiple postgres foreign servers

2016-12-04 Thread Haribabu Kommi
On Fri, Nov 11, 2016 at 5:38 PM, Masahiko Sawada wrote: > > 2PC is a basic building block to support the atomic commit and there > are some optimizations way in order to reduce disadvantage of 2PC. As > you mentioned, it's hard to support a single model that would suit >

Re: [HACKERS] move collation import to backend

2016-12-04 Thread Haribabu Kommi
On Thu, Dec 1, 2016 at 12:18 AM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > > > > + > +Datum pg_import_system_collations(PG_FUNCTION_ARGS); > + > +Datum > +pg_import_system_collations(PG_FUNCTION_ARGS) > +{ > >>> > >>> Uh? > >> > >> Required to

Re: [HACKERS] postgres_fdw : altering foreign table not invalidating prepare statement execution plan.

2016-12-04 Thread Haribabu Kommi
On Wed, Nov 30, 2016 at 8:05 PM, Etsuro Fujita wrote: > On 2016/11/30 17:53, Amit Langote wrote: > >> On 2016/11/30 17:25, Etsuro Fujita wrote: >> >>> Done. I modified the patch so that any inval in pg_foreign_server also >>> blows the whole plan cache. >>> >> > I

Re: [HACKERS] Multi-tenancy with RLS

2016-12-04 Thread Haribabu Kommi
On Mon, Oct 3, 2016 at 3:11 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Tue, Jul 19, 2016 at 3:42 PM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > The above changes are based on my understanding to the discussion > occurred in > > this

Re: [HACKERS] raw output from copy

2016-12-04 Thread Haribabu Kommi
On Tue, Nov 22, 2016 at 10:48 PM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > Hi, > > This is a gentle reminder. > > you assigned as reviewer to the current patch in the 11-2016 commitfest. > But you haven't shared your review yet. Please share your

Re: [HACKERS] amcheck (B-Tree integrity checking tool)

2016-12-04 Thread Haribabu Kommi
On Wed, Nov 30, 2016 at 9:06 AM, Peter Geoghegan wrote: > On Wed, Nov 23, 2016 at 2:47 PM, Thomas Munro > wrote: > > Actually I meant that at T2 the btree is exactly same as it was at T1, > > but the order of the values has changed according to

Re: [HACKERS] Logical Replication WIP

2016-12-04 Thread Haribabu Kommi
On Sun, Dec 4, 2016 at 12:06 PM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > I massaged the temporary replication slot patch a bit. I changed the > column name in pg_stat_replication_slots from "persistent" to > "temporary" and flipped the logical sense, so that it is

Re: [HACKERS] [PROPOSAL] Temporal query processing with range types

2016-12-04 Thread Haribabu Kommi
On Tue, Oct 25, 2016 at 8:44 PM, Peter Moser wrote: > > We decided to follow your recommendation and add the patch to the > commitfest. > > Path is not applying properly to HEAD. Moved to next CF with "waiting on author" status. Regards, Hari Babu Fujitsu Australia

Re: [HACKERS] COPY as a set returning function

2016-12-04 Thread Haribabu Kommi
On Tue, Nov 1, 2016 at 7:45 AM, Corey Huinker wrote: > Attached is a patch that implements copy_srf(). > Moved to next CF with "needs review" status. Regards, Hari Babu Fujitsu Australia

Re: [HACKERS] sequence data type

2016-12-04 Thread Haribabu Kommi
On Tue, Nov 22, 2016 at 10:54 PM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > Hi Vik and Vinayak, > > This is a gentle reminder. > > you both are assigned as reviewer's to the current patch in the 11-2016 > commitfest. > But you haven't shared your review ye

Re: [HACKERS] Parallel tuplesort (for parallel B-Tree index creation)

2016-12-04 Thread Haribabu Kommi
On Mon, Dec 5, 2016 at 7:44 AM, Peter Geoghegan wrote: > On Sat, Dec 3, 2016 at 7:23 PM, Tomas Vondra > wrote: > > I do share your concerns about unpredictable behavior - that's > > particularly worrying for pg_restore, which may be used for time-

Re: [HACKERS] Parallel Index Scans

2016-12-04 Thread Haribabu Kommi
On Sat, Nov 26, 2016 at 10:35 PM, Amit Kapila wrote: > On Sat, Oct 22, 2016 at 9:07 AM, Amit Kapila > wrote: > > On Fri, Oct 21, 2016 at 10:55 PM, Robert Haas > wrote: > > I have rebased the patch (parallel_index_scan_v2)

Re: [HACKERS] PoC: Partial sort

2016-12-04 Thread Haribabu Kommi
On Fri, Dec 2, 2016 at 4:05 AM, Robert Haas wrote: > On Tue, Sep 13, 2016 at 4:32 AM, Alexander Korotkov > wrote: > > On Fri, Apr 8, 2016 at 10:09 PM, Peter Geoghegan wrote: > >> On Wed, Mar 30, 2016 at 8:02 AM, Alexander Korotkov >

Re: [HACKERS] [PATCH] Generic type subscription

2016-12-04 Thread Haribabu Kommi
On Thu, Nov 17, 2016 at 10:56 PM, Dmitry Dolgov <9erthali...@gmail.com> wrote: > > On 15 November 2016 at 15:03, Aleksander Alekseev < > a.aleks...@postgrespro.ru> wrote: > > Hello. > > > > I took a look on the latest -v4 patch. I would like to note that this > > patch breaks a backward

Re: [HACKERS] Creating a DSA area to provide work space for parallel execution

2016-12-04 Thread Haribabu Kommi
On Thu, Dec 1, 2016 at 10:35 PM, Thomas Munro wrote: > On Sat, Nov 26, 2016 at 1:55 AM, Thomas Munro > wrote: > > Here's a new version to apply on top of dsa-v7.patch. > > Here's a version to go with dsa-v8.patch. Moved to next CF

Re: [HACKERS] Speed up Clog Access by increasing CLOG buffers

2016-12-04 Thread Haribabu Kommi
On Mon, Dec 5, 2016 at 1:14 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Mon, Dec 5, 2016 at 6:00 AM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: > > No, that is not true. You have quoted the wrong message, that > discussion was about WALWriteLock con

Re: [HACKERS] identity columns

2016-12-04 Thread Haribabu Kommi
On Tue, Nov 22, 2016 at 10:51 PM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > Hi Vitaly, > > > This is a gentle reminder. > > you assigned as reviewer to the current patch in the 11-2016 commitfest. > But you haven't shared your review yet on the new patch in t

Re: [HACKERS] Bug in to_timestamp().

2016-12-04 Thread Haribabu Kommi
On Mon, Nov 7, 2016 at 2:26 AM, Artur Zakirov wrote: > > Hm, truly. Fixed it. > > I've attached the fixed patch. > Moved to next CF with "needs review" status. Regards, Hari Babu Fujitsu Australia

Re: [HACKERS] Proposal for changes to recovery.conf API

2016-12-04 Thread Haribabu Kommi
On Fri, Dec 2, 2016 at 12:58 PM, Magnus Hagander wrote: > > As there was a feedback from others related to the patch and doesn't find any update from author. Closed in 2016-11 commitfest with "returned with feedback" status. Please feel free to update the status once you

Re: [HACKERS] Pinning a buffer in TupleTableSlot is unnecessary

2016-12-04 Thread Haribabu Kommi
On Tue, Nov 15, 2016 at 1:17 PM, Noah Misch wrote: > On Mon, Nov 14, 2016 at 10:21:53AM -0800, Peter Geoghegan wrote: > > BTW, I recently noticed that the latest version of Valgrind, 3.12, > > added this new feature: > > > > * Memcheck: > > > > - Added meta mempool support

Re: [HACKERS] New SQL counter statistics view (pg_stat_sql)

2016-12-04 Thread Haribabu Kommi
On Tue, Nov 22, 2016 at 5:57 PM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > Hi Vinayak, > > This is a gentle reminder. > > you assigned as reviewer to the current patch in the 11-2016 commitfest. > If you have any more review comments / performance results

Re: [HACKERS] Parallel bitmap heap scan

2016-12-04 Thread Haribabu Kommi
On Wed, Nov 30, 2016 at 4:38 PM, Dilip Kumar wrote: > On Fri, Nov 25, 2016 at 6:55 PM, Dilip Kumar > wrote: > > I have changed the design to directly make it based on DSA instead of > using DHT. > > In new version we no longer use DHT. Instead, of

Re: [HACKERS] Vacuum: allow usage of more than 1GB of work mem

2016-12-04 Thread Haribabu Kommi
On Tue, Nov 22, 2016 at 4:53 AM, Claudio Freire wrote: > On Mon, Nov 21, 2016 at 2:15 PM, Masahiko Sawada > wrote: > > On Fri, Nov 18, 2016 at 6:54 AM, Claudio Freire > wrote: > >> On Thu, Nov 17, 2016 at 6:34 PM, Robert

Re: [HACKERS] Gather Merge

2016-12-04 Thread Haribabu Kommi
On Thu, Nov 24, 2016 at 11:12 PM, Rushabh Lathia wrote: > > PFA latest patch with fix as well as few cosmetic changes. > > Moved to next CF with "needs review" status. Regards, Hari Babu Fujitsu Australia

Re: [HACKERS] Speed up Clog Access by increasing CLOG buffers

2016-12-04 Thread Haribabu Kommi
On Fri, Nov 4, 2016 at 8:20 PM, Amit Kapila wrote: > On Thu, Nov 3, 2016 at 8:38 PM, Robert Haas wrote: > > On Tue, Nov 1, 2016 at 11:31 PM, Tomas Vondra > >> The difference is that both the fast-path locks and msgNumLock went into > >> 9.2, so

Re: [HACKERS] Hash tables in dynamic shared memory

2016-12-04 Thread Haribabu Kommi
On Sun, Nov 20, 2016 at 9:54 AM, John Gorman wrote: > I reviewed the dht-v2.patch and found that it is in excellent shape. > > The overall performance will be faster due to not having to examine > more than one hash bucket array most of the time. > > Reviewer didn't find

Re: [HACKERS] Performance improvement for joins where outer side is unique

2016-12-02 Thread Haribabu Kommi
On Wed, Nov 2, 2016 at 1:21 PM, David Rowley wrote: > On 31 October 2016 at 18:37, David Rowley > wrote: > > I've rebased the changes I made to address this back in April to current > master. > > Please note that I went ahead and

Re: [HACKERS] WIP: [[Parallel] Shared] Hash

2016-12-02 Thread Haribabu Kommi
On Thu, Nov 3, 2016 at 4:19 PM, Thomas Munro wrote: > Obviously I'm actively working on developing and stabilising all this. > Some of the things I'm working on are: work_mem accounting, batch > increases, rescans and figuring out if the resource management for >

Re: [HACKERS] background sessions

2016-12-02 Thread Haribabu Kommi
On Tue, Nov 1, 2016 at 2:25 PM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > Here is a patch for the background sessions C API and PL/Python support. > This was previously submitted as "autonomous transactions", which > proved controversial, and there have been several

Re: ParallelFinish-hook of FDW/CSP (Re: [HACKERS] Steps inside ExecEndGather)

2016-12-02 Thread Haribabu Kommi
On Tue, Nov 1, 2016 at 1:33 AM, Kouhei Kaigai wrote: > Hello, > > The attached patch implements the suggestion by Amit before. > > What I'm motivated is to collect extra run-time statistics specific > to a particular ForeignScan/CustomScan, not only the standard >

Re: [HACKERS] Proposal: scan key push down to heap [WIP]

2016-12-02 Thread Haribabu Kommi
On Fri, Dec 2, 2016 at 8:41 AM, Andres Freund wrote: > On 2016-11-30 16:11:23 +0530, Dilip Kumar wrote: > > On Tue, Nov 29, 2016 at 11:21 PM, Robert Haas > wrote: > > > On Mon, Nov 28, 2016 at 11:17 PM, Dilip Kumar > wrote: > >

Re: [HACKERS] Proposal : For Auto-Prewarm.

2016-12-02 Thread Haribabu Kommi
On Tue, Nov 29, 2016 at 4:26 PM, Mithun Cy wrote: > Sorry I took some time on this please find latest patch with addressed > review comments. Apart from fixes for comments I have introduced a new GUC > variable for the pg_autoprewarm "buff_dump_interval". So now we

Re: [HACKERS] Supporting huge pages on Windows

2016-12-02 Thread Haribabu Kommi
On Tue, Oct 11, 2016 at 1:36 PM, Tsunakawa, Takayuki < tsunakawa.ta...@jp.fujitsu.com> wrote: > > Moved to next CF with "needs review" status. Regards, Hari Babu Fujitsu Australia

Re: [HACKERS] Improvements in psql hooks for variables

2016-12-02 Thread Haribabu Kommi
On Wed, Nov 23, 2016 at 11:17 PM, Daniel Verite wrote: >I wrote: > > > So I went through the psql commands which don't fail on parse errors > > for booleans > > [...] > > Here's a v5 patch implementing the suggestions mentioned upthread: > all meta-commands calling

Re: [HACKERS] patch proposal

2016-12-02 Thread Haribabu Kommi
On Tue, Nov 22, 2016 at 10:17 PM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > > Hi Abhijit, > > This is a gentle reminder. > > you assigned as reviewer to the current patch in the 11-2016 commitfest. > But you haven't shared your review yet. Please share yo

Re: [HACKERS] Dynamic shared memory areas

2016-12-02 Thread Haribabu Kommi
On Thu, Dec 1, 2016 at 10:33 PM, Thomas Munro wrote: > > Please find attached dsa-v8.patch, and also a small test module for > running random allocate/free exercises and dumping the internal > allocator state. Moved to next CF with "needs review" status.

Re: [HACKERS] WIP: multivariate statistics / proof of concept

2016-12-02 Thread Haribabu Kommi
On Tue, Nov 22, 2016 at 2:42 PM, Tomas Vondra wrote: > On 11/21/2016 11:10 PM, Robert Haas wrote: > >> [ reviving an old multivariate statistics thread ] >> >> On Thu, Nov 13, 2014 at 6:31 AM, Simon Riggs >> wrote: >> >>> On 12 October 2014

Re: [HACKERS] DROP FUNCTION of multiple functions

2016-12-02 Thread Haribabu Kommi
On Fri, Dec 2, 2016 at 1:32 PM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 11/23/16 5:04 PM, Tom Lane wrote: > > I looked at this briefly. I agree that 0001-0003 are simple cleanup of > > the grammar and could be pushed without further ado. > > Done. > > > However, starting

Re: [HACKERS] Patch to implement pg_current_logfile() function

2016-12-02 Thread Haribabu Kommi
On Fri, Dec 2, 2016 at 12:08 PM, Karl O. Pinc wrote: > On Sun, 27 Nov 2016 21:54:46 +0100 > Gilles Darold wrote: > > > I've attached the v15 of the patch > > > I've not applied patch patch_pg_current_logfile-v14.diff.backoff to > > prevent constant call

Re: [HACKERS] pgbench more operators & functions

2016-12-01 Thread Haribabu Kommi
On Fri, Dec 2, 2016 at 5:28 PM, Fabien COELHO wrote: > > Hello Haribabu, > > Alas, performance testing is quite sensitive to many details:-( >>> >> > The current status of the patch and recent mail thread discussion doesn't >> represent the same. >> > > The same what? > >

Re: [HACKERS] PATCH: two slab-like memory allocators

2016-12-01 Thread Haribabu Kommi
On Thu, Dec 1, 2016 at 1:26 PM, Tomas Vondra wrote: > > > Dne 11/27/2016 v 11:02 PM Andres Freund napsal(a): > >> On 2016-11-27 22:21:49 +0100, Petr Jelinek wrote: >> >>> On 27/11/16 21:47, Andres Freund wrote: >>> Hi, +typedef struct SlabBlockData

Re: [HACKERS] [PATCH] Better logging of COPY queries if log_statement='all'

2016-12-01 Thread Haribabu Kommi
On Thu, Nov 17, 2016 at 12:57 PM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > Hi Dmitry, > > This is a gentle reminder. > > you assigned as reviewer to the current patch in the 11-2016 commitfest. > But you haven't shared your review yet. Can you please try to sh

Re: [HACKERS] Danger of automatic connection reset in psql

2016-12-01 Thread Haribabu Kommi
On Tue, Nov 22, 2016 at 11:06 PM, Pavel Stehule wrote: > > > 2016-11-22 13:02 GMT+01:00 Oleksandr Shulgin >: > >> On Tue, Nov 22, 2016 at 5:28 AM, Pavel Stehule >> wrote: >> >>> >>> 2016-11-22 3:46 GMT+01:00

Re: [HACKERS] proposal: psql \setfileref

2016-12-01 Thread Haribabu Kommi
On Fri, Nov 18, 2016 at 5:53 AM, Pavel Stehule wrote: > Hi > > 2016-11-17 12:00 GMT+01:00 Pavel Stehule : > >> >> Hi >> >> a independent implementation of parametrized queries can looks like >> attached patch: >> >> this code is simple without

Re: [HACKERS] pgbench - allow backslash continuations in \set expressions

2016-12-01 Thread Haribabu Kommi
On Fri, Dec 2, 2016 at 6:13 AM, Tom Lane wrote: > Fabien COELHO writes: > >> In psql, if backslash followed by [CR]LF is interpreted as a > >> continuation symbol, commands like these seem problematic > >> on Windows since backslash is the directory

Re: [HACKERS] pgbench - allow to store select results into variables

2016-12-01 Thread Haribabu Kommi
On Mon, Oct 3, 2016 at 12:43 AM, Michael Paquier wrote: > On Tue, Sep 27, 2016 at 10:41 AM, Amit Langote > wrote: > > On 2016/09/26 20:27, Fabien COELHO wrote: > >> > >> Hello Amit, > >> > I am marking the pgbench-into-5.patch [1]

Re: [HACKERS] [PATCH] pgpassfile connection option

2016-12-01 Thread Haribabu Kommi
On Tue, Nov 29, 2016 at 2:53 AM, Fabien COELHO wrote: > > Hello Julian, > > I've adressed those spacing errors. >> > > Ok. > > You are right, if pgpassfile_used is true, it SHOULD be defined, I just >> like to be careful whenever I'm working with strings. But I guess in this

Re: [HACKERS] patch: function xmltable

2016-12-01 Thread Haribabu Kommi
On Thu, Dec 1, 2016 at 2:21 AM, Pavel Stehule wrote: > Dne 30. 11. 2016 14:53 napsal uživatel "Pavel Stehule" < > pavel.steh...@gmail.com>: > > > > > > > > 2016-11-30 13:38 GMT+01:00 Alvaro Herrera : > >> > >> Pavel Stehule wrote: > >> >

Re: [HACKERS] pg_sequence catalog

2016-12-01 Thread Haribabu Kommi
On Fri, Dec 2, 2016 at 1:47 PM, Andreas Karlsson wrote: > I think this patch looks good now so I am setting it to ready for > committer. > > I like the idea of the patch and I think that while this change will break > some tools which look at the sequence relations I think the

Re: [HACKERS] pgbench more operators & functions

2016-12-01 Thread Haribabu Kommi
On Sat, Oct 8, 2016 at 11:27 PM, Fabien COELHO wrote: > > Hello Amit. > > Also, given the heavy UPDATE nature of the pgbench test, a non 100% default >>> fill factor on some tables would make sense. >>> >> >> FWIW, sometime back I have seen that with fill factor 80, at

Re: [HACKERS] asynchronous and vectorized execution

2016-12-01 Thread Haribabu Kommi
On Mon, Oct 3, 2016 at 3:25 PM, Kyotaro HORIGUCHI < horiguchi.kyot...@lab.ntt.co.jp> wrote: > At Mon, 3 Oct 2016 13:14:23 +0900, Michael Paquier < > michael.paqu...@gmail.com> wrote in xn_g7uwnpqun_a_sewb...@mail.gmail.com> > > On Thu, Sep 29, 2016 at 5:50 PM, Kyotaro HORIGUCHI > >

Re: [HACKERS] WAL logging problem in 9.4.3?

2016-12-01 Thread Haribabu Kommi
On Wed, Nov 9, 2016 at 5:55 PM, Michael Paquier wrote: > > > On Wed, Nov 9, 2016 at 9:27 AM, Michael Paquier > wrote: > > On Wed, Nov 9, 2016 at 5:39 AM, Robert Haas > wrote: > >> On Thu, Feb 4, 2016 at 7:24 AM,

Re: [HACKERS] pg_xlogdump follow into the future

2016-12-01 Thread Haribabu Kommi
On Fri, Dec 2, 2016 at 2:21 AM, Vladimir Rusinov wrote: > This patch does not have a reviewer, so I've decided to try myself on. > > Disclaimer: although I review quite a lot of code daily, this is my first > review for PostgreSQL. I don't know code very well, and frankly I

Re: [HACKERS] VACUUM's ancillary tasks

2016-12-01 Thread Haribabu Kommi
On Wed, Oct 19, 2016 at 2:44 AM, Robert Haas wrote: > On Sun, Oct 16, 2016 at 3:35 PM, Jeff Janes wrote: > > On Fri, Oct 7, 2016 at 6:14 AM, Robert Haas > wrote: > >> On Thu, Oct 6, 2016 at 8:40 PM, Jeff Janes

Re: [HACKERS] LOCK TABLE .. DEFERRABLE

2016-12-01 Thread Haribabu Kommi
On Fri, Sep 16, 2016 at 3:51 AM, Robert Haas wrote: > On Tue, Sep 6, 2016 at 6:04 AM, Simon Riggs wrote: > > On 1 September 2016 at 21:28, Simon Riggs wrote: > >> So the only way to handle multiple locks is to do this roughly

<    1   2   3   4   5   6   >